)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/commands.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a44c413aa3a81f640c5cff2b432e6f0c76f62b58","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                        acl_del_obj.delete()"},{"line_number":635,"context_line":"                    except AssertionError:"},{"line_number":636,"context_line":"                        # If we try to delete a row twice, just continue"},{"line_number":637,"context_line":"                        pass"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"            # Add new ACLs."},{"line_number":640,"context_line":"            acl_add_objs \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f2348649","line":637,"updated":"2019-12-19 18:23:20.000000000","message":"Is it easy enough to add a unit test for this in the TestUpdateACLsCommand class?","commit_id":"474bff078c9c9e736f86b7394320661bde70eaf4"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f9f1d91105cc7a56edfacc16a00d6983c6de4b3e","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                        acl_del_obj.delete()"},{"line_number":635,"context_line":"                    except AssertionError:"},{"line_number":636,"context_line":"                        # If we try to delete a row twice, just continue"},{"line_number":637,"context_line":"                        pass"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"            # Add new ACLs."},{"line_number":640,"context_line":"            acl_add_objs \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b8dcaf71","line":637,"in_reply_to":"3fa7e38b_f2348649","updated":"2019-12-19 20:13:42.000000000","message":"We could, though I really don\u0027t want this to be the permanent solution. This works around an issue, but the real solution would be to refactor the ACL code IMHO. So a test mocking the python-ovs row.delete() to throw an AssertionError and then still pass when updating ACLs, would end up just having to be deleted when a more robust fix was made.","commit_id":"474bff078c9c9e736f86b7394320661bde70eaf4"}]}