)]}'
{"neutron/plugins/metaplugin/meta_neutron_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"c127c62abe221e167d00516cfc6afc92e67a44af","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            for method_name, flavor in extension_list:"},{"line_number":125,"context_line":"                self.extension_map[method_name] \u003d flavor"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Register hooks."},{"line_number":128,"context_line":"        db_base_plugin_v2.NeutronDbPluginV2.register_model_query_hook("},{"line_number":129,"context_line":"            models_v2.Network,"},{"line_number":130,"context_line":"            \u0027metaplugin_net\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Faec%3D","line":127,"updated":"2014-02-26 19:24:21.000000000","message":"Ok the intent here is unclear.  Seems like you want to add the hook to all classes right?  If so, there should be a comment explaining that the call to base class is so that this hook is applied to any plugin instance.","commit_id":"2963e94bc6fc5c001a5c5d10d561e700aad4245c"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f748421867586ae9f04ae0058a1fc16563b671ef","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            for method_name, flavor in extension_list:"},{"line_number":125,"context_line":"                self.extension_map[method_name] \u003d flavor"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Register hooks."},{"line_number":128,"context_line":"        db_base_plugin_v2.NeutronDbPluginV2.register_model_query_hook("},{"line_number":129,"context_line":"            models_v2.Network,"},{"line_number":130,"context_line":"            \u0027metaplugin_net\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F%2F5I%3D","line":127,"in_reply_to":"AAAAU3%2F%2Faec%3D","updated":"2014-02-26 22:57:31.000000000","message":"please check new patch.","commit_id":"2963e94bc6fc5c001a5c5d10d561e700aad4245c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"c127c62abe221e167d00516cfc6afc92e67a44af","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                plugin_filters \u003d {}"},{"line_number":242,"context_line":"            plugin_filters[FLAVOR_NETWORK] \u003d [flavor]"},{"line_number":243,"context_line":"            l \u003d plugin.get_networks(context, plugin_filters, fields)"},{"line_number":244,"context_line":"            for net in l:"},{"line_number":245,"context_line":"                if not fields or FLAVOR_NETWORK in fields:"},{"line_number":246,"context_line":"                    net[FLAVOR_NETWORK] \u003d flavor"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAU3%2F%2Fafs%3D","line":243,"updated":"2014-02-26 19:24:21.000000000","message":"please choose a better variable name","commit_id":"2963e94bc6fc5c001a5c5d10d561e700aad4245c"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f748421867586ae9f04ae0058a1fc16563b671ef","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                plugin_filters \u003d {}"},{"line_number":242,"context_line":"            plugin_filters[FLAVOR_NETWORK] \u003d [flavor]"},{"line_number":243,"context_line":"            l \u003d plugin.get_networks(context, plugin_filters, fields)"},{"line_number":244,"context_line":"            for net in l:"},{"line_number":245,"context_line":"                if not fields or FLAVOR_NETWORK in fields:"},{"line_number":246,"context_line":"                    net[FLAVOR_NETWORK] \u003d flavor"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F%2F2w%3D","line":243,"in_reply_to":"AAAAU3%2F%2Fafs%3D","updated":"2014-02-26 22:57:31.000000000","message":"done","commit_id":"2963e94bc6fc5c001a5c5d10d561e700aad4245c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1d9c3ca8f57ae28b922e931922e08d2bf90723c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if fields and \u0027id\u0027 not in fields:"},{"line_number":190,"context_line":"            del net[\u0027id\u0027]"},{"line_number":191,"context_line":"        return net"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_networks_with_flavor(self, context, filters\u003dNone,"},{"line_number":194,"context_line":"                                 fields\u003dNone):"},{"line_number":195,"context_line":"        collection \u003d self._model_query(context, models_v2.Network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2Fyno%3D","side":"PARENT","line":192,"updated":"2014-03-04 04:24:40.000000000","message":"get_networks_with_flavor looks unnecessary.","commit_id":"65ba119a2237b67d9c2f42bc7c691d204bab79ae"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c12eb4e657c2b842922063207f014cec250a2659","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if fields and \u0027id\u0027 not in fields:"},{"line_number":190,"context_line":"            del net[\u0027id\u0027]"},{"line_number":191,"context_line":"        return net"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_networks_with_flavor(self, context, filters\u003dNone,"},{"line_number":194,"context_line":"                                 fields\u003dNone):"},{"line_number":195,"context_line":"        collection \u003d self._model_query(context, models_v2.Network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2Fd8g%3D","side":"PARENT","line":192,"in_reply_to":"AAAAVn%2F%2FlnU%3D","updated":"2014-03-05 22:26:10.000000000","message":"I agree it should be removed. \n\nI wanted to get merged as soon as possible, but it does not get merged yet after all.\n\nI fixed this and uploaded new patch set. Would you check and approve it if it is OK ?","commit_id":"65ba119a2237b67d9c2f42bc7c691d204bab79ae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cb1235288d371b98c092c389d8b80974cae07447","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if fields and \u0027id\u0027 not in fields:"},{"line_number":190,"context_line":"            del net[\u0027id\u0027]"},{"line_number":191,"context_line":"        return net"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_networks_with_flavor(self, context, filters\u003dNone,"},{"line_number":194,"context_line":"                                 fields\u003dNone):"},{"line_number":195,"context_line":"        collection \u003d self._model_query(context, models_v2.Network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2FlnU%3D","side":"PARENT","line":192,"in_reply_to":"AAAAVn%2F%2FmiM%3D","updated":"2014-03-05 07:31:13.000000000","message":"It doesn\u0027t seem a reasonable reason to keep it that the name does not start with an underscore. This is a method specific to metaplugin and if it is not used it should be removed.\n\nCould you file a bug before approving?","commit_id":"65ba119a2237b67d9c2f42bc7c691d204bab79ae"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"27e1258fe17b2a7b5669aa1a82829e389c57da5a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if fields and \u0027id\u0027 not in fields:"},{"line_number":190,"context_line":"            del net[\u0027id\u0027]"},{"line_number":191,"context_line":"        return net"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_networks_with_flavor(self, context, filters\u003dNone,"},{"line_number":194,"context_line":"                                 fields\u003dNone):"},{"line_number":195,"context_line":"        collection \u003d self._model_query(context, models_v2.Network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2FmiM%3D","side":"PARENT","line":192,"in_reply_to":"AAAAVn%2F%2FyXg%3D","updated":"2014-03-05 04:56:14.000000000","message":"Motoki-san,\n\nI have other three fixes of metaplugin which realy need to fix in my queue. If it is better to remove this method let me issue another bug report (e.g. remove unnecessary method) later.","commit_id":"65ba119a2237b67d9c2f42bc7c691d204bab79ae"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"82cf54ae28c09aae20ef326963c9fccb4f9dfc8e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if fields and \u0027id\u0027 not in fields:"},{"line_number":190,"context_line":"            del net[\u0027id\u0027]"},{"line_number":191,"context_line":"        return net"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def get_networks_with_flavor(self, context, filters\u003dNone,"},{"line_number":194,"context_line":"                                 fields\u003dNone):"},{"line_number":195,"context_line":"        collection \u003d self._model_query(context, models_v2.Network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2FyXg%3D","side":"PARENT","line":192,"in_reply_to":"AAAAVn%2F%2Fyno%3D","updated":"2014-03-04 05:02:03.000000000","message":"I agree with you. I keep this only because its name is not started with \u0027_\u0027 .\n\nDo you recommend to remove it ?","commit_id":"65ba119a2237b67d9c2f42bc7c691d204bab79ae"}]}