)]}'
{"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"067979d5acfe0e916cbf3dd3b3e3cc56a305c875","unresolved":false,"context_lines":[{"line_number":3035,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3036,"context_line":"            self.assertEqual(expected_on_int_br, int_br.mock_calls)"},{"line_number":3037,"context_line":"            self.assertFalse([], tun_br.mock_calls)"},{"line_number":3038,"context_line":"            self.assertFalse([], phys_br.mock_calls)"},{"line_number":3039,"context_line":""},{"line_number":3040,"context_line":"    def _test_port_bound_for_dvr_on_vxlan_network("},{"line_number":3041,"context_line":"            self, device_owner, ip_version\u003dn_const.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4ab7378a","side":"PARENT","line":3038,"updated":"2020-01-12 10:33:19.000000000","message":"nice catch, thx :)","commit_id":"ba4895d479f871791b70d862f77171e5aee53de7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ca7016319e13f7d3d60c3b941b1fb5087d0d5cfc","unresolved":false,"context_lines":[{"line_number":3012,"context_line":"            ] + self._expected_port_bound(self._port, lvid,"},{"line_number":3013,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3014,"context_line":"            self.assertEqual(expected_on_int_br, int_br.mock_calls)"},{"line_number":3015,"context_line":"            self.assertEqual([], tun_br.mock_calls)"},{"line_number":3016,"context_line":"            self.assertEqual(expected_on_phys_br, phys_br.mock_calls)"},{"line_number":3017,"context_line":"            int_br.reset_mock()"},{"line_number":3018,"context_line":"            tun_br.reset_mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_819d746d","line":3015,"updated":"2020-01-03 18:24:46.000000000","message":"Similar statement, but correct since it\u0027s assertEqual() and was maybe what was intended below?","commit_id":"feed8a64bfc470d46bf4ebd235b6ca05c33eefd8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ca7016319e13f7d3d60c3b941b1fb5087d0d5cfc","unresolved":false,"context_lines":[{"line_number":3035,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3036,"context_line":"            self.assertEqual(expected_on_int_br, int_br.mock_calls)"},{"line_number":3037,"context_line":"            self.assertFalse(tun_br.mock_calls)"},{"line_number":3038,"context_line":"            self.assertFalse(phys_br.mock_calls)"},{"line_number":3039,"context_line":""},{"line_number":3040,"context_line":"    def _test_port_bound_for_dvr_on_vxlan_network("},{"line_number":3041,"context_line":"            self, device_owner, ip_version\u003dn_const.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_21c92078","line":3038,"updated":"2020-01-03 18:24:46.000000000","message":"Should these be something like phys_br.assert_not_called() or self.assertFalse(phys_br.called) ?  I think the latter.","commit_id":"feed8a64bfc470d46bf4ebd235b6ca05c33eefd8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9ed83b29d4e439a7315f1079f6ac831af7989300","unresolved":false,"context_lines":[{"line_number":3035,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3036,"context_line":"            self.assertEqual(expected_on_int_br, int_br.mock_calls)"},{"line_number":3037,"context_line":"            self.assertFalse(tun_br.mock_calls)"},{"line_number":3038,"context_line":"            self.assertFalse(phys_br.mock_calls)"},{"line_number":3039,"context_line":""},{"line_number":3040,"context_line":"    def _test_port_bound_for_dvr_on_vxlan_network("},{"line_number":3041,"context_line":"            self, device_owner, ip_version\u003dn_const.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7b7e2e6e","line":3038,"in_reply_to":"3fa7e38b_15783e2a","updated":"2020-01-17 10:08:09.000000000","message":"I updated this patch to use assert_not_called() and assert_has_calls() everywhere. I hope it will be better for Brian now :)","commit_id":"feed8a64bfc470d46bf4ebd235b6ca05c33eefd8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de709ab84517d5b298dc29790c77093b4988cb7c","unresolved":false,"context_lines":[{"line_number":3035,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3036,"context_line":"            self.assertEqual(expected_on_int_br, int_br.mock_calls)"},{"line_number":3037,"context_line":"            self.assertFalse(tun_br.mock_calls)"},{"line_number":3038,"context_line":"            self.assertFalse(phys_br.mock_calls)"},{"line_number":3039,"context_line":""},{"line_number":3040,"context_line":"    def _test_port_bound_for_dvr_on_vxlan_network("},{"line_number":3041,"context_line":"            self, device_owner, ip_version\u003dn_const.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_bf8aa062","line":3038,"in_reply_to":"3fa7e38b_21c92078","updated":"2020-01-13 14:37:45.000000000","message":"I\u0027m going to change my vote to a -1, just because looking further through this file and others, using assertFalse and assertEqual aren\u0027t what we should be using, one of the two options I put above is better.\n\nThis would also apply to all the assertEqual([], foo.mock_calls) in this file - we should fix the ones here too, this seems to be one of the only test files we do that.","commit_id":"feed8a64bfc470d46bf4ebd235b6ca05c33eefd8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0e23091d576922a3582db7165e44c45faa70be64","unresolved":false,"context_lines":[{"line_number":3035,"context_line":"                                          network_type\u003dnetwork_type)"},{"line_number":3036,"context_line":"            self.assertEqual(expected_on_int_br, int_br.mock_calls)"},{"line_number":3037,"context_line":"            self.assertFalse(tun_br.mock_calls)"},{"line_number":3038,"context_line":"            self.assertFalse(phys_br.mock_calls)"},{"line_number":3039,"context_line":""},{"line_number":3040,"context_line":"    def _test_port_bound_for_dvr_on_vxlan_network("},{"line_number":3041,"context_line":"            self, device_owner, ip_version\u003dn_const.IP_VERSION_4):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_15783e2a","line":3038,"in_reply_to":"3fa7e38b_bf8aa062","updated":"2020-01-16 02:58:40.000000000","message":"oh, I don\u0027t know exactly what the assert statements should be, so please feel free to fix them if you like, thanks:)","commit_id":"feed8a64bfc470d46bf4ebd235b6ca05c33eefd8"}]}