)]}'
{"devstack/lib/ovn_agent":[{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"66f2085107ef846a708fc7db78691a88a8d002eb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":117,"context_line":"Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS:-\"vni_ranges\u003d1:65536\"}"},{"line_number":118,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security,dns}"},{"line_number":119,"context_line":"ML2_L3_PLUGIN\u003d\"neutron.services.ovn_l3.plugin.OVNL3RouterPlugin,trunk\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Utility Functions"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_f6f2cf68","line":119,"updated":"2020-01-07 14:13:12.000000000","message":"This could be ``ovn-router`` ref https://github.com/openstack/neutron/blob/ac63c570a1c630ac4405e4caf3d516d069165d69/setup.cfg#L81","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f51a99bfb5f7f18ed07b669c703f00eb739b0b12","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":117,"context_line":"Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS:-\"vni_ranges\u003d1:65536\"}"},{"line_number":118,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security,dns}"},{"line_number":119,"context_line":"ML2_L3_PLUGIN\u003d\"neutron.services.ovn_l3.plugin.OVNL3RouterPlugin,trunk\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Utility Functions"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_1c88ed1f","line":119,"in_reply_to":"3fa7e38b_7c580124","updated":"2020-01-07 14:46:54.000000000","message":"nice, will change!","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f55360a59314ddf556717d146423ca1c4af66346","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":117,"context_line":"Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS:-\"vni_ranges\u003d1:65536\"}"},{"line_number":118,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security,dns}"},{"line_number":119,"context_line":"ML2_L3_PLUGIN\u003d\"neutron.services.ovn_l3.plugin.OVNL3RouterPlugin,trunk\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Utility Functions"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_560c0343","line":119,"in_reply_to":"3fa7e38b_f6f2cf68","updated":"2020-01-07 14:20:19.000000000","message":"+1","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"455e585a121070daecdeb16c912e68adaf4e6cc2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":117,"context_line":"Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GENEVE_TYPE_OPTIONS:-\"vni_ranges\u003d1:65536\"}"},{"line_number":118,"context_line":"Q_ML2_PLUGIN_EXT_DRIVERS\u003d${Q_ML2_PLUGIN_EXT_DRIVERS:-port_security,dns}"},{"line_number":119,"context_line":"ML2_L3_PLUGIN\u003d\"neutron.services.ovn_l3.plugin.OVNL3RouterPlugin,trunk\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Utility Functions"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_7c580124","line":119,"in_reply_to":"3fa7e38b_f6f2cf68","updated":"2020-01-07 14:27:58.000000000","message":"yep +1","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"0920ff5cc7022c789cf1316029acd118a082de59","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    fi"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    if is_service_enabled n-api-meta ; then"},{"line_number":517,"context_line":"        if is_service_enabled neutron-ovn-metadata-agent ; then"},{"line_number":518,"context_line":"            iniset $NOVA_CONF neutron service_metadata_proxy True"},{"line_number":519,"context_line":"        fi"},{"line_number":520,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_76e7bfac","line":517,"range":{"start_line":517,"start_character":30,"end_line":517,"end_character":56},"updated":"2020-01-07 14:17:24.000000000","message":"Hum, so we should unique the naming now?\nI think we still have some differences between those two right?","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f51a99bfb5f7f18ed07b669c703f00eb739b0b12","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    fi"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    if is_service_enabled n-api-meta ; then"},{"line_number":517,"context_line":"        if is_service_enabled neutron-ovn-metadata-agent ; then"},{"line_number":518,"context_line":"            iniset $NOVA_CONF neutron service_metadata_proxy True"},{"line_number":519,"context_line":"        fi"},{"line_number":520,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_7c6c816a","line":517,"range":{"start_line":517,"start_character":30,"end_line":517,"end_character":56},"in_reply_to":"3fa7e38b_3c9cc9bd","updated":"2020-01-07 14:46:54.000000000","message":"hah it\u0027s not stupid no...\n\nBut yeah for now the OVN metadata agent and the Neutron metadata agent are two different agents with different code bases so we should keep it separated.","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"455e585a121070daecdeb16c912e68adaf4e6cc2","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    fi"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    if is_service_enabled n-api-meta ; then"},{"line_number":517,"context_line":"        if is_service_enabled neutron-ovn-metadata-agent ; then"},{"line_number":518,"context_line":"            iniset $NOVA_CONF neutron service_metadata_proxy True"},{"line_number":519,"context_line":"        fi"},{"line_number":520,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_3c9cc9bd","line":517,"range":{"start_line":517,"start_character":30,"end_line":517,"end_character":56},"in_reply_to":"3fa7e38b_76e7bfac","updated":"2020-01-07 14:27:58.000000000","message":"Don\u0027t look. Sorry, stupid comment.","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"66f2085107ef846a708fc7db78691a88a8d002eb","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    fi"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    if is_service_enabled neutron-ovn-metadata-agent; then"},{"line_number":694,"context_line":"        run_process neutron-ovn-metadata-agent \"$NEUTRON_OVN_BIN_DIR/$NEUTRON_OVN_METADATA_BINARY --config-file $OVN_META_CONF\""},{"line_number":695,"context_line":"        # Format logging"},{"line_number":696,"context_line":"        setup_logging $OVN_META_CONF"},{"line_number":697,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_d6a31343","line":694,"updated":"2020-01-07 14:13:12.000000000","message":"Would it make sense to pull in ``/$Q_PLUGIN_CONF_FILE`` here so that we do not need to configure the SB connection properties multiple places?","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8ab7fb4bd5fd41bac750f129acede71bf4adaeca","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    fi"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    if is_service_enabled neutron-ovn-metadata-agent; then"},{"line_number":694,"context_line":"        run_process neutron-ovn-metadata-agent \"$NEUTRON_OVN_BIN_DIR/$NEUTRON_OVN_METADATA_BINARY --config-file $OVN_META_CONF\""},{"line_number":695,"context_line":"        # Format logging"},{"line_number":696,"context_line":"        setup_logging $OVN_META_CONF"},{"line_number":697,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_bc37594b","line":694,"in_reply_to":"3fa7e38b_7cba41ba","updated":"2020-01-07 14:50:17.000000000","message":"Yup, that\u0027s fine, I\u0027ll propose it along with my test-with-TLS work which is where the duplication gets visible.","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f55360a59314ddf556717d146423ca1c4af66346","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    fi"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    if is_service_enabled neutron-ovn-metadata-agent; then"},{"line_number":694,"context_line":"        run_process neutron-ovn-metadata-agent \"$NEUTRON_OVN_BIN_DIR/$NEUTRON_OVN_METADATA_BINARY --config-file $OVN_META_CONF\""},{"line_number":695,"context_line":"        # Format logging"},{"line_number":696,"context_line":"        setup_logging $OVN_META_CONF"},{"line_number":697,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_dc025508","line":694,"in_reply_to":"3fa7e38b_d6a31343","updated":"2020-01-07 14:20:19.000000000","message":"I think this can be handle in a follow-up patch, not now.\n\nBut it makes sense.","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f51a99bfb5f7f18ed07b669c703f00eb739b0b12","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    fi"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    if is_service_enabled neutron-ovn-metadata-agent; then"},{"line_number":694,"context_line":"        run_process neutron-ovn-metadata-agent \"$NEUTRON_OVN_BIN_DIR/$NEUTRON_OVN_METADATA_BINARY --config-file $OVN_META_CONF\""},{"line_number":695,"context_line":"        # Format logging"},{"line_number":696,"context_line":"        setup_logging $OVN_META_CONF"},{"line_number":697,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_7cba41ba","line":694,"in_reply_to":"3fa7e38b_dc025508","updated":"2020-01-07 14:46:54.000000000","message":"Yeah it\u0027s a good point. If you do not mind I can tackle it in a separated patch as Rodolfo suggested and this patch is just to make things start working (since before, we weren\u0027t able to even deploy the OVN driver from the neutron repository).","commit_id":"3d107345d66db3b790262d83680b07095dc75b5b"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3c097db577048c6250a4922fe399a887af56d96","unresolved":false,"context_lines":[{"line_number":795,"context_line":"        # FIXME(lucasagomes): PortContext does not have a session,"},{"line_number":796,"context_line":"        # we need to investigate why"},{"line_number":797,"context_line":"        db_rev.delete_revision(context._plugin_context, port_id,"},{"line_number":798,"context_line":"                               ovn_const.TYPE_PORTS)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    def _create_or_update_floatingip(self, floatingip, txn\u003dNone):"},{"line_number":801,"context_line":"        router_id \u003d floatingip.get(\u0027router_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_927a79b8","line":798,"updated":"2020-01-08 10:36:06.000000000","message":"Just for the record: I think we need to make this change here [1]\n\n[1] https://review.opendev.org/#/c/697698/12/neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py@617","commit_id":"ad84740231d1835befa6a777e781b583f1f6cff5"}]}