)]}'
{"neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"373e976519c52b4ccce025ad97fe0e784ac9b617","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from neutron.agent.ovn.metadata import agent"},{"line_number":18,"context_line":"from neutron.agent.ovn.metadata import ovsdb"},{"line_number":19,"context_line":"from neutron.agent.ovn.metadata import server as metadata_server"},{"line_number":20,"context_line":"from neutron.common.ovn import constants as ovn_const"},{"line_number":21,"context_line":"from neutron.common import utils as n_utils"},{"line_number":22,"context_line":"from neutron.conf.agent.metadata import config as meta_config"},{"line_number":23,"context_line":"from neutron.conf.agent.ovn.metadata import config as meta_config_ovn"},{"line_number":24,"context_line":"from neutron.tests.functional import base"},{"line_number":25,"context_line":"from oslo_config import fixture as fixture_config"},{"line_number":26,"context_line":"from oslo_utils import uuidutils"},{"line_number":27,"context_line":"from ovsdbapp.backend.ovs_idl import event"}],"source_content_type":"text/x-python","patch_set":38,"id":"3fa7e38b_59a2a5ae","line":24,"range":{"start_line":17,"start_character":0,"end_line":24,"end_character":41},"updated":"2020-02-18 04:37:27.000000000","message":"neutron imports are not third party imports but project imports now. They need to be moved below as a separate import group.","commit_id":"a164270e86857ded7f37cf900228ef4ed789d339"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27833380f283a5379990a681c455a3c30fe90633","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from neutron.agent.ovn.metadata import agent"},{"line_number":18,"context_line":"from neutron.agent.ovn.metadata import ovsdb"},{"line_number":19,"context_line":"from neutron.agent.ovn.metadata import server as metadata_server"},{"line_number":20,"context_line":"from neutron.common.ovn import constants as ovn_const"},{"line_number":21,"context_line":"from neutron.common import utils as n_utils"},{"line_number":22,"context_line":"from neutron.conf.agent.metadata import config as meta_config"},{"line_number":23,"context_line":"from neutron.conf.agent.ovn.metadata import config as meta_config_ovn"},{"line_number":24,"context_line":"from neutron.tests.functional import base"},{"line_number":25,"context_line":"from oslo_config import fixture as fixture_config"},{"line_number":26,"context_line":"from oslo_utils import uuidutils"},{"line_number":27,"context_line":"from ovsdbapp.backend.ovs_idl import event"}],"source_content_type":"text/x-python","patch_set":38,"id":"3fa7e38b_59a94576","line":24,"range":{"start_line":17,"start_character":0,"end_line":24,"end_character":41},"in_reply_to":"3fa7e38b_59a2a5ae","updated":"2020-02-18 04:46:47.000000000","message":"Done","commit_id":"a164270e86857ded7f37cf900228ef4ed789d339"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"9c796641df66c59082a5ba3ae969bacaf654ac09","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    # Please see neutron/tests/contrib/gate_hook.sh."},{"line_number":165,"context_line":"    # It installs openvswitch in the \u0027/usr/local\u0027 path and the ovn-nb schema"},{"line_number":166,"context_line":"    # file will be present in this path."},{"line_number":167,"context_line":"    OVS_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/openvswitch\u0027"},{"line_number":168,"context_line":"    OVN_INSTALL_SHARE_PATH \u003d \u0027/usr/local/share/ovn\u0027"},{"line_number":169,"context_line":"    _mechanism_drivers \u003d [\u0027logger\u0027, \u0027ovn\u0027]"},{"line_number":170,"context_line":"    _extension_drivers \u003d [\u0027port_security\u0027]"},{"line_number":171,"context_line":"    _counter \u003d 0"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_baef991a","line":168,"range":{"start_line":167,"start_character":3,"end_line":168,"end_character":51},"updated":"2020-01-21 08:53:16.000000000","message":"Looks like those variables needs to be modified.","commit_id":"66f76e9fb76e2114a732adab07d369fa1f6bf50b"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"cea39f22f4f4bf1aa0fd51b740f2a13c0db8b880","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            for distribution in [self.OVN_DISTRIBUTION, self.OVS_DISTRIBUTION]:"},{"line_number":206,"context_line":"                exists \u003d True"},{"line_number":207,"context_line":"                for ovn_file in self.OVN_SCHEMA_FILES:"},{"line_number":208,"context_line":"                    path \u003d os.path.join(\u0027/usr\u0027, installation, \u0027share\u0027,"},{"line_number":209,"context_line":"                                        distribution, ovn_file)"},{"line_number":210,"context_line":"                    exists \u0026\u003d os.path.isfile(path)"},{"line_number":211,"context_line":"                if exists:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_513d2327","line":208,"range":{"start_line":208,"start_character":39,"end_line":208,"end_character":47},"updated":"2020-01-21 16:08:09.000000000","message":"since you are going through path.join -- which is nice -- replace: \u0027/usr/\u0027,\nwith:  os.path.sep, \u0027usr\u0027,","commit_id":"483ffa1acb0531dd673f7cdaf70e3cfa5b920b70"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1bd5a3077fc64297351f40e55b712b97e37d220a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            for distribution in [self.OVN_DISTRIBUTION, self.OVS_DISTRIBUTION]:"},{"line_number":206,"context_line":"                exists \u003d True"},{"line_number":207,"context_line":"                for ovn_file in self.OVN_SCHEMA_FILES:"},{"line_number":208,"context_line":"                    path \u003d os.path.join(\u0027/usr\u0027, installation, \u0027share\u0027,"},{"line_number":209,"context_line":"                                        distribution, ovn_file)"},{"line_number":210,"context_line":"                    exists \u0026\u003d os.path.isfile(path)"},{"line_number":211,"context_line":"                if exists:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_1b27bd20","line":208,"range":{"start_line":208,"start_character":39,"end_line":208,"end_character":47},"in_reply_to":"3fa7e38b_513d2327","updated":"2020-01-22 10:57:46.000000000","message":"Ok! Done, thanks!","commit_id":"483ffa1acb0531dd673f7cdaf70e3cfa5b920b70"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"844d14a96bf53e2d8dac99e6843f95fe902475f0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            for distribution in [self.OVN_DISTRIBUTION, self.OVS_DISTRIBUTION]:"},{"line_number":206,"context_line":"                exists \u003d True"},{"line_number":207,"context_line":"                for ovn_file in self.OVN_SCHEMA_FILES:"},{"line_number":208,"context_line":"                    path \u003d os.path.join(\u0027/usr\u0027, installation, \u0027share\u0027,"},{"line_number":209,"context_line":"                                        distribution, ovn_file)"},{"line_number":210,"context_line":"                    exists \u0026\u003d os.path.isfile(path)"},{"line_number":211,"context_line":"                if exists:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_b153376e","line":208,"range":{"start_line":208,"start_character":39,"end_line":208,"end_character":47},"in_reply_to":"3fa7e38b_513d2327","updated":"2020-01-21 16:10:13.000000000","message":"path \u003d os.path.join(os.path.sep, \u0027usr\u0027, installation, \u0027share\u0027,","commit_id":"483ffa1acb0531dd673f7cdaf70e3cfa5b920b70"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8fe1cec6b5798f40efd8aa3e489031c273572e38","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                if exists:"},{"line_number":212,"context_line":"                    return os.path.dirname(path)"},{"line_number":213,"context_line":"        raise FileNotFoundError("},{"line_number":214,"context_line":"                    errno.ENOENT, os.strerror(errno.ENOENT), path)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # FIXME(lucasagomes): Workaround for"},{"line_number":217,"context_line":"    # https://bugs.launchpad.net/networking-ovn/+bug/1808146. We should"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_9042a73b","line":214,"range":{"start_line":214,"start_character":61,"end_line":214,"end_character":65},"updated":"2020-01-22 10:11:20.000000000","message":"This path will always be the last path no ?\n\nSince we do not fail if the file is not found at L210, it means that if the \"ovn-nb.ovsschema\" is missing (the first one) this error will still point to the \"ovn-sb.ovsschema\" as missing because the \"if exists\" checks runs after the for at L207.\n\nCan be a bit misleading I think.\n\nLet me know if that\u0027s the case please.","commit_id":"c1781d52eb14ce6b5ddcccaf1f4abcf812ffa729"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1bd5a3077fc64297351f40e55b712b97e37d220a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                if exists:"},{"line_number":212,"context_line":"                    return os.path.dirname(path)"},{"line_number":213,"context_line":"        raise FileNotFoundError("},{"line_number":214,"context_line":"                    errno.ENOENT, os.strerror(errno.ENOENT), path)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # FIXME(lucasagomes): Workaround for"},{"line_number":217,"context_line":"    # https://bugs.launchpad.net/networking-ovn/+bug/1808146. We should"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_707a8bf0","line":214,"range":{"start_line":214,"start_character":61,"end_line":214,"end_character":65},"in_reply_to":"3fa7e38b_9042a73b","updated":"2020-01-22 10:57:46.000000000","message":"Updated. Please check latest ps. :) Thanks!","commit_id":"c1781d52eb14ce6b5ddcccaf1f4abcf812ffa729"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"0011865a8e22a1ff5f20be3537bc4b2562a6e4df","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self._start_ovsdb_server_and_idls()"},{"line_number":201,"context_line":"        self._start_ovn_northd()"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_install_share_path(self):"},{"line_number":204,"context_line":"        lookup_paths \u003d set()"},{"line_number":205,"context_line":"        for installation in [\u0027local\u0027, \u0027\u0027]:"},{"line_number":206,"context_line":"            for distribution in [self.OVN_DISTRIBUTION, self.OVS_DISTRIBUTION]:"}],"source_content_type":"text/x-python","patch_set":20,"id":"3fa7e38b_f8a6520d","line":203,"range":{"start_line":203,"start_character":4,"end_line":203,"end_character":38},"updated":"2020-01-23 10:33:56.000000000","message":"Let\u0027s change this to look more like how it is done in \nhttps://review.opendev.org/#/c/703883/","commit_id":"da24b99cabf96396d24728b8d3c0f4f36e53d88b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"294709ec214f762bb00dce1da9af9ec40f7c4c34","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                          new\u003dovs_agent_decorator).start()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ConnectionFixture(fixtures.Fixture):"},{"line_number":128,"context_line":"    def __init__(self, idl\u003dNone, constr\u003dNone, schema\u003dNone, timeout\u003d60):"},{"line_number":129,"context_line":"        self.idl \u003d idl or ovsdb_monitor.BaseOvnIdl.from_server("},{"line_number":130,"context_line":"            constr, schema)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_e2499865","line":127,"updated":"2020-01-27 17:55:42.000000000","message":"this class could go into neutron.test.common, in a file named like conn_fixture]. Or into the new directory functional/resources\n\nAlso this is not a simple connection fixture, this is a OVNIdlConnectionFixture, IMO","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"604a8acb9439447029dfa8b607a015920dda8744","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                          new\u003dovs_agent_decorator).start()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ConnectionFixture(fixtures.Fixture):"},{"line_number":128,"context_line":"    def __init__(self, idl\u003dNone, constr\u003dNone, schema\u003dNone, timeout\u003d60):"},{"line_number":129,"context_line":"        self.idl \u003d idl or ovsdb_monitor.BaseOvnIdl.from_server("},{"line_number":130,"context_line":"            constr, schema)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_0952cd36","line":127,"in_reply_to":"3fa7e38b_e2499865","updated":"2020-01-28 14:12:42.000000000","message":"Ok, I\u0027ll do this.","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"4d5435de6dd3140c72e93a4d423c8975f92570fc","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":170,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":173,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"},{"line_number":174,"context_line":"        self.test_log_dir \u003d os.path.join(DEFAULT_LOG_DIR, self.id())"},{"line_number":175,"context_line":"        base.setup_test_logging("}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa7e38b_71076dca","line":172,"updated":"2020-01-31 15:09:15.000000000","message":"whoa. That was a hard one to seek. Good job!","commit_id":"536f3c49a3f60397f3ff07cbbfdeaa282d72218e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9bba077489b3e89769155b68eb52822d2245439e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":170,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":173,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"},{"line_number":174,"context_line":"        self.test_log_dir \u003d os.path.join(DEFAULT_LOG_DIR, self.id())"},{"line_number":175,"context_line":"        base.setup_test_logging("}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa7e38b_111159f9","line":172,"in_reply_to":"3fa7e38b_71076dca","updated":"2020-01-31 15:11:58.000000000","message":"+1","commit_id":"536f3c49a3f60397f3ff07cbbfdeaa282d72218e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"2f60298f5ed87ce55db7faa1b5f8d93a5f08834d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        ml2_config.cfg.CONF.set_override(\u0027vni_ranges\u0027,"},{"line_number":169,"context_line":"                                     [\u00271:65536\u0027],"},{"line_number":170,"context_line":"                                     group\u003d\u0027ml2_type_geneve\u0027)"},{"line_number":171,"context_line":"        ml2_config.cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":172,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":173,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":176,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":40,"id":"3fa7e38b_006589b0","line":173,"range":{"start_line":171,"start_character":0,"end_line":173,"end_character":49},"updated":"2020-02-18 13:34:02.000000000","message":"This option is not registered in ml2_config. We need to remove it from here.","commit_id":"c5ec785ec9935848058272198ad96662288424b7"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_impl_idl.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"294709ec214f762bb00dce1da9af9ec40f7c4c34","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestSbApi(base.FunctionalTestCase):"},{"line_number":27,"context_line":"    schemas \u003d [\u0027OVN_Southbound\u0027, \u0027OVN_Northbound\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestSbApi, self).setUp()"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_02d39438","line":27,"updated":"2020-01-27 17:55:42.000000000","message":"Where are you using this variable?","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"643539e1f0d067e9d2cfa960d0d68c70bedcd0b5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestSbApi(base.FunctionalTestCase):"},{"line_number":27,"context_line":"    schemas \u003d [\u0027OVN_Southbound\u0027, \u0027OVN_Northbound\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestSbApi, self).setUp()"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_1d8bf5c0","line":27,"in_reply_to":"3fa7e38b_02d39438","updated":"2020-01-27 18:02:48.000000000","message":"It\u0027s part of the ovsdbapp test code. https://github.com/openstack/ovsdbapp/blob/781ecb5bf648774f5d365585a0c2c13442523754/ovsdbapp/tests/functional/base.py#L57","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5516fc6e077e5ab441f76d33ecb22aed0fe9c106","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestSbApi(base.FunctionalTestCase):"},{"line_number":27,"context_line":"    schemas \u003d [\u0027OVN_Southbound\u0027, \u0027OVN_Northbound\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestSbApi, self).setUp()"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_f4ef0483","line":27,"in_reply_to":"3fa7e38b_1d8bf5c0","updated":"2020-01-28 14:40:33.000000000","message":"Ahhhh OK, thanks!","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e10bb0504b85ef405be8bd98321f4cafffd5f0d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.tests.functional.resources.ovsdb import events"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestSbApi(base.FunctionalTestCase):"},{"line_number":27,"context_line":"    schemas \u003d [\u0027OVN_Southbound\u0027, \u0027OVN_Northbound\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa7e38b_c85a2884","line":26,"updated":"2020-02-03 09:16:41.000000000","message":"this class should inherits from BaseLoggingTestCase or BaseSudoTestCase - than we would have logs from tests like neutron.tests.functional.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_impl_idl.TestSbApi in https://657f0c8ccc2e86eac912-55b0c2ba5371c8fe68fb316789a202d6.ssl.cf2.rackcdn.com/701733/27/check/neutron-functional/cfa1eaa/controller/logs/dsvm-functional-logs/ - now they are not available","commit_id":"536f3c49a3f60397f3ff07cbbfdeaa282d72218e"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"294709ec214f762bb00dce1da9af9ec40f7c4c34","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"@mock.patch(\u0027neutron.db.ovn_revision_numbers_db.\u0027"},{"line_number":226,"context_line":"            \u0027INCONSISTENCIES_OLDER_THAN\u0027, -1)"},{"line_number":227,"context_line":"class TestMaintenance(_TestMaintenanceHelper):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_network(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_c2b1fc01","line":226,"updated":"2020-01-27 17:55:42.000000000","message":"Why don\u0027t you patch this in the parent class, in setUp()?","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"31fd074da4541d03d48903347c03665f0541c759","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"@mock.patch(\u0027neutron.db.ovn_revision_numbers_db.\u0027"},{"line_number":226,"context_line":"            \u0027INCONSISTENCIES_OLDER_THAN\u0027, -1)"},{"line_number":227,"context_line":"class TestMaintenance(_TestMaintenanceHelper):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_network(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_dbdea969","line":226,"in_reply_to":"3fa7e38b_691ca17a","updated":"2020-01-29 09:38:21.000000000","message":"Sure I don\u0027t see any problem with that","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"604a8acb9439447029dfa8b607a015920dda8744","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"@mock.patch(\u0027neutron.db.ovn_revision_numbers_db.\u0027"},{"line_number":226,"context_line":"            \u0027INCONSISTENCIES_OLDER_THAN\u0027, -1)"},{"line_number":227,"context_line":"class TestMaintenance(_TestMaintenanceHelper):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_network(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_691ca17a","line":226,"in_reply_to":"3fa7e38b_c2b1fc01","updated":"2020-01-28 14:12:42.000000000","message":"Looks like there is no test in parent class.\nLucas that should be fine to move to parent right?","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"381d832a777e5af02c05ec1115e2289703301667","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"@mock.patch(\u0027neutron.db.ovn_revision_numbers_db.\u0027"},{"line_number":226,"context_line":"            \u0027INCONSISTENCIES_OLDER_THAN\u0027, -1)"},{"line_number":227,"context_line":"class TestMaintenance(_TestMaintenanceHelper):"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_network(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_a194dee7","line":226,"in_reply_to":"3fa7e38b_dbdea969","updated":"2020-01-29 13:04:44.000000000","message":"Thats a variable in module. I add monkey patching of it in setup.","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e10bb0504b85ef405be8bd98321f4cafffd5f0d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                return row"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class TestMaintenance(_TestMaintenanceHelper):"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test_network(self):"},{"line_number":220,"context_line":"        net_name \u003d \u0027networktest\u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa7e38b_c8bf8877","line":217,"updated":"2020-02-03 09:16:41.000000000","message":"same here, and probably in other classes which logs are not available there :)","commit_id":"536f3c49a3f60397f3ff07cbbfdeaa282d72218e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"94ebd2bfbb76d8775b4e7f630b2e5f86b3802389","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                return row"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class TestMaintenance(_TestMaintenanceHelper):"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test_network(self):"},{"line_number":220,"context_line":"        net_name \u003d \u0027networktest\u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa7e38b_8865101f","line":217,"in_reply_to":"3fa7e38b_c8bf8877","updated":"2020-02-03 09:25:45.000000000","message":"++","commit_id":"536f3c49a3f60397f3ff07cbbfdeaa282d72218e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"373e976519c52b4ccce025ad97fe0e784ac9b617","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from futurist import periodics"},{"line_number":19,"context_line":"from neutron.common.ovn import constants as ovn_const"},{"line_number":20,"context_line":"from neutron.common.ovn import utils"},{"line_number":21,"context_line":"from neutron.conf.plugins.ml2.drivers.ovn import ovn_conf as ovn_config"},{"line_number":22,"context_line":"from neutron.db import ovn_revision_numbers_db as db_rev"},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb import maintenance"},{"line_number":24,"context_line":"from neutron.tests.functional import base"},{"line_number":25,"context_line":"from neutron.tests.unit.api import test_extensions"},{"line_number":26,"context_line":"from neutron.tests.unit.extensions import test_extraroute"},{"line_number":27,"context_line":"from neutron_lib.api.definitions import external_net as extnet_apidef"},{"line_number":28,"context_line":"from neutron_lib import constants as n_const"},{"line_number":29,"context_line":"from neutron_lib import context as n_context"}],"source_content_type":"text/x-python","patch_set":38,"id":"3fa7e38b_9981fd00","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":57},"updated":"2020-02-18 04:37:27.000000000","message":"neutron imports needs to be moved below.","commit_id":"a164270e86857ded7f37cf900228ef4ed789d339"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27833380f283a5379990a681c455a3c30fe90633","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from futurist import periodics"},{"line_number":19,"context_line":"from neutron.common.ovn import constants as ovn_const"},{"line_number":20,"context_line":"from neutron.common.ovn import utils"},{"line_number":21,"context_line":"from neutron.conf.plugins.ml2.drivers.ovn import ovn_conf as ovn_config"},{"line_number":22,"context_line":"from neutron.db import ovn_revision_numbers_db as db_rev"},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb import maintenance"},{"line_number":24,"context_line":"from neutron.tests.functional import base"},{"line_number":25,"context_line":"from neutron.tests.unit.api import test_extensions"},{"line_number":26,"context_line":"from neutron.tests.unit.extensions import test_extraroute"},{"line_number":27,"context_line":"from neutron_lib.api.definitions import external_net as extnet_apidef"},{"line_number":28,"context_line":"from neutron_lib import constants as n_const"},{"line_number":29,"context_line":"from neutron_lib import context as n_context"}],"source_content_type":"text/x-python","patch_set":38,"id":"3fa7e38b_99d49df2","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":57},"in_reply_to":"3fa7e38b_9981fd00","updated":"2020-02-18 04:46:47.000000000","message":"Done","commit_id":"a164270e86857ded7f37cf900228ef4ed789d339"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89e83b3d6d576416be6c2a0a426ca8591bbedbbd","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        # Assert the virt port has the type virtual and master is set"},{"line_number":251,"context_line":"        # as parent"},{"line_number":252,"context_line":"        n_utils.wait_until_true("},{"line_number":253,"context_line":"            lambda: self._is_ovn_port_type("},{"line_number":254,"context_line":"                virt_port[\u0027id\u0027], ovn_const.LSP_TYPE_VIRTUAL),"},{"line_number":255,"context_line":"            timeout\u003d10)"},{"line_number":256,"context_line":"        ovn_vport \u003d self._find_port_row(virt_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_656f0461","line":253,"updated":"2020-02-12 11:59:03.000000000","message":"You need the method reference, here you are passing the method result. Something like http://paste.openstack.org/show/789460/","commit_id":"85f78d995df9cf5b7d50b327d87940d036890119"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"690581af379d88e9db702a838d5199a7fa68b608","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        # Assert the virt port has the type virtual and master is set"},{"line_number":251,"context_line":"        # as parent"},{"line_number":252,"context_line":"        n_utils.wait_until_true("},{"line_number":253,"context_line":"            lambda: self._is_ovn_port_type("},{"line_number":254,"context_line":"                virt_port[\u0027id\u0027], ovn_const.LSP_TYPE_VIRTUAL),"},{"line_number":255,"context_line":"            timeout\u003d10)"},{"line_number":256,"context_line":"        ovn_vport \u003d self._find_port_row(virt_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_5075e495","line":253,"in_reply_to":"3fa7e38b_656f0461","updated":"2020-02-12 12:49:29.000000000","message":"Thanks for helpful comments! I updated it in new PS.","commit_id":"85f78d995df9cf5b7d50b327d87940d036890119"}],"neutron/tests/functional/requirements.txt":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"294709ec214f762bb00dce1da9af9ec40f7c4c34","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"psycopg2"},{"line_number":8,"context_line":"psutil\u003e\u003d1.1.1,\u003c2.0.0"},{"line_number":9,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":24,"id":"3fa7e38b_621e080e","line":8,"updated":"2020-01-27 17:55:42.000000000","message":"Why this limitation? os-ken, nova or neutron-vpnass set the lower version in 3.2.2","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"604a8acb9439447029dfa8b607a015920dda8744","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"psycopg2"},{"line_number":8,"context_line":"psutil\u003e\u003d1.1.1,\u003c2.0.0"},{"line_number":9,"context_line":"PyMySQL\u003e\u003d0.6.2  # MIT License"}],"source_content_type":"text/plain","patch_set":24,"id":"3fa7e38b_292229b8","line":8,"in_reply_to":"3fa7e38b_621e080e","updated":"2020-01-28 14:12:42.000000000","message":"Thats copy-paste from previous code. I\u0027ll update it. Thanks for pointing this out!","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"}],"neutron/tests/functional/resources/process.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"294709ec214f762bb00dce1da9af9ec40f7c4c34","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _setUp(self):"},{"line_number":108,"context_line":"        if self.ovn_nb_db:"},{"line_number":109,"context_line":"            self.ovsdb_server_processes.append("},{"line_number":110,"context_line":"                {\u0027db_path\u0027: self.temp_dir + \u0027/ovn_nb.db\u0027,"},{"line_number":111,"context_line":"                 \u0027schema_path\u0027: self.ovs_dir + \u0027/ovn-nb.ovsschema\u0027,"},{"line_number":112,"context_line":"                 \u0027remote_path\u0027: self.temp_dir + \u0027/ovnnb_db.sock\u0027,"},{"line_number":113,"context_line":"                 \u0027protocol\u0027: self.protocol,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_a23960a2","line":110,"updated":"2020-01-27 17:55:42.000000000","message":"maybe better use os.path.join (and in the rest of config parameters)","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"604a8acb9439447029dfa8b607a015920dda8744","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _setUp(self):"},{"line_number":108,"context_line":"        if self.ovn_nb_db:"},{"line_number":109,"context_line":"            self.ovsdb_server_processes.append("},{"line_number":110,"context_line":"                {\u0027db_path\u0027: self.temp_dir + \u0027/ovn_nb.db\u0027,"},{"line_number":111,"context_line":"                 \u0027schema_path\u0027: self.ovs_dir + \u0027/ovn-nb.ovsschema\u0027,"},{"line_number":112,"context_line":"                 \u0027remote_path\u0027: self.temp_dir + \u0027/ovnnb_db.sock\u0027,"},{"line_number":113,"context_line":"                 \u0027protocol\u0027: self.protocol,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_c916f558","line":110,"in_reply_to":"3fa7e38b_a23960a2","updated":"2020-01-28 14:12:42.000000000","message":"I\u0027ll do. Thanks","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"381d832a777e5af02c05ec1115e2289703301667","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _setUp(self):"},{"line_number":108,"context_line":"        if self.ovn_nb_db:"},{"line_number":109,"context_line":"            self.ovsdb_server_processes.append("},{"line_number":110,"context_line":"                {\u0027db_path\u0027: self.temp_dir + \u0027/ovn_nb.db\u0027,"},{"line_number":111,"context_line":"                 \u0027schema_path\u0027: self.ovs_dir + \u0027/ovn-nb.ovsschema\u0027,"},{"line_number":112,"context_line":"                 \u0027remote_path\u0027: self.temp_dir + \u0027/ovnnb_db.sock\u0027,"},{"line_number":113,"context_line":"                 \u0027protocol\u0027: self.protocol,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3fa7e38b_acfe1501","line":110,"in_reply_to":"3fa7e38b_c916f558","updated":"2020-01-29 13:04:44.000000000","message":"done","commit_id":"307d2eaa81e9f855e0c77200d5a16fd734995692"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"373e976519c52b4ccce025ad97fe0e784ac9b617","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import fixtures"},{"line_number":20,"context_line":"from neutron.agent.linux import utils"},{"line_number":21,"context_line":"import psutil"},{"line_number":22,"context_line":"import tenacity"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"3fa7e38b_b98b9914","line":20,"updated":"2020-02-18 04:37:27.000000000","message":"neutron import is a project import.","commit_id":"a164270e86857ded7f37cf900228ef4ed789d339"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27833380f283a5379990a681c455a3c30fe90633","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import fixtures"},{"line_number":20,"context_line":"from neutron.agent.linux import utils"},{"line_number":21,"context_line":"import psutil"},{"line_number":22,"context_line":"import tenacity"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"3fa7e38b_59de2510","line":20,"in_reply_to":"3fa7e38b_b98b9914","updated":"2020-02-18 04:46:47.000000000","message":"Done","commit_id":"a164270e86857ded7f37cf900228ef4ed789d339"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e2301219c05ed75ae26542af5e733f28c6848691","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def _api_for_resource(self, resource):"},{"line_number":577,"context_line":"        if resource in [\u0027networks\u0027, \u0027subnets\u0027, \u0027ports\u0027, \u0027subnetpools\u0027,"},{"line_number":578,"context_line":"                        \u0027security-groups\u0027]:"},{"line_number":579,"context_line":"            return self.api"},{"line_number":580,"context_line":"        else:"},{"line_number":581,"context_line":"            return self.ext_api"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_4c768194","line":578,"range":{"start_line":578,"start_character":25,"end_line":578,"end_character":33},"updated":"2020-01-29 13:06:49.000000000","message":"By registering this here we are now able to remove an security group object from ovn maintanance task.","commit_id":"a8c6ac74c783a72358b4b50dca960e4a715cf9f6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9a71ea5348398583b1f25f02227c8d65083680a6","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def _api_for_resource(self, resource):"},{"line_number":577,"context_line":"        if resource in [\u0027networks\u0027, \u0027subnets\u0027, \u0027ports\u0027, \u0027subnetpools\u0027,"},{"line_number":578,"context_line":"                        \u0027security-groups\u0027]:"},{"line_number":579,"context_line":"            return self.api"},{"line_number":580,"context_line":"        else:"},{"line_number":581,"context_line":"            return self.ext_api"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa7e38b_aca055a5","line":578,"range":{"start_line":578,"start_character":25,"end_line":578,"end_character":33},"in_reply_to":"3fa7e38b_4c768194","updated":"2020-01-29 13:20:55.000000000","message":"++!!!","commit_id":"a8c6ac74c783a72358b4b50dca960e4a715cf9f6"}],"zuul.d/base.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"29ae1273065ec97f94e328237ee09dca1b0883d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: neutron-functional"},{"line_number":3,"context_line":"    parent: devstack"},{"line_number":4,"context_line":"    description: Run neutron functional tests"},{"line_number":5,"context_line":"    timeout: 7800"},{"line_number":6,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3fa7e38b_3a134c04","line":3,"updated":"2020-02-13 17:14:12.000000000","message":"Sorry but this change is not necessary in this patch.","commit_id":"a07b3e1d25923d634ad6b52f2a0744dce8633b33"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f4b0b0c563c12cd1db2a31d5f962c128468fa873","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: neutron-functional"},{"line_number":3,"context_line":"    parent: devstack"},{"line_number":4,"context_line":"    description: Run neutron functional tests"},{"line_number":5,"context_line":"    timeout: 7800"},{"line_number":6,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3fa7e38b_a399581d","line":3,"in_reply_to":"3fa7e38b_002dc28e","updated":"2020-02-13 19:26:47.000000000","message":"The solution for the FT problem should be now in the parent patch","commit_id":"a07b3e1d25923d634ad6b52f2a0744dce8633b33"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3b6dece40919492a28bd84c0313c86d3651afd9b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: neutron-functional"},{"line_number":3,"context_line":"    parent: devstack"},{"line_number":4,"context_line":"    description: Run neutron functional tests"},{"line_number":5,"context_line":"    timeout: 7800"},{"line_number":6,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3fa7e38b_002dc28e","line":3,"in_reply_to":"3fa7e38b_3a134c04","updated":"2020-02-13 17:39:01.000000000","message":"lucas\u0027 comment:\n\n\u003e Ok, functional has passed after changing from devstack-minimal to devstack, let\u0027s see if it was just a coincidence or not.\n\nmade it sound like he was trying to test to see if it passed again w/ that change?","commit_id":"a07b3e1d25923d634ad6b52f2a0744dce8633b33"}]}