)]}'
{"neutron/services/trunk/plugin.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"6ca9c5f5739897e942f40c827e43c93a03f24e0d","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                # the trunk remains in the status where it was."},{"line_number":274,"context_line":"                try:"},{"line_number":275,"context_line":"                    trunk.delete()"},{"line_number":276,"context_line":"                    payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":277,"context_line":"                                                     original_trunk\u003dtrunk)"},{"line_number":278,"context_line":"                    registry.notify(resources.TRUNK,"},{"line_number":279,"context_line":"                                    events.PRECOMMIT_DELETE,"},{"line_number":280,"context_line":"                                    self, payload\u003dpayload)"},{"line_number":281,"context_line":"                except Exception as e:"},{"line_number":282,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":283,"context_line":"                        LOG.info(\u0027Trunk driver raised exception when deleting \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_db66a9bc","line":280,"range":{"start_line":276,"start_character":0,"end_line":280,"end_character":58},"updated":"2020-01-10 09:54:26.000000000","message":"Did you really want to catch possible exceptions from here too? Asking just because this is technically not the trunk driver.","commit_id":"862bd25dc45c85bec6328b5ea5e2cf043ec52fe6"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b12d15ddbdf3afdc2a7c61163c6dde03117adc46","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                # the trunk remains in the status where it was."},{"line_number":274,"context_line":"                try:"},{"line_number":275,"context_line":"                    trunk.delete()"},{"line_number":276,"context_line":"                    payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":277,"context_line":"                                                     original_trunk\u003dtrunk)"},{"line_number":278,"context_line":"                    registry.notify(resources.TRUNK,"},{"line_number":279,"context_line":"                                    events.PRECOMMIT_DELETE,"},{"line_number":280,"context_line":"                                    self, payload\u003dpayload)"},{"line_number":281,"context_line":"                except Exception as e:"},{"line_number":282,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":283,"context_line":"                        LOG.info(\u0027Trunk driver raised exception when deleting \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2f08d4d5","line":280,"range":{"start_line":276,"start_character":0,"end_line":280,"end_character":58},"in_reply_to":"3fa7e38b_db66a9bc","updated":"2020-01-10 17:00:35.000000000","message":"Good point, moved then putside the try/except.","commit_id":"862bd25dc45c85bec6328b5ea5e2cf043ec52fe6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64d904fa14455553fe5d201fcc1c4cfeaabebcfe","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                 \u0027trunk port %s: %s\u0027, trunk_id, str(e))"},{"line_number":285,"context_line":"            else:"},{"line_number":286,"context_line":"                LOG.info(\u0027Trunk driver does not consider trunk %s \u0027"},{"line_number":287,"context_line":"                        \u0027untrunkable\u0027, trunk_id)"},{"line_number":288,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":289,"context_line":"        registry.notify(resources.TRUNK, events.AFTER_DELETE, self,"},{"line_number":290,"context_line":"                        payload\u003dpayload)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3167e3ec","line":287,"updated":"2020-01-09 22:31:20.000000000","message":"off by one space if pep8 complains","commit_id":"862bd25dc45c85bec6328b5ea5e2cf043ec52fe6"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b12d15ddbdf3afdc2a7c61163c6dde03117adc46","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                 \u0027trunk port %s: %s\u0027, trunk_id, str(e))"},{"line_number":285,"context_line":"            else:"},{"line_number":286,"context_line":"                LOG.info(\u0027Trunk driver does not consider trunk %s \u0027"},{"line_number":287,"context_line":"                        \u0027untrunkable\u0027, trunk_id)"},{"line_number":288,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":289,"context_line":"        registry.notify(resources.TRUNK, events.AFTER_DELETE, self,"},{"line_number":290,"context_line":"                        payload\u003dpayload)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4f0bd0d2","line":287,"in_reply_to":"3fa7e38b_3167e3ec","updated":"2020-01-10 17:00:35.000000000","message":"Shockingly pep8 did not complain, but fixed it anyway.","commit_id":"862bd25dc45c85bec6328b5ea5e2cf043ec52fe6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3eb19fb2efce9f8642633748a9a63d3b68b376d3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    trunk.delete()"},{"line_number":276,"context_line":"                except Exception as e:"},{"line_number":277,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":278,"context_line":"                        LOG.info(\u0027Trunk driver raised exception when deleting \u0027"},{"line_number":279,"context_line":"                                 \u0027trunk port %s: %s\u0027, trunk_id, str(e))"},{"line_number":280,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":281,"context_line":"                                                 original_trunk\u003dtrunk)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dd260f23","line":278,"range":{"start_line":278,"start_character":28,"end_line":278,"end_character":32},"updated":"2020-01-21 10:14:27.000000000","message":"should this be info or maybe warning()?","commit_id":"3527b0921ba56cd3c4c7b81b99a99df8f35b4bb3"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"9371ff9df1a88096689c01b898c9618b125e142a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    trunk.delete()"},{"line_number":276,"context_line":"                except Exception as e:"},{"line_number":277,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":278,"context_line":"                        LOG.info(\u0027Trunk driver raised exception when deleting \u0027"},{"line_number":279,"context_line":"                                 \u0027trunk port %s: %s\u0027, trunk_id, str(e))"},{"line_number":280,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":281,"context_line":"                                                 original_trunk\u003dtrunk)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3c5f0c4e","line":278,"range":{"start_line":278,"start_character":28,"end_line":278,"end_character":32},"in_reply_to":"3fa7e38b_dd260f23","updated":"2020-01-22 15:05:56.000000000","message":"I am generally pretty stingy with moving things to warning() but I am OK with it here.","commit_id":"3527b0921ba56cd3c4c7b81b99a99df8f35b4bb3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"232a5ccb01290ca54a08c0d2871832dc15f543f8","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                                events.PRECOMMIT_DELETE,"},{"line_number":284,"context_line":"                                self, payload\u003dpayload)"},{"line_number":285,"context_line":"            else:"},{"line_number":286,"context_line":"                LOG.info(\u0027Trunk driver does not consider trunk %s \u0027"},{"line_number":287,"context_line":"                         \u0027untrunkable\u0027, trunk_id)"},{"line_number":288,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":289,"context_line":"        registry.notify(resources.TRUNK, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_efe39c04","line":286,"updated":"2020-01-10 17:05:25.000000000","message":"Well, you can infer this from the exception TrunkInUse","commit_id":"3527b0921ba56cd3c4c7b81b99a99df8f35b4bb3"}]}