)]}'
{"neutron/cmd/ovn/migration_mtu.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13957d0908fd2d52835349ad04739af4290e500f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def get_connection():"},{"line_number":26,"context_line":"    user_domain_id \u003d os.environ.get(\u0027OS_USER_DOMAIN_ID\u0027, \u0027default\u0027)"},{"line_number":27,"context_line":"    project_domain_id \u003d os.environ.get(\u0027OS_PROJECT_DOMAIN_ID\u0027, \u0027default\u0027)"},{"line_number":28,"context_line":"    conn \u003d connection.Connection(auth_url\u003dos.environ[\u0027OS_AUTH_URL\u0027],"},{"line_number":29,"context_line":"                                 project_name\u003dos.environ[\u0027OS_PROJECT_NAME\u0027],"},{"line_number":30,"context_line":"                                 username\u003dos.environ[\u0027OS_USERNAME\u0027],"},{"line_number":31,"context_line":"                                 password\u003dos.environ[\u0027OS_PASSWORD\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_03933a50","line":28,"updated":"2020-01-15 10:19:33.000000000","message":"If we need to create a connection to \"network\" service, we should use the configuration deployed instead of exporting the env variables.\n\nE.g.: https://github.com/openstack/neutron/blob/master/neutron/notifiers/ironic.py#L55-L70","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bf4fa6eee1d7b7abeddc184b53d83daf7462422","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def get_connection():"},{"line_number":26,"context_line":"    user_domain_id \u003d os.environ.get(\u0027OS_USER_DOMAIN_ID\u0027, \u0027default\u0027)"},{"line_number":27,"context_line":"    project_domain_id \u003d os.environ.get(\u0027OS_PROJECT_DOMAIN_ID\u0027, \u0027default\u0027)"},{"line_number":28,"context_line":"    conn \u003d connection.Connection(auth_url\u003dos.environ[\u0027OS_AUTH_URL\u0027],"},{"line_number":29,"context_line":"                                 project_name\u003dos.environ[\u0027OS_PROJECT_NAME\u0027],"},{"line_number":30,"context_line":"                                 username\u003dos.environ[\u0027OS_USERNAME\u0027],"},{"line_number":31,"context_line":"                                 password\u003dos.environ[\u0027OS_PASSWORD\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d4a87622","line":28,"in_reply_to":"3fa7e38b_03933a50","updated":"2020-01-15 13:26:11.000000000","message":"I\u0027m just porting this script as they are in networking-ovn, I would refrain changing it as we port it since it may require documentation changes and other things that still lives in other patches that are \"in flight\". \n\nAre you OK with changing it at a later phase of this effort ? Once we have not only the scripts but also documentation and ansible playbooks in place.","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fc6afe30e6be62b17355c74c80eb388d7d68630a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def get_connection():"},{"line_number":26,"context_line":"    user_domain_id \u003d os.environ.get(\u0027OS_USER_DOMAIN_ID\u0027, \u0027default\u0027)"},{"line_number":27,"context_line":"    project_domain_id \u003d os.environ.get(\u0027OS_PROJECT_DOMAIN_ID\u0027, \u0027default\u0027)"},{"line_number":28,"context_line":"    conn \u003d connection.Connection(auth_url\u003dos.environ[\u0027OS_AUTH_URL\u0027],"},{"line_number":29,"context_line":"                                 project_name\u003dos.environ[\u0027OS_PROJECT_NAME\u0027],"},{"line_number":30,"context_line":"                                 username\u003dos.environ[\u0027OS_USERNAME\u0027],"},{"line_number":31,"context_line":"                                 password\u003dos.environ[\u0027OS_PASSWORD\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_f70c9194","line":28,"in_reply_to":"3fa7e38b_d4a87622","updated":"2020-01-15 16:59:46.000000000","message":"Ok then, but please add a TODO note here to refactor the connection creation to use the conf instead. Thanks!","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13957d0908fd2d52835349ad04739af4290e500f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    print(\u0027Usage: %s \u003cupdate|verify\u003e mtu\u0027 % sys.argv[0])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def main():"},{"line_number":85,"context_line":"    if len(sys.argv) \u003c 3:"},{"line_number":86,"context_line":"        print_usage()"},{"line_number":87,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a3a3469b","line":84,"updated":"2020-01-15 10:19:33.000000000","message":"Can you add some information about this script?\n\nE.g.: https://github.com/openstack/neutron/blob/master/neutron/cmd/netns_cleanup.py#L268-L282","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bf4fa6eee1d7b7abeddc184b53d83daf7462422","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    print(\u0027Usage: %s \u003cupdate|verify\u003e mtu\u0027 % sys.argv[0])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def main():"},{"line_number":85,"context_line":"    if len(sys.argv) \u003c 3:"},{"line_number":86,"context_line":"        print_usage()"},{"line_number":87,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_94a2fe3e","line":84,"in_reply_to":"3fa7e38b_a3a3469b","updated":"2020-01-15 13:26:11.000000000","message":"Sure, will add some more information here.","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"}],"neutron/cmd/ovn/neutron_ovn_db_sync_util.py":[{"author":{"_account_id":27295,"name":"Li Zhouzhou","email":"lizhouzhou_yewu@cmss.chinamobile.com","username":"LiZhouzhou"},"change_message_id":"89da7a7a5cff224106030c84487617c8d4afca04","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":81,"context_line":"        port \u003d context.current"},{"line_number":82,"context_line":"        self.ovn_client.delete_port(port)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class AgentNotifierApi(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7d98a619","line":82,"range":{"start_line":82,"start_character":36,"end_line":82,"end_character":40},"updated":"2020-01-14 08:58:48.000000000","message":"I think the paramter is port_id, not a port.","commit_id":"44d5f1a00796ef40ecc526574e2a3791432d1022"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"de5b1a6d7a7f65b0146a98edb95aa260136167b3","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":81,"context_line":"        port \u003d context.current"},{"line_number":82,"context_line":"        self.ovn_client.delete_port(port)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class AgentNotifierApi(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_536a7982","line":82,"range":{"start_line":82,"start_character":36,"end_line":82,"end_character":40},"in_reply_to":"3fa7e38b_7d98a619","updated":"2020-01-14 10:18:58.000000000","message":"Good point, I think that with the migration some things changed in the OVN CLient API. I will review it. Thanks!","commit_id":"44d5f1a00796ef40ecc526574e2a3791432d1022"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13957d0908fd2d52835349ad04739af4290e500f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.notifier \u003d AgentNotifierApi(topics.AGENT)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class OVNMechanismDriver(mech_driver.OVNMechanismDriver):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def subscribe(self):"},{"line_number":50,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2382f6c8","line":47,"updated":"2020-01-15 10:19:33.000000000","message":"I\u0027m a bit lost: where do we need this?","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bf4fa6eee1d7b7abeddc184b53d83daf7462422","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.notifier \u003d AgentNotifierApi(topics.AGENT)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class OVNMechanismDriver(mech_driver.OVNMechanismDriver):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def subscribe(self):"},{"line_number":50,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_f43fb2dc","line":47,"in_reply_to":"3fa7e38b_2382f6c8","updated":"2020-01-15 13:26:11.000000000","message":"I do not know for sure. I\u0027m just porting this script as they are in networking-ovn.\n\nI will try to gather more information about it with the original author.","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13957d0908fd2d52835349ad04739af4290e500f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"def main():"},{"line_number":145,"context_line":"    \"\"\"Main method for syncing neutron networks and ports with ovn nb db."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    The utility syncs neutron db with ovn nb db."},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":"    conf \u003d setup_conf()"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_63b78ed9","line":147,"updated":"2020-01-15 10:19:33.000000000","message":"nit: just a bit more information, if possible","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bf4fa6eee1d7b7abeddc184b53d83daf7462422","unresolved":false,"context_lines":[{"line_number":144,"context_line":"def main():"},{"line_number":145,"context_line":"    \"\"\"Main method for syncing neutron networks and ports with ovn nb db."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    The utility syncs neutron db with ovn nb db."},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":"    conf \u003d setup_conf()"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_146cce05","line":147,"in_reply_to":"3fa7e38b_63b78ed9","updated":"2020-01-15 13:26:11.000000000","message":"Will do","commit_id":"32a6fa2e77c715c84f3d4522443959fafe66b527"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fc6afe30e6be62b17355c74c80eb388d7d68630a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            LOG.error(\u0027No \"ovn\" mechanism driver found : \"%s\".\u0027,"},{"line_number":181,"context_line":"                      cfg.CONF.ml2.mechanism_drivers)"},{"line_number":182,"context_line":"            return"},{"line_number":183,"context_line":"        cfg.CONF.set_override(\u0027mechanism_drivers\u0027, [\u0027ovn-sync\u0027], \u0027ml2\u0027)"},{"line_number":184,"context_line":"        conf.service_plugins \u003d ["},{"line_number":185,"context_line":"            \u0027neutron.services.ovn_l3.plugin.OVNL3RouterPlugin\u0027]"},{"line_number":186,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1aff14b2","line":183,"updated":"2020-01-15 16:59:46.000000000","message":"Ahhh as commented via IRC: this mech_driver should be defined in setup.cfg.\n\nThanks Lucas!","commit_id":"c686fe6fb7c404a4feb848b5ba4edc8e925d56b1"}]}