)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a2e9f0199e5a2310c8db539bbe57a93c741ab333","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            sg_rule \u003d self._plugin.get_security_group_rule("},{"line_number":297,"context_line":"                admin_context, kwargs.get(\u0027security_group_rule_id\u0027))"},{"line_number":298,"context_line":"            self._ovn_client.delete_security_group_rule("},{"line_number":299,"context_line":"                admin_context,"},{"line_number":300,"context_line":"                sg_rule)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _is_network_type_supported(self, network_type):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_803419fc","line":299,"range":{"start_line":299,"start_character":16,"end_line":299,"end_character":29},"updated":"2020-01-14 10:05:31.000000000","message":"The notification for (esources.SECURITY_GROUP_RULE, events.AFTER_CREATE) or (resources.SECURITY_GROUP_RULE,                                events.BEFORE_DELETE), that calls \"_process_sg_rule_notification\", always have \"context\" in kwargs. We should use it instead of creating a new one.","commit_id":"24d66b1a1efc3037be197ea69ebbff3934b7cebf"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"d7c8e5b74612bba717360be1b7c95881971a7e97","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            sg_rule \u003d self._plugin.get_security_group_rule("},{"line_number":297,"context_line":"                admin_context, kwargs.get(\u0027security_group_rule_id\u0027))"},{"line_number":298,"context_line":"            self._ovn_client.delete_security_group_rule("},{"line_number":299,"context_line":"                admin_context,"},{"line_number":300,"context_line":"                sg_rule)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _is_network_type_supported(self, network_type):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_330c9d39","line":299,"range":{"start_line":299,"start_character":16,"end_line":299,"end_character":29},"in_reply_to":"3fa7e38b_803419fc","updated":"2020-01-14 10:08:35.000000000","message":"Ok! Thanks. In next push I\u0027ll change the whole _process_sg_rule_notification() to not use admin_context but passed one. Thanks!","commit_id":"24d66b1a1efc3037be197ea69ebbff3934b7cebf"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"83af0dc6fd5de277c910f38934c86c37fc2840a4","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            if row.resource_type in [ovn_const.TYPE_PORTS,"},{"line_number":193,"context_line":"                                     ovn_const.TYPE_ROUTER_PORTS,"},{"line_number":194,"context_line":"                                     ovn_const.TYPE_ROUTERS]:"},{"line_number":195,"context_line":"                args \u003d [context, row.resource_uuid]"},{"line_number":196,"context_line":"            else:"},{"line_number":197,"context_line":"                args \u003d [row.resource_uuid]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_419dd507","line":194,"updated":"2020-01-13 13:10:04.000000000","message":"The only resource not using a context during the deletion is \"delete_floatingip\". The other resources have are creating admin_context in the methods; instead of this, you can pass the existing one.\n\nSo instead of filtering, pass the context to all delete methods.","commit_id":"97c5f9c3bfa6ec042c3e9244c4aef126ddf7efd9"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"adf78a0a1bcd468c5cafd5a136cbc7b248bf4390","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            if row.resource_type in [ovn_const.TYPE_PORTS,"},{"line_number":193,"context_line":"                                     ovn_const.TYPE_ROUTER_PORTS,"},{"line_number":194,"context_line":"                                     ovn_const.TYPE_ROUTERS]:"},{"line_number":195,"context_line":"                args \u003d [context, row.resource_uuid]"},{"line_number":196,"context_line":"            else:"},{"line_number":197,"context_line":"                args \u003d [row.resource_uuid]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e1064123","line":194,"in_reply_to":"3fa7e38b_419dd507","updated":"2020-01-13 13:20:45.000000000","message":"delete_floatingip is also using passed context:\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L964\n\nSo I\u0027ll update it to pass for all of the types.","commit_id":"97c5f9c3bfa6ec042c3e9244c4aef126ddf7efd9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a2e9f0199e5a2310c8db539bbe57a93c741ab333","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            revision_numbers_db.delete_revision("},{"line_number":190,"context_line":"                context, row.resource_uuid, row.resource_type)"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            res_map[\u0027ovn_delete\u0027](context, row.resource_uuid)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def _fix_create_update_subnet(self, context, row):"},{"line_number":195,"context_line":"        # Get the lasted version of the port in Neutron DB"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c08e91d6","line":192,"updated":"2020-01-14 10:05:31.000000000","message":"+1","commit_id":"24d66b1a1efc3037be197ea69ebbff3934b7cebf"}]}