)]}'
{"plugin.spec":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"config:"},{"line_number":3,"context_line":"    entry_point: ./tools/ovn_migration/infrared/tripleo-ovn-migration/main.yml"},{"line_number":4,"context_line":"    plugin_type: install"}],"source_content_type":"text/x-rpm-spec","patch_set":6,"id":"df33271e_19fec3ad","line":1,"updated":"2020-03-25 10:57:43.000000000","message":"what is the purpose of this file and why it has to be in top level directory?","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"config:"},{"line_number":3,"context_line":"    entry_point: ./tools/ovn_migration/infrared/tripleo-ovn-migration/main.yml"},{"line_number":4,"context_line":"    plugin_type: install"}],"source_content_type":"text/x-rpm-spec","patch_set":6,"id":"df33271e_c5c6c19a","line":1,"in_reply_to":"df33271e_19fec3ad","updated":"2020-03-31 14:11:32.000000000","message":"This is the infrared [0] configuration. I was also confused by this file when I was porting this patch here.\n\nTo be honest, I don\u0027t really know what I should do with it. Perhaps we should move this to infrared itself. Any thoughts ?\n\n[0] https://infrared.readthedocs.io/en/stable/plugins.html","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8e9540c400d814f36cd2c2bdd75b70f3a09d0728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"config:"},{"line_number":3,"context_line":"    entry_point: ./tools/ovn_migration/infrared/tripleo-ovn-migration/main.yml"},{"line_number":4,"context_line":"    plugin_type: install"}],"source_content_type":"text/x-rpm-spec","patch_set":7,"id":"df33271e_55268cbc","line":1,"updated":"2020-04-03 14:36:05.000000000","message":"I know this has been in networking-ovn, I just wanted to open a discussion about this. I don\u0027t like there is a file to support some third party software that is outside of openstack umbrella. Perhaps we should think about making this a plugin under infrared project that uses bits from Neutron.","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91fe3e1a83be83ff2bcfb7aad803106de5baa829","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"config:"},{"line_number":3,"context_line":"    entry_point: ./tools/ovn_migration/infrared/tripleo-ovn-migration/main.yml"},{"line_number":4,"context_line":"    plugin_type: install"}],"source_content_type":"text/x-rpm-spec","patch_set":7,"id":"df33271e_521dde0d","line":1,"in_reply_to":"df33271e_55268cbc","updated":"2020-04-06 08:09:01.000000000","message":"I agree. Would be great to move it outside of neutron repo.","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e7349ace3a91451a069e9d31278435eadd087006","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                  image_name:"},{"line_number":79,"context_line":"                      type: Value"},{"line_number":80,"context_line":"                      help: Image name to use"},{"line_number":81,"context_line":"                      default: cirros-0.3.5-x86_64-disk.img"}],"source_content_type":"text/x-rpm-spec","patch_set":7,"id":"df33271e_e4dc6be5","line":81,"range":{"start_line":81,"start_character":31,"end_line":81,"end_character":59},"updated":"2020-04-02 15:31:04.000000000","message":"Nit: That is old one. We could use 0.4.0.","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"}],"setup.cfg":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"46b60d756c749b0bd91a877f56ee53ad2f6ca363","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    etc/neutron/rootwrap.d \u003d etc/neutron/rootwrap.d/*"},{"line_number":29,"context_line":"    share/ansible/neutron-ovn-migration/playbooks \u003d tools/ovn_migration/tripleo_environment/playbooks/*"},{"line_number":30,"context_line":"scripts \u003d"},{"line_number":31,"context_line":"    bin/neutron-rootwrap-xen-dom0"},{"line_number":32,"context_line":"    tools/ovn_migration/tripleo_environment/ovn_migration.sh"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3fa7e38b_309e8168","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":33},"updated":"2020-02-06 12:41:29.000000000","message":"Since this script was deprecated and removed (in Ic3eda36e7e79726fb2f22aa015539c7d47ab7430) this is breaking the zuul jobs.","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2f15422b0b9b373e6713f10a58d1b458da490f2d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    etc/neutron/rootwrap.d \u003d etc/neutron/rootwrap.d/*"},{"line_number":29,"context_line":"    share/ansible/neutron-ovn-migration/playbooks \u003d tools/ovn_migration/tripleo_environment/playbooks/*"},{"line_number":30,"context_line":"scripts \u003d"},{"line_number":31,"context_line":"    bin/neutron-rootwrap-xen-dom0"},{"line_number":32,"context_line":"    tools/ovn_migration/tripleo_environment/ovn_migration.sh"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3fa7e38b_9d989e1a","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":33},"in_reply_to":"3fa7e38b_309e8168","updated":"2020-02-07 09:25:38.000000000","message":"ops my bad!","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e3f28d3220be54b501cd8a34a85f2c9fe8e4bcc8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    etc/neutron/rootwrap.d \u003d etc/neutron/rootwrap.d/*"},{"line_number":29,"context_line":"    share/ansible/neutron-ovn-migration/playbooks \u003d tools/ovn_migration/tripleo_environment/playbooks/*"},{"line_number":30,"context_line":"scripts \u003d"},{"line_number":31,"context_line":"    bin/neutron-rootwrap-xen-dom0"},{"line_number":32,"context_line":"    tools/ovn_migration/tripleo_environment/ovn_migration.sh"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"1fa4df85_3dfdc36d","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":33},"in_reply_to":"3fa7e38b_98ec2c29","updated":"2020-03-24 23:49:25.000000000","message":"Done","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"608775cd85574dad48d679cd222f159a1d209368","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    etc/neutron/rootwrap.d \u003d etc/neutron/rootwrap.d/*"},{"line_number":29,"context_line":"    share/ansible/neutron-ovn-migration/playbooks \u003d tools/ovn_migration/tripleo_environment/playbooks/*"},{"line_number":30,"context_line":"scripts \u003d"},{"line_number":31,"context_line":"    bin/neutron-rootwrap-xen-dom0"},{"line_number":32,"context_line":"    tools/ovn_migration/tripleo_environment/ovn_migration.sh"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"3fa7e38b_98ec2c29","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":33},"in_reply_to":"3fa7e38b_9d989e1a","updated":"2020-02-07 09:59:37.000000000","message":"No prob. Just wanted to call your attention that the recheck won\u0027t help in itself. :-)","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"}],"tools/ovn_migration/README.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Testing Status:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Tested on an RDO cloud on CentOS 7.3 based on Ocata."},{"line_number":28,"context_line":"- The cloud had 3 controller nodes and 6 compute nodes."},{"line_number":29,"context_line":"- Observed network downtime was 10 seconds."},{"line_number":30,"context_line":"- The \"--forks 10\" option was used with ansible-playbook to ensure"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_d999fc1f","line":27,"updated":"2020-03-25 10:57:43.000000000","message":"that testing is actually pretty old :)","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Testing Status:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Tested on an RDO cloud on CentOS 7.3 based on Ocata."},{"line_number":28,"context_line":"- The cloud had 3 controller nodes and 6 compute nodes."},{"line_number":29,"context_line":"- Observed network downtime was 10 seconds."},{"line_number":30,"context_line":"- The \"--forks 10\" option was used with ansible-playbook to ensure"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_25a16df9","line":27,"in_reply_to":"df33271e_d999fc1f","updated":"2020-03-31 14:11:32.000000000","message":"Yeah, perhaps we need to rerun some of those tests. Since I haven\u0027t tested it myself I will this note as-is","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/README.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Infrared plugin to carry out migration from ML2OVS to OVN"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is an infrared plugin which can be used to carry out the migration"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_b99238f5","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"updated":"2020-03-25 10:57:43.000000000","message":"nit: shouldn\u0027t be \"from ML2/OVS to ML2/OVN\"","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Infrared plugin to carry out migration from ML2OVS to OVN"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is an infrared plugin which can be used to carry out the migration"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_456111a9","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":57},"in_reply_to":"df33271e_b99238f5","updated":"2020-03-31 14:11:32.000000000","message":"\u003e nit: shouldn\u0027t be \"from ML2/OVS to ML2/OVN\"\n\n++","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is an infrared plugin which can be used to carry out the migration"},{"line_number":5,"context_line":"from ML2OVS to OVN if the tripleo was deployed using infrared."},{"line_number":6,"context_line":"See http://infrared.readthedocs.io/en/stable/index.html for more information."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Before using this plugin, first deploy an ML2OVS overcloud and then:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_998f74cb","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":18},"updated":"2020-03-25 10:57:43.000000000","message":"same nit here","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This is an infrared plugin which can be used to carry out the migration"},{"line_number":5,"context_line":"from ML2OVS to OVN if the tripleo was deployed using infrared."},{"line_number":6,"context_line":"See http://infrared.readthedocs.io/en/stable/index.html for more information."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Before using this plugin, first deploy an ML2OVS overcloud and then:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_25668dc2","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":18},"in_reply_to":"df33271e_998f74cb","updated":"2020-03-31 14:11:32.000000000","message":"++","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"from ML2OVS to OVN if the tripleo was deployed using infrared."},{"line_number":6,"context_line":"See http://infrared.readthedocs.io/en/stable/index.html for more information."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Before using this plugin, first deploy an ML2OVS overcloud and then:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"1. On your undercloud, install python-neutron-ovn-migration-tool package (https://trunk.rdoproject.org/centos7-master/current/)"},{"line_number":11,"context_line":"   You also need to install python-neutron and python3-openvswitch packages."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_d9c29ce9","line":8,"range":{"start_line":8,"start_character":42,"end_line":8,"end_character":48},"updated":"2020-03-25 10:57:43.000000000","message":"nitty nit: \"ML2/OVS\"?","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":5,"context_line":"from ML2OVS to OVN if the tripleo was deployed using infrared."},{"line_number":6,"context_line":"See http://infrared.readthedocs.io/en/stable/index.html for more information."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Before using this plugin, first deploy an ML2OVS overcloud and then:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"1. On your undercloud, install python-neutron-ovn-migration-tool package (https://trunk.rdoproject.org/centos7-master/current/)"},{"line_number":11,"context_line":"   You also need to install python-neutron and python3-openvswitch packages."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df33271e_855799ca","line":8,"range":{"start_line":8,"start_character":42,"end_line":8,"end_character":48},"in_reply_to":"df33271e_d9c29ce9","updated":"2020-03-31 14:11:32.000000000","message":"++","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/main.yml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    python_major_version: \"{{ ansible_facts.python_version.split(\u0027.\u0027)[0] }}\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"      - name: Install python 2 virtualenv and neutron ovn migration tool"},{"line_number":9,"context_line":"        yum:"},{"line_number":10,"context_line":"            name:"},{"line_number":11,"context_line":"              - python-virtualenv"},{"line_number":12,"context_line":"              - python-neutron-ovn-migration-tool"},{"line_number":13,"context_line":"            state: present"},{"line_number":14,"context_line":"        when: python_major_version | int \u003d\u003d 2"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"      - name: Install python 3 virtualenv and neutron ovn migration tool"},{"line_number":17,"context_line":"        yum:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_59ae8c2e","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":45},"updated":"2020-03-25 10:57:43.000000000","message":"we dropped support for python 2 in Neutron some time ago. Do we still need this part in master branch?","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    python_major_version: \"{{ ansible_facts.python_version.split(\u0027.\u0027)[0] }}\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"      - name: Install python 2 virtualenv and neutron ovn migration tool"},{"line_number":9,"context_line":"        yum:"},{"line_number":10,"context_line":"            name:"},{"line_number":11,"context_line":"              - python-virtualenv"},{"line_number":12,"context_line":"              - python-neutron-ovn-migration-tool"},{"line_number":13,"context_line":"            state: present"},{"line_number":14,"context_line":"        when: python_major_version | int \u003d\u003d 2"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"      - name: Install python 3 virtualenv and neutron ovn migration tool"},{"line_number":17,"context_line":"        yum:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_a5f61dd6","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"df33271e_59ae8c2e","updated":"2020-03-31 14:11:32.000000000","message":"Yeah, good point. I believe this can be dropped","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/roles/create-resources/templates/create-resources.sh.j2":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"a23b421926f13fb91b86f0da51bb6cef084cf5f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"then"},{"line_number":11,"context_line":"    if [ ! -f cirros-0.4.0-x86_64-disk.img ]"},{"line_number":12,"context_line":"    then"},{"line_number":13,"context_line":"        curl -o cirros-0.4.0-x86_64-disk.img http://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    openstack image create \"cirros-ovn-migration-{{ resource_suffix }}\"  --file cirros-0.4.0-x86_64-disk.img \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_78c1a980","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":112},"updated":"2020-03-26 20:26:12.000000000","message":"Note: this command won\u0027t download cirros image properly and should be updated, see https://review.opendev.org/#/c/708476/","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":10,"context_line":"then"},{"line_number":11,"context_line":"    if [ ! -f cirros-0.4.0-x86_64-disk.img ]"},{"line_number":12,"context_line":"    then"},{"line_number":13,"context_line":"        curl -o cirros-0.4.0-x86_64-disk.img http://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    openstack image create \"cirros-ovn-migration-{{ resource_suffix }}\"  --file cirros-0.4.0-x86_64-disk.img \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_452f513e","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":112},"in_reply_to":"df33271e_78c1a980","updated":"2020-03-31 14:11:32.000000000","message":"Oh thanks for the pointer! Roman++","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/roles/create-resources/templates/start-pinger.sh.j2":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -x"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"creating virtualven in {{ ovn_migration_temp_dir }}/pinger_venv\""},{"line_number":6,"context_line":"virtualenv {{ ovn_migration_temp_dir }}/pinger_venv"},{"line_number":7,"context_line":"source {{ ovn_migration_temp_dir }}/pinger_venv/bin/activate"},{"line_number":8,"context_line":"pip install --upgrade pip"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_992bf492","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":25},"updated":"2020-03-25 10:57:43.000000000","message":"s/virtualenv ?","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -x"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"creating virtualven in {{ ovn_migration_temp_dir }}/pinger_venv\""},{"line_number":6,"context_line":"virtualenv {{ ovn_migration_temp_dir }}/pinger_venv"},{"line_number":7,"context_line":"source {{ ovn_migration_temp_dir }}/pinger_venv/bin/activate"},{"line_number":8,"context_line":"pip install --upgrade pip"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_8525d95e","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":25},"in_reply_to":"df33271e_992bf492","updated":"2020-03-31 14:11:32.000000000","message":"++","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/roles/prepare-migration/tasks/main.yml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73ae499e512c8bbfddd31b7795bdfe8eec42d23c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set docker images environment file"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"      output_env_file: /home/stack/docker-images-ovn.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Get the proper neutron-ovn-ha.yaml path"},{"line_number":39,"context_line":"  stat:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_e0f9a9c5","line":36,"updated":"2020-01-24 12:39:34.000000000","message":"At least we should enforce the user to create this directory.","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set docker images environment file"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"      output_env_file: /home/stack/docker-images-ovn.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Get the proper neutron-ovn-ha.yaml path"},{"line_number":39,"context_line":"  stat:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_dd5cd659","line":36,"in_reply_to":"3fa7e38b_e0f9a9c5","updated":"2020-03-31 14:11:32.000000000","message":"I think being TripleO, the \"stack\" user will always be created ?","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"a71fb13ce5341cbe6ce01e6ea331c6cfc5022496","unresolved":false,"context_lines":[{"line_number":139,"context_line":"           mv overcloud.tar.gz /tmp/oc_plan/"},{"line_number":140,"context_line":"           cd /tmp/oc_plan"},{"line_number":141,"context_line":"           tar xvf overcloud.tar.gz"},{"line_number":142,"context_line":"           reg\u003d`cat /tmp/oc_plan/environments/containers-default-parameters.yaml  | grep DockerNeutronApiImage | awk \u0027{ split($2, image , \"/\"); print image[1] }\u0027`"},{"line_number":143,"context_line":"           namespace\u003d`cat /tmp/oc_plan/environments/containers-default-parameters.yaml  | grep DockerNeutronApiImage | awk \u0027{ split($2, image , \"/\"); print image[2] }\u0027`"},{"line_number":144,"context_line":"           echo $reg/$namespace \u003e /tmp/_reg_namespace"},{"line_number":145,"context_line":"           rm -rf /tmp/oc_plan"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_f88db931","line":143,"range":{"start_line":142,"start_character":11,"end_line":143,"end_character":117},"updated":"2020-03-26 20:42:30.000000000","message":"All Docker* container names should be updated in this file to Container*. See https://review.opendev.org/#/c/698503/","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":139,"context_line":"           mv overcloud.tar.gz /tmp/oc_plan/"},{"line_number":140,"context_line":"           cd /tmp/oc_plan"},{"line_number":141,"context_line":"           tar xvf overcloud.tar.gz"},{"line_number":142,"context_line":"           reg\u003d`cat /tmp/oc_plan/environments/containers-default-parameters.yaml  | grep DockerNeutronApiImage | awk \u0027{ split($2, image , \"/\"); print image[1] }\u0027`"},{"line_number":143,"context_line":"           namespace\u003d`cat /tmp/oc_plan/environments/containers-default-parameters.yaml  | grep DockerNeutronApiImage | awk \u0027{ split($2, image , \"/\"); print image[2] }\u0027`"},{"line_number":144,"context_line":"           echo $reg/$namespace \u003e /tmp/_reg_namespace"},{"line_number":145,"context_line":"           rm -rf /tmp/oc_plan"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_0519c920","line":143,"range":{"start_line":142,"start_character":11,"end_line":143,"end_character":117},"in_reply_to":"df33271e_f88db931","updated":"2020-03-31 14:11:32.000000000","message":"Roman++!","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"a71fb13ce5341cbe6ce01e6ea331c6cfc5022496","unresolved":false,"context_lines":[{"line_number":176,"context_line":"- name: Upload the ovn docker images to the local registry"},{"line_number":177,"context_line":"  shell: |"},{"line_number":178,"context_line":"      source ~/stackrc"},{"line_number":179,"context_line":"      openstack overcloud container image upload --verbose --config-file ~/ovn_container_images.yaml"},{"line_number":180,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_d8f1d5cf","line":179,"range":{"start_line":179,"start_character":6,"end_line":179,"end_character":100},"updated":"2020-03-26 20:42:30.000000000","message":"This command won\u0027t work and should be updated. See https://review.opendev.org/#/c/702905/","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":176,"context_line":"- name: Upload the ovn docker images to the local registry"},{"line_number":177,"context_line":"  shell: |"},{"line_number":178,"context_line":"      source ~/stackrc"},{"line_number":179,"context_line":"      openstack overcloud container image upload --verbose --config-file ~/ovn_container_images.yaml"},{"line_number":180,"context_line":"  changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_25d96d56","line":179,"range":{"start_line":179,"start_character":6,"end_line":179,"end_character":100},"in_reply_to":"df33271e_d8f1d5cf","updated":"2020-03-31 14:11:32.000000000","message":"Roman++","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/infrared/tripleo-ovn-migration/templates/start-ovn-migration.sh.j2":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73ae499e512c8bbfddd31b7795bdfe8eec42d23c","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export PUBLIC_NETWORK_NAME\u003d{{ public_network }}"},{"line_number":4,"context_line":"# TODO: Get this from the var"},{"line_number":5,"context_line":"export OPT_WORKDIR\u003d/home/stack/ovn_migration"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"/usr/bin/ovn_migration.sh $1"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_c0058dc2","line":5,"updated":"2020-01-24 12:39:34.000000000","message":"This should not be static. Does infrared provide this information?","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"}],"tools/ovn_migration/migrate-to-ovn.yml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73ae499e512c8bbfddd31b7795bdfe8eec42d23c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  become: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"  - name: Ensure OVN packages are installed on compute nodes."},{"line_number":11,"context_line":"    yum:"},{"line_number":12,"context_line":"      name: openvswitch-ovn-host"},{"line_number":13,"context_line":"      state: present"},{"line_number":14,"context_line":"  # TODO to make ansible-lint happy, all of these commands should be conditionally run"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_803d558e","line":11,"updated":"2020-01-24 12:39:34.000000000","message":"If this is going to be only for RedHat OS, you should warn this in [1], or create an OS dependent script\n\n[1] https://review.opendev.org/#/c/702247/5/tools/ovn_migration/infrared/tripleo-ovn-migration/README.rst","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73ae499e512c8bbfddd31b7795bdfe8eec42d23c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - name: Configure ovn-bridge-mappings."},{"line_number":29,"context_line":"    command: \"ovs-vsctl set open . external_ids:ovn-bridge-mappings\u003d{{ ovn_bridge_mappings }}\""},{"line_number":30,"context_line":"    changed_when: false"},{"line_number":31,"context_line":"  - name: Get hostname"},{"line_number":32,"context_line":"    command: hostname -f"},{"line_number":33,"context_line":"    register: hostname"},{"line_number":34,"context_line":"    check_mode: no"},{"line_number":35,"context_line":"    changed_when: false"},{"line_number":36,"context_line":"  - name: Set host name"},{"line_number":37,"context_line":"    command: \"ovs-vsctl set Open_vSwitch . external-ids:hostname\u003d{{ hostname.stdout }}\""},{"line_number":38,"context_line":"    changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_4043dd11","line":35,"range":{"start_line":31,"start_character":0,"end_line":35,"end_character":23},"updated":"2020-01-24 12:39:34.000000000","message":"You have the fqdn in ansible_facts[\u0027fqdn\u0027]","commit_id":"87ae8e4d414d81e961d1e36032bd8610caf3fca7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e7349ace3a91451a069e9d31278435eadd087006","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2\u0027, option: \u0027tenant_network_types\u0027, value: \u0027geneve\u0027 }"},{"line_number":105,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027vni_ranges\u0027, value: \u00271:65536\u0027 }"},{"line_number":106,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027max_header_size\u0027, value: \u002738\u0027 }"},{"line_number":107,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_nb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6641\"\u0027 }"},{"line_number":108,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_sb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6642\"\u0027 }"},{"line_number":109,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovsdb_connection_timeout\u0027, value: \u0027180\u0027 }"},{"line_number":110,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027neutron_sync_mode\u0027, value: \u0027repair\u0027 }"},{"line_number":111,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_l3_mode\u0027, value: \u0027true\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_271bf572","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":140},"updated":"2020-04-02 15:31:04.000000000","message":"What if its ssl-only deployment?","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"3e5e06a54766d20d31934a6cbd88cfbf4833be02","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2\u0027, option: \u0027tenant_network_types\u0027, value: \u0027geneve\u0027 }"},{"line_number":105,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027vni_ranges\u0027, value: \u00271:65536\u0027 }"},{"line_number":106,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027max_header_size\u0027, value: \u002738\u0027 }"},{"line_number":107,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_nb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6641\"\u0027 }"},{"line_number":108,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_sb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6642\"\u0027 }"},{"line_number":109,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovsdb_connection_timeout\u0027, value: \u0027180\u0027 }"},{"line_number":110,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027neutron_sync_mode\u0027, value: \u0027repair\u0027 }"},{"line_number":111,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_l3_mode\u0027, value: \u0027true\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_57231006","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":140},"in_reply_to":"df33271e_1549a45f","updated":"2020-04-06 07:31:16.000000000","message":"Added LP to not forget about it:\nhttps://bugs.launchpad.net/neutron/+bug/1871032","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8e9540c400d814f36cd2c2bdd75b70f3a09d0728","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2\u0027, option: \u0027tenant_network_types\u0027, value: \u0027geneve\u0027 }"},{"line_number":105,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027vni_ranges\u0027, value: \u00271:65536\u0027 }"},{"line_number":106,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027max_header_size\u0027, value: \u002738\u0027 }"},{"line_number":107,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_nb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6641\"\u0027 }"},{"line_number":108,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_sb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6642\"\u0027 }"},{"line_number":109,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovsdb_connection_timeout\u0027, value: \u0027180\u0027 }"},{"line_number":110,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027neutron_sync_mode\u0027, value: \u0027repair\u0027 }"},{"line_number":111,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_l3_mode\u0027, value: \u0027true\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_1549a45f","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":140},"in_reply_to":"df33271e_271bf572","updated":"2020-04-03 14:36:05.000000000","message":"This is a copy from networking-ovn, I think your comment is a great point, maybe we must open a LP and verify migration works in SSL enabled environments too.","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91fe3e1a83be83ff2bcfb7aad803106de5baa829","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2\u0027, option: \u0027tenant_network_types\u0027, value: \u0027geneve\u0027 }"},{"line_number":105,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027vni_ranges\u0027, value: \u00271:65536\u0027 }"},{"line_number":106,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ml2_type_geneve\u0027, option: \u0027max_header_size\u0027, value: \u002738\u0027 }"},{"line_number":107,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_nb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6641\"\u0027 }"},{"line_number":108,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_sb_connection\u0027, value: \u0027\"tcp:{{ ovn_db_ip }}:6642\"\u0027 }"},{"line_number":109,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovsdb_connection_timeout\u0027, value: \u0027180\u0027 }"},{"line_number":110,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027neutron_sync_mode\u0027, value: \u0027repair\u0027 }"},{"line_number":111,"context_line":"        - { dest: \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027, section: \u0027ovn\u0027, option: \u0027ovn_l3_mode\u0027, value: \u0027true\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df33271e_92fe46ac","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":140},"in_reply_to":"df33271e_57231006","updated":"2020-04-06 08:09:01.000000000","message":"thx","commit_id":"b27940c2056e64e3f7ef9502cb08a7c8710d2bc1"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/delete-neutron-resources/templates/delete-neutron-resources.sh.j2":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"source {{ overcloudrc }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Delete non alive neutron agents"},{"line_number":8,"context_line":"for i in `openstack network agent list | grep neutron- | grep -v \u0027:-)\u0027 | awk {\u0027print $2\u0027}`"},{"line_number":9,"context_line":"do"},{"line_number":10,"context_line":"  openstack network agent delete $i"},{"line_number":11,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_b95a37f0","line":8,"updated":"2020-03-25 10:57:43.000000000","message":"agent is marked as dead when it will not send heartbeat for some time. Isn\u0027t it possible that this will be run too fast and due to that some agents which should be actually deleted will be left untouched?","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4bc840fa8b6a3bf660a9c6d4066861b57e093ce1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"source {{ overcloudrc }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Delete non alive neutron agents"},{"line_number":8,"context_line":"for i in `openstack network agent list | grep neutron- | grep -v \u0027:-)\u0027 | awk {\u0027print $2\u0027}`"},{"line_number":9,"context_line":"do"},{"line_number":10,"context_line":"  openstack network agent delete $i"},{"line_number":11,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_ef162da8","line":8,"in_reply_to":"df33271e_059c2968","updated":"2020-04-01 09:02:15.000000000","message":"sure, I was just curious but it can be checked and changed if needed in follow up","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":5,"context_line":"source {{ overcloudrc }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Delete non alive neutron agents"},{"line_number":8,"context_line":"for i in `openstack network agent list | grep neutron- | grep -v \u0027:-)\u0027 | awk {\u0027print $2\u0027}`"},{"line_number":9,"context_line":"do"},{"line_number":10,"context_line":"  openstack network agent delete $i"},{"line_number":11,"context_line":"done"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_059c2968","line":8,"in_reply_to":"df33271e_b95a37f0","updated":"2020-03-31 14:11:32.000000000","message":"Honestly, since this patch is just porting the code from networking-ovn to neutron I would keep it as is. \n\nWhat you said seems possible but I haven\u0027t played much with the migration myself to accurately answer that. If this becomes a problem I believe we can treat it as a bug in the migration scripts later on.","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/migration/tasks/cleanup-dataplane.yml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e684e6fd9da2788f15de9f4f4131e2f2b6044ac1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      echo \"Security groups cleaned\""},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"  register: out"},{"line_number":35,"context_line":"  changed_when: \"\u0027Security groups cleaned\u0027 in out.stdout\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Cleanup neutron datapath resources"},{"line_number":38,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_d96e1b95","line":35,"updated":"2020-03-25 10:57:43.000000000","message":"in readme file in this patch I read that one of prerequisites is to use openvswitch firewall driver. So why this cleaning of iptables is needed?","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4bc840fa8b6a3bf660a9c6d4066861b57e093ce1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      echo \"Security groups cleaned\""},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"  register: out"},{"line_number":35,"context_line":"  changed_when: \"\u0027Security groups cleaned\u0027 in out.stdout\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Cleanup neutron datapath resources"},{"line_number":38,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_ef646d4c","line":35,"in_reply_to":"df33271e_a57bbd25","updated":"2020-04-01 09:02:15.000000000","message":"ok, that can be also checked and maybe removed in follow up patch :)","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      echo \"Security groups cleaned\""},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"  register: out"},{"line_number":35,"context_line":"  changed_when: \"\u0027Security groups cleaned\u0027 in out.stdout\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Cleanup neutron datapath resources"},{"line_number":38,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_a57bbd25","line":35,"in_reply_to":"df33271e_d96e1b95","updated":"2020-03-31 14:11:32.000000000","message":"I need to double check with Miguel Ajo (original author), I will try to reach him and see if he can answer this","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}],"tools/ovn_migration/tripleo_environment/playbooks/roles/resources/create/templates/create-resources.sh.j2":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"a23b421926f13fb91b86f0da51bb6cef084cf5f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"then"},{"line_number":11,"context_line":"    if [ ! -f cirros-0.4.0-x86_64-disk.img ]"},{"line_number":12,"context_line":"    then"},{"line_number":13,"context_line":"        curl -o cirros-0.4.0-x86_64-disk.img http://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    openstack image create \"cirros-ovn-migration-{{ resource_suffix }}\"  --file cirros-0.4.0-x86_64-disk.img \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_18ea1d0e","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":112},"updated":"2020-03-26 20:26:12.000000000","message":"Note: this command won\u0027t download cirros image properly and should be updated. See https://review.opendev.org/#/c/708476/","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fa7ebc8000570255d3089b3e7ca1b63850536d28","unresolved":false,"context_lines":[{"line_number":10,"context_line":"then"},{"line_number":11,"context_line":"    if [ ! -f cirros-0.4.0-x86_64-disk.img ]"},{"line_number":12,"context_line":"    then"},{"line_number":13,"context_line":"        curl -o cirros-0.4.0-x86_64-disk.img http://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    openstack image create \"cirros-ovn-migration-{{ resource_suffix }}\"  --file cirros-0.4.0-x86_64-disk.img \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"df33271e_05aa696f","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":112},"in_reply_to":"df33271e_18ea1d0e","updated":"2020-03-31 14:11:32.000000000","message":"Roman++!","commit_id":"721de2b967698e7b08ffff86777c77b71fdd3d1b"}]}