)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19495e597136665a7c7d5b83289aa7d2625dbfb8","unresolved":false,"context_lines":[{"line_number":701,"context_line":"    def _create_qos_rules(self, qos_options, port, lswitch_name,"},{"line_number":702,"context_line":"                          if_delete\u003dFalse):"},{"line_number":703,"context_line":"        qos_rule \u003d {}"},{"line_number":704,"context_line":"        direction \u003d \u0027from-lport\u0027 if qos_options.get(\u0027direction\u0027) \u003d\u003d\\"},{"line_number":705,"context_line":"                    \u0027egress\u0027 else \u0027to-lport\u0027"},{"line_number":706,"context_line":"        qos_rule.update(switch\u003dlswitch_name, direction\u003ddirection,"},{"line_number":707,"context_line":"                        priority\u003d2002)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_c7abb086","line":704,"updated":"2020-03-02 14:26:36.000000000","message":"is this change related to this patch really?","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"13092bb1c70b17923b26f6c94652452ddfe870b4","unresolved":false,"context_lines":[{"line_number":701,"context_line":"    def _create_qos_rules(self, qos_options, port, lswitch_name,"},{"line_number":702,"context_line":"                          if_delete\u003dFalse):"},{"line_number":703,"context_line":"        qos_rule \u003d {}"},{"line_number":704,"context_line":"        direction \u003d \u0027from-lport\u0027 if qos_options.get(\u0027direction\u0027) \u003d\u003d\\"},{"line_number":705,"context_line":"                    \u0027egress\u0027 else \u0027to-lport\u0027"},{"line_number":706,"context_line":"        qos_rule.update(switch\u003dlswitch_name, direction\u003ddirection,"},{"line_number":707,"context_line":"                        priority\u003d2002)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_67faeabd","line":704,"in_reply_to":"1fa4df85_c7abb086","updated":"2020-03-03 09:21:59.000000000","message":"It\u0027s not related, but without it functional tests for QoS are failing.\nI saw that this problem is handled by [1].\n\nSo im going to remove QoS tests from this patch to not block it on QoS, then add QoS tests on top of the [1].\n\n[1] https://review.opendev.org/#/c/707352/5","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"09e2e13ade58ef5b5dcdf1364137c4ead3838cf8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        ml2_config.cfg.CONF.set_override(\u0027vni_ranges\u0027,"},{"line_number":170,"context_line":"                                     [\u00271:65536\u0027],"},{"line_number":171,"context_line":"                                     group\u003d\u0027ml2_type_geneve\u0027)"},{"line_number":172,"context_line":"        ovn_conf.cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":173,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":174,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1fa4df85_0c695624","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":16},"updated":"2020-02-24 09:54:32.000000000","message":"Prior it was using ml2_config instead ovn_conf. Actually the ovn.dns_servers value was not declared in ml2_config. Somehow it worked before in networking-ovn, but I went thorough a few issues because of it in OVN provider driver and I needed to delete it in the \u0027functionals part 1\u0027.\n\nNow I added this override to be on ovn_conf. Anyways, now works fine. :)","commit_id":"0390db07a64decd2ef2e199e1ef19d9cf9629a51"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19495e597136665a7c7d5b83289aa7d2625dbfb8","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                     [\u00271:65536\u0027],"},{"line_number":171,"context_line":"                                     group\u003d\u0027ml2_type_geneve\u0027)"},{"line_number":172,"context_line":"        ovn_conf.cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":173,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":174,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_679afc6e","line":173,"updated":"2020-03-02 14:26:36.000000000","message":"nit: You could align indentation here to the line above","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"13092bb1c70b17923b26f6c94652452ddfe870b4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                     [\u00271:65536\u0027],"},{"line_number":171,"context_line":"                                     group\u003d\u0027ml2_type_geneve\u0027)"},{"line_number":172,"context_line":"        ovn_conf.cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":173,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":174,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_62141845","line":173,"in_reply_to":"1fa4df85_679afc6e","updated":"2020-03-03 09:21:59.000000000","message":"Done","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19495e597136665a7c7d5b83289aa7d2625dbfb8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                     group\u003d\u0027ml2_type_geneve\u0027)"},{"line_number":172,"context_line":"        ovn_conf.cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":173,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":174,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":177,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_c784100f","line":174,"updated":"2020-03-02 14:26:36.000000000","message":"same here","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"13092bb1c70b17923b26f6c94652452ddfe870b4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                     group\u003d\u0027ml2_type_geneve\u0027)"},{"line_number":172,"context_line":"        ovn_conf.cfg.CONF.set_override(\u0027dns_servers\u0027,"},{"line_number":173,"context_line":"                                     [\u002710.10.10.10\u0027],"},{"line_number":174,"context_line":"                                     group\u003d\u0027ovn\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        self.addCleanup(exts.PluginAwareExtensionManager.clear_instance)"},{"line_number":177,"context_line":"        super(TestOVNFunctionalBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_82111455","line":174,"in_reply_to":"1fa4df85_c784100f","updated":"2020-03-03 09:21:59.000000000","message":"Done","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"}],"neutron/tests/functional/db/test_ovn_revision_numbers_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19495e597136665a7c7d5b83289aa7d2625dbfb8","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(str(updated_subnet[\u0027revision_number\u0027]), ovn_revision)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # TODO(lucasagomes): Add a test for floating IPs here when we get"},{"line_number":186,"context_line":"    # the router stuff done."}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_b0002869","line":186,"updated":"2020-03-02 14:26:36.000000000","message":"what router stuff should be done exactly?","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"401c099c9abfe5fb7155c8a6bf55f0c4f2cf5821","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(str(updated_subnet[\u0027revision_number\u0027]), ovn_revision)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # TODO(lucasagomes): Add a test for floating IPs here when we get"},{"line_number":186,"context_line":"    # the router stuff done."}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_c8108bab","line":186,"in_reply_to":"1fa4df85_623df8c2","updated":"2020-03-03 11:55:28.000000000","message":"Terrible TODO from my part, sorry... I think this is due to a problem that we had with the router ports that Ajo has fixed [0][1]\n\n[0] https://review.opendev.org/#/c/534423/\n[1] https://review.opendev.org/#/c/540391/","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"13092bb1c70b17923b26f6c94652452ddfe870b4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(str(updated_subnet[\u0027revision_number\u0027]), ovn_revision)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # TODO(lucasagomes): Add a test for floating IPs here when we get"},{"line_number":186,"context_line":"    # the router stuff done."}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_623df8c2","line":186,"in_reply_to":"1fa4df85_b0002869","updated":"2020-03-03 09:21:59.000000000","message":"I don\u0027t know, @Lucas ;)?","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_db_resources.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19495e597136665a7c7d5b83289aa7d2625dbfb8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        ovn_config.cfg.CONF.set_override(\u0027dns_domain\u0027, \u0027ovn.test\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def tearDown(self):"},{"line_number":43,"context_line":"        super(TestNBDbResources, self).tearDown()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # FIXME(lucasagomes): Map the revision numbers properly instead"},{"line_number":46,"context_line":"    # of stripping them out. Currently, tests like test_dhcp_options()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_f02b00e8","line":43,"updated":"2020-03-02 14:26:36.000000000","message":"I don\u0027t think this is really needed","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"13092bb1c70b17923b26f6c94652452ddfe870b4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        ovn_config.cfg.CONF.set_override(\u0027dns_domain\u0027, \u0027ovn.test\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def tearDown(self):"},{"line_number":43,"context_line":"        super(TestNBDbResources, self).tearDown()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # FIXME(lucasagomes): Map the revision numbers properly instead"},{"line_number":46,"context_line":"    # of stripping them out. Currently, tests like test_dhcp_options()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_025444fe","line":43,"in_reply_to":"1fa4df85_f02b00e8","updated":"2020-03-03 09:21:59.000000000","message":"Yhm, yes. That is not clever at all.","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_db_sync.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19495e597136665a7c7d5b83289aa7d2625dbfb8","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"        return \u0027tcp\u0027"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"class TestOvnNbSyncOverSsl(TestOvnNbSync):"},{"line_number":1624,"context_line":"    def get_ovsdb_server_protocol(self):"},{"line_number":1625,"context_line":"        return \u0027ssl\u0027"},{"line_number":1626,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_b08348cc","line":1623,"updated":"2020-03-02 14:26:36.000000000","message":"just a question: why You don\u0027t need to override \"enable_distributed_floating_ip\" option here in same way as in class above?","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"13092bb1c70b17923b26f6c94652452ddfe870b4","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"        return \u0027tcp\u0027"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"class TestOvnNbSyncOverSsl(TestOvnNbSync):"},{"line_number":1624,"context_line":"    def get_ovsdb_server_protocol(self):"},{"line_number":1625,"context_line":"        return \u0027ssl\u0027"},{"line_number":1626,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1fa4df85_e285685b","line":1623,"in_reply_to":"1fa4df85_b08348cc","updated":"2020-03-03 09:21:59.000000000","message":"Good question. Actually setting DVR has nothing to \u0027TCP\u0027.\nI moved it to base class - TestOvnNbSync.","commit_id":"f34d393ed6dee838bcb34015f2e359a846fdad37"}]}