)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"17425ba4e9194182b09442df31ab21c7f422b62b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[2] http://codesearch.openstack.org/?q\u003dL3RpcCallback"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Conflicts:"},{"line_number":27,"context_line":"\tneutron/agent/l3/agent.py"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I764423e175d6e82729a647e415a9f267f495916f"},{"line_number":30,"context_line":"Closes-Bug: #1844168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_e4c78410","line":27,"updated":"2020-01-23 22:36:01.000000000","message":"nit: tab\n\nneutron/tests/unit/agent/l3/test_agent.py is also different from master","commit_id":"9750acab589dd78f4f4044576d81e8beb845995f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e6d3aa5ddee50bc7402d84e33bf7689e2d870cff","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[2] http://codesearch.openstack.org/?q\u003dL3RpcCallback"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Conflicts:"},{"line_number":27,"context_line":"\tneutron/agent/l3/agent.py"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I764423e175d6e82729a647e415a9f267f495916f"},{"line_number":30,"context_line":"Closes-Bug: #1844168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_252033b1","line":27,"in_reply_to":"3fa7e38b_2af56284","updated":"2020-01-24 11:51:50.000000000","message":"Just the tab.\n\nFor me, with the explanation and the \"conflicts\" section given automatically by git, is enough.","commit_id":"9750acab589dd78f4f4044576d81e8beb845995f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c9f7fb2fcdf8bd81798d0bc0c1ea950a878184f9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[2] http://codesearch.openstack.org/?q\u003dL3RpcCallback"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Conflicts:"},{"line_number":27,"context_line":"\tneutron/agent/l3/agent.py"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I764423e175d6e82729a647e415a9f267f495916f"},{"line_number":30,"context_line":"Closes-Bug: #1844168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_2af56284","line":27,"in_reply_to":"3fa7e38b_e4c78410","updated":"2020-01-24 10:03:49.000000000","message":"Added a sentence about that to the first paragraph.","commit_id":"9750acab589dd78f4f4044576d81e8beb845995f"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c08a979602133708be70eef086d55e4ac543753","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        1.9 - Added get_router_ids"},{"line_number":114,"context_line":"        1.10 Added update_all_ha_network_port_statuses"},{"line_number":115,"context_line":"        1.11 Added get_host_ha_router_count"},{"line_number":116,"context_line":"        1.13 Removed get_external_network_id"},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def __init__(self, topic, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3ecbc41d","line":116,"updated":"2020-01-17 12:35:18.000000000","message":"The conflict on the cherry-pick mainly happened because 1.12 is missing in stein. Not sure whether you\u0027d still want to keep the version at 1.13 here or change to 1.12. Or whether this change is only possible at all if we cherry-pick 1.12 first.","commit_id":"5a3939c53368a02064a0bb9f7cc88922d2d803f4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09d2690146f0d9c588554e68f55391effcb06343","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        1.9 - Added get_router_ids"},{"line_number":114,"context_line":"        1.10 Added update_all_ha_network_port_statuses"},{"line_number":115,"context_line":"        1.11 Added get_host_ha_router_count"},{"line_number":116,"context_line":"        1.13 Removed get_external_network_id"},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def __init__(self, topic, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b92fce87","line":116,"in_reply_to":"3fa7e38b_3ecbc41d","updated":"2020-01-17 12:59:08.000000000","message":"I was dealing with this patch too and we should not make this, although this is not changing any RPC versioned call. \n\nInstead of that, what we can keep is the change in \"_process_router_if_compatible\":\n- Doing this we implement the change needed to allow multiple networks\n- We don\u0027t modify the agent RPC versioning.","commit_id":"5a3939c53368a02064a0bb9f7cc88922d2d803f4"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"278a25083cc15e325cf02f719fcccaffb11879c2","unresolved":false,"context_lines":[{"line_number":2864,"context_line":"        agent._process_router_if_compatible(router)"},{"line_number":2865,"context_line":"        self.assertIn(router[\u0027id\u0027], agent.router_info)"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"    def test_process_router_if_compatible_with_ext_net_in_conf(self):"},{"line_number":2868,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":2869,"context_line":"        self.plugin_api.get_external_network_id.return_value \u003d \u0027aaa\u0027"},{"line_number":2870,"context_line":""},{"line_number":2871,"context_line":"        router \u003d {\u0027id\u0027: _uuid(),"},{"line_number":2872,"context_line":"                  \u0027routes\u0027: [],"},{"line_number":2873,"context_line":"                  \u0027admin_state_up\u0027: True,"},{"line_number":2874,"context_line":"                  \u0027external_gateway_info\u0027: {\u0027network_id\u0027: \u0027bbb\u0027}}"},{"line_number":2875,"context_line":""},{"line_number":2876,"context_line":"        agent.router_info \u003d {}"},{"line_number":2877,"context_line":"        self.conf.set_override(\u0027gateway_external_network_id\u0027, \u0027aaa\u0027)"},{"line_number":2878,"context_line":"        agent._process_router_if_compatible(router)"},{"line_number":2879,"context_line":"        self.assertIn(router[\u0027id\u0027], agent.router_info)"},{"line_number":2880,"context_line":""},{"line_number":2881,"context_line":"    def test_nonexistent_interface_driver(self):"},{"line_number":2882,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_39351ef7","line":2879,"range":{"start_line":2867,"start_character":4,"end_line":2879,"end_character":54},"updated":"2020-01-17 14:02:39.000000000","message":"Not sure whether this modified test makes sense or if I should drop it like the other ones.","commit_id":"6822fe4c329215acf98d1d95065b56dd684a269b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"8d5f464de3a2a6918d6ed6f47fc97cba6c47c69e","unresolved":false,"context_lines":[{"line_number":2864,"context_line":"        agent._process_router_if_compatible(router)"},{"line_number":2865,"context_line":"        self.assertIn(router[\u0027id\u0027], agent.router_info)"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"    def test_process_router_if_compatible_with_ext_net_in_conf(self):"},{"line_number":2868,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":2869,"context_line":"        self.plugin_api.get_external_network_id.return_value \u003d \u0027aaa\u0027"},{"line_number":2870,"context_line":""},{"line_number":2871,"context_line":"        router \u003d {\u0027id\u0027: _uuid(),"},{"line_number":2872,"context_line":"                  \u0027routes\u0027: [],"},{"line_number":2873,"context_line":"                  \u0027admin_state_up\u0027: True,"},{"line_number":2874,"context_line":"                  \u0027external_gateway_info\u0027: {\u0027network_id\u0027: \u0027bbb\u0027}}"},{"line_number":2875,"context_line":""},{"line_number":2876,"context_line":"        agent.router_info \u003d {}"},{"line_number":2877,"context_line":"        self.conf.set_override(\u0027gateway_external_network_id\u0027, \u0027aaa\u0027)"},{"line_number":2878,"context_line":"        agent._process_router_if_compatible(router)"},{"line_number":2879,"context_line":"        self.assertIn(router[\u0027id\u0027], agent.router_info)"},{"line_number":2880,"context_line":""},{"line_number":2881,"context_line":"    def test_nonexistent_interface_driver(self):"},{"line_number":2882,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cf499c2f","line":2879,"range":{"start_line":2867,"start_character":4,"end_line":2879,"end_character":54},"in_reply_to":"3fa7e38b_39351ef7","updated":"2020-01-17 15:23:40.000000000","message":"Config option ``gateway_external_network_id`` is still in stable/stein. So I guess we should remain this case.","commit_id":"6822fe4c329215acf98d1d95065b56dd684a269b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"710c9d8012d5bb0a2eabebae9b3de91cc4a4a42f","unresolved":false,"context_lines":[{"line_number":2864,"context_line":"        agent._process_router_if_compatible(router)"},{"line_number":2865,"context_line":"        self.assertIn(router[\u0027id\u0027], agent.router_info)"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"    def test_process_router_if_compatible_with_ext_net_in_conf(self):"},{"line_number":2868,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":2869,"context_line":"        self.plugin_api.get_external_network_id.return_value \u003d \u0027aaa\u0027"},{"line_number":2870,"context_line":""},{"line_number":2871,"context_line":"        router \u003d {\u0027id\u0027: _uuid(),"},{"line_number":2872,"context_line":"                  \u0027routes\u0027: [],"},{"line_number":2873,"context_line":"                  \u0027admin_state_up\u0027: True,"},{"line_number":2874,"context_line":"                  \u0027external_gateway_info\u0027: {\u0027network_id\u0027: \u0027bbb\u0027}}"},{"line_number":2875,"context_line":""},{"line_number":2876,"context_line":"        agent.router_info \u003d {}"},{"line_number":2877,"context_line":"        self.conf.set_override(\u0027gateway_external_network_id\u0027, \u0027aaa\u0027)"},{"line_number":2878,"context_line":"        agent._process_router_if_compatible(router)"},{"line_number":2879,"context_line":"        self.assertIn(router[\u0027id\u0027], agent.router_info)"},{"line_number":2880,"context_line":""},{"line_number":2881,"context_line":"    def test_nonexistent_interface_driver(self):"},{"line_number":2882,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8f03a475","line":2879,"range":{"start_line":2867,"start_character":4,"end_line":2879,"end_character":54},"in_reply_to":"3fa7e38b_cf499c2f","updated":"2020-01-17 15:36:24.000000000","message":"You mean keep the modified test and document the changed behavior in a release note?\n\nOr keep the original test and make sure that the agent\u0027s behaviour doesn\u0027t change in this case?","commit_id":"6822fe4c329215acf98d1d95065b56dd684a269b"}]}