)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"524d68eae53b67fa01695cb4d1b4e93d42bd47b2","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":971,"context_line":"        # to avoid false positives."},{"line_number":972,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":973,"context_line":"            # update the time of our successful check"},{"line_number":974,"context_line":"            value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":975,"context_line":"            self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_29b04541","line":972,"range":{"start_line":972,"start_character":34,"end_line":972,"end_character":40},"updated":"2020-01-21 13:33:36.000000000","message":"Potentially this could fail on:\nNone - int ?","commit_id":"96f4d9b5fd49f2be80115d405d8b71d693cae272"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"e5c92c1e8d2583bbac6baa89d2b08f26ffc1886a","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":971,"context_line":"        # to avoid false positives."},{"line_number":972,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":973,"context_line":"            # update the time of our successful check"},{"line_number":974,"context_line":"            value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":975,"context_line":"            self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_49db4179","line":972,"range":{"start_line":972,"start_character":34,"end_line":972,"end_character":40},"in_reply_to":"3fa7e38b_09ea290d","updated":"2020-01-21 13:36:01.000000000","message":"It\u0027d not be unrelated as before there was any substraction sorry. I can\u0027t see nb_cfg being None but perhaps in the initialization? I\u0027m not sure, fail to see it","commit_id":"96f4d9b5fd49f2be80115d405d8b71d693cae272"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"f8bdb75e299cd55aa6804ee945429a51c9320b86","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":971,"context_line":"        # to avoid false positives."},{"line_number":972,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":973,"context_line":"            # update the time of our successful check"},{"line_number":974,"context_line":"            value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":975,"context_line":"            self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_09ea290d","line":972,"range":{"start_line":972,"start_character":34,"end_line":972,"end_character":40},"in_reply_to":"3fa7e38b_29b04541","updated":"2020-01-21 13:34:40.000000000","message":"Can you explain how can that happen?\nPlus that\u0027d be unrelated to this patch, isn\u0027t it?","commit_id":"96f4d9b5fd49f2be80115d405d8b71d693cae272"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"2613278e34d9c94e380cea1c8e814a455e9b149b","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":971,"context_line":"        # to avoid false positives."},{"line_number":972,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":973,"context_line":"            # update the time of our successful check"},{"line_number":974,"context_line":"            value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":975,"context_line":"            self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e9322dc0","line":972,"range":{"start_line":972,"start_character":34,"end_line":972,"end_character":40},"in_reply_to":"3fa7e38b_49db4179","updated":"2020-01-21 13:37:27.000000000","message":"If the agent is new, just installed, the nb_cfg value is not set. So that will be None or [], no?","commit_id":"96f4d9b5fd49f2be80115d405d8b71d693cae272"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"8db1f612d7c05499820de117e9958dacb92f0113","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":971,"context_line":"        # to avoid false positives."},{"line_number":972,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":973,"context_line":"            # update the time of our successful check"},{"line_number":974,"context_line":"            value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":975,"context_line":"            self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_29e845de","line":972,"range":{"start_line":972,"start_character":34,"end_line":972,"end_character":40},"in_reply_to":"3fa7e38b_e9322dc0","updated":"2020-01-21 13:44:08.000000000","message":"Ok, checked the SB schema. chassis.nb_cfg is int so defaults to 0. Shouldn\u0027t be any exception.","commit_id":"96f4d9b5fd49f2be80115d405d8b71d693cae272"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"563d12bc8bb4c913f3a5e8d90fe2cecfef0aa447","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        # Allow a maximum of 1 difference between expected and read values"},{"line_number":971,"context_line":"        # to avoid false positives."},{"line_number":972,"context_line":"        if self._nb_ovn.nb_global.nb_cfg - nb_cfg \u003c\u003d 1:"},{"line_number":973,"context_line":"            # update the time of our successful check"},{"line_number":974,"context_line":"            value \u003d timeutils.utcnow(with_timezone\u003dTrue).isoformat()"},{"line_number":975,"context_line":"            self._sb_ovn.db_set(\u0027Chassis\u0027, chassis.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_891a9915","line":972,"range":{"start_line":972,"start_character":34,"end_line":972,"end_character":40},"in_reply_to":"3fa7e38b_e9322dc0","updated":"2020-01-21 13:41:33.000000000","message":"This is the NB_Global value which has nothing to do with agents.\nIf the agent is new and it\u0027s not set, then L961 will default \u0027nb_cfg\u0027 to 0 so it\u0027s still an int.","commit_id":"96f4d9b5fd49f2be80115d405d8b71d693cae272"}]}