)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae9911fb435263fb62fc5c0e38be4937a74dab46","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If we somehow have an empty set of addresses, lsp_set_addresses"},{"line_number":10,"context_line":"will fail. This instead calls db_clear() on the addresses field if"},{"line_number":11,"context_line":"we are trying to set it to empty."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied92eb85b74e63a7317d50970b5131fb49e3e4b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_acaaf9cf","line":12,"updated":"2020-01-21 22:46:35.000000000","message":"It seems like this is something worth backporting, so we should file a bug and put a Closes-bug here and eventually cherry-pick to networking-ovn stable branch.","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"38a2e60291ad57d732ab275db5cb68f49a42589e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If we somehow have an empty set of addresses, lsp_set_addresses"},{"line_number":10,"context_line":"will fail. This instead calls db_clear() on the addresses field if"},{"line_number":11,"context_line":"we are trying to set it to empty."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied92eb85b74e63a7317d50970b5131fb49e3e4b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7cb7c423","line":12,"in_reply_to":"3fa7e38b_2f5efb78","updated":"2020-01-22 14:18:42.000000000","message":"++!","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bc5debe425fa6c3aa0b7e30a806a2d07aa4e73bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If we somehow have an empty set of addresses, lsp_set_addresses"},{"line_number":10,"context_line":"will fail. This instead calls db_clear() on the addresses field if"},{"line_number":11,"context_line":"we are trying to set it to empty."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ied92eb85b74e63a7317d50970b5131fb49e3e4b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_2f5efb78","line":12,"in_reply_to":"3fa7e38b_acaaf9cf","updated":"2020-01-22 00:41:54.000000000","message":"Will do. Not 100% sure that this is what someone was hitting (bad input, may not be empty addresses though) so was waiting on some debugging output from them and being a little proactive while I waited (and hoping others could verify that this makes sense generally).","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae9911fb435263fb62fc5c0e38be4937a74dab46","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"            if addresses:"},{"line_number":439,"context_line":"                self._nb_idl.lsp_set_addresses("},{"line_number":440,"context_line":"                    port.name, addresses\u003daddresses).execute(check_error\u003dTrue)"},{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self._nb_idl.db_clear("},{"line_number":443,"context_line":"                    \u0027Logical_Switch_Port\u0027, port.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2c97e99e","line":440,"updated":"2020-01-21 22:46:35.000000000","message":"reading the API it does say \"one or more addresses\", in a perfect world I guess we could change that, but that\u0027s the long way to fix this bug.  So I don\u0027t have an issue doing it this way.","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bc5debe425fa6c3aa0b7e30a806a2d07aa4e73bb","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"            if addresses:"},{"line_number":439,"context_line":"                self._nb_idl.lsp_set_addresses("},{"line_number":440,"context_line":"                    port.name, addresses\u003daddresses).execute(check_error\u003dTrue)"},{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self._nb_idl.db_clear("},{"line_number":443,"context_line":"                    \u0027Logical_Switch_Port\u0027, port.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4f07b782","line":440,"in_reply_to":"3fa7e38b_2c97e99e","updated":"2020-01-22 00:41:54.000000000","message":"yeah, this is inherited from the way ovn-nbctl lsp-set-addresses does things as well.","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae9911fb435263fb62fc5c0e38be4937a74dab46","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self._nb_idl.db_clear("},{"line_number":443,"context_line":"                    \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":444,"context_line":"                    \u0027addresses\u0027).execute(check_error\u003dTrue)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        raise periodics.NeverAgain()"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4c4ee56e","line":444,"updated":"2020-01-21 22:46:35.000000000","message":"I guess there\u0027s no unit tests for most of this class :(\n\nBut there is a functional test for it in https://review.opendev.org/#/c/701733, so we should do a follow-on to that.","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bc5debe425fa6c3aa0b7e30a806a2d07aa4e73bb","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self._nb_idl.db_clear("},{"line_number":443,"context_line":"                    \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":444,"context_line":"                    \u0027addresses\u0027).execute(check_error\u003dTrue)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        raise periodics.NeverAgain()"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_cf2087fb","line":444,"in_reply_to":"3fa7e38b_4c4ee56e","updated":"2020-01-22 00:41:54.000000000","message":"Yeah. lsp_set_addresses itself is tested pretty heavily (including the raising an exception when invalid input is passed), but need to wait on that review for testing this method as a whole. I\u0027ll definitely add a test that tests this case once that merges. I might even rebase this off of those and ad it here before merging. I\u0027ve seen a customer run into *some* kind of invalid addresses input to lsp_set_addresses here, but I don\u0027t know for sure that it is the empty address list. I\u0027ve added https://review.opendev.org/#/c/703644/ to make future debugging easier.","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e1a3351b9426fe96aed7de64e67a2d03d5d8fbc","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self._nb_idl.db_clear("},{"line_number":443,"context_line":"                    \u0027Logical_Switch_Port\u0027, port.name,"},{"line_number":444,"context_line":"                    \u0027addresses\u0027).execute(check_error\u003dTrue)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        raise periodics.NeverAgain()"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1cc9f0a9","line":444,"in_reply_to":"3fa7e38b_cf2087fb","updated":"2020-01-22 14:17:51.000000000","message":"Yeah that\u0027s very unfortunate, the patches adding functional tests are proposed but not yet merged.\n\nThat said, can you please create a card in the public trello board [0] for the OVN code merging effort to later add such test ?\n\nThat way we won\u0027t lose track of it.\n\n[0] https://trello.com/b/IQcOUZkR/neutron-ovn-convergence-upstream","commit_id":"ae33e6d780254f5acc2d65a9c4b3726ac10ed460"}]}