)]}'
{"neutron/services/trunk/plugin.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7175fc989872aaf99e44edefe3ef3879862e8904","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                trunk.delete()"},{"line_number":273,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":274,"context_line":"                                                 original_trunk\u003dtrunk)"},{"line_number":275,"context_line":"                registry.notify(constants.TRUNK, events.PRECOMMIT_DELETE, self,"},{"line_number":276,"context_line":"                                payload\u003dpayload)"},{"line_number":277,"context_line":"            else:"},{"line_number":278,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":279,"context_line":"        registry.notify(constants.TRUNK, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2bbbcb10","side":"PARENT","line":276,"range":{"start_line":275,"start_character":16,"end_line":276,"end_character":48},"updated":"2020-01-31 08:51:50.000000000","message":"Missing part in backport?","commit_id":"530f6d5b44e6c3dbaadebcc2a633e1212deea1be"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"5e741468926ba2e18811106ccee0bbd91fb52bbe","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                trunk.delete()"},{"line_number":273,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":274,"context_line":"                                                 original_trunk\u003dtrunk)"},{"line_number":275,"context_line":"                registry.notify(constants.TRUNK, events.PRECOMMIT_DELETE, self,"},{"line_number":276,"context_line":"                                payload\u003dpayload)"},{"line_number":277,"context_line":"            else:"},{"line_number":278,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":279,"context_line":"        registry.notify(constants.TRUNK, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6e06a725","side":"PARENT","line":276,"range":{"start_line":275,"start_character":16,"end_line":276,"end_character":48},"in_reply_to":"3fa7e38b_0217c99f","updated":"2020-01-31 22:51:01.000000000","message":"Sorry I should have been more explicit :)\nOriginal patch and train backport have a reindented call (same code):\n                registry.notify(resources.TRUNK,\n                                events.PRECOMMIT_DELETE,\n                                self, payload\u003dpayload)\nhttps://review.opendev.org/#/c/704690/1/neutron/services/trunk/plugin.py","commit_id":"530f6d5b44e6c3dbaadebcc2a633e1212deea1be"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"d0bbe7eab732f5c0162f02185f53b175a925917c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                trunk.delete()"},{"line_number":273,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":274,"context_line":"                                                 original_trunk\u003dtrunk)"},{"line_number":275,"context_line":"                registry.notify(constants.TRUNK, events.PRECOMMIT_DELETE, self,"},{"line_number":276,"context_line":"                                payload\u003dpayload)"},{"line_number":277,"context_line":"            else:"},{"line_number":278,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":279,"context_line":"        registry.notify(constants.TRUNK, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0217c99f","side":"PARENT","line":276,"range":{"start_line":275,"start_character":16,"end_line":276,"end_character":48},"in_reply_to":"3fa7e38b_2bbbcb10","updated":"2020-01-31 18:18:19.000000000","message":"I am confused, I see this on the right in lines 282 to 283...","commit_id":"530f6d5b44e6c3dbaadebcc2a633e1212deea1be"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"41377ff153022c27a63d60d4993f4af75055b652","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                trunk.delete()"},{"line_number":273,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":274,"context_line":"                                                 original_trunk\u003dtrunk)"},{"line_number":275,"context_line":"                registry.notify(constants.TRUNK, events.PRECOMMIT_DELETE, self,"},{"line_number":276,"context_line":"                                payload\u003dpayload)"},{"line_number":277,"context_line":"            else:"},{"line_number":278,"context_line":"                raise trunk_exc.TrunkInUse(trunk_id\u003dtrunk_id)"},{"line_number":279,"context_line":"        registry.notify(constants.TRUNK, events.AFTER_DELETE, self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_751179f8","side":"PARENT","line":276,"range":{"start_line":275,"start_character":16,"end_line":276,"end_character":48},"in_reply_to":"3fa7e38b_6e06a725","updated":"2020-02-04 00:40:50.000000000","message":"Done","commit_id":"530f6d5b44e6c3dbaadebcc2a633e1212deea1be"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8792f1eea81521ec43a3f791d263186952405102","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                                    str(e))"},{"line_number":280,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":281,"context_line":"                                                 original_trunk\u003dtrunk)"},{"line_number":282,"context_line":"                registry.notify(constants.TRUNK,"},{"line_number":283,"context_line":"                                events.PRECOMMIT_DELETE,"},{"line_number":284,"context_line":"                                self, payload\u003dpayload)"},{"line_number":285,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d215dc3f","line":282,"range":{"start_line":282,"start_character":32,"end_line":282,"end_character":47},"updated":"2020-02-04 11:49:11.000000000","message":"nit: as I see you can use the same resources.TRUNK as in the original patch:\nhttps://opendev.org/openstack/neutron-lib/src/branch/stable/stein/neutron_lib/callbacks/resources.py#L36","commit_id":"49a1e90b3d2d9e739474688ebb262ed6c45525af"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"e8c6a040bd5c311b3d372117b3e7008508a0f431","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                                    str(e))"},{"line_number":280,"context_line":"                payload \u003d callbacks.TrunkPayload(context, trunk_id,"},{"line_number":281,"context_line":"                                                 original_trunk\u003dtrunk)"},{"line_number":282,"context_line":"                registry.notify(constants.TRUNK,"},{"line_number":283,"context_line":"                                events.PRECOMMIT_DELETE,"},{"line_number":284,"context_line":"                                self, payload\u003dpayload)"},{"line_number":285,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_53db2b4b","line":282,"range":{"start_line":282,"start_character":32,"end_line":282,"end_character":47},"in_reply_to":"3fa7e38b_d215dc3f","updated":"2020-02-04 17:13:11.000000000","message":"Sure!  Made the change.","commit_id":"49a1e90b3d2d9e739474688ebb262ed6c45525af"}]}