)]}'
{"neutron/common/eventlet_utils.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"261c16075ff6fd8c17d601717f2e7e5203d81c76","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def monkey_patch():"},{"line_number":23,"context_line":"    # NOTE(slaweq): to workaround issue with import cycles in"},{"line_number":24,"context_line":"    # eventlet \u003c 0.22.0;"},{"line_number":25,"context_line":"    # This issue is fixed in eventlet with patch"},{"line_number":26,"context_line":"    # https://github.com/eventlet/eventlet/commit/b756447bab51046dfc6f1e0e299cc997ab343701"},{"line_number":27,"context_line":"    # For details please check https://bugs.launchpad.net/neutron/+bug/1745013"},{"line_number":28,"context_line":"    hub \u003d eventlet.hubs.get_default_hub().Hub()"},{"line_number":29,"context_line":"    hub.is_available \u003d lambda: True"},{"line_number":30,"context_line":"    if os.name !\u003d \u0027nt\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_85391541","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":78},"updated":"2020-02-08 23:47:12.000000000","message":"If my understanding is correct, it seems this patch removes or modified the workaround.\n\nIn before, the workaround is this line:\n\n    eventlet.hubs.get_hub()\n\nThis commit somehow modifies the logic a bit. Could you verify with @slaweq that this is still fine? Or to be safe, we keep the workaround untouched and add your changes in before:\n\n    hub \u003d eventlet.hubs.get_default_hub().Hub()\n    hub.is_available \u003d lambda: True\n    eventlet.hubs.get_hub()","commit_id":"6573f871e4a0280ef775df26da0a43bae2718455"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"532ceb9bbf065d5dfa5720d269eaa4de88a1bd53","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def monkey_patch():"},{"line_number":23,"context_line":"    # NOTE(slaweq): to workaround issue with import cycles in"},{"line_number":24,"context_line":"    # eventlet \u003c 0.22.0;"},{"line_number":25,"context_line":"    # This issue is fixed in eventlet with patch"},{"line_number":26,"context_line":"    # https://github.com/eventlet/eventlet/commit/b756447bab51046dfc6f1e0e299cc997ab343701"},{"line_number":27,"context_line":"    # For details please check https://bugs.launchpad.net/neutron/+bug/1745013"},{"line_number":28,"context_line":"    hub \u003d eventlet.hubs.get_default_hub().Hub()"},{"line_number":29,"context_line":"    hub.is_available \u003d lambda: True"},{"line_number":30,"context_line":"    if os.name !\u003d \u0027nt\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cde16cff","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":78},"in_reply_to":"3fa7e38b_85391541","updated":"2020-02-10 11:36:12.000000000","message":"Thanks for the comment!\n\nActually what I need to do is to retrieve the current hub used (get_hub).\n\nAlthough get_default_hub probably will return the type of hub used (depending on the OS), we need to call the hub that is currently used [1].\n\nI\u0027ll change this code.\n\n[1] https://eventlet.net/doc/hubs.html","commit_id":"6573f871e4a0280ef775df26da0a43bae2718455"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4ca72e2511b599ae3caf563a4509700f5d3c8991","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # https://github.com/eventlet/eventlet/commit/b756447bab51046dfc6f1e0e299cc997ab343701"},{"line_number":27,"context_line":"    # For details please check https://bugs.launchpad.net/neutron/+bug/1745013"},{"line_number":28,"context_line":"    hub \u003d eventlet.hubs.get_hub()"},{"line_number":29,"context_line":"    hub.is_available \u003d lambda: True"},{"line_number":30,"context_line":"    if os.name !\u003d \u0027nt\u0027:"},{"line_number":31,"context_line":"        eventlet.monkey_patch()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3f759b97","line":29,"updated":"2020-02-12 09:34:03.000000000","message":"This was added only to workaround bug which should be now fixed in new versions of eventlet. Should we maybe bump min eventlet version and get rid of this code then?","commit_id":"f9b5a7b6d73bf7d9ca5de85d50dfd9216854de30"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f9018b6be2176fb978884582b043222e24241fa2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # https://github.com/eventlet/eventlet/commit/b756447bab51046dfc6f1e0e299cc997ab343701"},{"line_number":27,"context_line":"    # For details please check https://bugs.launchpad.net/neutron/+bug/1745013"},{"line_number":28,"context_line":"    hub \u003d eventlet.hubs.get_hub()"},{"line_number":29,"context_line":"    hub.is_available \u003d lambda: True"},{"line_number":30,"context_line":"    if os.name !\u003d \u0027nt\u0027:"},{"line_number":31,"context_line":"        eventlet.monkey_patch()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_05d8904e","line":29,"in_reply_to":"3fa7e38b_3f759b97","updated":"2020-02-12 11:50:48.000000000","message":"This could be the next step, but take a look at this: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L63-L65\n\nI\u0027m afraid of setting an eventlet version in Neutron that could break anything else.","commit_id":"f9b5a7b6d73bf7d9ca5de85d50dfd9216854de30"}]}