)]}'
{"neutron/common/ovn/extensions.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"259dffd52d15d2beea5249e7fbbcc1caa1623b46","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027router\u0027,"},{"line_number":22,"context_line":"    \u0027extraroute\u0027,"},{"line_number":23,"context_line":"    \u0027ext-gw-mode\u0027,"},{"line_number":24,"context_line":"    \u0027fip-port-details\u0027,"},{"line_number":25,"context_line":"    \u0027pagination\u0027,"},{"line_number":26,"context_line":"    \u0027sorting\u0027,"},{"line_number":27,"context_line":"    \u0027project-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b856c8cc","line":24,"updated":"2020-02-07 10:05:18.000000000","message":"but I still see the same error in nova-api logs on this patch https://7f1d3bc811eac15dd3d0-a12e67e84744b622e6a13b507a2faa27.ssl.cf1.rackcdn.com/705982/2/check/neutron-ovn-tempest-ovs-release/b77ed16/controller/logs/screen-n-api.txt\nShould we change this job\u0027s configuration somehow also?","commit_id":"b532febb7b28a41fd29977cc1c6485d20aef70e0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61843a2c6bf6446f8012ded7cdf9e0415cc9e6c9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027router\u0027,"},{"line_number":22,"context_line":"    \u0027extraroute\u0027,"},{"line_number":23,"context_line":"    \u0027ext-gw-mode\u0027,"},{"line_number":24,"context_line":"    \u0027fip-port-details\u0027,"},{"line_number":25,"context_line":"    \u0027pagination\u0027,"},{"line_number":26,"context_line":"    \u0027sorting\u0027,"},{"line_number":27,"context_line":"    \u0027project-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a0f3d8e7","line":24,"in_reply_to":"3fa7e38b_98e0accd","updated":"2020-02-10 09:47:06.000000000","message":"So I checked in the code. \"Normal\" L3 service plugin inherits from Fip_port_details_db_mixin (https://github.com/openstack/neutron/blob/master/neutron/db/l3_fip_port_details.py#L30) and that extends FIP with port_details attribute.\nSo if You want to have the same for ovn_l3 service plugin, this plugin also needs to inherit from the same class.","commit_id":"b532febb7b28a41fd29977cc1c6485d20aef70e0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a4d768133199117e5cea308543f4621822d9dc51","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027router\u0027,"},{"line_number":22,"context_line":"    \u0027extraroute\u0027,"},{"line_number":23,"context_line":"    \u0027ext-gw-mode\u0027,"},{"line_number":24,"context_line":"    \u0027fip-port-details\u0027,"},{"line_number":25,"context_line":"    \u0027pagination\u0027,"},{"line_number":26,"context_line":"    \u0027sorting\u0027,"},{"line_number":27,"context_line":"    \u0027project-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_50298f37","line":24,"in_reply_to":"3fa7e38b_a0f3d8e7","updated":"2020-02-10 12:15:54.000000000","message":"I saw this too hehehehe. I\u0027ll push, in the same patch, a fix for that.\n\nI\u0027ll check which other mixins are necessary in the OVN plugin.","commit_id":"b532febb7b28a41fd29977cc1c6485d20aef70e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"30e752ff1a233584b19f712cddcae438f81491b5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027router\u0027,"},{"line_number":22,"context_line":"    \u0027extraroute\u0027,"},{"line_number":23,"context_line":"    \u0027ext-gw-mode\u0027,"},{"line_number":24,"context_line":"    \u0027fip-port-details\u0027,"},{"line_number":25,"context_line":"    \u0027pagination\u0027,"},{"line_number":26,"context_line":"    \u0027sorting\u0027,"},{"line_number":27,"context_line":"    \u0027project-id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_98e0accd","line":24,"in_reply_to":"3fa7e38b_b856c8cc","updated":"2020-02-07 10:30:11.000000000","message":"Yeah, not sure what\u0027s happening here. We should have this fixed with [1]. Am I correct in saying \u0027port_details\u0027 will *always* be present here if this extension is enabled, even if it\u0027s set to null? That\u0027s the only additional thing I can think of\n\n[1] https://review.opendev.org/#/c/706213/","commit_id":"b532febb7b28a41fd29977cc1c6485d20aef70e0"}]}