)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"248caedd51e77a5d4e238ee726015dce391ed21f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The fullstack test TestPlacementBandwidthReport."},{"line_number":10,"context_line":"test_configurations_are_synced_towards_placement sporadically failing"},{"line_number":11,"context_line":"and one possible reason is that multiple agents are visible to the"},{"line_number":12,"context_line":"server after restart of the agent (perhaps due to parallel execution)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1862177"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_571c3e13","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":23},"updated":"2020-02-07 14:50:11.000000000","message":"... and the other is that the agent actually did not get into the SYNC_FAILED state. We\u0027ll see which one is happening after this change gets merged.","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c6950f6838dacc76c7f7362cd72ef6b7509cf70","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The fullstack test TestPlacementBandwidthReport."},{"line_number":10,"context_line":"test_configurations_are_synced_towards_placement sporadically failing"},{"line_number":11,"context_line":"and one possible reason is that multiple agents are visible to the"},{"line_number":12,"context_line":"server after restart of the agent (perhaps due to parallel execution)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1862177"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_26e61db1","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":23},"in_reply_to":"3fa7e38b_571c3e13","updated":"2020-02-10 14:12:29.000000000","message":"yeah, we will see","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"248caedd51e77a5d4e238ee726015dce391ed21f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and one possible reason is that multiple agents are visible to the"},{"line_number":12,"context_line":"server after restart of the agent (perhaps due to parallel execution)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1862177"},{"line_number":15,"context_line":"Change-Id: I79aa2cb9bcd69fc0cb35e0fd351a373e00feb062"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_779a9a60","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":10},"updated":"2020-02-07 14:50:11.000000000","message":"Partial-Bug?","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c6950f6838dacc76c7f7362cd72ef6b7509cf70","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and one possible reason is that multiple agents are visible to the"},{"line_number":12,"context_line":"server after restart of the agent (perhaps due to parallel execution)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1862177"},{"line_number":15,"context_line":"Change-Id: I79aa2cb9bcd69fc0cb35e0fd351a373e00feb062"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_8646f1a7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":10},"in_reply_to":"3fa7e38b_779a9a60","updated":"2020-02-10 14:12:29.000000000","message":"Done","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"}],"neutron/tests/fullstack/test_agent_bandwidth_report.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"248caedd51e77a5d4e238ee726015dce391ed21f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def _check_agent_synced(self):"},{"line_number":218,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":219,"context_line":"        for agent in agents[\u0027agents\u0027]:"},{"line_number":220,"context_line":"            if (agent[\u0027id\u0027] \u003d\u003d self.original_agent_id and"},{"line_number":221,"context_line":"                    agent[\u0027resources_synced\u0027]):"},{"line_number":222,"context_line":"                return True"},{"line_number":223,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_77c7fa66","line":220,"range":{"start_line":220,"start_character":31,"end_line":220,"end_character":53},"updated":"2020-02-07 14:50:11.000000000","message":"This is better than the idea I had in the bug report.","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"248caedd51e77a5d4e238ee726015dce391ed21f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        neutron_config \u003d self.environment.hosts[0].l2_agent.neutron_config"},{"line_number":227,"context_line":"        report_interval \u003d int(neutron_config[\u0027agent\u0027][\u0027report_interval\u0027])"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # Note(lajoskatona): let\u0027s assume we have 1 agent at this point"},{"line_number":230,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":231,"context_line":"        self.original_agent_id \u003d agents[\u0027agents\u0027][0][\u0027id\u0027]"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f7bbeae0","line":229,"range":{"start_line":229,"start_character":29,"end_line":229,"end_character":41},"updated":"2020-02-07 14:50:11.000000000","message":"nit: an \u0027assert\u0027 is almost always better than a comment starting with \"let\u0027s assume\" :-)","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6c6950f6838dacc76c7f7362cd72ef6b7509cf70","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        neutron_config \u003d self.environment.hosts[0].l2_agent.neutron_config"},{"line_number":227,"context_line":"        report_interval \u003d int(neutron_config[\u0027agent\u0027][\u0027report_interval\u0027])"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # Note(lajoskatona): let\u0027s assume we have 1 agent at this point"},{"line_number":230,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":231,"context_line":"        self.original_agent_id \u003d agents[\u0027agents\u0027][0][\u0027id\u0027]"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_46b9d979","line":229,"range":{"start_line":229,"start_character":29,"end_line":229,"end_character":41},"in_reply_to":"3fa7e38b_f7bbeae0","updated":"2020-02-10 14:12:29.000000000","message":"assert here is too final, let\u0027s give the test another chance to see if resources can be synced.","commit_id":"1f2e8a8116f43a8b83f6c4b7b1e920eeb8e2909e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c07e5bc221288e521224f5703bd644209446a4cc","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        neutron_config \u003d self.environment.hosts[0].l2_agent.neutron_config"},{"line_number":227,"context_line":"        report_interval \u003d int(neutron_config[\u0027agent\u0027][\u0027report_interval\u0027])"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # Note(lajoskatona): let\u0027s assume we have 1 agent at this point"},{"line_number":230,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":231,"context_line":"        self.original_agent_id \u003d agents[\u0027agents\u0027][0][\u0027id\u0027]"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f74d0d70","line":229,"updated":"2020-02-10 15:30:16.000000000","message":"Hmmm but why? This is exactly what you are trying to solve in this bug, the problem when more than one agent is running. At least you can retrieve the \"agent_type\" to filter the list (maybe in \"configurations\" you have more options).","commit_id":"41bfbbd481a864d0f6698c1484f9799d08c0c89d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3f8d490b3582e96f780858a359f59bd8da35826f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        neutron_config \u003d self.environment.hosts[0].l2_agent.neutron_config"},{"line_number":227,"context_line":"        report_interval \u003d int(neutron_config[\u0027agent\u0027][\u0027report_interval\u0027])"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # Note(lajoskatona): let\u0027s assume we have 1 agent at this point"},{"line_number":230,"context_line":"        agents \u003d self.client.list_agents()"},{"line_number":231,"context_line":"        self.original_agent_id \u003d agents[\u0027agents\u0027][0][\u0027id\u0027]"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f05f42e1","line":229,"in_reply_to":"3fa7e38b_f74d0d70","updated":"2020-02-11 14:22:10.000000000","message":"True, both Bence and you are right.\nI added filtering for agent_type and added the assert.","commit_id":"41bfbbd481a864d0f6698c1484f9799d08c0c89d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"4e6dd365189c36bd509b037f9d5ab045e0cbe7e1","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _check_agent_synced(self):"},{"line_number":218,"context_line":"        agents \u003d self.client.list_agents(agent_type\u003dself.l2_agent_type)"},{"line_number":219,"context_line":"        for agent in agents[\u0027agents\u0027]:"},{"line_number":220,"context_line":"            if (agent[\u0027id\u0027] \u003d\u003d self.original_agent_id and"},{"line_number":221,"context_line":"                    agent[\u0027resources_synced\u0027]):"},{"line_number":222,"context_line":"                return True"},{"line_number":223,"context_line":"        return False"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def test_configurations_are_synced_towards_placement(self):"},{"line_number":226,"context_line":"        neutron_config \u003d self.environment.hosts[0].l2_agent.neutron_config"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1050de2c","line":223,"range":{"start_line":219,"start_character":8,"end_line":223,"end_character":20},"updated":"2020-02-11 14:53:34.000000000","message":"nit: This logic is a bit off with how we use this predicate below.\n\nFor wait_until_true(predicate\u003dcheck_agent_synced) it\u0027s perfect.\n\nBut for wait_until_true(predicate\u003dcheck_agent_not_synced) this logic terminates the wait if the the agent\u0027s synced field is false or if the agent is not present at all.\n\nHowever below where we use this predicate we clearly expect the agent to be present and not be synced.\n\nThis is just a generic note, because this does not seem to affect what we are doing in this change.","commit_id":"c9a3d49513f863be144e0df31530861938b95979"}]}