)]}'
{"neutron/plugins/ml2/drivers/type_vlan.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e27928bf4a1f215e4c4c74aaae71f178a9ec04e5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                # allocatable"},{"line_number":134,"context_line":"                if physical_network in allocations:"},{"line_number":135,"context_line":"                    for alloc in allocations[physical_network]:"},{"line_number":136,"context_line":"                        try:"},{"line_number":137,"context_line":"                            # see if vlan is allocatable"},{"line_number":138,"context_line":"                            vlan_ids.remove(alloc.vlan_id)"},{"line_number":139,"context_line":"                        except KeyError:"},{"line_number":140,"context_line":"                            # it\u0027s not allocatable, so check if its allocated"},{"line_number":141,"context_line":"                            if not alloc.allocated:"},{"line_number":142,"context_line":"                                # it\u0027s not, so remove it from table"},{"line_number":143,"context_line":"                                LOG.debug(\"Removing vlan %(vlan_id)s on \""},{"line_number":144,"context_line":"                                          \"physical network \""},{"line_number":145,"context_line":"                                          \"%(physical_network)s from pool\","},{"line_number":146,"context_line":"                                          {\u0027vlan_id\u0027: alloc.vlan_id,"},{"line_number":147,"context_line":"                                           \u0027physical_network\u0027:"},{"line_number":148,"context_line":"                                           physical_network})"},{"line_number":149,"context_line":"                                # This UPDATE WHERE statement blocks anyone"},{"line_number":150,"context_line":"                                # from concurrently changing the allocation"},{"line_number":151,"context_line":"                                # values to True while our transaction is"},{"line_number":152,"context_line":"                                # open so we don\u0027t accidentally delete"},{"line_number":153,"context_line":"                                # allocated segments. If someone has already"},{"line_number":154,"context_line":"                                # allocated, update_objects will return 0 so we"},{"line_number":155,"context_line":"                                # don\u0027t delete."},{"line_number":156,"context_line":"                                if vlanalloc.VlanAllocation.update_objects("},{"line_number":157,"context_line":"                                        ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":158,"context_line":"                                        allocated\u003dFalse, vlan_id\u003dalloc.vlan_id,"},{"line_number":159,"context_line":"                                        physical_network\u003dphysical_network):"},{"line_number":160,"context_line":"                                    alloc.delete()"},{"line_number":161,"context_line":"                    del allocations[physical_network]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                # Add missing allocatable VLAN registers for \"physical_network\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4408d82c","line":160,"range":{"start_line":136,"start_character":0,"end_line":160,"end_character":50},"updated":"2020-02-11 18:28:19.000000000","message":"I should move part of this section to vlanalloc.VlanAllocation class","commit_id":"016e7826f165e69c3956375fc3aa8b8d642c9dc9"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"7a952b129178571ce3660dba7885f71b16000e28","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                # allocatable"},{"line_number":134,"context_line":"                if physical_network in allocations:"},{"line_number":135,"context_line":"                    for alloc in allocations[physical_network]:"},{"line_number":136,"context_line":"                        try:"},{"line_number":137,"context_line":"                            # see if vlan is allocatable"},{"line_number":138,"context_line":"                            vlan_ids.remove(alloc.vlan_id)"},{"line_number":139,"context_line":"                        except KeyError:"},{"line_number":140,"context_line":"                            # it\u0027s not allocatable, so check if its allocated"},{"line_number":141,"context_line":"                            if not alloc.allocated:"},{"line_number":142,"context_line":"                                # it\u0027s not, so remove it from table"},{"line_number":143,"context_line":"                                LOG.debug(\"Removing vlan %(vlan_id)s on \""},{"line_number":144,"context_line":"                                          \"physical network \""},{"line_number":145,"context_line":"                                          \"%(physical_network)s from pool\","},{"line_number":146,"context_line":"                                          {\u0027vlan_id\u0027: alloc.vlan_id,"},{"line_number":147,"context_line":"                                           \u0027physical_network\u0027:"},{"line_number":148,"context_line":"                                           physical_network})"},{"line_number":149,"context_line":"                                # This UPDATE WHERE statement blocks anyone"},{"line_number":150,"context_line":"                                # from concurrently changing the allocation"},{"line_number":151,"context_line":"                                # values to True while our transaction is"},{"line_number":152,"context_line":"                                # open so we don\u0027t accidentally delete"},{"line_number":153,"context_line":"                                # allocated segments. If someone has already"},{"line_number":154,"context_line":"                                # allocated, update_objects will return 0 so we"},{"line_number":155,"context_line":"                                # don\u0027t delete."},{"line_number":156,"context_line":"                                if vlanalloc.VlanAllocation.update_objects("},{"line_number":157,"context_line":"                                        ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":158,"context_line":"                                        allocated\u003dFalse, vlan_id\u003dalloc.vlan_id,"},{"line_number":159,"context_line":"                                        physical_network\u003dphysical_network):"},{"line_number":160,"context_line":"                                    alloc.delete()"},{"line_number":161,"context_line":"                    del allocations[physical_network]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                # Add missing allocatable VLAN registers for \"physical_network\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a6bc1fd5","line":160,"range":{"start_line":136,"start_character":0,"end_line":160,"end_character":50},"in_reply_to":"3fa7e38b_4408d82c","updated":"2020-02-12 17:04:43.000000000","message":"Perhaps add a #TODO?","commit_id":"016e7826f165e69c3956375fc3aa8b8d642c9dc9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a48d0ab6e0dde6cf9fd22cbc7a79a1c8cc7f2407","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                # allocatable"},{"line_number":134,"context_line":"                if physical_network in allocations:"},{"line_number":135,"context_line":"                    for alloc in allocations[physical_network]:"},{"line_number":136,"context_line":"                        try:"},{"line_number":137,"context_line":"                            # see if vlan is allocatable"},{"line_number":138,"context_line":"                            vlan_ids.remove(alloc.vlan_id)"},{"line_number":139,"context_line":"                        except KeyError:"},{"line_number":140,"context_line":"                            # it\u0027s not allocatable, so check if its allocated"},{"line_number":141,"context_line":"                            if not alloc.allocated:"},{"line_number":142,"context_line":"                                # it\u0027s not, so remove it from table"},{"line_number":143,"context_line":"                                LOG.debug(\"Removing vlan %(vlan_id)s on \""},{"line_number":144,"context_line":"                                          \"physical network \""},{"line_number":145,"context_line":"                                          \"%(physical_network)s from pool\","},{"line_number":146,"context_line":"                                          {\u0027vlan_id\u0027: alloc.vlan_id,"},{"line_number":147,"context_line":"                                           \u0027physical_network\u0027:"},{"line_number":148,"context_line":"                                           physical_network})"},{"line_number":149,"context_line":"                                # This UPDATE WHERE statement blocks anyone"},{"line_number":150,"context_line":"                                # from concurrently changing the allocation"},{"line_number":151,"context_line":"                                # values to True while our transaction is"},{"line_number":152,"context_line":"                                # open so we don\u0027t accidentally delete"},{"line_number":153,"context_line":"                                # allocated segments. If someone has already"},{"line_number":154,"context_line":"                                # allocated, update_objects will return 0 so we"},{"line_number":155,"context_line":"                                # don\u0027t delete."},{"line_number":156,"context_line":"                                if vlanalloc.VlanAllocation.update_objects("},{"line_number":157,"context_line":"                                        ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":158,"context_line":"                                        allocated\u003dFalse, vlan_id\u003dalloc.vlan_id,"},{"line_number":159,"context_line":"                                        physical_network\u003dphysical_network):"},{"line_number":160,"context_line":"                                    alloc.delete()"},{"line_number":161,"context_line":"                    del allocations[physical_network]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"                # Add missing allocatable VLAN registers for \"physical_network\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4e145242","line":160,"range":{"start_line":136,"start_character":0,"end_line":160,"end_character":50},"in_reply_to":"3fa7e38b_a6bc1fd5","updated":"2020-02-13 14:29:06.000000000","message":"I\u0027ll revisit this in the next PS","commit_id":"016e7826f165e69c3956375fc3aa8b8d642c9dc9"}]}