)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c044c19b75ced39188863bd9457c6ad7b27ca667","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check SG members instead of ports to skip flow update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Security group can have a state of empty ports but non-empty members. So"},{"line_number":10,"context_line":"we need skip the flow update only when members dict is empty."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I429edb3d2dea5fa97441909b4d2c776f97f0516f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_e46adae8","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":68},"updated":"2020-02-17 10:48:35.000000000","message":"question: Does this case happen when a remote group is not used on a local node?  According to the bug report, for example, no port on a hypervisor where application-server is deployed uses bastion-sec-grp SG, so remote group processing on bastion-sec-grp will be skipped. Is my understanding right?","commit_id":"22e4206bf5720bdb333392c995c3c9344cea4a84"},{"author":{"_account_id":28159,"name":"Hang Yang","email":"hangyang@yahooinc.com","username":"hangyang"},"change_message_id":"78a7ee794ca93f9adce5bff986f02bb962d85556","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check SG members instead of ports to skip flow update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Security group can have a state of empty ports but non-empty members. So"},{"line_number":10,"context_line":"we need skip the flow update only when members dict is empty."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I429edb3d2dea5fa97441909b4d2c776f97f0516f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_1f1654f5","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":68},"in_reply_to":"3fa7e38b_e46adae8","updated":"2020-02-17 20:47:34.000000000","message":"Yes, your understanding is correct.","commit_id":"22e4206bf5720bdb333392c995c3c9344cea4a84"}],"neutron/tests/unit/agent/linux/openvswitch_firewall/test_firewall.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2648b0a9048571c9fcb0d828080ed997a7deac0c","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_update_flows_for_vlan_no_members(self):"},{"line_number":312,"context_line":"        remote_group \u003d self.driver.sg_port_map.get_sg.return_value"},{"line_number":313,"context_line":"        remote_group.members \u003d {}"},{"line_number":314,"context_line":"        with mock.patch.object(self.manager.conj_id_map,"},{"line_number":315,"context_line":"                               \u0027get_conj_id\u0027) as get_conj_id_mock:"},{"line_number":316,"context_line":"            get_conj_id_mock.return_value \u003d self.conj_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_bfc66b68","line":313,"updated":"2020-02-12 09:50:32.000000000","message":"can You also add test case which You described in commit message? So ports dict empty but members not.","commit_id":"5b6a53fe0acd1502ad4a38458bb513946c7cf65d"}],"releasenotes/notes/fix-remote-security-group-no-port-on-host-9177e66d4b16e90c.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"46cb395bd3b98f22950d049ca970fcd9041e3238","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue when a remote security group does not have a port on a"},{"line_number":5,"context_line":"    local hypervervisor, then openflow update will be skipped which breaks"},{"line_number":6,"context_line":"    the basic functionality of remote security group. For more information"},{"line_number":7,"context_line":"    see bugs: `1862703 \u003chttps://bugs.launchpad.net/neutron/+bug/1862703\u003e`_"},{"line_number":8,"context_line":"    and `1854131 \u003chttps://bugs.launchpad.net/neutron/+bug/1854131\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1f388dca","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":24},"updated":"2020-02-18 07:42:34.000000000","message":"A comma is unnecessary.","commit_id":"8370f9a647b4947f79eed64b5135b2d393e6a6a5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"46cb395bd3b98f22950d049ca970fcd9041e3238","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue when a remote security group does not have a port on a"},{"line_number":5,"context_line":"    local hypervervisor, then openflow update will be skipped which breaks"},{"line_number":6,"context_line":"    the basic functionality of remote security group. For more information"},{"line_number":7,"context_line":"    see bugs: `1862703 \u003chttps://bugs.launchpad.net/neutron/+bug/1862703\u003e`_"},{"line_number":8,"context_line":"    and `1854131 \u003chttps://bugs.launchpad.net/neutron/+bug/1854131\u003e`__."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_df419539","line":6,"updated":"2020-02-18 07:42:34.000000000","message":"I think it is better to mention it is related to the OVS firewall driver explicitly.\n\nMy suggestion (as non-native) is:\n\n  Fixes an issue that the OVS firewall driver does not \n  configure security group rules using remote group properly\n  when a corresponding remote group has no port on a local hypervisor.","commit_id":"8370f9a647b4947f79eed64b5135b2d393e6a6a5"}]}