)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"2d5e947686b88d7d431c190cb3064ecb9519fbcc","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                txn.add(self._nb_idl.update_lrouter(router_name, **update))"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"                # Check for route updates"},{"line_number":1255,"context_line":"                routes \u003d new_router.get(\u0027routes\u0027) or []"},{"line_number":1256,"context_line":"                old_routes \u003d utils.get_lrouter_non_gw_routes(ovn_router)"},{"line_number":1257,"context_line":"                added, removed \u003d helpers.diff_list_of_dict("},{"line_number":1258,"context_line":"                    old_routes, routes)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8c20af9f","line":1255,"range":{"start_line":1255,"start_character":16,"end_line":1255,"end_character":55},"updated":"2020-02-20 09:20:37.000000000","message":"routes \u003d new_router.get(\u0027routes\u0027, [])","commit_id":"018fb55b500c740e723037b39f050a918cd2be0d"},{"author":{"_account_id":31210,"name":"zhangyuhe","email":"1073258077@qq.com","username":"zhangyuhe"},"change_message_id":"404e8b05ccceb2eb8164166b73121351f8c28afc","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                txn.add(self._nb_idl.update_lrouter(router_name, **update))"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"                # Check for route updates"},{"line_number":1255,"context_line":"                routes \u003d new_router.get(\u0027routes\u0027) or []"},{"line_number":1256,"context_line":"                old_routes \u003d utils.get_lrouter_non_gw_routes(ovn_router)"},{"line_number":1257,"context_line":"                added, removed \u003d helpers.diff_list_of_dict("},{"line_number":1258,"context_line":"                    old_routes, routes)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a1ca4ca0","line":1255,"range":{"start_line":1255,"start_character":16,"end_line":1255,"end_character":55},"in_reply_to":"3fa7e38b_8c20af9f","updated":"2020-03-02 05:46:30.000000000","message":"Done","commit_id":"018fb55b500c740e723037b39f050a918cd2be0d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8f3b797a8a13d9c4edc749752a330f336531f8df","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                txn.add(self._nb_idl.update_lrouter(router_name, **update))"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"                # Check for route updates"},{"line_number":1255,"context_line":"                routes \u003d new_router.get(\u0027routes\u0027, [])"},{"line_number":1256,"context_line":"                old_routes \u003d utils.get_lrouter_non_gw_routes(ovn_router)"},{"line_number":1257,"context_line":"                added, removed \u003d helpers.diff_list_of_dict("},{"line_number":1258,"context_line":"                    old_routes, routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_73297837","line":1255,"updated":"2020-02-21 13:49:21.000000000","message":"Thanks!\n\nCode-wise it LGTM. But, is it possible to add or update an unittest for this case to prevent this error from happening again ?","commit_id":"16324678f68a18332edf47cbe539b80fa43cc928"},{"author":{"_account_id":31210,"name":"zhangyuhe","email":"1073258077@qq.com","username":"zhangyuhe"},"change_message_id":"966cfea6bf10cedb71b94cc87b88a6198a95d8c9","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                txn.add(self._nb_idl.update_lrouter(router_name, **update))"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"                # Check for route updates"},{"line_number":1255,"context_line":"                routes \u003d new_router.get(\u0027routes\u0027, [])"},{"line_number":1256,"context_line":"                old_routes \u003d utils.get_lrouter_non_gw_routes(ovn_router)"},{"line_number":1257,"context_line":"                added, removed \u003d helpers.diff_list_of_dict("},{"line_number":1258,"context_line":"                    old_routes, routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_e7b6f1fa","line":1255,"in_reply_to":"1fa4df85_e5b5bfef","updated":"2020-03-02 06:35:41.000000000","message":"Done","commit_id":"16324678f68a18332edf47cbe539b80fa43cc928"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9c1eda0181ad05c6391e384a10ee651a531ab2fd","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                txn.add(self._nb_idl.update_lrouter(router_name, **update))"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"                # Check for route updates"},{"line_number":1255,"context_line":"                routes \u003d new_router.get(\u0027routes\u0027, [])"},{"line_number":1256,"context_line":"                old_routes \u003d utils.get_lrouter_non_gw_routes(ovn_router)"},{"line_number":1257,"context_line":"                added, removed \u003d helpers.diff_list_of_dict("},{"line_number":1258,"context_line":"                    old_routes, routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_e5b5bfef","line":1255,"in_reply_to":"3fa7e38b_73297837","updated":"2020-02-26 15:12:51.000000000","message":"+1 on a test","commit_id":"16324678f68a18332edf47cbe539b80fa43cc928"},{"author":{"_account_id":31210,"name":"zhangyuhe","email":"1073258077@qq.com","username":"zhangyuhe"},"change_message_id":"966cfea6bf10cedb71b94cc87b88a6198a95d8c9","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                txn.add(self._nb_idl.update_lrouter(router_name, **update))"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"                # Check for route updates"},{"line_number":1255,"context_line":"                routes \u003d new_router.get(\u0027routes\u0027, [])"},{"line_number":1256,"context_line":"                old_routes \u003d utils.get_lrouter_non_gw_routes(ovn_router)"},{"line_number":1257,"context_line":"                added, removed \u003d helpers.diff_list_of_dict("},{"line_number":1258,"context_line":"                    old_routes, routes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_47c02551","line":1255,"in_reply_to":"3fa7e38b_73297837","updated":"2020-03-02 06:35:41.000000000","message":"Done","commit_id":"16324678f68a18332edf47cbe539b80fa43cc928"}]}