)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"96c4690fb27f0e0a6c9aeeca0bda1d2441a907bd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clear lsp.addresses always if port is OVN LB VIP port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The check _is_virtual_port_supported() prevented us from"},{"line_number":10,"context_line":"clearning the addresses field while port was OVN LB VIP port."},{"line_number":11,"context_line":"The virtual port should be set only when port is Octavia Amphore\u0027a"},{"line_number":12,"context_line":"VIP port."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_f8683522","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2020-02-24 08:41:56.000000000","message":"nit: cleaning","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e8b2cbea349b52aef0c2d795e7963c5a53baa42d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clear lsp.addresses always if port is OVN LB VIP port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The check _is_virtual_port_supported() prevented us from"},{"line_number":10,"context_line":"clearning the addresses field while port was OVN LB VIP port."},{"line_number":11,"context_line":"The virtual port should be set only when port is Octavia Amphore\u0027a"},{"line_number":12,"context_line":"VIP port."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_003ef728","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"1fa4df85_f8683522","updated":"2020-02-24 13:18:24.000000000","message":"Done","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"96c4690fb27f0e0a6c9aeeca0bda1d2441a907bd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The check _is_virtual_port_supported() prevented us from"},{"line_number":10,"context_line":"clearning the addresses field while port was OVN LB VIP port."},{"line_number":11,"context_line":"The virtual port should be set only when port is Octavia Amphore\u0027a"},{"line_number":12,"context_line":"VIP port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id6dd29650951855d13498a7206f6d1dde7db7864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_987581fd","line":11,"range":{"start_line":11,"start_character":57,"end_line":11,"end_character":64},"updated":"2020-02-24 08:41:56.000000000","message":"nit: Amphorae?","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e8b2cbea349b52aef0c2d795e7963c5a53baa42d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The check _is_virtual_port_supported() prevented us from"},{"line_number":10,"context_line":"clearning the addresses field while port was OVN LB VIP port."},{"line_number":11,"context_line":"The virtual port should be set only when port is Octavia Amphore\u0027a"},{"line_number":12,"context_line":"VIP port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id6dd29650951855d13498a7206f6d1dde7db7864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_203bf338","line":11,"range":{"start_line":11,"start_character":57,"end_line":11,"end_character":64},"in_reply_to":"1fa4df85_987581fd","updated":"2020-02-24 13:18:24.000000000","message":"Done","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"96c4690fb27f0e0a6c9aeeca0bda1d2441a907bd","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            }"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"            # NOTE(mjozefcz): Do not set addresses if the port is not"},{"line_number":345,"context_line":"            # bound, has no device_owner and its OVN LB VIP port."},{"line_number":346,"context_line":"            # For more details check related bug #1789686."},{"line_number":347,"context_line":"            if (port.get(\u0027name\u0027).startswith(ovn_const.LB_VIP_PORT_PREFIX) and"},{"line_number":348,"context_line":"                not port.get(\u0027device_owner\u0027) and"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_1882f1c9","line":345,"range":{"start_line":345,"start_character":45,"end_line":345,"end_character":48},"updated":"2020-02-24 08:41:56.000000000","message":"nit: it\u0027s","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e8b2cbea349b52aef0c2d795e7963c5a53baa42d","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            }"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"            # NOTE(mjozefcz): Do not set addresses if the port is not"},{"line_number":345,"context_line":"            # bound, has no device_owner and its OVN LB VIP port."},{"line_number":346,"context_line":"            # For more details check related bug #1789686."},{"line_number":347,"context_line":"            if (port.get(\u0027name\u0027).startswith(ovn_const.LB_VIP_PORT_PREFIX) and"},{"line_number":348,"context_line":"                not port.get(\u0027device_owner\u0027) and"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_a01843d3","line":345,"range":{"start_line":345,"start_character":45,"end_line":345,"end_character":48},"in_reply_to":"1fa4df85_1882f1c9","updated":"2020-02-24 13:18:24.000000000","message":"Done","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"96c4690fb27f0e0a6c9aeeca0bda1d2441a907bd","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            # NOTE(mjozefcz): Do not set addresses if the port is not"},{"line_number":345,"context_line":"            # bound, has no device_owner and its OVN LB VIP port."},{"line_number":346,"context_line":"            # For more details check related bug #1789686."},{"line_number":347,"context_line":"            if (port.get(\u0027name\u0027).startswith(ovn_const.LB_VIP_PORT_PREFIX) and"},{"line_number":348,"context_line":"                not port.get(\u0027device_owner\u0027) and"},{"line_number":349,"context_line":"                port.get(portbindings.VIF_TYPE) \u003d\u003d"},{"line_number":350,"context_line":"                    portbindings.VIF_TYPE_UNBOUND):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_38d56dba","line":347,"range":{"start_line":347,"start_character":15,"end_line":347,"end_character":73},"updated":"2020-02-24 08:41:56.000000000","message":"I\u0027m a bit confused. So this new code is accounting just for LB VIP ports. What about for example two VMs with allowed address pairs and a VIP balanced through keepalived running in both VMs? Would this work?","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"d7aa2120a5fb32daedf05268bcdf205c34ea9eae","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            # NOTE(mjozefcz): Do not set addresses if the port is not"},{"line_number":345,"context_line":"            # bound, has no device_owner and its OVN LB VIP port."},{"line_number":346,"context_line":"            # For more details check related bug #1789686."},{"line_number":347,"context_line":"            if (port.get(\u0027name\u0027).startswith(ovn_const.LB_VIP_PORT_PREFIX) and"},{"line_number":348,"context_line":"                not port.get(\u0027device_owner\u0027) and"},{"line_number":349,"context_line":"                port.get(portbindings.VIF_TYPE) \u003d\u003d"},{"line_number":350,"context_line":"                    portbindings.VIF_TYPE_UNBOUND):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_98aa6117","line":347,"range":{"start_line":347,"start_character":15,"end_line":347,"end_character":73},"in_reply_to":"1fa4df85_38d56dba","updated":"2020-02-24 08:50:55.000000000","message":"Yes, if port will have allowed address pairs configured (with macs taken from VIP port) it will work because we\u0027ll use virtual_ports type.\n\nIn this situation OVN LB VIP doesn\u0027t configure allowed_address_pairs, because its not needed. In previous situation the check _is_virtual_port_supported() returned true, and in fact the addresses were not cleaned.","commit_id":"34bf67ca0fcd33eb39a929c8d3bd53f36e865841"}]}