)]}'
{"neutron/agent/metadata/agent.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"cf7d6e3907a2eedfb96e82ddc68daa8e84939af4","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # Only one should be given, drop since it could be spoofed"},{"line_number":162,"context_line":"        if network_id and router_id:"},{"line_number":163,"context_line":"            return None, None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        ports \u003d self._get_ports(remote_address, network_id, router_id)"},{"line_number":166,"context_line":"        LOG.debug(\"Gotten ports for remote_address %(remote_address)s, \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_d05da4e9","line":163,"updated":"2020-03-02 14:07:25.000000000","message":"In the event that we later introduce a bug that happens to send both of these, it would be hard to discern what is going on.  I think I\u0027d prefer a DEBUG-level message here just in case.","commit_id":"8fbf90665a16e35bf4f7082b72772e11404fa18f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cbc797d63f7c1ef81819a2cb8de50c9c60e2028b","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # Only one should be given, drop since it could be spoofed"},{"line_number":162,"context_line":"        if network_id and router_id:"},{"line_number":163,"context_line":"            return None, None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        ports \u003d self._get_ports(remote_address, network_id, router_id)"},{"line_number":166,"context_line":"        LOG.debug(\"Gotten ports for remote_address %(remote_address)s, \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_6a6ddc30","line":163,"in_reply_to":"1fa4df85_d05da4e9","updated":"2020-03-02 16:27:04.000000000","message":"Done","commit_id":"8fbf90665a16e35bf4f7082b72772e11404fa18f"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"735ab18d98cbe9f17943ee3d6712f56d6c744661","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        ports \u003d ["},{"line_number":348,"context_line":"            [{\u0027device_id\u0027: \u0027device_id\u0027,"},{"line_number":349,"context_line":"              \u0027tenant_id\u0027: \u0027tenant_id\u0027,"},{"line_number":350,"context_line":"              \u0027network_id\u0027: \u0027the_nid\u0027}]"},{"line_number":351,"context_line":"        ]"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_ab59b25a","line":350,"range":{"start_line":350,"start_character":28,"end_line":350,"end_character":37},"updated":"2020-02-28 19:47:58.000000000","message":"should probably just use network_id","commit_id":"326052344fd9fd57120d6d9da25cec956e04a50a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3a05d46e183e9b4ee5423214c15b99e2c5af4823","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        ports \u003d ["},{"line_number":348,"context_line":"            [{\u0027device_id\u0027: \u0027device_id\u0027,"},{"line_number":349,"context_line":"              \u0027tenant_id\u0027: \u0027tenant_id\u0027,"},{"line_number":350,"context_line":"              \u0027network_id\u0027: \u0027the_nid\u0027}]"},{"line_number":351,"context_line":"        ]"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_0f457117","line":350,"range":{"start_line":350,"start_character":28,"end_line":350,"end_character":37},"in_reply_to":"1fa4df85_ab59b25a","updated":"2020-02-28 20:12:58.000000000","message":"Done, changed below too, was a copy/paste from all the above tests","commit_id":"326052344fd9fd57120d6d9da25cec956e04a50a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c839a2a7f844fd69d77896b0d7c49efa74a54839","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            self._get_instance_and_tenant_id_helper(headers, ports,"},{"line_number":355,"context_line":"                                                    networks\u003d(network_id,),"},{"line_number":356,"context_line":"                                                    router_id\u003drouter_id),"},{"line_number":357,"context_line":"            (None, None)"},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def _proxy_request_test_helper(self, response_code\u003d200, method\u003d\u0027GET\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_5850085e","line":357,"updated":"2020-03-01 09:58:37.000000000","message":"it should be\n\n    self.assertEqual(expected, actual)\n\nbut I see that it\u0027s done in opposite way in other places in this file too so maybe it can be changed in follow-up patch.","commit_id":"8fbf90665a16e35bf4f7082b72772e11404fa18f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cbc797d63f7c1ef81819a2cb8de50c9c60e2028b","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            self._get_instance_and_tenant_id_helper(headers, ports,"},{"line_number":355,"context_line":"                                                    networks\u003d(network_id,),"},{"line_number":356,"context_line":"                                                    router_id\u003drouter_id),"},{"line_number":357,"context_line":"            (None, None)"},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def _proxy_request_test_helper(self, response_code\u003d200, method\u003d\u0027GET\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_0ac228ea","line":357,"in_reply_to":"1fa4df85_5850085e","updated":"2020-03-02 16:27:04.000000000","message":"Will fix this and others in the file in a follow-on.","commit_id":"8fbf90665a16e35bf4f7082b72772e11404fa18f"}]}