)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_tun.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1aea7b65ba6b17759d4b8d2b29c7ead6f7523547","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # REVISIT(yamamoto): This is for API compat with \"ovs-ofctl\""},{"line_number":275,"context_line":"        # interface.  Consider removing this mechanism when obsoleting"},{"line_number":276,"context_line":"        # \"ovs-ofctl\" interface."},{"line_number":277,"context_line":"        # For \"ovs-ofctl\" interface, \"deferred\" mechanism would improve"},{"line_number":278,"context_line":"        # performance by batching flow-mods with a single ovs-ofctl command"},{"line_number":279,"context_line":"        # invocation."},{"line_number":280,"context_line":"        # On the other hand, for this \"native\" interface, the overheads of"},{"line_number":281,"context_line":"        # each flow-mods are already minimum and batching doesn\u0027t make much"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_e0cf1755","side":"PARENT","line":278,"range":{"start_line":277,"start_character":37,"end_line":278,"end_character":21},"updated":"2020-03-21 09:33:25.000000000","message":"This should be highlighted.","commit_id":"a9d6eae110022caa2c77d7508687ddc0f6c0aec5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"282b3014484f4e11288cc097303f616d0778426d","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # sense.  Thus this method is left as no-op."},{"line_number":283,"context_line":"        # It might be possible to send multiple flow-mods with a single"},{"line_number":284,"context_line":"        # barrier.  But it\u0027s unclear that level of performance optimization"},{"line_number":285,"context_line":"        # is desirable while it would certainly complicate error handling."},{"line_number":286,"context_line":"        return self"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def __enter__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_61d03652","side":"PARENT","line":285,"updated":"2020-03-20 14:49:33.000000000","message":"Liu - I based things on this comment, is it incorrect?","commit_id":"a9d6eae110022caa2c77d7508687ddc0f6c0aec5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1aea7b65ba6b17759d4b8d2b29c7ead6f7523547","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # sense.  Thus this method is left as no-op."},{"line_number":283,"context_line":"        # It might be possible to send multiple flow-mods with a single"},{"line_number":284,"context_line":"        # barrier.  But it\u0027s unclear that level of performance optimization"},{"line_number":285,"context_line":"        # is desirable while it would certainly complicate error handling."},{"line_number":286,"context_line":"        return self"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def __enter__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_80ebabae","side":"PARENT","line":285,"in_reply_to":"df33271e_61d03652","updated":"2020-03-21 09:33:25.000000000","message":"I\u0027m not sure if there are any code still use the tunnel bridge derrered method. But this patch should not remove the integration bridge (br-int) derrered method.","commit_id":"a9d6eae110022caa2c77d7508687ddc0f6c0aec5"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a49e60a971695d5e5cc0cf6daa4172fb2d0ebd1e","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            self.deleted_ports -\u003d port_info[\u0027removed\u0027]"},{"line_number":654,"context_line":"        deleted_ports \u003d list(self.deleted_ports)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        with self.int_br.deferred(full_ordered\u003dTrue,"},{"line_number":657,"context_line":"                                  use_bundle\u003dTrue) as int_br:"},{"line_number":658,"context_line":"            while self.deleted_ports:"},{"line_number":659,"context_line":"                port_id \u003d self.deleted_ports.pop()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_2e4d9d99","side":"PARENT","line":656,"range":{"start_line":656,"start_character":25,"end_line":656,"end_character":33},"updated":"2020-03-20 05:55:18.000000000","message":"Remove the \"deferred mode\" will significantly increase the agent restart time.","commit_id":"a9d6eae110022caa2c77d7508687ddc0f6c0aec5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1aea7b65ba6b17759d4b8d2b29c7ead6f7523547","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            self.deleted_ports -\u003d port_info[\u0027removed\u0027]"},{"line_number":654,"context_line":"        deleted_ports \u003d list(self.deleted_ports)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        with self.int_br.deferred(full_ordered\u003dTrue,"},{"line_number":657,"context_line":"                                  use_bundle\u003dTrue) as int_br:"},{"line_number":658,"context_line":"            while self.deleted_ports:"},{"line_number":659,"context_line":"                port_id \u003d self.deleted_ports.pop()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_20773f3d","side":"PARENT","line":656,"range":{"start_line":656,"start_character":25,"end_line":656,"end_character":33},"in_reply_to":"1fa4df85_2e4d9d99","updated":"2020-03-21 09:33:25.000000000","message":"This deferred action was intended to accelerate the ports processing, the \u0027--bundle\u0027 action for flows installation:\n[\u0027ovs-ofctl\u0027, \u0027add-flows\u0027, \u0027-O\u0027, \u0027OpenFlow10\u0027, \u0027br-int\u0027, \u0027--bundle\u0027, \u0027-\u0027]","commit_id":"a9d6eae110022caa2c77d7508687ddc0f6c0aec5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5bb857f9c29210f74c731d50ceadcb9953659188","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"        lvm \u003d self.vlan_manager.get(port_detail[\u0027network_id\u0027])"},{"line_number":2080,"context_line":"        port \u003d port_detail[\u0027vif_port\u0027]"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"        br_int.add_flow("},{"line_number":2083,"context_line":"            table\u003dconstants.TRANSIENT_TABLE,"},{"line_number":2084,"context_line":"            priority\u003d9,"},{"line_number":2085,"context_line":"            in_port\u003dport.ofport,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_e1dfbc37","line":2082,"range":{"start_line":2082,"start_character":15,"end_line":2082,"end_character":23},"updated":"2020-03-20 05:52:58.000000000","message":"I don\u0027t think this has been implemented by the RYU api.","commit_id":"d954cd4fea64fff3714d7bd1a609dea850c7f056"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"282b3014484f4e11288cc097303f616d0778426d","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"        lvm \u003d self.vlan_manager.get(port_detail[\u0027network_id\u0027])"},{"line_number":2080,"context_line":"        port \u003d port_detail[\u0027vif_port\u0027]"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"        br_int.add_flow("},{"line_number":2083,"context_line":"            table\u003dconstants.TRANSIENT_TABLE,"},{"line_number":2084,"context_line":"            priority\u003d9,"},{"line_number":2085,"context_line":"            in_port\u003dport.ofport,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_e150c6d7","line":2082,"range":{"start_line":2082,"start_character":15,"end_line":2082,"end_character":23},"in_reply_to":"1fa4df85_e1dfbc37","updated":"2020-03-20 14:49:33.000000000","message":"I\u0027m not sure what it has to do with this change as any exceptions will be caught by caller above, right?","commit_id":"d954cd4fea64fff3714d7bd1a609dea850c7f056"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1aea7b65ba6b17759d4b8d2b29c7ead6f7523547","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"        lvm \u003d self.vlan_manager.get(port_detail[\u0027network_id\u0027])"},{"line_number":2080,"context_line":"        port \u003d port_detail[\u0027vif_port\u0027]"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"        br_int.add_flow("},{"line_number":2083,"context_line":"            table\u003dconstants.TRANSIENT_TABLE,"},{"line_number":2084,"context_line":"            priority\u003d9,"},{"line_number":2085,"context_line":"            in_port\u003dport.ofport,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_809d6b5b","line":2082,"range":{"start_line":2082,"start_character":15,"end_line":2082,"end_character":23},"in_reply_to":"df33271e_e150c6d7","updated":"2020-03-21 09:33:25.000000000","message":"No exception, but reduce the flow installation performance.\n\nPlease see my comments in the left side.","commit_id":"d954cd4fea64fff3714d7bd1a609dea850c7f056"}]}