)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8b1869d61467be49c6a44090b3e0112d28df93dd","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://www.keepalived.org/manpage.html"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Related-bug: #1859832"},{"line_number":25,"context_line":"Change-Id: I9c4f0f8bee43d695878aedfcd19c449540541991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8570e441_3efb9177","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":21},"updated":"2021-12-02 09:36:51.000000000","message":"And [1] could be added too as related bug (or closing this bug, maybe).\n\n[1]https://bugs.launchpad.net/neutron/+bug/1952907","commit_id":"e0c4493008e4e1d4d0088f262f78d77e5cf82ce4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8b1869d61467be49c6a44090b3e0112d28df93dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c843df7d_903607f0","updated":"2021-12-02 09:36:51.000000000","message":"\u003e Patch Set 7: Code-Review-1\n\u003e \n\u003e I\u0027m ok with this change but should be aligned with https://review.opendev.org/c/openstack/neutron/+/759886\n\n^^ This patch is abandoned, I think we can continue with this idea.","commit_id":"e0c4493008e4e1d4d0088f262f78d77e5cf82ce4"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"42f692ad917f1cfcc5599d1c46de7fd624deacf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"984e57f0_a0bcd7a0","updated":"2021-12-06 16:56:29.000000000","message":"Hello,\n\nI see few problems with this change:\n\n1. At least for me(keepalived v2.0.19) it does not work. Keepalived complains about \"Unknown keyword \u0027vrrp_garp_interval\u0027\". If i can read the code properly, there\u0027s no way to set garp_interval/vrrp_garp_interval inside vrrp instance section. It has to be defined globally or per garp group.\n2. Even I have edited this change to set `vrrp_garp_interval 10` globally, it didn\u0027t solve my issue. Keepalived still complains about \u0027Error 100 (Network is down) sending gratuitous ARP on qg-4a2f0239-5c for 172.29.249.194\u0027 and doesn\u0027t send any GARPs\n3. I think it may be better to find out why keepalived is spawned before router interfaces are created/linked rather than implementing this workaround(but feel free to correct me if I\u0027m wrong). I\u0027m currently working on this but I may need a helping hand.","commit_id":"e0c4493008e4e1d4d0088f262f78d77e5cf82ce4"}],"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"07a91e554fe4638c3e9a20a38c03b3672d824e3d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"KEEPALIVED_EMAIL_FROM \u003d \u0027neutron@openstack.local\u0027"},{"line_number":39,"context_line":"KEEPALIVED_ROUTER_ID \u003d \u0027neutron\u0027"},{"line_number":40,"context_line":"GARP_PRIMARY_DELAY \u003d 60"},{"line_number":41,"context_line":"VRRP_GARP_INTERVAL \u003d 0.2"},{"line_number":42,"context_line":"HEALTH_CHECK_NAME \u003d \u0027ha_health_check\u0027"},{"line_number":43,"context_line":"_IS_NO_TRACK_SUPPORTED \u003d None"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"720ff3aa_01f47db2","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":24},"updated":"2021-12-02 00:54:53.000000000","message":"Maybe this can be configrable since the bug [1] tells us keepalived set GARP that is 1s eailer before neutron done set device up. Users can estimate the final value based on the resources quantity and processing pressure.\n\n[1] https://bugs.launchpad.net/neutron/+bug/1952907","commit_id":"e0c4493008e4e1d4d0088f262f78d77e5cf82ce4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8b1869d61467be49c6a44090b3e0112d28df93dd","unresolved":true,"context_lines":[{"line_number":38,"context_line":"KEEPALIVED_EMAIL_FROM \u003d \u0027neutron@openstack.local\u0027"},{"line_number":39,"context_line":"KEEPALIVED_ROUTER_ID \u003d \u0027neutron\u0027"},{"line_number":40,"context_line":"GARP_PRIMARY_DELAY \u003d 60"},{"line_number":41,"context_line":"VRRP_GARP_INTERVAL \u003d 0.2"},{"line_number":42,"context_line":"HEALTH_CHECK_NAME \u003d \u0027ha_health_check\u0027"},{"line_number":43,"context_line":"_IS_NO_TRACK_SUPPORTED \u003d None"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"056e99d2_3483269a","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":24},"in_reply_to":"720ff3aa_01f47db2","updated":"2021-12-02 09:36:51.000000000","message":"Agree. Once [1] is no longer the expected implementation, we can continue with this patch.\n\n0.2 seems too quick, I\u0027ll set a default value of 0.5. But yes, I agree with the idea of adding a conf value.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/759886","commit_id":"e0c4493008e4e1d4d0088f262f78d77e5cf82ce4"}]}