)]}'
{"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fd92351d42056db61d22e1da663bd2ef766f47b2","unresolved":false,"context_lines":[{"line_number":6508,"context_line":"                                        project_id\u003d\u0027fake_project\u0027,"},{"line_number":6509,"context_line":"                                        mtu\u003d1500)"},{"line_number":6510,"context_line":"            ctx.session.add(network)"},{"line_number":6511,"context_line":"            with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":6512,"context_line":"                sg \u003d sg_models.SecurityGroup(name\u003d\u0027sg\u0027, description\u003d\u0027sg\u0027)"},{"line_number":6513,"context_line":"                ctx.session.add(sg)"},{"line_number":6514,"context_line":"            # ensure db rels aren\u0027t loaded until commit for network object"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_672686ba","line":6511,"range":{"start_line":6511,"start_character":12,"end_line":6511,"end_character":50},"updated":"2020-03-20 15:56:34.000000000","message":"You don\u0027t need to nest the same transaction here. The context \"ctx\" session is active since L6505","commit_id":"32fc70a733369e0b81524d832cb3509a4648704f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e9bb177d31de83f8cbd6796348550dfff3705d08","unresolved":false,"context_lines":[{"line_number":6508,"context_line":"                                        project_id\u003d\u0027fake_project\u0027,"},{"line_number":6509,"context_line":"                                        mtu\u003d1500)"},{"line_number":6510,"context_line":"            ctx.session.add(network)"},{"line_number":6511,"context_line":"            with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":6512,"context_line":"                sg \u003d sg_models.SecurityGroup(name\u003d\u0027sg\u0027, description\u003d\u0027sg\u0027)"},{"line_number":6513,"context_line":"                ctx.session.add(sg)"},{"line_number":6514,"context_line":"            # ensure db rels aren\u0027t loaded until commit for network object"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a6886b71","line":6511,"range":{"start_line":6511,"start_character":12,"end_line":6511,"end_character":50},"in_reply_to":"df33271e_672686ba","updated":"2020-03-24 10:31:23.000000000","message":"True. But in fact this nested transaction was kind of needed  because we need to do session.flush() before creating RBAC object for this network later. So I replaced that with flush now.","commit_id":"32fc70a733369e0b81524d832cb3509a4648704f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1aa9f9273a7792b16921528b96d4874a50400364","unresolved":false,"context_lines":[{"line_number":6556,"context_line":"        return sg, rule"},{"line_number":6557,"context_line":""},{"line_number":6558,"context_line":"    def _make_floating_ip(self, ctx, port_id):"},{"line_number":6559,"context_line":"        with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":6560,"context_line":"            flip \u003d l3_obj.FloatingIP("},{"line_number":6561,"context_line":"                ctx, floating_ip_address\u003dnetaddr.IPAddress(\u00271.2.3.4\u0027),"},{"line_number":6562,"context_line":"                floating_network_id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_6112f6b3","line":6559,"updated":"2020-03-20 14:57:43.000000000","message":"I guess being a unit test this never caused problems :-o","commit_id":"32fc70a733369e0b81524d832cb3509a4648704f"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"477b6731d47d9d497fc641d96f4154cd1890188d","unresolved":false,"context_lines":[{"line_number":6556,"context_line":"        return sg, rule"},{"line_number":6557,"context_line":""},{"line_number":6558,"context_line":"    def _make_floating_ip(self, ctx, port_id):"},{"line_number":6559,"context_line":"        with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":6560,"context_line":"            flip \u003d l3_obj.FloatingIP("},{"line_number":6561,"context_line":"                ctx, floating_ip_address\u003dnetaddr.IPAddress(\u00271.2.3.4\u0027),"},{"line_number":6562,"context_line":"                floating_network_id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_e1ef26ae","line":6559,"range":{"start_line":6559,"start_character":8,"end_line":6559,"end_character":45},"updated":"2020-03-20 14:55:43.000000000","message":"Should not this be in the object itself? NeutronDbObject.create() has \"with self.db_context_writer(self.obj_context)\" wrap","commit_id":"32fc70a733369e0b81524d832cb3509a4648704f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e9bb177d31de83f8cbd6796348550dfff3705d08","unresolved":false,"context_lines":[{"line_number":6556,"context_line":"        return sg, rule"},{"line_number":6557,"context_line":""},{"line_number":6558,"context_line":"    def _make_floating_ip(self, ctx, port_id):"},{"line_number":6559,"context_line":"        with db_api.CONTEXT_WRITER.using(ctx):"},{"line_number":6560,"context_line":"            flip \u003d l3_obj.FloatingIP("},{"line_number":6561,"context_line":"                ctx, floating_ip_address\u003dnetaddr.IPAddress(\u00271.2.3.4\u0027),"},{"line_number":6562,"context_line":"                floating_network_id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c6d12f5a","line":6559,"in_reply_to":"df33271e_6112f6b3","updated":"2020-03-24 10:31:23.000000000","message":"actually, without that I had problems with some UT because FIP object was \"already attached to session \u002710\u0027 and this is \u002711\u0027\"","commit_id":"32fc70a733369e0b81524d832cb3509a4648704f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a7d01f9d949f5895cff5aff37584cf6f7e793130","unresolved":false,"context_lines":[{"line_number":6510,"context_line":"            ctx.session.add(network)"},{"line_number":6511,"context_line":"            # ensure db rels aren\u0027t loaded until commit for network object"},{"line_number":6512,"context_line":"            # by sharing after flush"},{"line_number":6513,"context_line":"            ctx.session.flush()"},{"line_number":6514,"context_line":""},{"line_number":6515,"context_line":"            network_obj.NetworkRBAC("},{"line_number":6516,"context_line":"                ctx, object_id\u003dnetwork.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_9f512a12","line":6513,"updated":"2020-03-24 12:43:26.000000000","message":"yeah, much better","commit_id":"d982a68446ad9b9c432ab2788900993aa21e135a"}]}