)]}'
{"doc/source/install/ovn/manual_install.rst":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"73f82bcb544ea155da1fd7dac5e830c93af4b88f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      .. warning::"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        The default for ``max_header_size``, ``30``, is too low for OVN."},{"line_number":200,"context_line":"        An acceptable minimum is ``38``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"   * Optionally, enable support for VLAN provider and self-service"},{"line_number":203,"context_line":"     networks on one or more physical networks. If you specify only"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df33271e_5ceae3ab","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":29},"updated":"2020-03-26 13:02:53.000000000","message":"Is there a point to set this higher than 38? If not, I\u0027d say something like this instead: \"OVN requires max_header_size\u003d38\".","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b6259c09144c5741f6d68227aa2ac62b92544c70","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      .. warning::"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        The default for ``max_header_size``, ``30``, is too low for OVN."},{"line_number":200,"context_line":"        An acceptable minimum is ``38``."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"   * Optionally, enable support for VLAN provider and self-service"},{"line_number":203,"context_line":"     networks on one or more physical networks. If you specify only"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df33271e_38c12f30","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":29},"in_reply_to":"df33271e_5ceae3ab","updated":"2020-04-04 15:10:15.000000000","message":"I don\u0027t think either wording is great because OVN will work fine with higher max_header_size. OTOH, my wording suggests there could be some benefit to doing more than \"the minimum\". I would maybe use the wording from the other file?","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"}],"neutron/conf/plugins/ml2/drivers/driver_type.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"73f82bcb544ea155da1fd7dac5e830c93af4b88f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      \"The default is 30, which is the size of the Geneve \""},{"line_number":53,"context_line":"                      \"header without any additional option headers. \""},{"line_number":54,"context_line":"                      \"Note the default is not enough for OVN which \""},{"line_number":55,"context_line":"                      \"requires at least 38.\")),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"vxlan_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5c030374","line":55,"range":{"start_line":55,"start_character":32,"end_line":55,"end_character":40},"updated":"2020-03-26 13:02:53.000000000","message":"May be superfluous as commented in the previous file.","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b6259c09144c5741f6d68227aa2ac62b92544c70","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      \"The default is 30, which is the size of the Geneve \""},{"line_number":53,"context_line":"                      \"header without any additional option headers. \""},{"line_number":54,"context_line":"                      \"Note the default is not enough for OVN which \""},{"line_number":55,"context_line":"                      \"requires at least 38.\")),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"vxlan_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_d8e5a3de","line":55,"range":{"start_line":55,"start_character":32,"end_line":55,"end_character":40},"in_reply_to":"df33271e_5c030374","updated":"2020-04-04 15:10:15.000000000","message":"Not sure, 39 will make ovn happy as well. See the previous answer.","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c68d7009ad4ac8fee1865e0ea1531071e0a58c16","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if cfg.CONF.SECURITYGROUP.firewall_driver:"},{"line_number":119,"context_line":"            LOG.warning(\u0027Firewall driver configuration is ignored\u0027)"},{"line_number":120,"context_line":"        if cfg.CONF.ml2_type_geneve.max_header_size \u003c \\"},{"line_number":121,"context_line":"                OVN_MIN_GENEVE_MAX_HEADER_SIZE:"},{"line_number":122,"context_line":"            LOG.error(\u0027Geneve max_header_size set too low for OVN (%d vs %d)\u0027,"},{"line_number":123,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":124,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_111fca6c","line":121,"updated":"2020-03-24 18:25:52.000000000","message":"nit: can you use parens around this to avoid the \\ ?  thanks","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0ead045a81ac2473e90cc3111367db9915b3a779","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if cfg.CONF.SECURITYGROUP.firewall_driver:"},{"line_number":119,"context_line":"            LOG.warning(\u0027Firewall driver configuration is ignored\u0027)"},{"line_number":120,"context_line":"        if cfg.CONF.ml2_type_geneve.max_header_size \u003c \\"},{"line_number":121,"context_line":"                OVN_MIN_GENEVE_MAX_HEADER_SIZE:"},{"line_number":122,"context_line":"            LOG.error(\u0027Geneve max_header_size set too low for OVN (%d vs %d)\u0027,"},{"line_number":123,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":124,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_34147ca0","line":121,"in_reply_to":"df33271e_111fca6c","updated":"2020-03-24 18:51:27.000000000","message":"makes sense, will do","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c68d7009ad4ac8fee1865e0ea1531071e0a58c16","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                OVN_MIN_GENEVE_MAX_HEADER_SIZE:"},{"line_number":122,"context_line":"            LOG.error(\u0027Geneve max_header_size set too low for OVN (%d vs %d)\u0027,"},{"line_number":123,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":124,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"},{"line_number":125,"context_line":"        self._setup_vif_port_bindings()"},{"line_number":126,"context_line":"        self.subscribe()"},{"line_number":127,"context_line":"        self.qos_driver \u003d qos_driver.OVNQosNotificationDriver.create(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_910aba23","line":124,"updated":"2020-03-24 18:25:52.000000000","message":"This seems like it should be fatal, since OVN will not operate otherwise.  Perhaps this should be a LOG.exception with a sys.exit(1) afterwards?","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b6259c09144c5741f6d68227aa2ac62b92544c70","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                OVN_MIN_GENEVE_MAX_HEADER_SIZE:"},{"line_number":122,"context_line":"            LOG.error(\u0027Geneve max_header_size set too low for OVN (%d vs %d)\u0027,"},{"line_number":123,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":124,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"},{"line_number":125,"context_line":"        self._setup_vif_port_bindings()"},{"line_number":126,"context_line":"        self.subscribe()"},{"line_number":127,"context_line":"        self.qos_driver \u003d qos_driver.OVNQosNotificationDriver.create(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b8ea5fa9","line":124,"in_reply_to":"df33271e_3c627f3f","updated":"2020-04-04 15:10:15.000000000","message":"Your wish is my command, sir.","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"73f82bcb544ea155da1fd7dac5e830c93af4b88f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                OVN_MIN_GENEVE_MAX_HEADER_SIZE:"},{"line_number":122,"context_line":"            LOG.error(\u0027Geneve max_header_size set too low for OVN (%d vs %d)\u0027,"},{"line_number":123,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":124,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"},{"line_number":125,"context_line":"        self._setup_vif_port_bindings()"},{"line_number":126,"context_line":"        self.subscribe()"},{"line_number":127,"context_line":"        self.qos_driver \u003d qos_driver.OVNQosNotificationDriver.create(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3c627f3f","line":124,"in_reply_to":"df33271e_548820e6","updated":"2020-03-26 13:02:53.000000000","message":"+1 to make this fatal. As a deployer I\u0027d be happy I realized my error earlier and don\u0027t have to carefully hand-manage network mtu-s later.","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0ead045a81ac2473e90cc3111367db9915b3a779","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                OVN_MIN_GENEVE_MAX_HEADER_SIZE:"},{"line_number":122,"context_line":"            LOG.error(\u0027Geneve max_header_size set too low for OVN (%d vs %d)\u0027,"},{"line_number":123,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":124,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"},{"line_number":125,"context_line":"        self._setup_vif_port_bindings()"},{"line_number":126,"context_line":"        self.subscribe()"},{"line_number":127,"context_line":"        self.qos_driver \u003d qos_driver.OVNQosNotificationDriver.create(self)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_548820e6","line":124,"in_reply_to":"df33271e_910aba23","updated":"2020-03-24 18:51:27.000000000","message":"I gave this some thought and stayed with LOG.error due to two reasons: 1) other mech drivers still work, 2) it affects only OVN\u0027s MTU. OTOH, affecting MTU is bad and possibly could be healthier to prevent it at an early stage. I\u0027m open to any decision.","commit_id":"3e1f15e4446c76c768c58182f0d93e0b96d3c0aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a4667598eb1a177518df7d2a7e8db2cd566d135c","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            LOG.critical(\u0027Geneve max_header_size set too low for OVN \u0027"},{"line_number":124,"context_line":"                         \u0027(%d vs %d)\u0027,"},{"line_number":125,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":126,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"},{"line_number":127,"context_line":"            raise SystemExit(1)"},{"line_number":128,"context_line":"        self._setup_vif_port_bindings()"},{"line_number":129,"context_line":"        if impl_idl_ovn.OvsdbSbOvnIdl.schema_has_table(\u0027Chassis_Private\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"134a51f7_e86038d4","line":126,"updated":"2021-09-02 11:41:11.000000000","message":"just an idea: maybe instead of failing here, we could simply log warning and override value with minimal required one?","commit_id":"dc4a57d96661fcb56ff916cafbbbdc683653e9c4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1abd1dd52802d95c410e5ee863dd9cf4d46ca271","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            LOG.critical(\u0027Geneve max_header_size set too low for OVN \u0027"},{"line_number":124,"context_line":"                         \u0027(%d vs %d)\u0027,"},{"line_number":125,"context_line":"                      cfg.CONF.ml2_type_geneve.max_header_size,"},{"line_number":126,"context_line":"                      OVN_MIN_GENEVE_MAX_HEADER_SIZE)"},{"line_number":127,"context_line":"            raise SystemExit(1)"},{"line_number":128,"context_line":"        self._setup_vif_port_bindings()"},{"line_number":129,"context_line":"        if impl_idl_ovn.OvsdbSbOvnIdl.schema_has_table(\u0027Chassis_Private\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"91ddd4ee_a88545d1","line":126,"in_reply_to":"134a51f7_e86038d4","updated":"2021-09-02 11:42:24.000000000","message":"It\u0027s good practice to be explicit and fail early. This we can easily fail early.","commit_id":"dc4a57d96661fcb56ff916cafbbbdc683653e9c4"}]}