)]}'
{"neutron/services/trunk/drivers/openvswitch/agent/ovsdb_handler.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f9d1f9382c9f9d74ffb967037129ab77bb02b2d0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # try to mitigate the issue by checking if there is a port on the"},{"line_number":219,"context_line":"        # bridge and if so then do not remove it."},{"line_number":220,"context_line":"        bridge \u003d ovs_lib.OVSBridge(bridge_name)"},{"line_number":221,"context_line":"        greenthread.sleep(WAIT_BEFORE_TRUNK_DELETE)"},{"line_number":222,"context_line":"        if bridge_has_instance_port(bridge):"},{"line_number":223,"context_line":"            LOG.debug(\"The bridge %s has instances attached so it will not \""},{"line_number":224,"context_line":"                      \"be deleted.\", bridge_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_76ca716d","line":221,"updated":"2020-03-25 21:00:18.000000000","message":"I think something about using greenthread.sleep is causing an issue that is showing up in grenade tests especially.  Trying time.sleep instead, since we\u0027re in a greenthread at this point.","commit_id":"d151d13b544d71e956e8637f83c0d03e55a79c61"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"41bd4fdb504e737e85bf5077b4593e9f4111368c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # try to mitigate the issue by checking if there is a port on the"},{"line_number":219,"context_line":"        # bridge and if so then do not remove it."},{"line_number":220,"context_line":"        bridge \u003d ovs_lib.OVSBridge(bridge_name)"},{"line_number":221,"context_line":"        time.sleep(WAIT_BEFORE_TRUNK_DELETE)"},{"line_number":222,"context_line":"        if bridge_has_instance_port(bridge):"},{"line_number":223,"context_line":"            LOG.debug(\"The bridge %s has instances attached so it will not \""},{"line_number":224,"context_line":"                      \"be deleted.\", bridge_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_0bff9867","line":221,"updated":"2020-04-06 14:24:45.000000000","message":"Sorry, I\u0027m a little late to the party, but just saw all the stable backports and have a question here before we approve them all.\n\nI understand we want to try and wait for a few seconds to make sure we don\u0027t delete the trunk accidentally.  But it seems like there are cases where bridge_has_instance_port() can return True when called without a delay?  Would it have been better to use something like wait_until_true() with a 3 second timeout, that way we could delay less than 3 seconds?  Just a thought.","commit_id":"e37722c0f5f0b746135200db6f654674dc0f6f12"}]}