)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f0962ddef5ddb7d9fd896b0784c3aebb1d710aa","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # NOTE(lucasgomes): If the external_ids column wasn\u0027t updated"},{"line_number":86,"context_line":"        # (meaning, Chassis \"gateway\" status didn\u0027t change) just returns"},{"line_number":87,"context_line":"        if not hasattr(old, \u0027external_ids\u0027) and event \u003d\u003d self.ROW_UPDATE:"},{"line_number":88,"context_line":"            return"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        is_gw_chassis \u003d utils.is_gateway_chassis(row)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_43682820","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":43},"updated":"2020-03-27 15:31:04.000000000","message":"In think you can write this inside the \"if event \u003d\u003d self.ROW_UPDATE\" (L95).\n\nBut maybe is better here, just to avoid any further processing.","commit_id":"73690fa1da873cad4cce621149c01226089698d9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5cd2790a73722fc83ca8ccc14f0c57753cff3969","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # NOTE(lucasgomes): If the external_ids column wasn\u0027t updated"},{"line_number":86,"context_line":"        # (meaning, Chassis \"gateway\" status didn\u0027t change) just returns"},{"line_number":87,"context_line":"        if not hasattr(old, \u0027external_ids\u0027) and event \u003d\u003d self.ROW_UPDATE:"},{"line_number":88,"context_line":"            return"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        is_gw_chassis \u003d utils.is_gateway_chassis(row)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a350145f","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":43},"in_reply_to":"df33271e_43682820","updated":"2020-03-27 15:32:06.000000000","message":"Exactly, I thought about checking here first to avoid any processing and just return as quickly as possible","commit_id":"73690fa1da873cad4cce621149c01226089698d9"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"40abf948d59f13bb6f972554fe922bff12d65d3e","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # NOTE(lucasgomes): If the external_ids column wasn\u0027t updated"},{"line_number":86,"context_line":"        # (meaning, Chassis \"gateway\" status didn\u0027t change) just returns"},{"line_number":87,"context_line":"        if not hasattr(old, \u0027external_ids\u0027) and event \u003d\u003d self.ROW_UPDATE:"},{"line_number":88,"context_line":"            return"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        is_gw_chassis \u003d utils.is_gateway_chassis(row)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_e395fce5","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":43},"in_reply_to":"df33271e_43682820","updated":"2020-03-27 15:35:29.000000000","message":"Yeah I was going to suggest the same but we save checking further things.","commit_id":"73690fa1da873cad4cce621149c01226089698d9"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"03f6bfe598930238914451e9ee8218db49de51f7","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    def test_handle_ha_chassis_group_changes_update_ext_id_not_found(self):"},{"line_number":563,"context_line":"        self.is_gw_ch_mock.side_effect \u003d (True, False)"},{"line_number":564,"context_line":"        old \u003d fakes.FakeOvsdbTable.create_one_ovsdb_table("},{"line_number":565,"context_line":"            attrs\u003d{\u0027name\u0027: \u0027SpongeBob\u0027})"},{"line_number":566,"context_line":"        self.assertIsNone(self.event.handle_ha_chassis_group_changes("},{"line_number":567,"context_line":"            self.event.ROW_UPDATE, mock.Mock(), old))"},{"line_number":568,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_add_chassis.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_5256305e","line":565,"range":{"start_line":565,"start_character":28,"end_line":565,"end_character":37},"updated":"2020-03-27 19:19:46.000000000","message":"square pants!","commit_id":"ea999564a5b80dcf13c0c43f107165f0754210b7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"969a3c914385b4629185433e2e516e923c65bbdb","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    def test_handle_ha_chassis_group_changes_update_ext_id_not_found(self):"},{"line_number":563,"context_line":"        self.is_gw_ch_mock.side_effect \u003d (True, False)"},{"line_number":564,"context_line":"        old \u003d fakes.FakeOvsdbTable.create_one_ovsdb_table("},{"line_number":565,"context_line":"            attrs\u003d{\u0027name\u0027: \u0027SpongeBob\u0027})"},{"line_number":566,"context_line":"        self.assertIsNone(self.event.handle_ha_chassis_group_changes("},{"line_number":567,"context_line":"            self.event.ROW_UPDATE, mock.Mock(), old))"},{"line_number":568,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_add_chassis.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d8625f3e","line":565,"range":{"start_line":565,"start_character":28,"end_line":565,"end_character":37},"in_reply_to":"df33271e_5256305e","updated":"2020-03-27 20:52:04.000000000","message":":D","commit_id":"ea999564a5b80dcf13c0c43f107165f0754210b7"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"03f6bfe598930238914451e9ee8218db49de51f7","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            attrs\u003d{\u0027name\u0027: \u0027SpongeBob\u0027})"},{"line_number":566,"context_line":"        self.assertIsNone(self.event.handle_ha_chassis_group_changes("},{"line_number":567,"context_line":"            self.event.ROW_UPDATE, mock.Mock(), old))"},{"line_number":568,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_add_chassis.called)"},{"line_number":569,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_del_chassis.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d2c7e011","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":25},"updated":"2020-03-27 19:19:46.000000000","message":"nit: you could use\n\nself.nb_ovn.ha_chassis_group_add_chassis.assert_not_called()\n\nhere","commit_id":"ea999564a5b80dcf13c0c43f107165f0754210b7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"969a3c914385b4629185433e2e516e923c65bbdb","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            attrs\u003d{\u0027name\u0027: \u0027SpongeBob\u0027})"},{"line_number":566,"context_line":"        self.assertIsNone(self.event.handle_ha_chassis_group_changes("},{"line_number":567,"context_line":"            self.event.ROW_UPDATE, mock.Mock(), old))"},{"line_number":568,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_add_chassis.called)"},{"line_number":569,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_del_chassis.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_58564f5e","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":25},"in_reply_to":"df33271e_d2c7e011","updated":"2020-03-27 20:52:04.000000000","message":"++\n\nSince it\u0027s already approved I will keep as is, but in case I need to spin a new version of this patch I will change it.\n\nThanks","commit_id":"ea999564a5b80dcf13c0c43f107165f0754210b7"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"03f6bfe598930238914451e9ee8218db49de51f7","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        self.assertIsNone(self.event.handle_ha_chassis_group_changes("},{"line_number":567,"context_line":"            self.event.ROW_UPDATE, mock.Mock(), old))"},{"line_number":568,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_add_chassis.called)"},{"line_number":569,"context_line":"        self.assertFalse(self.nb_ovn.ha_chassis_group_del_chassis.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_b2ca1c17","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":73},"updated":"2020-03-27 19:19:46.000000000","message":"same","commit_id":"ea999564a5b80dcf13c0c43f107165f0754210b7"}]}