)]}'
{"neutron/objects/trunk.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7dd90df8ba1b0718635e04fac16ea5f398ba9a68","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return _dict"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def create(self):"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            with self.db_context_writer(self.obj_context):"},{"line_number":57,"context_line":"                super(SubPort, self).create()"},{"line_number":58,"context_line":"        except o_db_exc.DBReferenceError as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_4d027c0b","line":55,"updated":"2020-04-03 18:02:11.000000000","message":"Shouldn\u0027t we make this check here too? When we create a \"subport\", the \"port\" register (port_id) should have device_id\u003dtrunk_id\n\nAm I correct?","commit_id":"a791079d3dfa4e9728bd473d12ab962ec8a1cf94"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"855af5d52f714f0da2cb6fa8271c70b047e71ad8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return _dict"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def create(self):"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            with self.db_context_writer(self.obj_context):"},{"line_number":57,"context_line":"                super(SubPort, self).create()"},{"line_number":58,"context_line":"        except o_db_exc.DBReferenceError as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_73e8b515","line":55,"in_reply_to":"df33271e_4d027c0b","updated":"2020-04-07 22:21:07.000000000","message":"Good point, I took a whack at this in the next PS.","commit_id":"a791079d3dfa4e9728bd473d12ab962ec8a1cf94"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24056730f6cc1b2ea8fb362b370f083e877d4a3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                raise n_exc.PortNotFound(port_id\u003dself.port_id)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            if self.port_id:"},{"line_number":121,"context_line":"                core_plugin.update_port(context, self.port_id,"},{"line_number":122,"context_line":"                                        {\u0027port\u0027: {\u0027device_id\u0027: self.id}})"},{"line_number":123,"context_line":"            if sub_ports:"},{"line_number":124,"context_line":"                for sub_port in sub_ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_59319ea2","line":121,"updated":"2020-04-03 22:07:55.000000000","message":"pep8: F821 undefined name \u0027context\u0027","commit_id":"a791079d3dfa4e9728bd473d12ab962ec8a1cf94"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24056730f6cc1b2ea8fb362b370f083e877d4a3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                raise n_exc.PortNotFound(port_id\u003dself.port_id)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            if self.port_id:"},{"line_number":121,"context_line":"                core_plugin.update_port(context, self.port_id,"},{"line_number":122,"context_line":"                                        {\u0027port\u0027: {\u0027device_id\u0027: self.id}})"},{"line_number":123,"context_line":"            if sub_ports:"},{"line_number":124,"context_line":"                for sub_port in sub_ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_792c624a","line":121,"updated":"2020-04-03 22:07:55.000000000","message":"pep8: F821 undefined name \u0027core_plugin\u0027","commit_id":"a791079d3dfa4e9728bd473d12ab962ec8a1cf94"}],"neutron/services/trunk/plugin.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c67df04541a989f8e9aa17a865fc7d00da547464","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                resources.TRUNK, events.PRECOMMIT_CREATE, self,"},{"line_number":234,"context_line":"                payload\u003dpayload)"},{"line_number":235,"context_line":"        registry.notify("},{"line_number":236,"context_line":"\t\tresources.TRUNK, events.AFTER_CREATE, self, payload\u003dpayload)"},{"line_number":237,"context_line":"        port \u003d ports.Port.get_object(context, id\u003dtrunk_obj[\u0027port_id\u0027])"},{"line_number":238,"context_line":"        if port:"},{"line_number":239,"context_line":"            port.device_id \u003d trunk_obj.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_6d698ef7","line":236,"updated":"2020-04-28 23:57:23.000000000","message":"pep8: E101 indentation contains mixed spaces and tabs","commit_id":"6604311dae08f6c16936719a9128292a1f1471a9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c67df04541a989f8e9aa17a865fc7d00da547464","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                resources.TRUNK, events.PRECOMMIT_CREATE, self,"},{"line_number":234,"context_line":"                payload\u003dpayload)"},{"line_number":235,"context_line":"        registry.notify("},{"line_number":236,"context_line":"\t\tresources.TRUNK, events.AFTER_CREATE, self, payload\u003dpayload)"},{"line_number":237,"context_line":"        port \u003d ports.Port.get_object(context, id\u003dtrunk_obj[\u0027port_id\u0027])"},{"line_number":238,"context_line":"        if port:"},{"line_number":239,"context_line":"            port.device_id \u003d trunk_obj.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_cd6a62eb","line":236,"updated":"2020-04-28 23:57:23.000000000","message":"pep8: W191 indentation contains tabs","commit_id":"6604311dae08f6c16936719a9128292a1f1471a9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c67df04541a989f8e9aa17a865fc7d00da547464","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                payload\u003dpayload)"},{"line_number":235,"context_line":"        registry.notify("},{"line_number":236,"context_line":"\t\tresources.TRUNK, events.AFTER_CREATE, self, payload\u003dpayload)"},{"line_number":237,"context_line":"        port \u003d ports.Port.get_object(context, id\u003dtrunk_obj[\u0027port_id\u0027])"},{"line_number":238,"context_line":"        if port:"},{"line_number":239,"context_line":"            port.device_id \u003d trunk_obj.id"},{"line_number":240,"context_line":"            port.update()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_ad6f16fa","line":237,"updated":"2020-04-28 23:57:23.000000000","message":"pep8: E101 indentation contains mixed spaces and tabs","commit_id":"6604311dae08f6c16936719a9128292a1f1471a9"}],"neutron/tests/unit/services/trunk/test_plugin.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24056730f6cc1b2ea8fb362b370f083e877d4a3","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        with self.port() as parent_port:"},{"line_number":115,"context_line":"            callback \u003d register_mock_callback(resources.TRUNK, event)"},{"line_number":116,"context_line":"            trunk \u003d self._create_test_trunk(parent_port)"},{"line_number":117,"context_line":"            self.assertEquals(trunk.id, parent_port.device_id)"},{"line_number":118,"context_line":"            trunk_obj \u003d self._get_trunk_obj(trunk[\u0027id\u0027])"},{"line_number":119,"context_line":"            payload \u003d callbacks.TrunkPayload(self.context, trunk[\u0027id\u0027],"},{"line_number":120,"context_line":"                                             current_trunk\u003dtrunk_obj)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_19fef6ad","line":117,"updated":"2020-04-03 22:07:55.000000000","message":"pep8: H234  assertEquals is deprecated, use assertEqual","commit_id":"a791079d3dfa4e9728bd473d12ab962ec8a1cf94"}]}