)]}'
{"neutron/objects/network_segment_range.py":[{"author":{"_account_id":28917,"name":"Joseph Richard","email":"joseph.richard@windriver.com","username":"jrichard"},"change_message_id":"6ce89b40d8413a160fd8bead67a2fc61866d1f69","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                default_range.filter(cls.db_model.physical_network \u003d\u003d"},{"line_number":196,"context_line":"                                     _filters[\u0027physical_network\u0027])"},{"line_number":197,"context_line":"            default_range_res \u003d default_range.first()"},{"line_number":198,"context_line":"            if not default_range_res:"},{"line_number":199,"context_line":"                return []"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"            segment_ids \u003d set(range(default_range_res.minimum,"},{"line_number":202,"context_line":"                                    default_range_res.maximum + 1))"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_4bcec083","line":199,"range":{"start_line":198,"start_character":12,"end_line":199,"end_character":25},"updated":"2020-04-06 14:17:43.000000000","message":"This won\u0027t allocate from any not-default shared ranges.  Shouldn\u0027t get_segments_shared also return the unassigned shared non-default segments?","commit_id":"69cd28640d3bf2bc9bcdd43a981d0de14ff2c0a8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d722c262408647054465ffd2600f39b87bd01b6","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                default_range.filter(cls.db_model.physical_network \u003d\u003d"},{"line_number":196,"context_line":"                                     _filters[\u0027physical_network\u0027])"},{"line_number":197,"context_line":"            default_range_res \u003d default_range.first()"},{"line_number":198,"context_line":"            if not default_range_res:"},{"line_number":199,"context_line":"                return []"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"            segment_ids \u003d set(range(default_range_res.minimum,"},{"line_number":202,"context_line":"                                    default_range_res.maximum + 1))"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7a654be1","line":199,"range":{"start_line":198,"start_character":12,"end_line":199,"end_character":25},"in_reply_to":"df33271e_4bcec083","updated":"2020-04-06 17:59:48.000000000","message":"You are right. Actually in the title of this patch I\u0027m mixing default and shared.\n\nVia CLI we can\u0027t create a default range (this is done via server during the initialization). But we can create as many shared ranges as we want. And those ranges should be taken here.\n\nThanks for your comment!","commit_id":"69cd28640d3bf2bc9bcdd43a981d0de14ff2c0a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d2e5a422c9ce6374bda82e7b95f6c1bac4f0c33b","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            # assigned to other projects."},{"line_number":230,"context_line":"            query \u003d cls._build_query_segments(context, model, network_type,"},{"line_number":231,"context_line":"                                              **_filters)"},{"line_number":232,"context_line":"            clauses \u003d [and_(model_segmentation_id \u003e\u003d _range[0],"},{"line_number":233,"context_line":"                            model_segmentation_id \u003c\u003d _range[1])"},{"line_number":234,"context_line":"                       for _range in segment_ranges]"},{"line_number":235,"context_line":"            query \u003d query.filter(or_(*clauses))"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_72d53db7","line":232,"range":{"start_line":232,"start_character":53,"end_line":232,"end_character":55},"updated":"2020-04-08 13:11:52.000000000","message":"nit: unrelated, but good catch :-)","commit_id":"2e6aa290a38798f0eef04231d8424237daf3b2d4"}]}