)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"40b553b2b7e51bd502707f4d1b002bdc711d91cd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like this was missed on the OVN migration, without"},{"line_number":10,"context_line":"it the OVN Octavia provider driver will fail to work"},{"line_number":11,"context_line":"properly in devstack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idb80cd164c6b41ca6636373696a9a1e7f19b5e62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_b661993c","line":11,"updated":"2020-04-07 14:42:42.000000000","message":"Maybe I should re-phrase this since with another patch of mine updating the example file the OVN Octavia provider driver does work.  Adding this file here shouldn\u0027t hurt anything though.","commit_id":"05b097e23db6298a333be757b60d3e212110c2dd"}],"devstack/lib/octavia":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1de9a5c0215fc6e656163e4c867cac8d06730281","unresolved":false,"context_lines":[{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Restore xtrace"},{"line_number":22,"context_line":"$XTRACE"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"df33271e_9013b466","line":22,"updated":"2020-04-07 18:40:06.000000000","message":"This file should actually be a copy of what\u0027s in the Octavia repo, realing with differing DSN backends, with support for OVN.  Will update.","commit_id":"05b097e23db6298a333be757b60d3e212110c2dd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"34aa2cf4b85828821aacc62749ec0a816140535b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        MGMT_PORT_ID\u003d$2"},{"line_number":11,"context_line":"        MGMT_PORT_MAC\u003d$3"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        if [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" || $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\"]]; then"},{"line_number":14,"context_line":"            if [[ $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\"]]; then"},{"line_number":15,"context_line":"                openstack subnet set --gateway none lb-mgmt-subnet"},{"line_number":16,"context_line":"            fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df33271e_b620704b","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":28},"updated":"2020-04-07 19:34:47.000000000","message":"Should this be Q_AGENT?","commit_id":"a02d0a0a30f1afa35013c1e10f6a4c2ba67d1bcd"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"bd47e7560390704c28402c37e5f0f266e48021d2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        MGMT_PORT_ID\u003d$2"},{"line_number":11,"context_line":"        MGMT_PORT_MAC\u003d$3"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        if [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" || $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\"]]; then"},{"line_number":14,"context_line":"            if [[ $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\"]]; then"},{"line_number":15,"context_line":"                openstack subnet set --gateway none lb-mgmt-subnet"},{"line_number":16,"context_line":"            fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df33271e_1e4cc59c","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":28},"in_reply_to":"df33271e_a135c8dd","updated":"2020-04-08 07:02:38.000000000","message":"Yes, for now we should use both.","commit_id":"a02d0a0a30f1afa35013c1e10f6a4c2ba67d1bcd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bba734ab9020f878678fce0ef5cd04a8f68eefbe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        MGMT_PORT_ID\u003d$2"},{"line_number":11,"context_line":"        MGMT_PORT_MAC\u003d$3"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        if [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" || $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\"]]; then"},{"line_number":14,"context_line":"            if [[ $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\"]]; then"},{"line_number":15,"context_line":"                openstack subnet set --gateway none lb-mgmt-subnet"},{"line_number":16,"context_line":"            fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df33271e_a135c8dd","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":28},"in_reply_to":"df33271e_b620704b","updated":"2020-04-07 20:08:27.000000000","message":"From what I can tell either can be set depending on how you configure local.conf or your job - lib/neutron and lib/neutron-legacy use differing values so for now we should keep them both.","commit_id":"a02d0a0a30f1afa35013c1e10f6a4c2ba67d1bcd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"165b96253c1c0f86edd9907c91a8cd97f1e93d47","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        if [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" || $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":14,"context_line":"            if [[ $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":15,"context_line":"                openstack subnet set --gateway none lb-mgmt-subnet"},{"line_number":16,"context_line":"            fi"},{"line_number":17,"context_line":"            sudo ovs-vsctl -- --may-exist add-port ${OVS_BRIDGE:-br-int} o-hm0 -- set Interface o-hm0 type\u003dinternal -- set Interface o-hm0 external-ids:iface-status\u003dactive -- set Interface o-hm0 external-ids:attached-mac\u003d$MGMT_PORT_MAC -- set Interface o-hm0 external-ids:iface-id\u003d$MGMT_PORT_ID -- set Interface o-hm0 external-ids:skip_cleanup\u003dtrue"},{"line_number":18,"context_line":"        elif [[ $NEUTRON_AGENT \u003d\u003d \"linuxbridge\" || $Q_AGENT \u003d\u003d \"linuxbridge\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"df33271e_e604eac8","line":15,"range":{"start_line":15,"start_character":52,"end_line":15,"end_character":66},"updated":"2020-04-08 15:28:30.000000000","message":"It\u0027s too bad this and lb-mgmt-net aren\u0027t arguments, then this whole function could maybe be generic for creating a network interface","commit_id":"0d235b7df81f2d92e41674ed6cd9f618bde6d658"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"165b96253c1c0f86edd9907c91a8cd97f1e93d47","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            if [[ $NEUTRON_AGENT \u003d\u003d \"ovn\" || $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":15,"context_line":"                openstack subnet set --gateway none lb-mgmt-subnet"},{"line_number":16,"context_line":"            fi"},{"line_number":17,"context_line":"            sudo ovs-vsctl -- --may-exist add-port ${OVS_BRIDGE:-br-int} o-hm0 -- set Interface o-hm0 type\u003dinternal -- set Interface o-hm0 external-ids:iface-status\u003dactive -- set Interface o-hm0 external-ids:attached-mac\u003d$MGMT_PORT_MAC -- set Interface o-hm0 external-ids:iface-id\u003d$MGMT_PORT_ID -- set Interface o-hm0 external-ids:skip_cleanup\u003dtrue"},{"line_number":18,"context_line":"        elif [[ $NEUTRON_AGENT \u003d\u003d \"linuxbridge\" || $Q_AGENT \u003d\u003d \"linuxbridge\" ]]; then"},{"line_number":19,"context_line":"            if ! ip link show o-hm0 ; then"},{"line_number":20,"context_line":"                sudo ip link add o-hm0 type veth peer name o-bhm0"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"df33271e_86ba3e07","line":17,"range":{"start_line":17,"start_character":73,"end_line":17,"end_character":78},"updated":"2020-04-08 15:28:30.000000000","message":"This is actually passed as the INTERFACE argument so should be changed.","commit_id":"0d235b7df81f2d92e41674ed6cd9f618bde6d658"}]}