)]}'
{"neutron/tests/functional/agent/l3/test_keepalived_state_change.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1034727e2c5fd623e2bb53464d6565de774ab27e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._generate_cmd_opts()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.ext_process \u003d external_process.ProcessManager("},{"line_number":58,"context_line":"            None, self.router_id, namespace\u003dself.router.namespace,"},{"line_number":59,"context_line":"            service\u003d\u0027test_ip_mon\u0027, pids_path\u003dself.conf_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_09897522","line":56,"updated":"2020-04-14 10:12:07.000000000","message":"nit: unintended whitespace","commit_id":"07bbf275fb566905c57dd85b97ce413a14427b21"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a79c107c5b35cc11095fe0738372d0f89f625ef5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.router_id \u003d uuidutils.generate_uuid()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._generate_cmd_opts()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.ext_process \u003d external_process.ProcessManager("},{"line_number":58,"context_line":"            None, self.router_id, namespace\u003dself.router.namespace,"},{"line_number":59,"context_line":"            service\u003d\u0027test_ip_mon\u0027, pids_path\u003dself.conf_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_9d513812","line":56,"in_reply_to":"3f4c43b2_09897522","updated":"2020-04-14 13:20:43.000000000","message":"sorry","commit_id":"07bbf275fb566905c57dd85b97ce413a14427b21"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1034727e2c5fd623e2bb53464d6565de774ab27e","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._generate_cmd_opts()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.ext_process \u003d external_process.ProcessManager("},{"line_number":58,"context_line":"            None, self.router_id, namespace\u003dself.router.namespace,"},{"line_number":59,"context_line":"            service\u003d\u0027test_ip_mon\u0027, pids_path\u003dself.conf_dir,"},{"line_number":60,"context_line":"            default_cmd_callback\u003dself._callback, run_as_root\u003dTrue,"},{"line_number":61,"context_line":"            pid_file\u003dself.pid_file)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        server \u003d linux_utils.UnixDomainWSGIServer("},{"line_number":64,"context_line":"            \u0027neutron-keepalived-state-change\u0027, num_threads\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_e9a089a8","line":61,"range":{"start_line":57,"start_character":44,"end_line":61,"end_character":35},"updated":"2020-04-14 10:12:07.000000000","message":"nit: could you please use named parameters everywher if you touch it\u003e:\nProcessManager(\n            conf\u003dNone, uuid\u003dself.router_id, namespace\u003dself.router.namespace,\n            service\u003d\u0027test_ip_mon\u0027, pids_path\u003dself.conf_dir,\n            default_cmd_callback\u003dself._callback, run_as_root\u003dTrue,\n            pid_file\u003dself.pid_file)","commit_id":"07bbf275fb566905c57dd85b97ce413a14427b21"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a79c107c5b35cc11095fe0738372d0f89f625ef5","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self._generate_cmd_opts()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.ext_process \u003d external_process.ProcessManager("},{"line_number":58,"context_line":"            None, self.router_id, namespace\u003dself.router.namespace,"},{"line_number":59,"context_line":"            service\u003d\u0027test_ip_mon\u0027, pids_path\u003dself.conf_dir,"},{"line_number":60,"context_line":"            default_cmd_callback\u003dself._callback, run_as_root\u003dTrue,"},{"line_number":61,"context_line":"            pid_file\u003dself.pid_file)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        server \u003d linux_utils.UnixDomainWSGIServer("},{"line_number":64,"context_line":"            \u0027neutron-keepalived-state-change\u0027, num_threads\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_5dbcd004","line":61,"range":{"start_line":57,"start_character":44,"end_line":61,"end_character":35},"in_reply_to":"3f4c43b2_e9a089a8","updated":"2020-04-14 13:20:43.000000000","message":"Yes because the number of arguments is very long, but I usually don\u0027t nominate positional arguments; in this case \"conf\" or \"uuid\".","commit_id":"07bbf275fb566905c57dd85b97ce413a14427b21"}]}