)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f6f6994f202e3f53f99baf5f23837be5e0904a5e","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            message \u003d self.server_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":545,"context_line":"            self.server_process.writeline(message)"},{"line_number":546,"context_line":"            message \u003d self.client_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":547,"context_line":"        except OSError as e:"},{"line_number":548,"context_line":"            LOG.debug(\"Error: %s occured during connectivity test.\", e)"},{"line_number":549,"context_line":"            message \u003d \"\""},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_479abe13","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":28},"updated":"2020-04-10 13:28:14.000000000","message":"If I understand well the documentation this will work only \u003epython3.3, but that is safe for us as I see","commit_id":"58529fc967fb83a2128b8c8bd679d394a54593fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a5dd49781b894b671450950ee4f93508b97644e3","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            message \u003d self.server_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":545,"context_line":"            self.server_process.writeline(message)"},{"line_number":546,"context_line":"            message \u003d self.client_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":547,"context_line":"        except OSError as e:"},{"line_number":548,"context_line":"            LOG.debug(\"Error: %s occured during connectivity test.\", e)"},{"line_number":549,"context_line":"            message \u003d \"\""},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_95bc7206","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":28},"in_reply_to":"3f4c43b2_1a2d3143","updated":"2020-04-14 11:36:38.000000000","message":"@Rodolfo, I think You are right, lets catch only ConnectionError exceptions here. Will it be better for You?","commit_id":"58529fc967fb83a2128b8c8bd679d394a54593fa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fd2d6c7eb22a5f9f6f52061c0f286c1e884940de","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            message \u003d self.server_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":545,"context_line":"            self.server_process.writeline(message)"},{"line_number":546,"context_line":"            message \u003d self.client_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":547,"context_line":"        except OSError as e:"},{"line_number":548,"context_line":"            LOG.debug(\"Error: %s occured during connectivity test.\", e)"},{"line_number":549,"context_line":"            message \u003d \"\""},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_1a2d3143","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":28},"in_reply_to":"3f4c43b2_665f8641","updated":"2020-04-14 11:18:41.000000000","message":"it was changed from 3.3 (as I remember) how the inheritance chain is implemented, so below 3.3 this will not catch BrokenPipeError","commit_id":"58529fc967fb83a2128b8c8bd679d394a54593fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d1939ca9c51ea964374f7ed41ecaa50eee0fbcd4","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            message \u003d self.server_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":545,"context_line":"            self.server_process.writeline(message)"},{"line_number":546,"context_line":"            message \u003d self.client_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":547,"context_line":"        except OSError as e:"},{"line_number":548,"context_line":"            LOG.debug(\"Error: %s occured during connectivity test.\", e)"},{"line_number":549,"context_line":"            message \u003d \"\""},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_be9e9860","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":28},"in_reply_to":"3f4c43b2_95bc7206","updated":"2020-04-15 11:23:15.000000000","message":"PS2 is fine for me!","commit_id":"58529fc967fb83a2128b8c8bd679d394a54593fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fc497b51c17ad4635c16688b9ebd994ca5894da0","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            message \u003d self.server_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":545,"context_line":"            self.server_process.writeline(message)"},{"line_number":546,"context_line":"            message \u003d self.client_process.read_stdout(READ_TIMEOUT).strip()"},{"line_number":547,"context_line":"        except OSError as e:"},{"line_number":548,"context_line":"            LOG.debug(\"Error: %s occured during connectivity test.\", e)"},{"line_number":549,"context_line":"            message \u003d \"\""},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_665f8641","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":28},"in_reply_to":"df33271e_479abe13","updated":"2020-04-14 09:48:21.000000000","message":"I don\u0027t get it...\n\nThe exception raised (as reported in the bug) is BrokenPipeError (inheriting from ConnectionError, inheriting from OSError). Why don\u0027t we catch only this exception?\n\nin [1] (subprocess.py), OSError is only suppressed when errno \u003d EINVAL (a Windows case).\n\n\n[1]https://github.com/python/cpython/blob/master/Lib/subprocess.py#L1061","commit_id":"58529fc967fb83a2128b8c8bd679d394a54593fa"}]}