)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"67ba6d0de5de4fddca554d1918911fa28c173022","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-04-14 15:57:48 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Start ovs if ovn-northd is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib12a076e50f010464735c6779d0e67bb218b66be"},{"line_number":10,"context_line":"Closes-Bug: #1871730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4c43b2_5612ed59","line":8,"updated":"2020-04-14 14:52:47.000000000","message":"Would be nice to expand the rationally for the change here. I understood it by reading the linked bug but, it would be easier to have a tl;dr in the commit message.","commit_id":"8ad1c6a7bdc80bffe8a0c340cf1827fc2a58d1c5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2effb0d144e3710d4db080639e58e3f67c9111a7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-04-14 15:57:48 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Start ovs if ovn-northd is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib12a076e50f010464735c6779d0e67bb218b66be"},{"line_number":10,"context_line":"Closes-Bug: #1871730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4c43b2_6d210cb5","line":8,"in_reply_to":"3f4c43b2_5612ed59","updated":"2020-04-15 08:51:40.000000000","message":"That is a valid need :-)","commit_id":"8ad1c6a7bdc80bffe8a0c340cf1827fc2a58d1c5"}],"devstack/lib/ovn_agent":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"043b409aa843ba57af598055b4f862a1d63a35ed","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"function _start_ovs {"},{"line_number":602,"context_line":"    echo \"Starting OVS\""},{"line_number":603,"context_line":"    if is_service_enabled ovn-controller || is_service_enabled ovn-controller-vtep || is_service_enabled ovn-northd; then"},{"line_number":604,"context_line":"        # ovsdb-server and ovs-vswitchd are used privately in OVN as openvswitch service names."},{"line_number":605,"context_line":"        enable_service ovsdb-server"},{"line_number":606,"context_line":"        enable_service ovs-vswitchd"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f4c43b2_54e014cd","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":115},"updated":"2020-04-15 12:33:58.000000000","message":"is_service_enabled takes multiple arguments so you can just write:\n\nif is_service_enabled ovn-controller ovn-controller-vtep ovn-northd\n    ...","commit_id":"68acac9651ab292b436491677d5332cfe90740fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ba6b199be1cc7611206b37d6f89d898043c7024e","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"function _start_ovs {"},{"line_number":602,"context_line":"    echo \"Starting OVS\""},{"line_number":603,"context_line":"    if is_service_enabled ovn-controller || is_service_enabled ovn-controller-vtep || is_service_enabled ovn-northd; then"},{"line_number":604,"context_line":"        # ovsdb-server and ovs-vswitchd are used privately in OVN as openvswitch service names."},{"line_number":605,"context_line":"        enable_service ovsdb-server"},{"line_number":606,"context_line":"        enable_service ovs-vswitchd"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f4c43b2_1a723512","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":115},"in_reply_to":"3f4c43b2_54e014cd","updated":"2020-04-15 14:19:58.000000000","message":"Thanks","commit_id":"68acac9651ab292b436491677d5332cfe90740fe"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6d58ad1a41415d1384c31e2d3a9010ddcddbdfcd","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"function _start_ovs {"},{"line_number":602,"context_line":"    echo \"Starting OVS\""},{"line_number":603,"context_line":"    if is_service_enabled ovn-controller ovn-controller-vtep ovn-northd; then"},{"line_number":604,"context_line":"        # ovsdb-server and ovs-vswitchd are used privately in OVN as openvswitch service names."},{"line_number":605,"context_line":"        enable_service ovsdb-server"},{"line_number":606,"context_line":"        enable_service ovs-vswitchd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f4c43b2_ec1df766","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":71},"updated":"2020-04-17 02:38:35.000000000","message":"This means if any of these service is enabled, aka, if it is eual to this:\n\"\"\n is_service_enabled ovn-controller || is_service_enabled ovn-controller-vtep || is_service_enabled ovn-northd\n\"\"\nor not?","commit_id":"d913f43056ccc1ba06afc13a1098ee4d48007507"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c8c5604f8dd955aa034cce6f5dc46e40dedf312f","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"function _start_ovs {"},{"line_number":602,"context_line":"    echo \"Starting OVS\""},{"line_number":603,"context_line":"    if is_service_enabled ovn-controller ovn-controller-vtep ovn-northd; then"},{"line_number":604,"context_line":"        # ovsdb-server and ovs-vswitchd are used privately in OVN as openvswitch service names."},{"line_number":605,"context_line":"        enable_service ovsdb-server"},{"line_number":606,"context_line":"        enable_service ovs-vswitchd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f4c43b2_ff3754af","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":71},"in_reply_to":"3f4c43b2_12edd824","updated":"2020-04-17 09:25:24.000000000","message":"Thank you. +2","commit_id":"d913f43056ccc1ba06afc13a1098ee4d48007507"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"fc44d6aecdb8f45acaa57ea96edb7e9a17622efc","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"function _start_ovs {"},{"line_number":602,"context_line":"    echo \"Starting OVS\""},{"line_number":603,"context_line":"    if is_service_enabled ovn-controller ovn-controller-vtep ovn-northd; then"},{"line_number":604,"context_line":"        # ovsdb-server and ovs-vswitchd are used privately in OVN as openvswitch service names."},{"line_number":605,"context_line":"        enable_service ovsdb-server"},{"line_number":606,"context_line":"        enable_service ovs-vswitchd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f4c43b2_12edd824","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":71},"in_reply_to":"3f4c43b2_ec1df766","updated":"2020-04-17 07:28:53.000000000","message":"This is equal to\n\"\"\nis_service_enabled ovn-controller || is_service_enabled ovn-controller-vtep || is_service_enabled ovn-north\n\"\"","commit_id":"d913f43056ccc1ba06afc13a1098ee4d48007507"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"897134e2a396a2f812b8017c1f5f0ceeb4697859","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"function _start_ovs {"},{"line_number":602,"context_line":"    echo \"Starting OVS\""},{"line_number":603,"context_line":"    if is_service_enabled ovn-controller ovn-controller-vtep ovn-northd; then"},{"line_number":604,"context_line":"        # ovsdb-server and ovs-vswitchd are used privately in OVN as openvswitch service names."},{"line_number":605,"context_line":"        enable_service ovsdb-server"},{"line_number":606,"context_line":"        enable_service ovs-vswitchd"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f4c43b2_e777a99f","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":71},"in_reply_to":"3f4c43b2_ff3754af","updated":"2020-04-20 07:44:48.000000000","message":"Bence was kind enough to point to this, but here is the related comment in devstack:\nhttps://opendev.org/openstack/devstack/src/commit/5b5aefb0898c791a5b58689579562d95f94750d4/functions-common#L1941-L1942","commit_id":"d913f43056ccc1ba06afc13a1098ee4d48007507"}]}