)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"291c6d5739e299de579757f6bede408c8a05a2e0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.ovsdb \u003d impl_idl.api_factory()"},{"line_number":123,"context_line":"        self._hw_offload \u003d None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @property"},{"line_number":126,"context_line":"    def ovsdb_timeout(self):"},{"line_number":127,"context_line":"        return self.ovsdb.ovsdb_connection.timeout"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def add_bridge(self, bridge_name,"},{"line_number":130,"context_line":"                   datapath_type\u003dconstants.OVS_DATAPATH_SYSTEM):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_559b0d71","line":127,"range":{"start_line":125,"start_character":0,"end_line":127,"end_character":50},"updated":"2020-07-27 14:48:26.000000000","message":"Seem no actual use of this property? Am I miss something?","commit_id":"de4c10882fc31f91c58f341d1e25cc769edac5af"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"50d74e8e9d88ae5fb98c1a2b3532726a5fa3e65e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.ovsdb \u003d impl_idl.api_factory()"},{"line_number":123,"context_line":"        self._hw_offload \u003d None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @property"},{"line_number":126,"context_line":"    def ovsdb_timeout(self):"},{"line_number":127,"context_line":"        return self.ovsdb.ovsdb_connection.timeout"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def add_bridge(self, bridge_name,"},{"line_number":130,"context_line":"                   datapath_type\u003dconstants.OVS_DATAPATH_SYSTEM):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_a69401ea","line":127,"range":{"start_line":125,"start_character":0,"end_line":127,"end_character":50},"in_reply_to":"9f560f44_559b0d71","updated":"2020-07-27 17:43:02.000000000","message":"For example here: https://github.com/openstack/neutron/blob/b90cb02799e4a2185c95583c4b3756ce0d6bf15f/neutron/agent/common/ovs_lib.py#L98","commit_id":"de4c10882fc31f91c58f341d1e25cc769edac5af"}],"neutron/agent/ovsdb/native/helpers.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e8576bccfd0ef871bd9bbd05ee125ae451c5c45b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"agent_ovs_conf.register_ovs_agent_opts(cfg.CONF)"},{"line_number":26,"context_line":"ml2_ovs_conf.register_ovs_opts(cfg\u003dcfg.CONF)"},{"line_number":27,"context_line":"#ovs_conf.register_ovs_agent_opts(cfg.CONF)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"enable_connection_uri \u003d functools.partial("},{"line_number":30,"context_line":"    helpers.enable_connection_uri, execute\u003dutils.execute, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_594bf929","line":27,"updated":"2020-04-17 20:16:45.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"b4930b11c0f1cbcf5f8571cd45ac7152dead8f5c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cf4c8b0dae8a8e64729bb3d950713b1bce52358e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"agent_ovs_conf.register_ovs_agent_opts(cfg.CONF)"},{"line_number":26,"context_line":"ml2_ovs_conf.register_ovs_opts(cfg\u003dcfg.CONF)"},{"line_number":27,"context_line":"#ovs_conf.register_ovs_agent_opts(cfg.CONF)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"enable_connection_uri \u003d functools.partial("},{"line_number":30,"context_line":"    helpers.enable_connection_uri, execute\u003dutils.execute, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_a765b347","line":27,"updated":"2020-04-18 12:40:18.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"421e62ab915c9d05bc1f7a845d1b13a8d6770f33"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"f66031ce6b050d7b4a8c4b2c1bd3be8bf3964e18","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    helpers.enable_connection_uri, execute\u003dutils.execute, run_as_root\u003dTrue,"},{"line_number":31,"context_line":"    log_fail_as_error\u003dFalse, check_exit_code\u003dFalse,"},{"line_number":32,"context_line":"    timeout\u003dcfg.CONF.OVS.ovsdb_timeout,"},{"line_number":33,"context_line":"    inactivity_probe\u003dint(cfg.CONF.OVS.of_inactivity_probe) * 1000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_22821f01","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":25},"updated":"2020-04-20 09:16:13.000000000","message":"of_inactivity_probe is an IntOpt. Why do we need to cast it to int here?","commit_id":"421e62ab915c9d05bc1f7a845d1b13a8d6770f33"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4b5804809c2953729273efb88136e31bacc7a8be","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    helpers.enable_connection_uri, execute\u003dutils.execute, run_as_root\u003dTrue,"},{"line_number":31,"context_line":"    log_fail_as_error\u003dFalse, check_exit_code\u003dFalse,"},{"line_number":32,"context_line":"    timeout\u003dcfg.CONF.OVS.ovsdb_timeout,"},{"line_number":33,"context_line":"    inactivity_probe\u003dint(cfg.CONF.OVS.of_inactivity_probe) * 1000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_a2fbcf44","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":25},"in_reply_to":"3f4c43b2_22821f01","updated":"2020-04-20 09:28:20.000000000","message":"Actually no, this was just an extra precaution.","commit_id":"421e62ab915c9d05bc1f7a845d1b13a8d6770f33"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e3c4753b3174db4e9308cb93ecef0503b007fc33","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"agent_ovs_conf.register_ovs_agent_opts(cfg.CONF)"},{"line_number":26,"context_line":"ml2_ovs_conf.register_ovs_opts(cfg\u003dcfg.CONF)"},{"line_number":27,"context_line":"#ovs_conf.register_ovs_agent_opts(cfg.CONF)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"enable_connection_uri \u003d functools.partial("},{"line_number":30,"context_line":"    helpers.enable_connection_uri, execute\u003dutils.execute, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_a2167854","line":27,"updated":"2020-05-06 13:20:23.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"e99abba84c7ac33fa9c0bf7d94fdb4199bc430b7"}],"neutron/tests/functional/agent/test_ovs_lib.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c508e68a7678027467f4ff334cb568f2ff7f5c57","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.common import utils"},{"line_number":27,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent.common import ("},{"line_number":28,"context_line":"    constants as agent_const)"},{"line_number":29,"context_line":"from neutron.tests.common.exclusive_resources import port"},{"line_number":30,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":31,"context_line":"from neutron.tests.functional.agent.linux import base"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_f04dba72","line":29,"updated":"2020-04-17 17:09:24.000000000","message":"pep8: F401 \u0027neutron.tests.common.exclusive_resources.port\u0027 imported but unused","commit_id":"e36805d9beee21ea0a7207db43f16ab6c22b4a3e"}],"neutron/tests/unit/agent/common/test_ovs_lib.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"75ef822167bc3cdf3b2d85cdcb42395939ea13af","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                       if_exists\u003dTrue)])"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def test_get_port_ofport_retry(self):"},{"line_number":514,"context_line":"        self.br.ovsdb.ovsdb_connection.timeout \u003d 10"},{"line_number":515,"context_line":"        with mock.patch.object("},{"line_number":516,"context_line":"                self.br, \u0027db_get_val\u0027,"},{"line_number":517,"context_line":"                side_effect\u003d[[], [], [], [], 1]):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_afd03ff9","line":514,"range":{"start_line":514,"start_character":39,"end_line":514,"end_character":51},"updated":"2020-06-17 06:34:05.000000000","message":"why need 10 here? a comment might be useful","commit_id":"b8cda2536d034987e527d124b349dd8a51a3d95c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c0e8bf557bc92964ec9810fce04f6306d8c5490a","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                       if_exists\u003dTrue)])"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def test_get_port_ofport_retry(self):"},{"line_number":514,"context_line":"        self.br.ovsdb.ovsdb_connection.timeout \u003d 10"},{"line_number":515,"context_line":"        with mock.patch.object("},{"line_number":516,"context_line":"                self.br, \u0027db_get_val\u0027,"},{"line_number":517,"context_line":"                side_effect\u003d[[], [], [], [], 1]):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_0c92f5f6","line":514,"range":{"start_line":514,"start_character":39,"end_line":514,"end_character":51},"in_reply_to":"bf51134e_afd03ff9","updated":"2020-07-06 17:37:04.000000000","message":"Just to avoid a timeout during testing.","commit_id":"b8cda2536d034987e527d124b349dd8a51a3d95c"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/test_ovs_bridge.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"75ef822167bc3cdf3b2d85cdcb42395939ea13af","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mock.patch.object(ovs_lib.OVSBridge, \u0027db_get_val\u0027,"},{"line_number":47,"context_line":"                          side_effect\u003d_mock_db_get_val).start()"},{"line_number":48,"context_line":"        br \u003d self.br_int_cls(\u0027br-int\u0027)"},{"line_number":49,"context_line":"        br.ovsdb.ovsdb_connection.timeout \u003d 1"},{"line_number":50,"context_line":"        # make sure that in case of any misconfiguration when no datapath is"},{"line_number":51,"context_line":"        # found a proper exception, not a TypeError is raised"},{"line_number":52,"context_line":"        self.assertRaises(RuntimeError, br._get_dp)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_efc5173e","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":45},"updated":"2020-06-17 06:34:05.000000000","message":"maybe add a comment like in previous file: \"# reduce timeout for faster execution\"?","commit_id":"b8cda2536d034987e527d124b349dd8a51a3d95c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c0e8bf557bc92964ec9810fce04f6306d8c5490a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mock.patch.object(ovs_lib.OVSBridge, \u0027db_get_val\u0027,"},{"line_number":47,"context_line":"                          side_effect\u003d_mock_db_get_val).start()"},{"line_number":48,"context_line":"        br \u003d self.br_int_cls(\u0027br-int\u0027)"},{"line_number":49,"context_line":"        br.ovsdb.ovsdb_connection.timeout \u003d 1"},{"line_number":50,"context_line":"        # make sure that in case of any misconfiguration when no datapath is"},{"line_number":51,"context_line":"        # found a proper exception, not a TypeError is raised"},{"line_number":52,"context_line":"        self.assertRaises(RuntimeError, br._get_dp)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_cc875db6","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":45},"in_reply_to":"bf51134e_efc5173e","updated":"2020-07-06 17:37:04.000000000","message":"Done","commit_id":"b8cda2536d034987e527d124b349dd8a51a3d95c"}]}