)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1f3c55a74f2ec6e0d59718fcfdf7f0975690cc02","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhouhenglc \u003czhouhenglc@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-20 12:34:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix bug: Floating IP was not removed from the router when the port forwarding"},{"line_number":8,"context_line":"deletion was completed"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The second parameter of fip_id_cidrs requires a cidr, but now is address. this"},{"line_number":11,"context_line":"causes line 368 and line 370 fail to remove vip as expected[1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4c43b2_6cc42060","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":22},"updated":"2020-04-20 07:03:14.000000000","message":"Please describe the fix, not the bug, and fit 80 chars. Like \"Provide correct fip cidr when deleting port forwarding\"","commit_id":"ac9bf6b00f19ed21ac8aa71e96306d9873d640e3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1f3c55a74f2ec6e0d59718fcfdf7f0975690cc02","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The second parameter of fip_id_cidrs requires a cidr, but now is address. this"},{"line_number":11,"context_line":"causes line 368 and line 370 fail to remove vip as expected[1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1873708"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2ae2ade29700a56dc340256389bf8b0efd697ba4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4c43b2_ec867013","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":51},"updated":"2020-04-20 07:03:14.000000000","message":"Closes-Bug: #1873708\n\nCurrently fix is not linked to the bug in launchpad","commit_id":"ac9bf6b00f19ed21ac8aa71e96306d9873d640e3"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"819632810a8682353d9ba2adb30e9be054e63a66","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Provide correct fip cidr when deleting port forwarding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The second parameter of fip_id_cidrs requires a cidr, but now is address. this"},{"line_number":10,"context_line":"causes line 368 and line 370 fail to remove vip as expected[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1873708"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4c43b2_84b05c45","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":28},"updated":"2020-04-20 14:06:09.000000000","message":"This is not clear to the reviwers, please illustrate the detail.","commit_id":"960024da69bd16f5d9c201c720ec21b5c337587d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"819632810a8682353d9ba2adb30e9be054e63a66","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The second parameter of fip_id_cidrs requires a cidr, but now is address. this"},{"line_number":10,"context_line":"causes line 368 and line 370 fail to remove vip as expected[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1873708"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-bug: #1873708"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4c43b2_04860c67","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":51},"updated":"2020-04-20 14:06:09.000000000","message":"This is not necessary.","commit_id":"960024da69bd16f5d9c201c720ec21b5c337587d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"819632810a8682353d9ba2adb30e9be054e63a66","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1873708"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-bug: #1873708"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2ae2ade29700a56dc340256389bf8b0efd697ba4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4c43b2_447c9471","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":7},"updated":"2020-04-20 14:06:09.000000000","message":"Why partial? There is another fix?","commit_id":"960024da69bd16f5d9c201c720ec21b5c337587d"}],"neutron/agent/l3/extensions/port_forwarding.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b18b9283e02fcced811f337b054ae34434c4ae10","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        iptables_manager.apply()"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        fip_id_cidrs \u003d set([(pf.floatingip_id,"},{"line_number":347,"context_line":"                             str(netaddr.IPNetwork(pf.floating_ip_address)))"},{"line_number":348,"context_line":"                            for pf in port_forwardings])"},{"line_number":349,"context_line":"        self._sync_and_remove_fip(context, fip_id_cidrs, device, ri)"},{"line_number":350,"context_line":"        self._store_local(port_forwardings, events.DELETED)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_31be4a65","line":347,"updated":"2020-04-22 14:52:54.000000000","message":"good catch.\n\nPlease, use common.utils.ip_to_cidr, same as in _add_vips()","commit_id":"3a6a8c334a65acd658072c2f681b35dac9ca3fcd"}],"neutron/tests/unit/agent/l3/extensions/test_port_forwarding.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1f3c55a74f2ec6e0d59718fcfdf7f0975690cc02","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            self.portforwarding1.external_port,"},{"line_number":275,"context_line":"            protocol\u003dself.portforwarding1.protocol)"},{"line_number":276,"context_line":"        mock_device.delete_addr_and_conntrack_state.assert_called_once_with("},{"line_number":277,"context_line":"            str(self.portforwarding1.floating_ip_address)) + \u0027/32\u0027"},{"line_number":278,"context_line":"        fip_status \u003d {"},{"line_number":279,"context_line":"            self.portforwarding1.floatingip_id:"},{"line_number":280,"context_line":"                lib_const.FLOATINGIP_STATUS_DOWN}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_cc90d446","line":277,"range":{"start_line":277,"start_character":58,"end_line":277,"end_character":66},"updated":"2020-04-20 07:03:14.000000000","message":"why not using netaddr?","commit_id":"ac9bf6b00f19ed21ac8aa71e96306d9873d640e3"}]}