)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b37b4931231b2e602d2ca974cd2eba3433a59057","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012736.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Conflicts:"},{"line_number":22,"context_line":"      neutron/common/_constants.py"},{"line_number":23,"context_line":"      neutron/objects/plugins/ml2/vlanallocation.py"},{"line_number":24,"context_line":"      neutron/tests/unit/objects/test_network_segment_range.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_40d5d0b8","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":10},"updated":"2020-04-24 13:12:51.000000000","message":"The ones listed in train backport probably still conflict here too?\n    neutron/objects/network_segment_range.py\n    neutron/objects/plugins/ml2/base.py\n    neutron/objects/plugins/ml2/vxlanallocation.py","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd637e9e14e8f5753ac9f18457d945a35616d6b9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012736.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Conflicts:"},{"line_number":22,"context_line":"      neutron/common/_constants.py"},{"line_number":23,"context_line":"      neutron/objects/plugins/ml2/vlanallocation.py"},{"line_number":24,"context_line":"      neutron/tests/unit/objects/test_network_segment_range.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_ebe5dda9","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":10},"in_reply_to":"1f493fa4_40d5d0b8","updated":"2020-04-24 13:41:27.000000000","message":"Yes, sorry. I didn\u0027t log the correct files. Thanks!!","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"cc42918c03fdc1e97a4c0cc3fc47f5f301804a2e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012736.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Conflicts:"},{"line_number":22,"context_line":"      neutron/common/_constants.py"},{"line_number":23,"context_line":"      neutron/objects/plugins/ml2/vlanallocation.py"},{"line_number":24,"context_line":"      neutron/tests/unit/objects/test_network_segment_range.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_285d9046","line":21,"updated":"2020-04-30 10:15:12.000000000","message":"Missing from train conflicts:\n    neutron/objects/network_segment_range.py\n    neutron/objects/plugins/ml2/base.py\n    neutron/objects/plugins/ml2/vxlanallocation.py","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"95ae0675b7eb184033916ffefd8b5cc2832043ef","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012736.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Conflicts:"},{"line_number":22,"context_line":"      neutron/common/_constants.py"},{"line_number":23,"context_line":"      neutron/objects/plugins/ml2/vlanallocation.py"},{"line_number":24,"context_line":"      neutron/tests/unit/objects/test_network_segment_range.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_e3010b6c","line":21,"in_reply_to":"1f493fa4_285d9046","updated":"2020-04-30 10:53:06.000000000","message":"Sorry!","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"cc42918c03fdc1e97a4c0cc3fc47f5f301804a2e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012736.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Conflicts:"},{"line_number":22,"context_line":"      neutron/common/_constants.py"},{"line_number":23,"context_line":"      neutron/objects/plugins/ml2/vlanallocation.py"},{"line_number":24,"context_line":"      neutron/tests/unit/objects/test_network_segment_range.py"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_287470ce","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":34},"updated":"2020-04-30 10:15:12.000000000","message":"This one does not conflict anymore I think (once extra lines mentioned below are dropped)","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"95ae0675b7eb184033916ffefd8b5cc2832043ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[1]http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012736.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Conflicts:"},{"line_number":22,"context_line":"      neutron/common/_constants.py"},{"line_number":23,"context_line":"      neutron/objects/plugins/ml2/vlanallocation.py"},{"line_number":24,"context_line":"      neutron/tests/unit/objects/test_network_segment_range.py"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_03ffd766","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":34},"in_reply_to":"1f493fa4_287470ce","updated":"2020-04-30 10:53:06.000000000","message":"Done","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"}],"neutron/common/_constants.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b37b4931231b2e602d2ca974cd2eba3433a59057","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# NOTE(boden): This module is common constants for neutron only."},{"line_number":19,"context_line":"# Any constants used outside of neutron should go into neutron-lib."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Security group protocols that support ports"},{"line_number":23,"context_line":"SG_PORT_PROTO_NUMS \u003d ["},{"line_number":24,"context_line":"    constants.PROTO_NUM_DCCP,"},{"line_number":25,"context_line":"    constants.PROTO_NUM_SCTP,"},{"line_number":26,"context_line":"    constants.PROTO_NUM_TCP,"},{"line_number":27,"context_line":"    constants.PROTO_NUM_UDP,"},{"line_number":28,"context_line":"    constants.PROTO_NUM_UDPLITE"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SG_PORT_PROTO_NAMES \u003d ["},{"line_number":32,"context_line":"    constants.PROTO_NAME_DCCP,"},{"line_number":33,"context_line":"    constants.PROTO_NAME_SCTP,"},{"line_number":34,"context_line":"    constants.PROTO_NAME_TCP,"},{"line_number":35,"context_line":"    constants.PROTO_NAME_UDP,"},{"line_number":36,"context_line":"    constants.PROTO_NAME_UDPLITE"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# iptables protocols that only support --dport and --sport using -m multiport"},{"line_number":40,"context_line":"IPTABLES_MULTIPORT_ONLY_PROTOCOLS \u003d ["},{"line_number":41,"context_line":"    constants.PROTO_NAME_UDPLITE"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Legacy IPv6 ICMP protocol list"},{"line_number":45,"context_line":"IPV6_ICMP_LEGACY_PROTO_LIST \u003d [constants.PROTO_NAME_ICMP,"},{"line_number":46,"context_line":"                               constants.PROTO_NAME_IPV6_ICMP_LEGACY]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Number of resources for neutron agent side functions to deal"},{"line_number":49,"context_line":"# with large sets."},{"line_number":50,"context_line":"# Setting this value does not count on special conditions, it is just a human"},{"line_number":51,"context_line":"# countable or scalable number. [1] gives us the method to test the scale"},{"line_number":52,"context_line":"# issue. And we have tested the value of 1000, 500, 200, 100. But for 100,"},{"line_number":53,"context_line":"# ovs-agent will have a lower timeout probability. And according to the"},{"line_number":54,"context_line":"# testing result, step size 100 can indeed cost about 10% much more time"},{"line_number":55,"context_line":"# than 500/1000. But such extra time looks inevitably needed to be sacrificed"},{"line_number":56,"context_line":"# for the restart success rate."},{"line_number":57,"context_line":"# [1] http://paste.openstack.org/show/745685/"},{"line_number":58,"context_line":"AGENT_RES_PROCESSING_STEP \u003d 100"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Number of resources for neutron to divide the large RPC"},{"line_number":61,"context_line":"# call data sets."},{"line_number":62,"context_line":"RPC_RES_PROCESSING_STEP \u003d 20"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# IPtables version to support --random-fully option."},{"line_number":65,"context_line":"# Do not move this constant to neutron-lib, since it is temporary"},{"line_number":66,"context_line":"IPTABLES_RANDOM_FULLY_VERSION \u003d \u00271.6.2\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Segmentation ID pool; DB select limit to improve the performace."},{"line_number":69,"context_line":"IDPOOL_SELECT_SIZE \u003d 100"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_600f2c89","line":66,"range":{"start_line":1,"start_character":0,"end_line":66,"end_character":39},"updated":"2020-04-24 13:12:51.000000000","message":"In stein, most of it is still neutron/common/constants.py if neede we should rather backport I2d65f8fcfa08984ccf60c4d023f9a9d72b89d79c that creates this file","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd637e9e14e8f5753ac9f18457d945a35616d6b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# NOTE(boden): This module is common constants for neutron only."},{"line_number":19,"context_line":"# Any constants used outside of neutron should go into neutron-lib."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Security group protocols that support ports"},{"line_number":23,"context_line":"SG_PORT_PROTO_NUMS \u003d ["},{"line_number":24,"context_line":"    constants.PROTO_NUM_DCCP,"},{"line_number":25,"context_line":"    constants.PROTO_NUM_SCTP,"},{"line_number":26,"context_line":"    constants.PROTO_NUM_TCP,"},{"line_number":27,"context_line":"    constants.PROTO_NUM_UDP,"},{"line_number":28,"context_line":"    constants.PROTO_NUM_UDPLITE"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SG_PORT_PROTO_NAMES \u003d ["},{"line_number":32,"context_line":"    constants.PROTO_NAME_DCCP,"},{"line_number":33,"context_line":"    constants.PROTO_NAME_SCTP,"},{"line_number":34,"context_line":"    constants.PROTO_NAME_TCP,"},{"line_number":35,"context_line":"    constants.PROTO_NAME_UDP,"},{"line_number":36,"context_line":"    constants.PROTO_NAME_UDPLITE"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# iptables protocols that only support --dport and --sport using -m multiport"},{"line_number":40,"context_line":"IPTABLES_MULTIPORT_ONLY_PROTOCOLS \u003d ["},{"line_number":41,"context_line":"    constants.PROTO_NAME_UDPLITE"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Legacy IPv6 ICMP protocol list"},{"line_number":45,"context_line":"IPV6_ICMP_LEGACY_PROTO_LIST \u003d [constants.PROTO_NAME_ICMP,"},{"line_number":46,"context_line":"                               constants.PROTO_NAME_IPV6_ICMP_LEGACY]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Number of resources for neutron agent side functions to deal"},{"line_number":49,"context_line":"# with large sets."},{"line_number":50,"context_line":"# Setting this value does not count on special conditions, it is just a human"},{"line_number":51,"context_line":"# countable or scalable number. [1] gives us the method to test the scale"},{"line_number":52,"context_line":"# issue. And we have tested the value of 1000, 500, 200, 100. But for 100,"},{"line_number":53,"context_line":"# ovs-agent will have a lower timeout probability. And according to the"},{"line_number":54,"context_line":"# testing result, step size 100 can indeed cost about 10% much more time"},{"line_number":55,"context_line":"# than 500/1000. But such extra time looks inevitably needed to be sacrificed"},{"line_number":56,"context_line":"# for the restart success rate."},{"line_number":57,"context_line":"# [1] http://paste.openstack.org/show/745685/"},{"line_number":58,"context_line":"AGENT_RES_PROCESSING_STEP \u003d 100"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Number of resources for neutron to divide the large RPC"},{"line_number":61,"context_line":"# call data sets."},{"line_number":62,"context_line":"RPC_RES_PROCESSING_STEP \u003d 20"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# IPtables version to support --random-fully option."},{"line_number":65,"context_line":"# Do not move this constant to neutron-lib, since it is temporary"},{"line_number":66,"context_line":"IPTABLES_RANDOM_FULLY_VERSION \u003d \u00271.6.2\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Segmentation ID pool; DB select limit to improve the performace."},{"line_number":69,"context_line":"IDPOOL_SELECT_SIZE \u003d 100"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_4ba33150","line":66,"range":{"start_line":1,"start_character":0,"end_line":66,"end_character":39},"in_reply_to":"1f493fa4_600f2c89","updated":"2020-04-24 13:41:27.000000000","message":"Done: https://review.opendev.org/#/c/722787/","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b37b4931231b2e602d2ca974cd2eba3433a59057","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# Do not move this constant to neutron-lib, since it is temporary"},{"line_number":66,"context_line":"IPTABLES_RANDOM_FULLY_VERSION \u003d \u00271.6.2\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Segmentation ID pool; DB select limit to improve the performace."},{"line_number":69,"context_line":"IDPOOL_SELECT_SIZE \u003d 100"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_80235805","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":24},"updated":"2020-04-24 13:12:51.000000000","message":"Or use neutron/common/constants.py for this added one","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd637e9e14e8f5753ac9f18457d945a35616d6b9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# Do not move this constant to neutron-lib, since it is temporary"},{"line_number":66,"context_line":"IPTABLES_RANDOM_FULLY_VERSION \u003d \u00271.6.2\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Segmentation ID pool; DB select limit to improve the performace."},{"line_number":69,"context_line":"IDPOOL_SELECT_SIZE \u003d 100"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_6ba0ad44","line":69,"range":{"start_line":68,"start_character":0,"end_line":69,"end_character":24},"in_reply_to":"1f493fa4_80235805","updated":"2020-04-24 13:41:27.000000000","message":"Done","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"cc42918c03fdc1e97a4c0cc3fc47f5f301804a2e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"IPTABLES_MULTIPORT_ONLY_PROTOCOLS \u003d ["},{"line_number":41,"context_line":"    constants.PROTO_NAME_UDPLITE"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Legacy IPv6 ICMP protocol list"},{"line_number":45,"context_line":"IPV6_ICMP_LEGACY_PROTO_LIST \u003d [constants.PROTO_NAME_ICMP,"},{"line_number":46,"context_line":"                               constants.PROTO_NAME_IPV6_ICMP_LEGACY]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Number of resources for neutron agent side functions to deal"},{"line_number":49,"context_line":"# with large sets."},{"line_number":50,"context_line":"# Setting this value does not count on special conditions, it is just a human"},{"line_number":51,"context_line":"# countable or scalable number. [1] gives us the method to test the scale"},{"line_number":52,"context_line":"# issue. And we have tested the value of 1000, 500, 200, 100. But for 100,"},{"line_number":53,"context_line":"# ovs-agent will have a lower timeout probability. And according to the"},{"line_number":54,"context_line":"# testing result, step size 100 can indeed cost about 10% much more time"},{"line_number":55,"context_line":"# than 500/1000. But such extra time looks inevitably needed to be sacrificed"},{"line_number":56,"context_line":"# for the restart success rate."},{"line_number":57,"context_line":"# [1] http://paste.openstack.org/show/745685/"},{"line_number":58,"context_line":"AGENT_RES_PROCESSING_STEP \u003d 100"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Number of resources for neutron to divide the large RPC"},{"line_number":61,"context_line":"# call data sets."},{"line_number":62,"context_line":"RPC_RES_PROCESSING_STEP \u003d 20"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# IPtables version to support --random-fully option."},{"line_number":65,"context_line":"# Do not move this constant to neutron-lib, since it is temporary"},{"line_number":66,"context_line":"IPTABLES_RANDOM_FULLY_VERSION \u003d \u00271.6.2\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Segmentation ID pool; DB select limit to improve the performace."},{"line_number":69,"context_line":"IDPOOL_SELECT_SIZE \u003d 100"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_a89a4010","line":66,"range":{"start_line":43,"start_character":0,"end_line":66,"end_character":39},"updated":"2020-04-30 10:15:12.000000000","message":"Not in original patch, and not needed if I grepped correctly","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"95ae0675b7eb184033916ffefd8b5cc2832043ef","unresolved":false,"context_lines":[{"line_number":40,"context_line":"IPTABLES_MULTIPORT_ONLY_PROTOCOLS \u003d ["},{"line_number":41,"context_line":"    constants.PROTO_NAME_UDPLITE"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Legacy IPv6 ICMP protocol list"},{"line_number":45,"context_line":"IPV6_ICMP_LEGACY_PROTO_LIST \u003d [constants.PROTO_NAME_ICMP,"},{"line_number":46,"context_line":"                               constants.PROTO_NAME_IPV6_ICMP_LEGACY]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Number of resources for neutron agent side functions to deal"},{"line_number":49,"context_line":"# with large sets."},{"line_number":50,"context_line":"# Setting this value does not count on special conditions, it is just a human"},{"line_number":51,"context_line":"# countable or scalable number. [1] gives us the method to test the scale"},{"line_number":52,"context_line":"# issue. And we have tested the value of 1000, 500, 200, 100. But for 100,"},{"line_number":53,"context_line":"# ovs-agent will have a lower timeout probability. And according to the"},{"line_number":54,"context_line":"# testing result, step size 100 can indeed cost about 10% much more time"},{"line_number":55,"context_line":"# than 500/1000. But such extra time looks inevitably needed to be sacrificed"},{"line_number":56,"context_line":"# for the restart success rate."},{"line_number":57,"context_line":"# [1] http://paste.openstack.org/show/745685/"},{"line_number":58,"context_line":"AGENT_RES_PROCESSING_STEP \u003d 100"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Number of resources for neutron to divide the large RPC"},{"line_number":61,"context_line":"# call data sets."},{"line_number":62,"context_line":"RPC_RES_PROCESSING_STEP \u003d 20"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# IPtables version to support --random-fully option."},{"line_number":65,"context_line":"# Do not move this constant to neutron-lib, since it is temporary"},{"line_number":66,"context_line":"IPTABLES_RANDOM_FULLY_VERSION \u003d \u00271.6.2\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Segmentation ID pool; DB select limit to improve the performace."},{"line_number":69,"context_line":"IDPOOL_SELECT_SIZE \u003d 100"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_43fc3f6f","line":66,"range":{"start_line":43,"start_character":0,"end_line":66,"end_character":39},"in_reply_to":"1f493fa4_a89a4010","updated":"2020-04-30 10:53:06.000000000","message":"Sorry, I made something wrong in the cherry-pick","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"}],"neutron/objects/plugins/ml2/vlanallocation.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b37b4931231b2e602d2ca974cd2eba3433a59057","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027, \u0027vlan_id\u0027]"},{"line_number":38,"context_line":"    network_type \u003d n_const.TYPE_VLAN"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def get_physical_networks(context):"},{"line_number":42,"context_line":"        query \u003d context.session.query(VlanAllocation.db_model.physical_network)"},{"line_number":43,"context_line":"        query \u003d query.group_by(VlanAllocation.db_model.physical_network)"},{"line_number":44,"context_line":"        physnets \u003d query.all()"},{"line_number":45,"context_line":"        return {physnet.physical_network for physnet in physnets}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @staticmethod"},{"line_number":48,"context_line":"    def delete_physical_networks(context, physical_networks):"},{"line_number":49,"context_line":"        column \u003d VlanAllocation.db_model.physical_network"},{"line_number":50,"context_line":"        context.session.query(VlanAllocation.db_model).filter("},{"line_number":51,"context_line":"            column.in_(physical_networks)).delete(synchronize_session\u003dFalse)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @staticmethod"},{"line_number":54,"context_line":"    def bulk_create(ctx, physical_network, vlan_ids):"},{"line_number":55,"context_line":"        ctx.session.bulk_insert_mappings("},{"line_number":56,"context_line":"            vlan_alloc_model.VlanAllocation,"},{"line_number":57,"context_line":"            [{\u0027physical_network\u0027: physical_network,"},{"line_number":58,"context_line":"              \u0027allocated\u0027: False,"},{"line_number":59,"context_line":"              \u0027vlan_id\u0027: vlan_id} for vlan_id in vlan_ids])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @classmethod"},{"line_number":62,"context_line":"    def update_primary_keys(cls, _dict, segmentation_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_e0505c60","line":59,"range":{"start_line":40,"start_character":0,"end_line":59,"end_character":59},"updated":"2020-04-24 13:12:51.000000000","message":"That part is being backported in https://review.opendev.org/#/c/721639/","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dd637e9e14e8f5753ac9f18457d945a35616d6b9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027, \u0027vlan_id\u0027]"},{"line_number":38,"context_line":"    network_type \u003d n_const.TYPE_VLAN"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def get_physical_networks(context):"},{"line_number":42,"context_line":"        query \u003d context.session.query(VlanAllocation.db_model.physical_network)"},{"line_number":43,"context_line":"        query \u003d query.group_by(VlanAllocation.db_model.physical_network)"},{"line_number":44,"context_line":"        physnets \u003d query.all()"},{"line_number":45,"context_line":"        return {physnet.physical_network for physnet in physnets}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @staticmethod"},{"line_number":48,"context_line":"    def delete_physical_networks(context, physical_networks):"},{"line_number":49,"context_line":"        column \u003d VlanAllocation.db_model.physical_network"},{"line_number":50,"context_line":"        context.session.query(VlanAllocation.db_model).filter("},{"line_number":51,"context_line":"            column.in_(physical_networks)).delete(synchronize_session\u003dFalse)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @staticmethod"},{"line_number":54,"context_line":"    def bulk_create(ctx, physical_network, vlan_ids):"},{"line_number":55,"context_line":"        ctx.session.bulk_insert_mappings("},{"line_number":56,"context_line":"            vlan_alloc_model.VlanAllocation,"},{"line_number":57,"context_line":"            [{\u0027physical_network\u0027: physical_network,"},{"line_number":58,"context_line":"              \u0027allocated\u0027: False,"},{"line_number":59,"context_line":"              \u0027vlan_id\u0027: vlan_id} for vlan_id in vlan_ids])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @classmethod"},{"line_number":62,"context_line":"    def update_primary_keys(cls, _dict, segmentation_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_6bd26dd4","line":59,"range":{"start_line":40,"start_character":0,"end_line":59,"end_character":59},"in_reply_to":"1f493fa4_e0505c60","updated":"2020-04-24 13:41:27.000000000","message":"Ainssss sorry\nI\u0027ll wait till this patch is merged. Then I\u0027ll push this one.\n\nThanks!!","commit_id":"686883b17eb39d3705214d00ddbd6806056c67d8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"cc42918c03fdc1e97a4c0cc3fc47f5f301804a2e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027, \u0027vlan_id\u0027]"},{"line_number":38,"context_line":"    network_type \u003d n_const.TYPE_VLAN"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def get_physical_networks(context):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_488bbcc1","line":38,"updated":"2020-04-30 10:15:12.000000000","message":"Nit: master and train backport have a newline here","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"95ae0675b7eb184033916ffefd8b5cc2832043ef","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027, \u0027vlan_id\u0027]"},{"line_number":38,"context_line":"    network_type \u003d n_const.TYPE_VLAN"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def get_physical_networks(context):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_63edfbb5","line":38,"in_reply_to":"1f493fa4_488bbcc1","updated":"2020-04-30 10:53:06.000000000","message":"Done","commit_id":"8b42384fda8dd482887ebdf7aacd5ef11fc9319b"}],"neutron/tests/unit/objects/test_network_segment_range.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2b27e008cd7fe92c7c0a4a4a7af6354e6c4d1b90","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_create_not_shared_without_project_id(self):"},{"line_number":165,"context_line":"        obj \u003d self._define_network_segment_range(remove_project_id\u003dTrue)"},{"line_number":166,"context_line":"        self.assertRaises(n_exc.ObjectActionError, obj.create)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_update_not_shared_with_project_id(self):"},{"line_number":169,"context_line":"        obj \u003d self._define_network_segment_range(shared\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ea836003","line":166,"updated":"2020-04-21 18:56:04.000000000","message":"pep8: F821 undefined name \u0027n_exc\u0027","commit_id":"9c39ad7f3b95fd6ea19176f0553d2b4a83a2d28c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2b27e008cd7fe92c7c0a4a4a7af6354e6c4d1b90","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                                 remove_project_id\u003dTrue)"},{"line_number":177,"context_line":"        obj.create()"},{"line_number":178,"context_line":"        obj.shared \u003d False"},{"line_number":179,"context_line":"        self.assertRaises(n_exc.ObjectActionError, obj.update)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _create_environment(self):"},{"line_number":182,"context_line":"        self.projects \u003d [uuidutils.generate_uuid() for _ in range(3)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ca882421","line":179,"updated":"2020-04-21 18:56:04.000000000","message":"pep8: F821 undefined name \u0027n_exc\u0027","commit_id":"9c39ad7f3b95fd6ea19176f0553d2b4a83a2d28c"}]}
