)]}'
{"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b3522889ed3e3daefae0f2e52ebc470b2be32df8","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                        return subnet"},{"line_number":397,"context_line":"            subnet \u003d get_matching_subnet()"},{"line_number":398,"context_line":"            if not subnet:"},{"line_number":399,"context_line":"                # Call this function to make response status code not changed"},{"line_number":400,"context_line":"                # when subnet not found"},{"line_number":401,"context_line":"                self._get_subnet_object(context, fixed[\u0027subnet_id\u0027])"},{"line_number":402,"context_line":"                msg \u003d (_(\"Failed to create port on network %(network_id)s\""},{"line_number":403,"context_line":"                         \", because fixed_ips included invalid subnet \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e365aa1f","line":400,"range":{"start_line":399,"start_character":16,"end_line":400,"end_character":39},"updated":"2020-04-29 08:17:26.000000000","message":"nit/grammar nazi: I think it should be a cleaner snetence if you change something like this:\n\"Call this method to keep original status code in case subnet is not found.\"","commit_id":"64a56a18189a9e49fce7645c3965d6b9d35ceb88"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"2f929e8522c16ab65eda6ef83f8711cd31147c97","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                        return subnet"},{"line_number":397,"context_line":"            subnet \u003d get_matching_subnet()"},{"line_number":398,"context_line":"            if not subnet:"},{"line_number":399,"context_line":"                # Call this function to make response status code not changed"},{"line_number":400,"context_line":"                # when subnet not found"},{"line_number":401,"context_line":"                self._get_subnet_object(context, fixed[\u0027subnet_id\u0027])"},{"line_number":402,"context_line":"                msg \u003d (_(\"Failed to create port on network %(network_id)s\""},{"line_number":403,"context_line":"                         \", because fixed_ips included invalid subnet \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_4922bdba","line":400,"range":{"start_line":399,"start_character":16,"end_line":400,"end_character":39},"in_reply_to":"1f493fa4_e365aa1f","updated":"2020-04-29 10:03:44.000000000","message":"Done","commit_id":"64a56a18189a9e49fce7645c3965d6b9d35ceb88"},{"author":{"_account_id":18480,"name":"zhengy","email":"zhengy23@163.com","username":"zhengyong"},"change_message_id":"addce5438a80c9c5cb53488b8119fa744ceeab22","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            if not subnet:"},{"line_number":399,"context_line":"                # Call this method to keep original status code"},{"line_number":400,"context_line":"                # in case subnet is not found"},{"line_number":401,"context_line":"                self._get_subnet_object(context, fixed[\u0027subnet_id\u0027])"},{"line_number":402,"context_line":"                msg \u003d (_(\"Failed to create port on network %(network_id)s\""},{"line_number":403,"context_line":"                         \", because fixed_ips included invalid subnet \""},{"line_number":404,"context_line":"                         \"%(subnet_id)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_8493915c","line":401,"range":{"start_line":401,"start_character":16,"end_line":401,"end_character":68},"updated":"2020-05-06 03:25:24.000000000","message":"[1] https://review.opendev.org/#/c/683273/, here I do not call self._get_subnet_object(context, fixed[\u0027subnet_id\u0027]), so when subnet is not found, status_code will be changed to 400, not 404 same as before, which impact heat.","commit_id":"e07b6d81080be49e49ca143ed16316eeede7d5e5"}]}