)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a6e5692d447ca3bd5d425a55c771171686c75936","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove OVN floating IP deletion of associated LSP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a floating IP is created or updated, and a router is defined,"},{"line_number":10,"context_line":"a NAT rule is created in OVN NB. There is not logical switch port"},{"line_number":11,"context_line":"associated to a floating IP, that means there is no need to"},{"line_number":12,"context_line":"remove any LSP associated."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icaf04f0b9184c153fa6b3fe218c889fd5684b3f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f493fa4_b9f22f05","line":11,"range":{"start_line":10,"start_character":33,"end_line":11,"end_character":28},"updated":"2020-05-06 09:59:10.000000000","message":"In case of DVR setup we link the NAT entry with Logical_Switch_Port.","commit_id":"6e770ff4f8d516db0019bc1cb0f43f62dc744752"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d17eb18cf110bf56b211f70d6d3e9264a34340a6","unresolved":false,"context_lines":[{"line_number":742,"context_line":"        # require changes in ovn-northd."},{"line_number":743,"context_line":"        commands.append(self._nb_idl.delete_lswitch_port("},{"line_number":744,"context_line":"                        fip_db[\u0027floating_port_id\u0027],"},{"line_number":745,"context_line":"                        utils.ovn_name(floatingip[\u0027floating_network_id\u0027])))"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        ext_ids \u003d {"},{"line_number":748,"context_line":"            ovn_const.OVN_FIP_EXT_ID_KEY: floatingip[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_bcd6b426","side":"PARENT","line":745,"updated":"2020-05-05 10:26:16.000000000","message":"Cool, just adding to this. The reason why it didn\u0027t fail is because the if_exists parameter for this command defaults to True. So it won\u0027t raise any exception in case that port is not present in the OVN database.\n\nhttps://github.com/openstack/neutron/blob/2a6ab2e9c033faf9daa5de9bb9ec21b6f0a6dcfb/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/api.py#L61","commit_id":"34448578cba471a0a4f1b49308eeb5c54009a725"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a6e5692d447ca3bd5d425a55c771171686c75936","unresolved":false,"context_lines":[{"line_number":742,"context_line":"        # require changes in ovn-northd."},{"line_number":743,"context_line":"        commands.append(self._nb_idl.delete_lswitch_port("},{"line_number":744,"context_line":"                        fip_db[\u0027floating_port_id\u0027],"},{"line_number":745,"context_line":"                        utils.ovn_name(floatingip[\u0027floating_network_id\u0027])))"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        ext_ids \u003d {"},{"line_number":748,"context_line":"            ovn_const.OVN_FIP_EXT_ID_KEY: floatingip[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_b9406f09","side":"PARENT","line":745,"in_reply_to":"1f493fa4_7c9a6c6e","updated":"2020-05-06 09:59:10.000000000","message":"I also don\u0027t understand reasoning of this.","commit_id":"34448578cba471a0a4f1b49308eeb5c54009a725"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1e4edc1e072d6b1ab2dc9c63d6f9df0487996662","unresolved":false,"context_lines":[{"line_number":742,"context_line":"        # require changes in ovn-northd."},{"line_number":743,"context_line":"        commands.append(self._nb_idl.delete_lswitch_port("},{"line_number":744,"context_line":"                        fip_db[\u0027floating_port_id\u0027],"},{"line_number":745,"context_line":"                        utils.ovn_name(floatingip[\u0027floating_network_id\u0027])))"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        ext_ids \u003d {"},{"line_number":748,"context_line":"            ovn_const.OVN_FIP_EXT_ID_KEY: floatingip[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7c9a6c6e","side":"PARENT","line":745,"in_reply_to":"1f493fa4_bcd6b426","updated":"2020-05-05 10:37:45.000000000","message":"Yeah, what I fear is that this command is actually needed. But I don\u0027t see any reason at all because a FIP does not create a LSP in OVN, but a NAT rule.","commit_id":"34448578cba471a0a4f1b49308eeb5c54009a725"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a6e5692d447ca3bd5d425a55c771171686c75936","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":758,"context_line":"            port \u003d self._plugin.get_port("},{"line_number":759,"context_line":"                admin_context, fip_db[\u0027floating_port_id\u0027])"},{"line_number":760,"context_line":"            columns[\u0027logical_port\u0027] \u003d floatingip[\u0027port_id\u0027]"},{"line_number":761,"context_line":"            ext_ids[ovn_const.OVN_FIP_EXT_MAC_KEY] \u003d port[\u0027mac_address\u0027]"},{"line_number":762,"context_line":"            if self._nb_idl.lsp_get_up(floatingip[\u0027port_id\u0027]).execute():"},{"line_number":763,"context_line":"                columns[\u0027external_mac\u0027] \u003d port[\u0027mac_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_99ce53b2","side":"PARENT","line":760,"range":{"start_line":760,"start_character":12,"end_line":760,"end_character":59},"updated":"2020-05-06 09:59:10.000000000","message":"In case of DVR we link the port_id to the NAT entry.","commit_id":"34448578cba471a0a4f1b49308eeb5c54009a725"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0183a36120359ea90052216723ebbbb2eea4f315","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":758,"context_line":"            port \u003d self._plugin.get_port("},{"line_number":759,"context_line":"                admin_context, fip_db[\u0027floating_port_id\u0027])"},{"line_number":760,"context_line":"            columns[\u0027logical_port\u0027] \u003d floatingip[\u0027port_id\u0027]"},{"line_number":761,"context_line":"            ext_ids[ovn_const.OVN_FIP_EXT_MAC_KEY] \u003d port[\u0027mac_address\u0027]"},{"line_number":762,"context_line":"            if self._nb_idl.lsp_get_up(floatingip[\u0027port_id\u0027]).execute():"},{"line_number":763,"context_line":"                columns[\u0027external_mac\u0027] \u003d port[\u0027mac_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_4abe8d65","side":"PARENT","line":760,"range":{"start_line":760,"start_character":12,"end_line":760,"end_character":59},"in_reply_to":"1f493fa4_99ce53b2","updated":"2020-05-13 17:02:26.000000000","message":"floatingip[\u0027port_id\u0027] is the fixed_port_id, that means, the VM port.\n\nWhat is wrong here? Sorry, I don\u0027t understand your comment","commit_id":"34448578cba471a0a4f1b49308eeb5c54009a725"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"001ecdcb8738e04260999d76d904793bd5bff01f","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":758,"context_line":"            port \u003d self._plugin.get_port("},{"line_number":759,"context_line":"                admin_context, fip_db[\u0027floating_port_id\u0027])"},{"line_number":760,"context_line":"            columns[\u0027logical_port\u0027] \u003d floatingip[\u0027port_id\u0027]"},{"line_number":761,"context_line":"            ext_ids[ovn_const.OVN_FIP_EXT_MAC_KEY] \u003d port[\u0027mac_address\u0027]"},{"line_number":762,"context_line":"            if self._nb_idl.lsp_get_up(floatingip[\u0027port_id\u0027]).execute():"},{"line_number":763,"context_line":"                columns[\u0027external_mac\u0027] \u003d port[\u0027mac_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_fb3764af","side":"PARENT","line":760,"range":{"start_line":760,"start_character":12,"end_line":760,"end_character":59},"in_reply_to":"ff570b3c_4abe8d65","updated":"2020-05-14 12:56:01.000000000","message":"I mean all is fine. I\u0027m referring to the commit message :)","commit_id":"34448578cba471a0a4f1b49308eeb5c54009a725"}]}