)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dfc4140d83afc680fd31a2f2b0e16f127228df5","unresolved":false,"context_lines":[{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        return hostname, fqdn"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def _merge_hosts_per_port_id(self, dhcp_enabled_subnet_ids,"},{"line_number":693,"context_line":"                                 merge_addr6_list\u003dFalse):"},{"line_number":694,"context_line":"        hosts_entries \u003d {}"},{"line_number":695,"context_line":"        # NOTE(ihrachyshka): the loop should not log anything inside it, to"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_3620174a","line":692,"range":{"start_line":692,"start_character":8,"end_line":692,"end_character":32},"updated":"2020-05-04 15:35:11.000000000","message":"afict, this makes _merge_alloc_addr6_list() function above redundant?","commit_id":"351ef2c6fb1e4e64488bd510b64b29f1d0392801"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2dfc4140d83afc680fd31a2f2b0e16f127228df5","unresolved":false,"context_lines":[{"line_number":866,"context_line":"            if not ips:"},{"line_number":867,"context_line":"                continue"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"            ip_address \u003d \",\".join(ips)"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"            if self._get_port_extra_dhcp_opts(port):"},{"line_number":872,"context_line":"                client_id \u003d self._get_client_id(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_56fe83ae","line":869,"range":{"start_line":869,"start_character":25,"end_line":869,"end_character":38},"updated":"2020-05-04 15:35:11.000000000","message":"note, For IPv4 we end up with something like this if there are multiple ip addresses:\n\n  dhcp-host\u003d52:54:00:bc:c3:fd,set:TAG_PREFIX,host-172-20-0-11,172.20.0.11,172.20.0.12\n\ndnsmasq will configure the host with \u0027172.20.0.12\u0027 in this case, and unless I\u0027m mistaken hostname will be host-172-20-0-11. Prior to this change dnsmasq would respond with: 172.20.0.12 and host-172-20-0-12 since the entry closes to EOF would be:\n\n    dhcp-host\u003d52:54:00:bc:c3:fd,set:TAG_PREFIX,host-172-20-0-12,172.20.0.12\n\nquestion is, do we care about the hostname generated from the IP?","commit_id":"351ef2c6fb1e4e64488bd510b64b29f1d0392801"}]}