)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"600a225a8bd2648e221d46ece97e3e3443512aa5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use dhcp-host tag support when supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In dnsmasq 2.81 there is a regression (see [1] for details)"},{"line_number":10,"context_line":"which causes problem that when dnsmasq will find first entry"},{"line_number":11,"context_line":"for MAC address it will stop processing the file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The same issue is also backported to the dnsmasq-2.79-11.el8.x86_64"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_36546eca","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":48},"updated":"2020-05-06 09:11:24.000000000","message":"nit: will find -\u003e finds","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"600a225a8bd2648e221d46ece97e3e3443512aa5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use dhcp-host tag support when supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In dnsmasq 2.81 there is a regression (see [1] for details)"},{"line_number":10,"context_line":"which causes problem that when dnsmasq will find first entry"},{"line_number":11,"context_line":"for MAC address it will stop processing the file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The same issue is also backported to the dnsmasq-2.79-11.el8.x86_64"},{"line_number":14,"context_line":"which is e.g. in RHEL 8.2 and probably will be in Centos 8."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_f6db267a","line":11,"range":{"start_line":10,"start_character":26,"end_line":11,"end_character":48},"updated":"2020-05-06 09:11:24.000000000","message":"This is confusing - logically second entry should be the issue (second in dnsmasq processing order no matter if it\u0027s top-bottom or bottom-top). Also mail thread does not mention stop processing the file - just that IPv4 dhcp stops working.","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c41bf15816c2e64d98a978e54b777ef2424e2ca5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use dhcp-host tag support when supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In dnsmasq 2.81 there is a regression (see [1] for details)"},{"line_number":10,"context_line":"which causes problem that when dnsmasq will find first entry"},{"line_number":11,"context_line":"for MAC address it will stop processing the file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The same issue is also backported to the dnsmasq-2.79-11.el8.x86_64"},{"line_number":14,"context_line":"which is e.g. in RHEL 8.2 and probably will be in Centos 8."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_8ecb99a3","line":11,"range":{"start_line":10,"start_character":26,"end_line":11,"end_character":48},"in_reply_to":"1f493fa4_8197f1eb","updated":"2020-05-06 23:37:38.000000000","message":"I updated the link to a later post in the dnsmasq mailing list. And this text to a short summary of what I believe is the root cause.","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ff569c026f69761296367b2a5f20b1a2294b88ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use dhcp-host tag support when supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In dnsmasq 2.81 there is a regression (see [1] for details)"},{"line_number":10,"context_line":"which causes problem that when dnsmasq will find first entry"},{"line_number":11,"context_line":"for MAC address it will stop processing the file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The same issue is also backported to the dnsmasq-2.79-11.el8.x86_64"},{"line_number":14,"context_line":"which is e.g. in RHEL 8.2 and probably will be in Centos 8."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_8197f1eb","line":11,"range":{"start_line":10,"start_character":26,"end_line":11,"end_character":48},"in_reply_to":"1f493fa4_f6db267a","updated":"2020-05-06 20:33:00.000000000","message":"I didn\u0027t see anything about stopping processing in the thread either, and it wasn\u0027t clear if that\u0027s what the patches were addressing.","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ff569c026f69761296367b2a5f20b1a2294b88ca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"which is e.g. in RHEL 8.2 and probably will be in Centos 8."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"dnsmasq version 2.81 also adds support for using tag\u0027s on host"},{"line_number":17,"context_line":"entries. When a dhcpv6 request is recived, dnsmasq automatically"},{"line_number":18,"context_line":"sets the tag \u0027dhcpv6\u0027."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change add\u0027s a runtime check, testing for dnsmasq host entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_81089191","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":41},"updated":"2020-05-06 20:33:00.000000000","message":"s/received","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c41bf15816c2e64d98a978e54b777ef2424e2ca5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"which is e.g. in RHEL 8.2 and probably will be in Centos 8."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"dnsmasq version 2.81 also adds support for using tag\u0027s on host"},{"line_number":17,"context_line":"entries. When a dhcpv6 request is recived, dnsmasq automatically"},{"line_number":18,"context_line":"sets the tag \u0027dhcpv6\u0027."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change add\u0027s a runtime check, testing for dnsmasq host entry"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_6ece0db5","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":41},"in_reply_to":"1f493fa4_81089191","updated":"2020-05-06 23:37:38.000000000","message":"Done","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ff569c026f69761296367b2a5f20b1a2294b88ca","unresolved":false,"context_lines":[{"line_number":17,"context_line":"entries. When a dhcpv6 request is recived, dnsmasq automatically"},{"line_number":18,"context_line":"sets the tag \u0027dhcpv6\u0027."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change add\u0027s a runtime check, testing for dnsmasq host entry"},{"line_number":21,"context_line":"tag support. And adds \u0027tag:dhcpv6\u0027 to all IPv6 host entries when"},{"line_number":22,"context_line":"dnsmasq supports this."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_a1c66d15","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":17},"updated":"2020-05-06 20:33:00.000000000","message":"nit: adds","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c41bf15816c2e64d98a978e54b777ef2424e2ca5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"entries. When a dhcpv6 request is recived, dnsmasq automatically"},{"line_number":18,"context_line":"sets the tag \u0027dhcpv6\u0027."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change add\u0027s a runtime check, testing for dnsmasq host entry"},{"line_number":21,"context_line":"tag support. And adds \u0027tag:dhcpv6\u0027 to all IPv6 host entries when"},{"line_number":22,"context_line":"dnsmasq supports this."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_cec48195","line":20,"range":{"start_line":20,"start_character":12,"end_line":20,"end_character":17},"in_reply_to":"1f493fa4_a1c66d15","updated":"2020-05-06 23:37:38.000000000","message":"Done","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6a135202aa065b5f360aebd19d3cd6f4bd7d53d2","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            for alloc in fixed_ips:"},{"line_number":731,"context_line":"                no_dhcp \u003d False"},{"line_number":732,"context_line":"                no_opts \u003d False"},{"line_number":733,"context_line":"                tag \u003d \u0027\u0027"},{"line_number":734,"context_line":"                if alloc.subnet_id in v6_nets:"},{"line_number":735,"context_line":"                    addr_mode \u003d v6_nets[alloc.subnet_id].ipv6_address_mode"},{"line_number":736,"context_line":"                    no_dhcp \u003d addr_mode in (constants.IPV6_SLAAC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e558b3fb","line":733,"updated":"2020-05-04 19:02:32.000000000","message":"I don\u0027t think it is required, but we could set \u0027tag:!dhcpv6\u0027 for IPv4 entries.","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ff569c026f69761296367b2a5f20b1a2294b88ca","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                    no_dhcp \u003d addr_mode in (constants.IPV6_SLAAC,"},{"line_number":737,"context_line":"                                            constants.DHCPV6_STATELESS)"},{"line_number":738,"context_line":"                    if self._is_dnsmasq_host_tag_supported():"},{"line_number":739,"context_line":"                        tag \u003d \u0027tag:dhcpv6,\u0027"},{"line_number":740,"context_line":"                    # we don\u0027t setup anything for SLAAC. It doesn\u0027t make sense"},{"line_number":741,"context_line":"                    # to provide options for a client that won\u0027t use DHCP"},{"line_number":742,"context_line":"                    no_opts \u003d addr_mode \u003d\u003d constants.IPV6_SLAAC"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_a1782df8","line":739,"range":{"start_line":739,"start_character":30,"end_line":739,"end_character":43},"updated":"2020-05-06 20:33:00.000000000","message":"nit: maybe defining this at the top of file would be better, then using it in the tests.","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af274a37c8f6774fbcb4314a4dc793f3c488b377","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                    no_dhcp \u003d addr_mode in (constants.IPV6_SLAAC,"},{"line_number":737,"context_line":"                                            constants.DHCPV6_STATELESS)"},{"line_number":738,"context_line":"                    if self._is_dnsmasq_host_tag_supported():"},{"line_number":739,"context_line":"                        tag \u003d \u0027tag:dhcpv6,\u0027"},{"line_number":740,"context_line":"                    # we don\u0027t setup anything for SLAAC. It doesn\u0027t make sense"},{"line_number":741,"context_line":"                    # to provide options for a client that won\u0027t use DHCP"},{"line_number":742,"context_line":"                    no_opts \u003d addr_mode \u003d\u003d constants.IPV6_SLAAC"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_76dc3618","line":739,"updated":"2020-05-06 09:23:50.000000000","message":"nit: we don\u0027t really need this tag in case of SLAAC or DHCPV6_STATELESS subnets, right? I think it is only needed in case of DHCP_STATEFUL subnets.\nBut that isn\u0027t big issue as it will not be added to host file in case of stateless of slaac subnets because it will be dropped in the _output_hosts_file() method","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"51b12fe74f30ae544072d7738ddb7efada27771b","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                    no_dhcp \u003d addr_mode in (constants.IPV6_SLAAC,"},{"line_number":737,"context_line":"                                            constants.DHCPV6_STATELESS)"},{"line_number":738,"context_line":"                    if self._is_dnsmasq_host_tag_supported():"},{"line_number":739,"context_line":"                        tag \u003d \u0027tag:dhcpv6,\u0027"},{"line_number":740,"context_line":"                    # we don\u0027t setup anything for SLAAC. It doesn\u0027t make sense"},{"line_number":741,"context_line":"                    # to provide options for a client that won\u0027t use DHCP"},{"line_number":742,"context_line":"                    no_opts \u003d addr_mode \u003d\u003d constants.IPV6_SLAAC"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_3c072d1f","line":739,"in_reply_to":"1f493fa4_76dc3618","updated":"2020-05-06 11:36:15.000000000","message":"We still add an entry for DHCPV6_STATELESS if the port have extra_dhcp_opts.\n\nThe host entry would only include \u003cmac\u003e,set:TAG_PREFIX for stateless. The opts file the uses tag:TAG_PREFIX:\u003cOPTS\u003e so that the correct options for this port is used. Using \u003cmac\u003e,tag:dhcpv6,set:TAG_PREFIX on the stateless entries should\u0027nt hurt.","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c41bf15816c2e64d98a978e54b777ef2424e2ca5","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                    no_dhcp \u003d addr_mode in (constants.IPV6_SLAAC,"},{"line_number":737,"context_line":"                                            constants.DHCPV6_STATELESS)"},{"line_number":738,"context_line":"                    if self._is_dnsmasq_host_tag_supported():"},{"line_number":739,"context_line":"                        tag \u003d \u0027tag:dhcpv6,\u0027"},{"line_number":740,"context_line":"                    # we don\u0027t setup anything for SLAAC. It doesn\u0027t make sense"},{"line_number":741,"context_line":"                    # to provide options for a client that won\u0027t use DHCP"},{"line_number":742,"context_line":"                    no_opts \u003d addr_mode \u003d\u003d constants.IPV6_SLAAC"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_eeb97d15","line":739,"range":{"start_line":739,"start_character":30,"end_line":739,"end_character":43},"in_reply_to":"1f493fa4_a1782df8","updated":"2020-05-06 23:37:38.000000000","message":"I added a constant, assume that is what you meant?","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"162b6a3b329f0b2369d736f061c8336b6ba2ea08","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                    no_dhcp \u003d addr_mode in (constants.IPV6_SLAAC,"},{"line_number":737,"context_line":"                                            constants.DHCPV6_STATELESS)"},{"line_number":738,"context_line":"                    if self._is_dnsmasq_host_tag_supported():"},{"line_number":739,"context_line":"                        tag \u003d \u0027tag:dhcpv6,\u0027"},{"line_number":740,"context_line":"                    # we don\u0027t setup anything for SLAAC. It doesn\u0027t make sense"},{"line_number":741,"context_line":"                    # to provide options for a client that won\u0027t use DHCP"},{"line_number":742,"context_line":"                    no_opts \u003d addr_mode \u003d\u003d constants.IPV6_SLAAC"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_d9ea89d6","line":739,"range":{"start_line":739,"start_character":30,"end_line":739,"end_character":43},"in_reply_to":"1f493fa4_eeb97d15","updated":"2020-05-07 01:44:24.000000000","message":"Yes, thanks","commit_id":"b0a99d0ae3d90de16f6eaa6a85d1c87eb71b32bb"}],"neutron/cmd/runtime_checks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"190581f5b6be0760c479dd8e21ccbc9bfbb9a543","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                  \"dnsmasq: No such file or directory\")"},{"line_number":49,"context_line":"        return False"},{"line_number":50,"context_line":"    elif returncode \u003d\u003d 1:"},{"line_number":51,"context_line":"        return False"},{"line_number":52,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_25757bcd","line":51,"updated":"2020-05-04 19:39:32.000000000","message":"Since the dnsmasq man page says:\n\n  --test Read and syntax check configuration file(s). Exit with code 0 if\n         all  is  OK,  or a non-zero code otherwise. Do not start up dns‐\n         masq.\n\nIs it enough to just check the return code is !\u003d 0?  I think by default agent_utils.execute() will raise if that is the case.  For example:\n\n\nfrom neutron_lib import exceptions\n\ntry:\n    agent_utils.execute(cmd, addl_env\u003denv, log_fail_as_error\u003dFalse)\nexcept exceptions.ProcessExecutionError:\n    return False\nreturn True\n\n\nOr even just catch all exceptions, print a message, and return False.","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5675729e1c3c84b0b9ae2c7c839d2f09b99a8f5f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                  \"dnsmasq: No such file or directory\")"},{"line_number":49,"context_line":"        return False"},{"line_number":50,"context_line":"    elif returncode \u003d\u003d 1:"},{"line_number":51,"context_line":"        return False"},{"line_number":52,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_a0ba19de","line":51,"in_reply_to":"1f493fa4_25757bcd","updated":"2020-05-04 20:37:23.000000000","message":"Thanks, this is much simpler and seems to work just fine.","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9eefe059e0cac5273da2b21b518f9932d85c4fb0","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def dnsmasq_host_tag_support():"},{"line_number":42,"context_line":"    cmd \u003d [\u0027dnsmasq\u0027, \u0027--test\u0027, \u0027--dhcp-host\u003dtag:foo\u0027]"},{"line_number":43,"context_line":"    env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"},{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        agent_utils.execute(cmd, addl_env\u003denv, log_fail_as_error\u003dFalse)"},{"line_number":46,"context_line":"    except exceptions.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_0dcb34a5","line":43,"updated":"2020-05-05 13:21:14.000000000","message":"maybe adding here:\n\n    \u0027PATH\u0027: \u0027/sbin:/usr/sbin\u0027\n\nwould solve the issue. In fact, according to https://github.com/openstack/neutron/blob/master/etc/neutron/rootwrap.d/dhcp.filters#L16 it should be enough to look only in those locations for dnsmasq binary.","commit_id":"e5da30cf19b286f28b25166f7bf25f9c32b79ff5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"71309d95cf341a9829d50005bf7d1104a7963bcc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    cmd \u003d [\u0027dnsmasq\u0027, \u0027--test\u0027, \u0027--dhcp-host\u003dtag:foo\u0027]"},{"line_number":43,"context_line":"    env \u003d {\u0027LC_ALL\u0027: \u0027C\u0027}"},{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        agent_utils.execute(cmd, addl_env\u003denv, log_fail_as_error\u003dFalse)"},{"line_number":46,"context_line":"    except exceptions.ProcessExecutionError:"},{"line_number":47,"context_line":"        return False"},{"line_number":48,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_4d11bc53","line":45,"updated":"2020-05-05 13:09:39.000000000","message":"this check will not work in tripleo based deployments as \"dnsmasq\" in the neutron_dhcp container is just simple wrapper script and will always return \"0\". So even when I used version which don\u0027t support dhcp-host it was trying to use this tag and it was failing to start later.\nIn such case I had to call directly /usr/sbin/dnsmasq to get proper results.\nBut TBH I\u0027m not sure what would be the best way to fix that issue.","commit_id":"e5da30cf19b286f28b25166f7bf25f9c32b79ff5"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"190581f5b6be0760c479dd8e21ccbc9bfbb9a543","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"        self.conf.set_override(\u0027dnsmasq_config_file\u0027, \u0027/foo\u0027)"},{"line_number":1397,"context_line":"        self._test_spawn([\u0027--conf-file\u003d/foo\u0027, \u0027--domain\u003dopenstacklocal\u0027])"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"    @mock.patch.object(checks, \u0027dnsmasq_host_tag_support\u0027, autospec\u003dTrue)"},{"line_number":1400,"context_line":"    def test_spawn_no_dns_domain(self, mock_tag_support):"},{"line_number":1401,"context_line":"        mock_tag_support.return_value \u003d False"},{"line_number":1402,"context_line":"        (exp_host_name, exp_host_data,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_20ad69ea","line":1399,"updated":"2020-05-04 19:39:32.000000000","message":"Wonder if you could just add a mock for this to the setUp() function above and set the return_value","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5675729e1c3c84b0b9ae2c7c839d2f09b99a8f5f","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"        self.conf.set_override(\u0027dnsmasq_config_file\u0027, \u0027/foo\u0027)"},{"line_number":1397,"context_line":"        self._test_spawn([\u0027--conf-file\u003d/foo\u0027, \u0027--domain\u003dopenstacklocal\u0027])"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"    @mock.patch.object(checks, \u0027dnsmasq_host_tag_support\u0027, autospec\u003dTrue)"},{"line_number":1400,"context_line":"    def test_spawn_no_dns_domain(self, mock_tag_support):"},{"line_number":1401,"context_line":"        mock_tag_support.return_value \u003d False"},{"line_number":1402,"context_line":"        (exp_host_name, exp_host_data,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_c0ae4597","line":1399,"in_reply_to":"1f493fa4_20ad69ea","updated":"2020-05-04 20:37:23.000000000","message":"I tried, but I was\u0027nt able to change the return_value when I did that.","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"190581f5b6be0760c479dd8e21ccbc9bfbb9a543","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"        exp_host_name \u003d \u0027/dhcp/cccccccc-cccc-cccc-cccc-cccccccccccc/host\u0027"},{"line_number":2080,"context_line":"        exp_host_data \u003d ("},{"line_number":2081,"context_line":"            \u002700:00:80:aa:bb:cc,host-192-168-0-2,192.168.0.2\\n\u0027"},{"line_number":2082,"context_line":"            \u002700:00:f3:aa:bb:cc,tag:dhcpv6,host-fdca-3ba5-a17a-4ba3--2,\u0027"},{"line_number":2083,"context_line":"            \u0027[fdca:3ba5:a17a:4ba3::2]\\n\u0027"},{"line_number":2084,"context_line":"            \u002700:00:0f:aa:bb:cc,host-192-168-0-3,192.168.0.3\\n\u0027"},{"line_number":2085,"context_line":"            \u002700:00:0f:aa:bb:cc,tag:dhcpv6,host-fdca-3ba5-a17a-4ba3--3,\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e0a381ff","line":2082,"range":{"start_line":2082,"start_character":31,"end_line":2082,"end_character":42},"updated":"2020-05-04 19:39:32.000000000","message":"nit: could probably reduce code duplication by having this take a tag argument, tag\u003d\u0027tag:dhcpv6,\u0027 or tag\u003d\u0027\u0027","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5675729e1c3c84b0b9ae2c7c839d2f09b99a8f5f","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"        exp_host_name \u003d \u0027/dhcp/cccccccc-cccc-cccc-cccc-cccccccccccc/host\u0027"},{"line_number":2080,"context_line":"        exp_host_data \u003d ("},{"line_number":2081,"context_line":"            \u002700:00:80:aa:bb:cc,host-192-168-0-2,192.168.0.2\\n\u0027"},{"line_number":2082,"context_line":"            \u002700:00:f3:aa:bb:cc,tag:dhcpv6,host-fdca-3ba5-a17a-4ba3--2,\u0027"},{"line_number":2083,"context_line":"            \u0027[fdca:3ba5:a17a:4ba3::2]\\n\u0027"},{"line_number":2084,"context_line":"            \u002700:00:0f:aa:bb:cc,host-192-168-0-3,192.168.0.3\\n\u0027"},{"line_number":2085,"context_line":"            \u002700:00:0f:aa:bb:cc,tag:dhcpv6,host-fdca-3ba5-a17a-4ba3--3,\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_60581156","line":2082,"range":{"start_line":2082,"start_character":31,"end_line":2082,"end_character":42},"in_reply_to":"1f493fa4_e0a381ff","updated":"2020-05-04 20:37:23.000000000","message":"Done","commit_id":"8f3aedaab7346b3ab1e065fe9a88a64d183e3135"}]}