)]}'
{"neutron/plugins/bigswitch/agent/restproxy_agent.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"33c2042f67964cb52612014fa987978b9155fd53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F8cc%3D","line":2,"updated":"2014-02-23 20:49:51.000000000","message":"I believe you would need an entry for this in:\n  https://github.com/openstack/neutron/blob/master/setup.cfg\n\nAlso, once you do that, you probably don\u0027t need L1","commit_id":"f148b624576c2d64ed0394da8d113e79fe394e16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5a4b4b37bafbc46f17012fb43de37aafee443bc7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F75c%3D","line":2,"in_reply_to":"AAAAU3%2F%2F8cc%3D","updated":"2014-02-24 00:10:38.000000000","message":"I added to setup.cfg, but I\u0027m leaving L1 in case we want to execute the agent directly without calling python first. \n\ni.e. \n\n~$ ./neutron/plugins/bigswitch/agent/restproxy_agent.py\n\ninstead of \n\n~$ python neutron/plugins/bigswitch/agent/restproxy_agent.py","commit_id":"f148b624576c2d64ed0394da8d113e79fe394e16"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"33c2042f67964cb52612014fa987978b9155fd53","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Copyright 2011 Nicira Networks, Inc."},{"line_number":7,"context_line":"# All Rights Reserved."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":10,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F8cY%3D","line":7,"updated":"2014-02-23 20:49:51.000000000","message":"Is this needed?","commit_id":"f148b624576c2d64ed0394da8d113e79fe394e16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5a4b4b37bafbc46f17012fb43de37aafee443bc7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Copyright 2011 Nicira Networks, Inc."},{"line_number":7,"context_line":"# All Rights Reserved."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":10,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F75s%3D","line":7,"in_reply_to":"AAAAU3%2F%2F8cY%3D","updated":"2014-02-24 00:10:38.000000000","message":"I\u0027m not sure. Some of the methods like port_update were copied directly from the original agent, so I left it in there.","commit_id":"f148b624576c2d64ed0394da8d113e79fe394e16"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3f1f11aded8d532f8a7a28951c0f9662bf93cd0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F6no%3D","line":1,"updated":"2014-02-24 04:20:48.000000000","message":"This should be removed.","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"272f0903a821b6a9634326afb61978d7a436c281","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F5%2BE%3D","line":1,"in_reply_to":"AAAAU3%2F%2F6no%3D","updated":"2014-02-24 06:41:27.000000000","message":"Done","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"}],"neutron/plugins/bigswitch/plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3f1f11aded8d532f8a7a28951c0f9662bf93cd0a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        return q_rpc.PluginRpcDispatcher([self,"},{"line_number":119,"context_line":"                                          agents_db.AgentExtRpcCallback()])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"},{"line_number":122,"context_line":"    def get_port_from_device(cls, device):"},{"line_number":123,"context_line":"        port_id \u003d re.sub(r\"^tap\", \"\", device)"},{"line_number":124,"context_line":"        port \u003d cls.get_port_and_sgs(port_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F6m8%3D","line":121,"updated":"2014-02-24 04:20:48.000000000","message":"Why are these class methods?","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"272f0903a821b6a9634326afb61978d7a436c281","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        return q_rpc.PluginRpcDispatcher([self,"},{"line_number":119,"context_line":"                                          agents_db.AgentExtRpcCallback()])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"},{"line_number":122,"context_line":"    def get_port_from_device(cls, device):"},{"line_number":123,"context_line":"        port_id \u003d re.sub(r\"^tap\", \"\", device)"},{"line_number":124,"context_line":"        port \u003d cls.get_port_and_sgs(port_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F504%3D","line":121,"in_reply_to":"AAAAU3%2F%2F6m8%3D","updated":"2014-02-24 06:41:27.000000000","message":"Whoops. That was just leftover from when I was trying different approaches to implementing the agent.","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"}],"neutron/tests/unit/bigswitch/test_agent.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"33c2042f67964cb52612014fa987978b9155fd53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Big Switch Networks, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F8UI%3D","line":1,"updated":"2014-02-23 20:49:51.000000000","message":"nit: suggest renaming this module to test_restproxy_agent","commit_id":"f148b624576c2d64ed0394da8d113e79fe394e16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5a4b4b37bafbc46f17012fb43de37aafee443bc7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Big Switch Networks, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F77U%3D","line":1,"in_reply_to":"AAAAU3%2F%2F8UI%3D","updated":"2014-02-24 00:10:38.000000000","message":"Done","commit_id":"f148b624576c2d64ed0394da8d113e79fe394e16"}],"neutron/tests/unit/bigswitch/test_restproxy_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3f1f11aded8d532f8a7a28951c0f9662bf93cd0a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        agent \u003d self.mock_agent()"},{"line_number":61,"context_line":"        agent.port_update(mock.Mock(), **kwargs)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_port_update(self, **kwargs):"},{"line_number":64,"context_line":"        port \u003d {\u0027id\u0027: 1, \u0027security_groups\u0027: \u0027default\u0027}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        with mock.patch.object(self.ovsbridge.return_value,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F6ls%3D","line":63,"updated":"2014-02-24 04:20:48.000000000","message":"kwargs is not used and should be dropped.","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"272f0903a821b6a9634326afb61978d7a436c281","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        agent \u003d self.mock_agent()"},{"line_number":61,"context_line":"        agent.port_update(mock.Mock(), **kwargs)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_port_update(self, **kwargs):"},{"line_number":64,"context_line":"        port \u003d {\u0027id\u0027: 1, \u0027security_groups\u0027: \u0027default\u0027}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        with mock.patch.object(self.ovsbridge.return_value,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F5zM%3D","line":63,"in_reply_to":"AAAAU3%2F%2F6ls%3D","updated":"2014-02-24 06:41:27.000000000","message":"Done","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3f1f11aded8d532f8a7a28951c0f9662bf93cd0a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            mock.call().refresh_firewall()"},{"line_number":74,"context_line":"        ])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_port_update_not_vifport(self, **kwargs):"},{"line_number":77,"context_line":"        port \u003d {\u0027id\u0027: 1, \u0027security_groups\u0027: \u0027default\u0027}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        with mock.patch.object(self.ovsbridge.return_value,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F6lc%3D","line":76,"updated":"2014-02-24 04:20:48.000000000","message":"kwargs is not used and should be dropped","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"272f0903a821b6a9634326afb61978d7a436c281","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            mock.call().refresh_firewall()"},{"line_number":74,"context_line":"        ])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_port_update_not_vifport(self, **kwargs):"},{"line_number":77,"context_line":"        port \u003d {\u0027id\u0027: 1, \u0027security_groups\u0027: \u0027default\u0027}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        with mock.patch.object(self.ovsbridge.return_value,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F5zU%3D","line":76,"in_reply_to":"AAAAU3%2F%2F6lc%3D","updated":"2014-02-24 06:41:27.000000000","message":"Done","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3f1f11aded8d532f8a7a28951c0f9662bf93cd0a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        get_vif.assert_called_once_with(1)"},{"line_number":85,"context_line":"        self.assertFalse(self.sg_agent.return_value.refresh_firewall.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_port_update_without_secgroup(self, **kwargs):"},{"line_number":88,"context_line":"        port \u003d {\u0027id\u0027: 1}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        with mock.patch.object(self.ovsbridge.return_value,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F6lU%3D","line":87,"updated":"2014-02-24 04:20:48.000000000","message":"kwargs is not used and should be dropped","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"272f0903a821b6a9634326afb61978d7a436c281","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        get_vif.assert_called_once_with(1)"},{"line_number":85,"context_line":"        self.assertFalse(self.sg_agent.return_value.refresh_firewall.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_port_update_without_secgroup(self, **kwargs):"},{"line_number":88,"context_line":"        port \u003d {\u0027id\u0027: 1}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        with mock.patch.object(self.ovsbridge.return_value,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F5zY%3D","line":87,"in_reply_to":"AAAAU3%2F%2F6lU%3D","updated":"2014-02-24 06:41:27.000000000","message":"Done","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"}],"neutron/tests/unit/bigswitch/test_security_groups.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3f1f11aded8d532f8a7a28951c0f9662bf93cd0a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron import manager"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.tests.unit.bigswitch import test_base"},{"line_number":19,"context_line":"from neutron.tests.unit import test_extension_security_group as test_sg"},{"line_number":20,"context_line":"from neutron.tests.unit import test_security_groups_rpc as test_sg_rpc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F6lA%3D","line":17,"updated":"2014-02-24 04:20:48.000000000","message":"this newline should be removed","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"272f0903a821b6a9634326afb61978d7a436c281","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron import manager"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.tests.unit.bigswitch import test_base"},{"line_number":19,"context_line":"from neutron.tests.unit import test_extension_security_group as test_sg"},{"line_number":20,"context_line":"from neutron.tests.unit import test_security_groups_rpc as test_sg_rpc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2F5ys%3D","line":17,"in_reply_to":"AAAAU3%2F%2F6lA%3D","updated":"2014-02-24 06:41:27.000000000","message":"Done","commit_id":"5600376e33fcb3278d9288252b2090d686e1fdcb"}]}
