)]}'
{".gitignore":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5483f29338833d044124afde06fad8977d1bc26","unresolved":false,"context_lines":[{"line_number":19,"context_line":"run_tests.log"},{"line_number":20,"context_line":"setuptools*.egg/"},{"line_number":21,"context_line":"subunit.log"},{"line_number":22,"context_line":"tempest.log"},{"line_number":23,"context_line":"*.mo"},{"line_number":24,"context_line":"*.sw?"},{"line_number":25,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":29,"id":"3a961159_1fe16cfc","line":22,"updated":"2014-12-31 05:26:45.000000000","message":"I wonder if we should just do *.log, but maybe out of scope.","commit_id":"0d6185781d1a656e9e2c97ea920dd6eb5317baf9"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e6ceb4ec376a154038e65c33f71ea547ae99cb04","unresolved":false,"context_lines":[{"line_number":19,"context_line":"run_tests.log"},{"line_number":20,"context_line":"setuptools*.egg/"},{"line_number":21,"context_line":"subunit.log"},{"line_number":22,"context_line":"tempest.log"},{"line_number":23,"context_line":"*.mo"},{"line_number":24,"context_line":"*.sw?"},{"line_number":25,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":29,"id":"3a961159_853fc6b4","line":22,"in_reply_to":"3a961159_1fe16cfc","updated":"2014-12-31 20:00:14.000000000","message":"If I have to rev again, I\u0027m happy to make that change.","commit_id":"0d6185781d1a656e9e2c97ea920dd6eb5317baf9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"35873f82cb907a243e3785dc8f07a681439d037b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"run_tests.log"},{"line_number":20,"context_line":"setuptools*.egg/"},{"line_number":21,"context_line":"subunit.log"},{"line_number":22,"context_line":"tempest.log"},{"line_number":23,"context_line":"*.mo"},{"line_number":24,"context_line":"*.sw?"},{"line_number":25,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"3a961159_20fd1db2","line":22,"updated":"2015-01-01 23:22:02.000000000","message":"You missed two opportunities to switch to *.log :)  -Here is another gentle reminder.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"run_tests.log"},{"line_number":20,"context_line":"setuptools*.egg/"},{"line_number":21,"context_line":"subunit.log"},{"line_number":22,"context_line":"tempest.log"},{"line_number":23,"context_line":"*.mo"},{"line_number":24,"context_line":"*.sw?"},{"line_number":25,"context_line":"*~"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"3a961159_4593f0a2","line":22,"in_reply_to":"3a961159_20fd1db2","updated":"2015-01-06 02:31:51.000000000","message":"Done","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"which will soon be run as part of the check queue by the"},{"line_number":21,"context_line":"neutron-dsvm-api job [1].  Running this tox env requires"},{"line_number":22,"context_line":"devstack-deployed Neutron and Tempest, though, so manual invocation is"},{"line_number":23,"context_line":"not recommended."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The intention is to refactor the existing plugin tests"},{"line_number":26,"context_line":"(e.g. NeutronDbPluginV2TestCase) to use this model.  Functional tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7adec928_56bd9c67","line":23,"updated":"2014-05-09 20:19:11.000000000","message":"I think it is ok to run it manually, as long as you\u0027ve deployed your stuff with devstack, which is what most developers do.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":20,"context_line":"which will soon be run as part of the check queue by the"},{"line_number":21,"context_line":"neutron-dsvm-api job [1].  Running this tox env requires"},{"line_number":22,"context_line":"devstack-deployed Neutron and Tempest, though, so manual invocation is"},{"line_number":23,"context_line":"not recommended."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The intention is to refactor the existing plugin tests"},{"line_number":26,"context_line":"(e.g. NeutronDbPluginV2TestCase) to use this model.  Functional tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"baada198_b67244e1","line":23,"in_reply_to":"7adec928_56bd9c67","updated":"2014-07-29 22:51:01.000000000","message":"Done","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"678620a34015fb1bb4413ee85fa99ac8a532de5e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"(e.g. NeutronDbPluginV2TestCase) to use this model.  Functional tests"},{"line_number":27,"context_line":"don\u0027t have to isolate functionality - they just need to exercise it -"},{"line_number":28,"context_line":"so fewer tests will be required.  The new tests will be able to target"},{"line_number":29,"context_line":"plugins directly rather that through the wsgi stack, so execution time"},{"line_number":30,"context_line":"will be decreased.  The refactored tests should be easier to maintain"},{"line_number":31,"context_line":"and take less time to run."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"baada198_0e9a3b13","line":29,"updated":"2014-08-13 11:35:03.000000000","message":"\"rather than\" instead if \"rather that\"","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"a6495306ca9a27926883d4fda284cdb9c5d3e984","unresolved":false,"context_lines":[{"line_number":26,"context_line":"(e.g. NeutronDbPluginV2TestCase) to use this model.  Functional tests"},{"line_number":27,"context_line":"don\u0027t have to isolate functionality - they just need to exercise it -"},{"line_number":28,"context_line":"so fewer tests will be required.  The new tests will be able to target"},{"line_number":29,"context_line":"plugins directly rather that through the wsgi stack, so execution time"},{"line_number":30,"context_line":"will be decreased.  The refactored tests should be easier to maintain"},{"line_number":31,"context_line":"and take less time to run."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1abeadc6_4a8b751e","line":29,"in_reply_to":"baada198_0e9a3b13","updated":"2014-08-23 13:47:51.000000000","message":"Done","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5483f29338833d044124afde06fad8977d1bc26","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The test added by this patch (test_network_lifecycle) can be run"},{"line_number":15,"context_line":"against the programmatic plugin api (for configured plugins) via \u0027tox"},{"line_number":16,"context_line":"-e functional\u0027.  This will run as part of the check queue by the"},{"line_number":17,"context_line":"neutron-dsvm-functional job."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test can also be run against the Neutron service via \u0027tox -e api\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"3a961159_5f14d4e8","line":16,"updated":"2014-12-31 05:26:45.000000000","message":"Is this statement still accurate? I have a different understanding of what tox -e dvsm-functional actually does (which is what the dsvm-functional Jenkins job executes). Can you elaborate, and perhaps remind me once again, what is the difference between the the tox envs \u0027functional\u0027 and \u0027dsvm-functional\u0027?","commit_id":"0d6185781d1a656e9e2c97ea920dd6eb5317baf9"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e6ceb4ec376a154038e65c33f71ea547ae99cb04","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The test added by this patch (test_network_lifecycle) can be run"},{"line_number":15,"context_line":"against the programmatic plugin api (for configured plugins) via \u0027tox"},{"line_number":16,"context_line":"-e functional\u0027.  This will run as part of the check queue by the"},{"line_number":17,"context_line":"neutron-dsvm-functional job."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test can also be run against the Neutron service via \u0027tox -e api\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"3a961159_8538a6d5","line":16,"in_reply_to":"3a961159_5f14d4e8","updated":"2014-12-31 20:00:14.000000000","message":"The \u0027functional\u0027 env will skip tests that require sudo and other system dependencies.  Once we have better automation in place for configuring the functional test environment, this distinction can probably go away and we can replace the \u0027functional\u0027 env with the configuration for \u0027dsvm-functional\u0027 env.  Less confusing that way, methinks.","commit_id":"0d6185781d1a656e9e2c97ea920dd6eb5317baf9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5483f29338833d044124afde06fad8977d1bc26","unresolved":false,"context_lines":[{"line_number":16,"context_line":"-e functional\u0027.  This will run as part of the check queue by the"},{"line_number":17,"context_line":"neutron-dsvm-functional job."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test can also be run against the Neutron service via \u0027tox -e api\u0027"},{"line_number":20,"context_line":"which will soon be run as part of the check queue by the"},{"line_number":21,"context_line":"neutron-dsvm-api job [1].  Running this tox env requires"},{"line_number":22,"context_line":"devstack-deployed Neutron and Tempest."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"3a961159_9fd55c1d","line":19,"updated":"2014-12-31 05:26:45.000000000","message":"the fact that we have two functional envs, functional and dsvm-functional, makes me wonder whether we need api and dsvm-api. I am sure we don\u0027t, but by reading this I can\u0027t help but raise the question. Can you clarify?","commit_id":"0d6185781d1a656e9e2c97ea920dd6eb5317baf9"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e6ceb4ec376a154038e65c33f71ea547ae99cb04","unresolved":false,"context_lines":[{"line_number":16,"context_line":"-e functional\u0027.  This will run as part of the check queue by the"},{"line_number":17,"context_line":"neutron-dsvm-functional job."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test can also be run against the Neutron service via \u0027tox -e api\u0027"},{"line_number":20,"context_line":"which will soon be run as part of the check queue by the"},{"line_number":21,"context_line":"neutron-dsvm-api job [1].  Running this tox env requires"},{"line_number":22,"context_line":"devstack-deployed Neutron and Tempest."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"3a961159_4556be07","line":19,"in_reply_to":"3a961159_9fd55c1d","updated":"2014-12-31 20:00:14.000000000","message":"The only reason for functional vs dsvm-functional was to allow the running of tests without a devstack environment via the functional env.  Since the api env in this patch absolutely requires a devstack-configured system, I don\u0027t see a reason for more than 1 env.\n\nIn the future, we\u0027re going to need to figure out how to allow Tempest to consume our API tests for the purposes of aggregating functional api tests across projects and running them as part of compliance validation.  I\u0027m also thinking that we\u0027ll want to run the tests against neutron-managed processes ala John\u0027s full stack work, which would allow the tests to run as part of the functional job and reduce our dependency on tempest to only the rest client.","commit_id":"0d6185781d1a656e9e2c97ea920dd6eb5317baf9"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The test added by this patch (test_network_lifecycle) can be run"},{"line_number":15,"context_line":"against the programmatic plugin api (for configured plugins) via both"},{"line_number":16,"context_line":"tox -e functional and tox -e dsvm-functional.  The latter env is used "},{"line_number":17,"context_line":"by the gating neutron-dsvm-functional job."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test can also be run against a live Neutron service via \u0027tox -e api\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"3a961159_b7be9162","line":16,"updated":"2015-01-05 16:02:25.000000000","message":"nit: whitespace XD","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The test added by this patch (test_network_lifecycle) can be run"},{"line_number":15,"context_line":"against the programmatic plugin api (for configured plugins) via both"},{"line_number":16,"context_line":"tox -e functional and tox -e dsvm-functional.  The latter env is used "},{"line_number":17,"context_line":"by the gating neutron-dsvm-functional job."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test can also be run against a live Neutron service via \u0027tox -e api\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"3a961159_e5785c80","line":16,"in_reply_to":"3a961159_b7be9162","updated":"2015-01-06 02:31:51.000000000","message":"Done\n\nThat\u0027ll teach me to use gerrit\u0027s commit editor.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"neutron/tests/api/base_v2.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93cbf81f4a976e400dfdd3ff25fe0de0680e3f52","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \"\"\"Allow attribute access for all keys in the dict.\"\"\""},{"line_number":66,"context_line":"        if name in self:"},{"line_number":67,"context_line":"            return self[name]"},{"line_number":68,"context_line":"        raise AttributeError(_(\"Unknown attribute \u0027%s\u0027.\"), name)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class BaseNeutronClient(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BODQ%3D","line":68,"updated":"2014-03-28 10:31:01.000000000","message":"I believe you need to use % here.\n\n\u003e\u003e\u003e AttributeError(\"aaa %s\",\"bbb\")\nAttributeError(\u0027aaa %s\u0027, \u0027bbb\u0027)\n\n\u003e\u003e\u003e AttributeError(\"aaa %s\" % \"bbb\")\nAttributeError(\u0027aaa bbb\u0027,)","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"3d77ae7ef1b6f5bc83a43112cfec359ff6c7f524","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \"\"\"Allow attribute access for all keys in the dict.\"\"\""},{"line_number":66,"context_line":"        if name in self:"},{"line_number":67,"context_line":"            return self[name]"},{"line_number":68,"context_line":"        raise AttributeError(_(\"Unknown attribute \u0027%s\u0027.\"), name)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class BaseNeutronClient(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXH%2F%2FQ%2BM%3D","line":68,"in_reply_to":"AAAAWH%2F%2BODQ%3D","updated":"2014-04-23 00:46:06.000000000","message":"Done","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93cbf81f4a976e400dfdd3ff25fe0de0680e3f52","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def create_network(self, **kwargs):"},{"line_number":98,"context_line":"        network \u003d self._create_network(**kwargs)"},{"line_number":99,"context_line":"        self.test_case.addCleanup(functools.partial(self._cleanup_network,"},{"line_number":100,"context_line":"                                                    network.id))"},{"line_number":101,"context_line":"        return network"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def update_network(self, id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BN%2BQ%3D","line":100,"updated":"2014-03-28 10:31:01.000000000","message":"Check Jay\u0027s comments here,\nhttps://review.openstack.org/#/c/72585/3/neutron/tests/unit/test_plugin_api.py\n\nI\u0027m unfamiliar with addCleanup, but he says:\n\n\"Why not just addCleanup(self._cleanup_network, network.id)? \"","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"3d77ae7ef1b6f5bc83a43112cfec359ff6c7f524","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def create_network(self, **kwargs):"},{"line_number":98,"context_line":"        network \u003d self._create_network(**kwargs)"},{"line_number":99,"context_line":"        self.test_case.addCleanup(functools.partial(self._cleanup_network,"},{"line_number":100,"context_line":"                                                    network.id))"},{"line_number":101,"context_line":"        return network"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def update_network(self, id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXH%2F%2FQ94%3D","line":100,"in_reply_to":"AAAAWH%2F%2BN%2BQ%3D","updated":"2014-04-23 00:46:06.000000000","message":"Done","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"   scenarios \u003d [(\u0027scenario_id\u0027, dict(client\u003dClient())]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":" - The client parameter of each scenario dict should be a subclass of"},{"line_number":29,"context_line":"   BaseNeutronClient."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":" - The module containing the test class should defines a \u0027load_tests\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_1c6335dd","line":28,"updated":"2014-05-09 20:19:11.000000000","message":"technically there is no client parameter, am I wrong?\nThe client seems to be the second element of the scenario tuple.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"   scenarios \u003d [(\u0027scenario_id\u0027, dict(client\u003dClient())]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":" - The client parameter of each scenario dict should be a subclass of"},{"line_number":29,"context_line":"   BaseNeutronClient."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":" - The module containing the test class should defines a \u0027load_tests\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_bb642c22","line":28,"in_reply_to":"7adec928_1c6335dd","updated":"2014-07-29 22:51:01.000000000","message":"I thought that this was clear from the above example but I\u0027ll reword.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def create_network(self, **kwargs):"},{"line_number":96,"context_line":"        network \u003d self._create_network(**kwargs)"},{"line_number":97,"context_line":"        self.test_case.addCleanup(self._cleanup_network, network.id)"},{"line_number":98,"context_line":"        return network"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_network(self, id, **kwargs):"},{"line_number":101,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_3c1631f2","line":98,"updated":"2014-05-09 20:19:11.000000000","message":"I was expecting all methods to be NotImplemented.\nWhy the above two have an implementation?\nIt\u0027s ok for _cleanup_network, I guess.\nPerhaps the intention is to have a general base method that ensures a created object is removed?\n\nIn that case it would be ok for me.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def create_network(self, **kwargs):"},{"line_number":96,"context_line":"        network \u003d self._create_network(**kwargs)"},{"line_number":97,"context_line":"        self.test_case.addCleanup(self._cleanup_network, network.id)"},{"line_number":98,"context_line":"        return network"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def update_network(self, id, **kwargs):"},{"line_number":101,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_3bd49cba","line":98,"in_reply_to":"7adec928_3c1631f2","updated":"2014-07-29 22:51:01.000000000","message":"Done\n\nI was thinking differently when I wrote this.  Automatic cleanup should only be implemented by the rest/native clients, and the plugin client should not do so.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9a65fdb8b67aab2ba5c24983d7d1dd39338028a7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        raise NotImplementedError"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_networks_count(self, filters\u003dNone):"},{"line_number":111,"context_line":"        return len(self.get_networks(filters\u003dfilters))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def delete_network(self, id):"},{"line_number":114,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_aca8fc77","line":111,"updated":"2014-09-03 05:02:08.000000000","message":"not sure how much performance matters here, but since this is just going for a count you could limit the fields param to \u0027id\u0027 only","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"fd0e90bf51b320bde5d2e2d932f7e070b0c785ac","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        raise NotImplementedError"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_networks_count(self, filters\u003dNone):"},{"line_number":111,"context_line":"        return len(self.get_networks(filters\u003dfilters))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def delete_network(self, id):"},{"line_number":114,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_b648425d","line":111,"in_reply_to":"fa98f980_aca8fc77","updated":"2014-09-12 22:44:22.000000000","message":"Good advice, but this method isn\u0027t even used in the most recent patch so I\u0027ll remove it.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        pre_creation_count \u003d self.client.get_networks_count()"},{"line_number":130,"context_line":"        net \u003d self.client.create_network(name\u003dbase.rand_name())"},{"line_number":131,"context_line":"        post_creation_count \u003d self.client.get_networks_count()"},{"line_number":132,"context_line":"        self.assertTrue(post_creation_count \u003e pre_creation_count)"},{"line_number":133,"context_line":"        listed_networks \u003d dict((x[\u0027id\u0027], x[\u0027name\u0027])"},{"line_number":134,"context_line":"                               for x in self.client.get_networks())"},{"line_number":135,"context_line":"        self.assertIn(net.id, listed_networks)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_7cbef9d5","line":132,"updated":"2014-05-09 20:19:11.000000000","message":"is this safe wrt. parallel execution?\nA networks might be deleted while this is being created","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        pre_creation_count \u003d self.client.get_networks_count()"},{"line_number":130,"context_line":"        net \u003d self.client.create_network(name\u003dbase.rand_name())"},{"line_number":131,"context_line":"        post_creation_count \u003d self.client.get_networks_count()"},{"line_number":132,"context_line":"        self.assertTrue(post_creation_count \u003e pre_creation_count)"},{"line_number":133,"context_line":"        listed_networks \u003d dict((x[\u0027id\u0027], x[\u0027name\u0027])"},{"line_number":134,"context_line":"                               for x in self.client.get_networks())"},{"line_number":135,"context_line":"        self.assertIn(net.id, listed_networks)"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_bbea6c0c","line":132,"in_reply_to":"7adec928_7cbef9d5","updated":"2014-07-29 22:51:01.000000000","message":"Done.\n\nI was foolishly trusting the magic of tenant isolation to save me.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertTrue(post_creation_count \u003e pre_creation_count)"},{"line_number":133,"context_line":"        listed_networks \u003d dict((x[\u0027id\u0027], x[\u0027name\u0027])"},{"line_number":134,"context_line":"                               for x in self.client.get_networks())"},{"line_number":135,"context_line":"        self.assertIn(net.id, listed_networks)"},{"line_number":136,"context_line":"        self.assertEqual(listed_networks[net.id], net.name,"},{"line_number":137,"context_line":"                         \u0027Listed network name is not as expected.\u0027)"},{"line_number":138,"context_line":"        updated_name \u003d \u0027new %s\u0027 % net.name"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_bcb881e6","line":135,"updated":"2014-05-09 20:19:11.000000000","message":"I think this assertion makes the one at line 132 redundant","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.assertTrue(post_creation_count \u003e pre_creation_count)"},{"line_number":133,"context_line":"        listed_networks \u003d dict((x[\u0027id\u0027], x[\u0027name\u0027])"},{"line_number":134,"context_line":"                               for x in self.client.get_networks())"},{"line_number":135,"context_line":"        self.assertIn(net.id, listed_networks)"},{"line_number":136,"context_line":"        self.assertEqual(listed_networks[net.id], net.name,"},{"line_number":137,"context_line":"                         \u0027Listed network name is not as expected.\u0027)"},{"line_number":138,"context_line":"        updated_name \u003d \u0027new %s\u0027 % net.name"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_71ff1303","line":135,"in_reply_to":"7adec928_bcb881e6","updated":"2014-07-29 22:51:01.000000000","message":"Done","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        updated_net \u003d self.client.update_network(net.id, name\u003dupdated_name)"},{"line_number":140,"context_line":"        self.assertEqual(updated_name, updated_net.name,"},{"line_number":141,"context_line":"                         \u0027Updated network name is not as expected.\u0027)"},{"line_number":142,"context_line":"        self.client.delete_network(net.id)"},{"line_number":143,"context_line":"        with testtools.ExpectedException(self.client.NetworkNotFound,"},{"line_number":144,"context_line":"                                         msg\u003d\u0027Network was not deleted\u0027):"},{"line_number":145,"context_line":"            self.client.get_network(net.id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_bcafa193","line":142,"updated":"2014-05-09 20:19:11.000000000","message":"uhm... this is why the autocleanup which should be scheduled by create_network passes on NetworkNotFound.\n\nI think it might be worth adding a parameter to create_network stating whether the network should be deleted on cleanup or not.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        updated_net \u003d self.client.update_network(net.id, name\u003dupdated_name)"},{"line_number":140,"context_line":"        self.assertEqual(updated_name, updated_net.name,"},{"line_number":141,"context_line":"                         \u0027Updated network name is not as expected.\u0027)"},{"line_number":142,"context_line":"        self.client.delete_network(net.id)"},{"line_number":143,"context_line":"        with testtools.ExpectedException(self.client.NetworkNotFound,"},{"line_number":144,"context_line":"                                         msg\u003d\u0027Network was not deleted\u0027):"},{"line_number":145,"context_line":"            self.client.get_network(net.id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_7b4294ac","line":142,"in_reply_to":"7adec928_bcafa193","updated":"2014-07-29 22:51:01.000000000","message":"This is an explicit test for deletion, and has no bearing on whether the resource is cleaned up on test failure.  As per the spec on removing autodeletion in the unit tests, the tests themselves should have no concept of resource cleanup - e.g. no_delete is a leaky abstraction.  Instead, the client hides responsibility for ensuring resource cleanup.  A rest client will make a best-effort at cleanup, but a plugin client will skip it because the db state is automatically reset.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"db5c91bae87e3431c1f1317924ea4d07166149bf","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        updated_net \u003d self.client.update_network(net.id, name\u003dupdated_name)"},{"line_number":140,"context_line":"        self.assertEqual(updated_name, updated_net.name,"},{"line_number":141,"context_line":"                         \u0027Updated network name is not as expected.\u0027)"},{"line_number":142,"context_line":"        self.client.delete_network(net.id)"},{"line_number":143,"context_line":"        with testtools.ExpectedException(self.client.NetworkNotFound,"},{"line_number":144,"context_line":"                                         msg\u003d\u0027Network was not deleted\u0027):"},{"line_number":145,"context_line":"            self.client.get_network(net.id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7ac7a964_ada05144","line":142,"in_reply_to":"baada198_7b4294ac","updated":"2014-08-15 08:19:17.000000000","message":"got it","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7a410febf9a98c83ba7432bedb2e9ecc3aa97535","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Allow attribute access for all keys in the dict.\"\"\""},{"line_number":65,"context_line":"        if name in self:"},{"line_number":66,"context_line":"            return self[name]"},{"line_number":67,"context_line":"        raise AttributeError(_(\"Unknown attribute \u0027%s\u0027.\") % name)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class BaseNeutronClient(object):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_2c16854c","line":67,"updated":"2014-10-28 11:15:37.000000000","message":"this is just a nit, but we have something similar here as we discussed:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L78\n\nMay be it\u0027s worth to re-factoring somewhere else and reusing, but not important, as it\u0027s a tiny piece of code.","commit_id":"ab73abb3364bc68ca55fbbbe98d280f0ce732d5e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7de13d359151cca65ac073724415ad3e64d44ad8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Allow attribute access for all keys in the dict.\"\"\""},{"line_number":65,"context_line":"        if name in self:"},{"line_number":66,"context_line":"            return self[name]"},{"line_number":67,"context_line":"        raise AttributeError(_(\"Unknown attribute \u0027%s\u0027.\") % name)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class BaseNeutronClient(object):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8c0949_b2127cb2","line":67,"in_reply_to":"9aa7fdbe_2c16854c","updated":"2014-10-31 00:41:01.000000000","message":"it looks awkward to import from a dhcp model. Since the duplication is pretty trivial I\u0027d keep it like this.","commit_id":"ab73abb3364bc68ca55fbbbe98d280f0ce732d5e"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014, Red Hat Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_3059f55a","line":1,"updated":"2014-12-09 19:44:46.000000000","message":"pls remove.","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"554d534578820c851de3692b8092dfb28f37dfc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014, Red Hat Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_65a9fade","line":1,"in_reply_to":"3a961159_3059f55a","updated":"2014-12-09 20:25:09.000000000","message":"Done","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"This module defines functional tests for the Neutron V2 API in the"},{"line_number":20,"context_line":"BaseTestApi class.  The intention is that the class will be overridden"},{"line_number":21,"context_line":"and configured for use with testscenarios as follows:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_b6631edc","line":18,"updated":"2014-12-09 19:44:46.000000000","message":"[H404] Multi line docstrings should start without a leading new line.","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"554d534578820c851de3692b8092dfb28f37dfc0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"This module defines functional tests for the Neutron V2 API in the"},{"line_number":20,"context_line":"BaseTestApi class.  The intention is that the class will be overridden"},{"line_number":21,"context_line":"and configured for use with testscenarios as follows:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_25ed3226","line":18,"in_reply_to":"3a961159_b6631edc","updated":"2014-12-09 20:25:09.000000000","message":"We don\u0027t enforce H404, and in general, reviewers should avoid manually trying to enforce rules that hacking checks can validate automatically.","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":57,"context_line":"class AttributeDict(dict):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":"    Provide attribute access (dict.key) to dictionary values."},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __getattr__(self, name):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_b63cfec0","line":60,"updated":"2014-12-09 19:44:46.000000000","message":"H404","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class BaseNeutronClient(object):"},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":"    Base class for a client that can interact the neutron api in some"},{"line_number":73,"context_line":"    manner."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    Reference: :file:`neutron/neutron_plugin_base_v2.py`"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_3651ee0e","line":72,"updated":"2014-12-09 19:44:46.000000000","message":"H404","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        Tests can use this property to assert for a missing resource"},{"line_number":88,"context_line":"        in a client-agnostic way."},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        raise NotImplementedError"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def create_network(self, **kwargs):"},{"line_number":93,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_fa6f20fa","line":90,"updated":"2015-01-05 16:02:25.000000000","message":"All these should return instances of NotImplementedError() instead.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        Tests can use this property to assert for a missing resource"},{"line_number":88,"context_line":"        in a client-agnostic way."},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        raise NotImplementedError"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def create_network(self, **kwargs):"},{"line_number":93,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_a53734af","line":90,"in_reply_to":"3a961159_fa6f20fa","updated":"2015-01-06 02:31:51.000000000","message":"Done","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"35873f82cb907a243e3785dc8f07a681439d037b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def create_network(self, **kwargs):"},{"line_number":93,"context_line":"        raise NotImplementedError"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def update_network(self, id, **kwargs):"},{"line_number":96,"context_line":"        raise NotImplementedError"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_network(self, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_60d5651a","line":95,"updated":"2015-01-01 23:22:02.000000000","message":"Nit: parameter id shadows python built-in function id(). There are more instances below too.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def create_network(self, **kwargs):"},{"line_number":93,"context_line":"        raise NotImplementedError"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def update_network(self, id, **kwargs):"},{"line_number":96,"context_line":"        raise NotImplementedError"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_network(self, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_c56360af","line":95,"in_reply_to":"3a961159_60d5651a","updated":"2015-01-06 02:31:51.000000000","message":"Done","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        super(BaseTestApi, self).setUp()"},{"line_number":115,"context_line":"        # Set a default to allow trival debugging of single tests"},{"line_number":116,"context_line":"        if not hasattr(self, \u0027client\u0027):"},{"line_number":117,"context_line":"            self.__dict__.update(self.scenarios[0][1])"},{"line_number":118,"context_line":"        self.client.setUp(self)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_network_lifecycle(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_da9ee406","line":117,"updated":"2015-01-05 16:02:25.000000000","message":"Now my eyes burn for all the brackets :(\n\nWhat if there is more than one scenarios? It is possible for example in: test_v2_plugin.py.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        super(BaseTestApi, self).setUp()"},{"line_number":115,"context_line":"        # Set a default to allow trival debugging of single tests"},{"line_number":116,"context_line":"        if not hasattr(self, \u0027client\u0027):"},{"line_number":117,"context_line":"            self.__dict__.update(self.scenarios[0][1])"},{"line_number":118,"context_line":"        self.client.setUp(self)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_network_lifecycle(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_b7283f98","line":117,"in_reply_to":"3a961159_da9ee406","updated":"2015-01-06 02:31:51.000000000","message":"Done\n\nThis ugliness was necessary to support debugging single tests with nosetests, which doesn\u0027t know about the load_tests protocol that uses the scenario data to generate tests.  I\u0027ve done some research and nose2 is a viable alternative, so I\u0027ve submitted a patch [1] that updates the documentation to reflect the problem and my next patch will remove these 3 lines.\n\n1: https://review.openstack.org/#/c/145103/","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"neutron/tests/api/test_v2_rest.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2ece109158d2727b0afc596e33db20f88b5d34f9","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class TestApiWithRestClient(base_v2.BaseTestApi):"},{"line_number":96,"context_line":"    scenarios \u003d get_scenarios()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BgCs%3D","line":96,"updated":"2014-03-26 11:43:54.000000000","message":"Marun can you please explain what you plan to test here that is not already tested in Tempest?","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"378d95a39c3cdd75add78ee500d024e97267be09","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class TestApiWithRestClient(base_v2.BaseTestApi):"},{"line_number":96,"context_line":"    scenarios \u003d get_scenarios()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bb8Q%3D","line":96,"in_reply_to":"AAAAWH%2F%2BgCs%3D","updated":"2014-03-26 19:38:45.000000000","message":"Neutron already duplicates a great deal of the api testing done in Tempest (search the neutron tree for any tests extending NeutronDbPluginV2TestCase).  Those tests are more complex than necessary, though, and take too long to run.  The goal of the refactor is to rewrite the tests to have the same coverage but be easier to maintain and less costly to run.  The side-effect is that the tests can be made to run against an integration environment and gate neutron merges accordingly.  \n\nSo, this effort is necessary to ensure the health of the neutron\u0027s in-tree testing.  This isn\u0027t something we shouldn\u0027t do because it duplicates what Tempest already does.  Maintaining the functional api tests in Tempest is the duplicative part of this equation, and when we achieve parity in coverage of the api, I will advocate for them to replace Tempest\u0027s equivalents.  The details of replacement - Tempest depending on Neutron, Neutron being responsible for validation of api compliance/backwards compatibility - are entirely political rather than technical and I want to avoid that distraction for now.","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9a65fdb8b67aab2ba5c24983d7d1dd39338028a7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def _create_network(self, _expected_status, **kwargs):"},{"line_number":52,"context_line":"        # Internal method - use create_network() instead"},{"line_number":53,"context_line":"        if not kwargs:"},{"line_number":54,"context_line":"            kwargs \u003d {}"},{"line_number":55,"context_line":"        resp, body \u003d self.client.create_network(**kwargs)"},{"line_number":56,"context_line":"        self.test_case.assertEqual(_expected_status, resp[\u0027status\u0027])"},{"line_number":57,"context_line":"        return base_v2.AttributeDict(body[\u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_8cab3874","line":54,"updated":"2014-09-03 05:02:08.000000000","message":"Any reason to construction a new kwargs here?","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"fd0e90bf51b320bde5d2e2d932f7e070b0c785ac","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def _create_network(self, _expected_status, **kwargs):"},{"line_number":52,"context_line":"        # Internal method - use create_network() instead"},{"line_number":53,"context_line":"        if not kwargs:"},{"line_number":54,"context_line":"            kwargs \u003d {}"},{"line_number":55,"context_line":"        resp, body \u003d self.client.create_network(**kwargs)"},{"line_number":56,"context_line":"        self.test_case.assertEqual(_expected_status, resp[\u0027status\u0027])"},{"line_number":57,"context_line":"        return base_v2.AttributeDict(body[\u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_76697abd","line":54,"in_reply_to":"fa98f980_8cab3874","updated":"2014-09-12 22:44:22.000000000","message":"Done","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    for fmt in [\u0027json\u0027, \u0027xml\u0027]:"},{"line_number":86,"context_line":"        manager \u003d t_test.BaseTestCase.get_client_manager(interface\u003dfmt)"},{"line_number":87,"context_line":"        client \u003d TempestRestClient(manager.network_client, exceptions.NotFound)"},{"line_number":88,"context_line":"        scenarios.append((\u0027tempest_%s\u0027 % fmt, {\u0027client\u0027: client}))"},{"line_number":89,"context_line":"    return scenarios"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_1cf255d2","line":88,"updated":"2014-05-09 20:19:11.000000000","message":"ah I see why you wrote \u0027client\u0027 parameter","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9e92de94a095dea384777563d760f7f4df47cd32","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \"\"\"Generate scenarios with the tempest rest client.\"\"\""},{"line_number":84,"context_line":"    manager \u003d t_test.BaseTestCase.get_client_manager(interface\u003d\u0027json\u0027)"},{"line_number":85,"context_line":"    client \u003d TempestRestClient(manager.network_client)"},{"line_number":86,"context_line":"    scenarios \u003d [(\u0027tempest_%s\u0027 % fmt, {\u0027client\u0027: client})]"},{"line_number":87,"context_line":"    return scenarios"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a961159_bfe22a9d","line":86,"updated":"2014-12-09 07:25:41.000000000","message":"What is fmt?","commit_id":"ae0099f111cd334fc48a55834931af369c887495"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"db091b6969547446b342bc1c0b110958127f2b1c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \"\"\"Generate scenarios with the tempest rest client.\"\"\""},{"line_number":84,"context_line":"    manager \u003d t_test.BaseTestCase.get_client_manager(interface\u003d\u0027json\u0027)"},{"line_number":85,"context_line":"    client \u003d TempestRestClient(manager.network_client)"},{"line_number":86,"context_line":"    scenarios \u003d [(\u0027tempest_%s\u0027 % fmt, {\u0027client\u0027: client})]"},{"line_number":87,"context_line":"    return scenarios"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a961159_5a5ea213","line":86,"in_reply_to":"3a961159_bfe22a9d","updated":"2014-12-09 16:37:08.000000000","message":"Done","commit_id":"ae0099f111cd334fc48a55834931af369c887495"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014, Red Hat Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_169cf2bf","line":1,"updated":"2014-12-09 19:44:46.000000000","message":"pls remove.","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"554d534578820c851de3692b8092dfb28f37dfc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014, Red Hat Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_45f4fef1","line":1,"in_reply_to":"3a961159_169cf2bf","updated":"2014-12-09 20:25:09.000000000","message":"Done","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"This module implements BaseNeutronClient for the Tempest rest client"},{"line_number":20,"context_line":"and configures the api tests with scenarios targeting the Neutron API."},{"line_number":21,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_d6b98a2f","line":18,"updated":"2014-12-09 19:44:46.000000000","message":"H404?","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"35873f82cb907a243e3785dc8f07a681439d037b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def NotFound(self):"},{"line_number":43,"context_line":"        return exceptions.NotFound"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _cleanup_network(self, id):"},{"line_number":46,"context_line":"        try:"},{"line_number":47,"context_line":"            self.delete_network(id)"},{"line_number":48,"context_line":"        except self.NotFound:"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_004821cb","line":45,"updated":"2015-01-01 23:22:02.000000000","message":"Nit: id shadows built-in (more instances below)","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def NotFound(self):"},{"line_number":43,"context_line":"        return exceptions.NotFound"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _cleanup_network(self, id):"},{"line_number":46,"context_line":"        try:"},{"line_number":47,"context_line":"            self.delete_network(id)"},{"line_number":48,"context_line":"        except self.NotFound:"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_77097730","line":45,"in_reply_to":"3a961159_004821cb","updated":"2015-01-06 02:31:51.000000000","message":"Done","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"neutron/tests/functional/agent/linux/base.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"VETH_PREFIX \u003d \u0027tst-vth\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#TODO(jschwarz): Move these two functions to neutron/tests/common/"},{"line_number":36,"context_line":"get_rand_name \u003d sub_base.get_rand_name"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_755c211a","line":35,"updated":"2015-01-05 16:02:25.000000000","message":"This is on the queue to be moved, I promise :)","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"neutron/tests/functional/api/test_v2_plugin.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93cbf81f4a976e400dfdd3ff25fe0de0680e3f52","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Internal method - use create_network() instead"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Supply defaults that are expected to be set by the api"},{"line_number":89,"context_line":"        # framwork"},{"line_number":90,"context_line":"        kwargs.setdefault(\u0027admin_state_up\u0027, True)"},{"line_number":91,"context_line":"        kwargs.setdefault(\u0027shared\u0027, False)"},{"line_number":92,"context_line":"        data \u003d dict(network\u003dkwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BN%2FA%3D","line":89,"updated":"2014-03-28 10:31:01.000000000","message":"nit: framework\n\nI think you missed Jay pipe\u0027s comments on \nhttps://review.openstack.org/#/c/72585/3/neutron/tests/unit/test_plugin_api.py","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"3d77ae7ef1b6f5bc83a43112cfec359ff6c7f524","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Internal method - use create_network() instead"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Supply defaults that are expected to be set by the api"},{"line_number":89,"context_line":"        # framwork"},{"line_number":90,"context_line":"        kwargs.setdefault(\u0027admin_state_up\u0027, True)"},{"line_number":91,"context_line":"        kwargs.setdefault(\u0027shared\u0027, False)"},{"line_number":92,"context_line":"        data \u003d dict(network\u003dkwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXH%2F%2FQ9o%3D","line":89,"in_reply_to":"AAAAWH%2F%2BN%2FA%3D","updated":"2014-04-23 00:46:06.000000000","message":"Done","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"This module implements BaseNeutronClient for the programmatic plugin"},{"line_number":20,"context_line":"api and configures the api tests with scenarios targeting individual"},{"line_number":21,"context_line":"plugins."},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_85d7e422","line":21,"updated":"2014-05-09 20:19:11.000000000","message":"I would have named this package neutron.tests.functional.plugin\n\nwhat\u0027s the reasoning being calling it neutron.tests.functional.api?\nDo you think it might be confused with neutron.tests.api?","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"This module implements BaseNeutronClient for the programmatic plugin"},{"line_number":20,"context_line":"api and configures the api tests with scenarios targeting individual"},{"line_number":21,"context_line":"plugins."},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_3e664a56","line":21,"in_reply_to":"7adec928_85d7e422","updated":"2014-07-29 22:51:01.000000000","message":"I imagined this package including tests for other api\u0027s (extensions and services).  Or do you think they should have packages of their own, e.g. neutron.tests.functional.extensions?","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return q_exc.NetworkNotFound"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _create_network(self, **kwargs):"},{"line_number":86,"context_line":"        # Internal method - use create_network() instead"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Supply defaults that are expected to be set by the api"},{"line_number":89,"context_line":"        # framwork"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_a5dea03d","line":86,"updated":"2014-05-09 20:19:11.000000000","message":"what do you mean by use \"create_network() instead\"?","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return q_exc.NetworkNotFound"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _create_network(self, **kwargs):"},{"line_number":86,"context_line":"        # Internal method - use create_network() instead"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Supply defaults that are expected to be set by the api"},{"line_number":89,"context_line":"        # framwork"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_3e82caa5","line":86,"in_reply_to":"7adec928_a5dea03d","updated":"2014-07-29 22:51:01.000000000","message":"This method has been renamed to create_network since automatic cleanup has been removed.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7a410febf9a98c83ba7432bedb2e9ecc3aa97535","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# configuration classes listed below for examples of this reuse."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#TODO(marun) Discover plugin conf via a metaclass"},{"line_number":44,"context_line":"plugin_conf \u003d ["},{"line_number":45,"context_line":"    test_ml2_plugin.Ml2PluginConf,"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_b2156c9d","line":44,"updated":"2014-10-28 11:15:37.000000000","message":"PLUGIN_CONF / PLUGIN_CONFS as it\u0027s a constant at this moment?","commit_id":"ab73abb3364bc68ca55fbbbe98d280f0ce732d5e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7de13d359151cca65ac073724415ad3e64d44ad8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# configuration classes listed below for examples of this reuse."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#TODO(marun) Discover plugin conf via a metaclass"},{"line_number":44,"context_line":"plugin_conf \u003d ["},{"line_number":45,"context_line":"    test_ml2_plugin.Ml2PluginConf,"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8c0949_52ff9834","line":44,"in_reply_to":"9aa7fdbe_b2156c9d","updated":"2014-10-31 00:41:01.000000000","message":"I\u0027ll let Maru chime in...if he chose not to have it all capital letters, I am sure there\u0027s a good reason :)","commit_id":"ab73abb3364bc68ca55fbbbe98d280f0ce732d5e"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014, Red Hat Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_7680d646","line":1,"updated":"2014-12-09 19:44:46.000000000","message":"pls remove.","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"554d534578820c851de3692b8092dfb28f37dfc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014, Red Hat Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_85dd0673","line":1,"in_reply_to":"3a961159_7680d646","updated":"2014-12-09 20:25:09.000000000","message":"Done","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"46c62d13b79f610ca4bb324a015d90d5d1a77007","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"This module implements BaseNeutronClient for the programmatic plugin"},{"line_number":20,"context_line":"api and configures the api tests with scenarios targeting individual"},{"line_number":21,"context_line":"plugins."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_16ea320f","line":18,"updated":"2014-12-09 19:44:46.000000000","message":"H404?","commit_id":"ff4bc5f95acd1e3034a74709e560402b1c1416d6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"35873f82cb907a243e3785dc8f07a681439d037b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"load_tests \u003d testscenarios.load_tests_apply_scenarios"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class PluginClient(base_v2.BaseNeutronClient):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def ctx(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_a0282d34","line":51,"updated":"2015-01-01 23:22:02.000000000","message":"I am assuming there will be classes for subnet, ports, etc. APIs too? Do you want a more specific class name here?","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"load_tests \u003d testscenarios.load_tests_apply_scenarios"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class PluginClient(base_v2.BaseNeutronClient):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def ctx(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_723ee5b9","line":51,"in_reply_to":"3a961159_a0282d34","updated":"2015-01-06 02:31:51.000000000","message":"The intent is to have a single client, not one that is resource-specific, so the generic name is very much intentional.  Future efforts are likely to follow the example of the tempest rest client [1], which dynamically binds as many methods as possible rather than defining them statically.\n\n1: https://github.com/openstack/tempest/blob/master/tempest/services/network/json/network_client.py","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def ctx(self):"},{"line_number":55,"context_line":"        if not hasattr(self, \u0027_ctx\u0027):"},{"line_number":56,"context_line":"            self._ctx \u003d context.Context(\u0027\u0027, \u0027test-tenant\u0027)"},{"line_number":57,"context_line":"        return self._ctx"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_35a9b9dd","line":56,"updated":"2015-01-05 16:02:25.000000000","message":"shouldn\u0027t the tenant also be generated using get_rand_name?","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def ctx(self):"},{"line_number":55,"context_line":"        if not hasattr(self, \u0027_ctx\u0027):"},{"line_number":56,"context_line":"            self._ctx \u003d context.Context(\u0027\u0027, \u0027test-tenant\u0027)"},{"line_number":57,"context_line":"        return self._ctx"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_32a7fd0c","line":56,"in_reply_to":"3a961159_35a9b9dd","updated":"2015-01-06 02:31:51.000000000","message":"In the case of the plugin-targeting tests, we don\u0027t care about uniqueness because each tests is cleanly isolated using a fixture db.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def setUp(self):"},{"line_number":109,"context_line":"        super(TestPluginApi, self).setUp()"},{"line_number":110,"context_line":"        self.setup_config()"},{"line_number":111,"context_line":"        testlib_api.configure_db(self)"},{"line_number":112,"context_line":"        self.setup_coreplugin(self.plugin_conf.plugin_name)"},{"line_number":113,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":114,"context_line":"        self.plugin_conf.setUp(self)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_7a71700b","line":111,"updated":"2015-01-05 16:02:25.000000000","message":"I am at a loss as to why configure_db exists. The alternative of leaving SqlTestCase as it was before this change, having TestPluginAPI inherit from SqlTestCase as well, and calling setup_config() before the call to super().setup() seems to work for me.\n\nThough I\u0027m probably missing something, so clarifications would be great :)","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def setUp(self):"},{"line_number":109,"context_line":"        super(TestPluginApi, self).setUp()"},{"line_number":110,"context_line":"        self.setup_config()"},{"line_number":111,"context_line":"        testlib_api.configure_db(self)"},{"line_number":112,"context_line":"        self.setup_coreplugin(self.plugin_conf.plugin_name)"},{"line_number":113,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":114,"context_line":"        self.plugin_conf.setUp(self)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_0d410663","line":111,"in_reply_to":"3a961159_7a71700b","updated":"2015-01-06 02:31:51.000000000","message":"This class doesn\u0027t extend BaseTestCase - BaseTestApi extends SubBaseTestCase instead to prevent import errors  when running against Tempest.  So, my goal here was to do some of the same setup as BaseTestCase without calling anything twice.  That said, I\u0027ve seen the error of my ways and I\u0027ll change things around to hopefully be cleaner (and better documented).","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"35873f82cb907a243e3785dc8f07a681439d037b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        super(TestPluginApi, self).setUp()"},{"line_number":110,"context_line":"        self.setup_config()"},{"line_number":111,"context_line":"        testlib_api.configure_db(self)"},{"line_number":112,"context_line":"        self.setup_coreplugin(self.plugin_conf.plugin_name)"},{"line_number":113,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":114,"context_line":"        self.plugin_conf.setUp(self)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_e01f95b6","line":112,"updated":"2015-01-01 23:22:02.000000000","message":"As far as I can tell, plugin_conf is not a class member. Is this part of the #TODO from line 41?","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        super(TestPluginApi, self).setUp()"},{"line_number":110,"context_line":"        self.setup_config()"},{"line_number":111,"context_line":"        testlib_api.configure_db(self)"},{"line_number":112,"context_line":"        self.setup_coreplugin(self.plugin_conf.plugin_name)"},{"line_number":113,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":114,"context_line":"        self.plugin_conf.setUp(self)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_b2a68da9","line":112,"in_reply_to":"3a961159_e01f95b6","updated":"2015-01-06 02:31:51.000000000","message":"It\u0027s actually defined on line 99 and applied to the class by testscenarios.  That said, I can understand your confusion given the identically-named module variable, so I\u0027ll fix that.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"neutron/tests/unit/linuxbridge/test_linuxbridge_plugin.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2ece109158d2727b0afc596e33db20f88b5d34f9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def setUp(self, parent_setup\u003dNone):"},{"line_number":40,"context_line":"        if parent_setup:"},{"line_number":41,"context_line":"            parent_setup()"},{"line_number":42,"context_line":"        self.port_create_status \u003d \u0027DOWN\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class LinuxBridgePluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2Bf60%3D","line":42,"updated":"2014-03-26 11:43:54.000000000","message":"where is this used?","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"378d95a39c3cdd75add78ee500d024e97267be09","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def setUp(self, parent_setup\u003dNone):"},{"line_number":40,"context_line":"        if parent_setup:"},{"line_number":41,"context_line":"            parent_setup()"},{"line_number":42,"context_line":"        self.port_create_status \u003d \u0027DOWN\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class LinuxBridgePluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2BcBA%3D","line":42,"in_reply_to":"AAAAWH%2F%2Bf60%3D","updated":"2014-03-26 19:38:45.000000000","message":"This class  extracts the setup of the class below so it can be reused for the retargetable testing.  See test_v2_plugin.","commit_id":"65dfec41c839143cbc7437376630e0e93b3d56de"}],"neutron/tests/unit/ml2/test_ml2_plugin.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"35873f82cb907a243e3785dc8f07a681439d037b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    plugin_name \u003d PLUGIN_NAME"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"},{"line_number":67,"context_line":"    def setUp(self, parent_setup\u003dNone):"},{"line_number":68,"context_line":"        if parent_setup:"},{"line_number":69,"context_line":"            parent_setup()"},{"line_number":70,"context_line":"        self.port_create_status \u003d \u0027DOWN\u0027"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_a0858dd0","line":67,"updated":"2015-01-01 23:22:02.000000000","message":"The name \u0027self\u0027 for the first argument here is a bit deceptive. Maybe name it \u0027plugin_test_case\u0027?","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    plugin_name \u003d PLUGIN_NAME"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"},{"line_number":67,"context_line":"    def setUp(self, parent_setup\u003dNone):"},{"line_number":68,"context_line":"        if parent_setup:"},{"line_number":69,"context_line":"            parent_setup()"},{"line_number":70,"context_line":"        self.port_create_status \u003d \u0027DOWN\u0027"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_92e35133","line":67,"in_reply_to":"3a961159_a0858dd0","updated":"2015-01-06 02:31:51.000000000","message":"Done","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        config.cfg.CONF.set_override(\u0027network_vlan_ranges\u0027,"},{"line_number":95,"context_line":"                                     [self.phys_vrange, self.phys2_vrange],"},{"line_number":96,"context_line":"                                     group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":97,"context_line":"        parent_setup \u003d functools.partial("},{"line_number":98,"context_line":"            super(Ml2PluginV2TestCase, self).setUp,"},{"line_number":99,"context_line":"            plugin\u003dMl2PluginConf.plugin_name,"},{"line_number":100,"context_line":"            service_plugins\u003dservice_plugins,"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_f5cc91bd","line":97,"updated":"2015-01-05 16:02:25.000000000","message":"I\u0027m not sure why these changes are needed. Can you clarify?","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        config.cfg.CONF.set_override(\u0027network_vlan_ranges\u0027,"},{"line_number":95,"context_line":"                                     [self.phys_vrange, self.phys2_vrange],"},{"line_number":96,"context_line":"                                     group\u003d\u0027ml2_type_vlan\u0027)"},{"line_number":97,"context_line":"        parent_setup \u003d functools.partial("},{"line_number":98,"context_line":"            super(Ml2PluginV2TestCase, self).setUp,"},{"line_number":99,"context_line":"            plugin\u003dMl2PluginConf.plugin_name,"},{"line_number":100,"context_line":"            service_plugins\u003dservice_plugins,"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_52964995","line":97,"in_reply_to":"3a961159_f5cc91bd","updated":"2015-01-06 02:31:51.000000000","message":"This is a hack to ensure that the api tests and the unit tests can share the same plugin configuration.  Future iterations are likely to formalize how plugins are commonly configured across different types of testing.\n\nI\u0027ve refactored this and included a bit more documentation - let me know if it helps.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"neutron/tests/unit/openvswitch/test_openvswitch_plugin.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"678620a34015fb1bb4413ee85fa99ac8a532de5e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.tests.unit import test_security_groups_rpc as test_sg_rpc"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OvsPluginConf(object):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    plugin_name \u003d (\u0027neutron.plugins.openvswitch.\u0027"},{"line_number":30,"context_line":"                   \u0027ovs_neutron_plugin.OVSNeutronPluginV2\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_8943a5af","line":27,"updated":"2014-08-13 11:35:03.000000000","message":"Code duplication with test_linuxbridge_plugin.py:LinuxBridgePluginConf, specifically only the plugin_name changes between the two. Perhaps make a baseclass?","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"a6495306ca9a27926883d4fda284cdb9c5d3e984","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.tests.unit import test_security_groups_rpc as test_sg_rpc"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OvsPluginConf(object):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    plugin_name \u003d (\u0027neutron.plugins.openvswitch.\u0027"},{"line_number":30,"context_line":"                   \u0027ovs_neutron_plugin.OVSNeutronPluginV2\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1abeadc6_2aa719a8","line":27,"in_reply_to":"baada198_8943a5af","updated":"2014-08-23 13:47:51.000000000","message":"I don\u0027t think I have a sufficiently broad view of how plugins configure themselves in tests to generalize yet.  The linuxbridge and ovs plugins are going to be removed along with their tests this cycle, so I don\u0027t think they are good examples to work from.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"678620a34015fb1bb4413ee85fa99ac8a532de5e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class OvsPluginConf(object):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    plugin_name \u003d (\u0027neutron.plugins.openvswitch.\u0027"},{"line_number":30,"context_line":"                   \u0027ovs_neutron_plugin.OVSNeutronPluginV2\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"},{"line_number":33,"context_line":"    def setUp(self, parent_setup\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_49d50db7","line":30,"updated":"2014-08-13 11:35:03.000000000","message":"Consistency - in test_linuxbridge_plugin.py, this variable is defined as a global PLUGIN_NAME outside the class, but here it is defined in-class.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"a6495306ca9a27926883d4fda284cdb9c5d3e984","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class OvsPluginConf(object):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    plugin_name \u003d (\u0027neutron.plugins.openvswitch.\u0027"},{"line_number":30,"context_line":"                   \u0027ovs_neutron_plugin.OVSNeutronPluginV2\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @staticmethod"},{"line_number":33,"context_line":"    def setUp(self, parent_setup\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1abeadc6_6a959131","line":30,"in_reply_to":"baada198_49d50db7","updated":"2014-08-23 13:47:51.000000000","message":"My goal was to change the configuration as little as possible - just enough to allow it to be reused across the existing tests and the retartegable one introduced by this change.  If there are inconsistencies, it\u0027s because I\u0027m maintaining them rather than creating them, and I think resolving test configuration inconsistencies can be an effort separate from the introduction of retargetable testing.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90cddb50067979fb900ce993069e8d31c681a21e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.port_create_status \u003d \u0027DOWN\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class OpenvswitchPluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        OvsPluginConf.setUp(self, parent_setup\u003dfunctools.partial("}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_e5e7c810","line":39,"updated":"2014-05-09 20:19:11.000000000","message":"this kind of change will probably cause some loss of unit test coverage.\nIf that is correct, what is your strategy to address this problem?","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"f50530d54bebe232b2bbf316759e7358d90f6642","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.port_create_status \u003d \u0027DOWN\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class OpenvswitchPluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        OvsPluginConf.setUp(self, parent_setup\u003dfunctools.partial("}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_d1545fc8","line":39,"in_reply_to":"7adec928_e5e7c810","updated":"2014-07-29 22:51:01.000000000","message":"I\u0027m not sure why you think this change implies any loss of unit test coverage.  The changes to this file are simply so the configuration can be shared between unit and functional tests.\n\nOr are you concerned that this change implies eventual removal of duplicative unit tests?  I think it will be up to reviewers to ensure that test removals are only performed when no loss of coverage will result.","commit_id":"1b4dca9a78b403ecabad7b787f6be85c017594f5"}],"neutron/tests/unit/test_plugin_api.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8fab6f1a2defc3517856d45b9a61e5eba6cf11e9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def create_network(self, **kwargs):"},{"line_number":81,"context_line":"        network \u003d self._create_network(**kwargs)"},{"line_number":82,"context_line":"        self.test_case.addCleanup(functools.partial(self._cleanup_network,"},{"line_number":83,"context_line":"                                                    network.id))"},{"line_number":84,"context_line":"        return network"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def update_network(self, id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FpLY%3D","line":83,"updated":"2014-02-11 19:53:41.000000000","message":"Why not just addCleanup(self._cleanup_network, network.id)?","commit_id":"9c4d5825676cbcc40ccad6a5fadd667343a1f214"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8fab6f1a2defc3517856d45b9a61e5eba6cf11e9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # Internal method - use create_network() instead"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # Supply defaults that are expected to be set by the api"},{"line_number":151,"context_line":"        # framwork"},{"line_number":152,"context_line":"        kwargs.setdefault(\u0027admin_state_up\u0027, True)"},{"line_number":153,"context_line":"        kwargs.setdefault(\u0027shared\u0027, False)"},{"line_number":154,"context_line":"        data \u003d dict(network\u003dkwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FpKw%3D","line":151,"updated":"2014-02-11 19:53:41.000000000","message":"s/framwork/framework/","commit_id":"9c4d5825676cbcc40ccad6a5fadd667343a1f214"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8fab6f1a2defc3517856d45b9a61e5eba6cf11e9","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def delete_network(self, id, _expected_status\u003d\u0027204\u0027):"},{"line_number":258,"context_line":"        resp, body \u003d self.client.delete_network(id)"},{"line_number":259,"context_line":"        self.test_case.assertEqual(_expected_status, resp[\u0027status\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class TestApi(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FpEQ%3D","line":259,"updated":"2014-02-11 19:53:41.000000000","message":"So the main issue I have with this is that this makes a hard dependency between the Neutron source code and Tempest. Currently, Tempest does not depend on Neutron (only python-neutronclient for scenario tests). And doing things this way means we would be dependent on code in the core projects, and further, if we wanted to make changes in how Tempest tested a core project API, we would need to make changes in each of the projects instead of just in Tempest.\n\nWe wouldn\u0027t be able to do central refactoring of clients, like is being done in this patch:\n\nhttps://review.openstack.org/#/c/62923/\n\nDoing the same refactoring when these classes are in the core projects\u0027 trees would mean half a dozen or more patches instead of just one....","commit_id":"9c4d5825676cbcc40ccad6a5fadd667343a1f214"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8fab6f1a2defc3517856d45b9a61e5eba6cf11e9","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.client.delete_network(net.id)"},{"line_number":295,"context_line":"        with testtools.ExpectedException(self.client.NetworkNotFound,"},{"line_number":296,"context_line":"                                         msg\u003d\u0027Network was not deleted\u0027):"},{"line_number":297,"context_line":"            self.client.get_network(net.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FpHE%3D","line":297,"updated":"2014-02-11 19:53:41.000000000","message":"I\u0027m pretty sure this isn\u0027t what I would categorize as a \"unit test\". Perhaps have a functional test directory in neutron/tests/ to place things like this (where there is no mocking or stubbing)","commit_id":"9c4d5825676cbcc40ccad6a5fadd667343a1f214"}],"neutron/tests/unit/testlib_api.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bfb7a9f45d48ff62a12566120931e82da71481cb","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def unregister_models():"},{"line_number":62,"context_line":"        \"\"\"Unregister all data models.\"\"\""},{"line_number":63,"context_line":"        model_base.BASEV2.metadata.drop_all(engine)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    test_case.addCleanup(unregister_models)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_1e30d106","line":63,"updated":"2014-10-29 05:34:15.000000000","message":"I think this needs a rebase. We no longer run drop_all to clear the tables.","commit_id":"ab73abb3364bc68ca55fbbbe98d280f0ce732d5e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7de13d359151cca65ac073724415ad3e64d44ad8","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def unregister_models():"},{"line_number":62,"context_line":"        \"\"\"Unregister all data models.\"\"\""},{"line_number":63,"context_line":"        model_base.BASEV2.metadata.drop_all(engine)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    test_case.addCleanup(unregister_models)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8c0949_92f90050","line":63,"in_reply_to":"9aa7fdbe_1e30d106","updated":"2014-10-31 00:41:01.000000000","message":"Done","commit_id":"ab73abb3364bc68ca55fbbbe98d280f0ce732d5e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cf1442c4114e5bce93a6afefd011dc4b156870f1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return req"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def configure_db(test_case):"},{"line_number":56,"context_line":"    # Register all data models"},{"line_number":57,"context_line":"    engine \u003d db_api.get_engine()"},{"line_number":58,"context_line":"    if not SqlTestCase._TABLES_ESTABLISHED:"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_35be1901","line":55,"updated":"2015-01-05 16:02:25.000000000","message":"Did you consider making configure_db a staticmethod of SqlTestCase instead?","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0089bae94f7a0de804b88ac0b165635b8c1c9a2e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return req"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def configure_db(test_case):"},{"line_number":56,"context_line":"    # Register all data models"},{"line_number":57,"context_line":"    engine \u003d db_api.get_engine()"},{"line_number":58,"context_line":"    if not SqlTestCase._TABLES_ESTABLISHED:"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a961159_0d0f463a","line":55,"in_reply_to":"3a961159_35be1901","updated":"2015-01-06 02:31:51.000000000","message":"As per a previous comment, I\u0027ll revert this.","commit_id":"e3e1ccd38ab74505cf4cd7a3327a52f29c0576c4"}],"tox.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0fe2cbdb701b32851f8e1a79e3bd904043a1dae5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[testenv:api]"},{"line_number":28,"context_line":"setenv \u003d OS_TEST_PATH\u003d./neutron/tests/api"},{"line_number":29,"context_line":"commands \u003d"},{"line_number":30,"context_line":"  python -m neutron.openstack.common.lockutils python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[testenv:functional]"}],"source_content_type":"text/x-properties","patch_set":27,"id":"3a961159_38173053","line":29,"updated":"2014-12-17 15:40:03.000000000","message":"you may want to get rid of \u0027commands\u0027","commit_id":"0e330fb67065d7a1f4998718fa536d7cc10a83d5"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"dbd12a56284b67430211a9c0615a652e17e90232","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[testenv:api]"},{"line_number":28,"context_line":"setenv \u003d OS_TEST_PATH\u003d./neutron/tests/api"},{"line_number":29,"context_line":"commands \u003d"},{"line_number":30,"context_line":"  python -m neutron.openstack.common.lockutils python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[testenv:functional]"}],"source_content_type":"text/x-properties","patch_set":27,"id":"3a961159_2ebd2003","line":29,"in_reply_to":"3a961159_38173053","updated":"2014-12-31 01:37:08.000000000","message":"Done","commit_id":"0e330fb67065d7a1f4998718fa536d7cc10a83d5"}]}
