)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d2e5c82c75d4c3b553f1be33cb5abc77dd6fc536","unresolved":false,"context_lines":[{"line_number":16,"context_line":"[1]: https://github.com/ovn-org/ovn/commit/6ec0b82038052866533f12823fe410308b3e457a"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I62e4e98556c71312a7cf85b6246ddbecbc59a039"},{"line_number":19,"context_line":"Related-Bug: #1852221"},{"line_number":20,"context_line":"Closes-Bug: #1877195"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_b97cdd20","line":19,"updated":"2020-05-07 01:53:01.000000000","message":"Related-Bug: #1871239 too","commit_id":"1a552daee2c20cf6d40010962daba0f808baaee4"}],"devstack/lib/ovn_agent":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d2e5c82c75d4c3b553f1be33cb5abc77dd6fc536","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f493fa4_79b1b5e1","line":167,"updated":"2020-05-07 01:53:01.000000000","message":"I had asked Flavio about this offline, having both versions here.  The answer is \"if we use new devstack with an older version of ovn, of13 will be needed, it does not hurt to have both.... i am suspecting there is users of older ovn in devstack, otherwise they would have been broken\"","commit_id":"1a552daee2c20cf6d40010962daba0f808baaee4"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"9a62093a89d0e8515bc897ee8bbe24e9bf18dfe7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f493fa4_aea49009","line":167,"in_reply_to":"1f493fa4_79b1b5e1","updated":"2020-05-07 08:27:15.000000000","message":"Can\u0027t we just remove this? If we wait until ovn-controller starts, it\u0027ll create the integration bridge accordingly. I\u0027d be in favor of doing that and we\u0027ll achieve backwards compatibility\n\nhttps://github.com/ovn-org/ovn/blob/6ec0b82038052866533f12823fe410308b3e457a/controller/ovn-controller.c#L317","commit_id":"1a552daee2c20cf6d40010962daba0f808baaee4"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"6c8e027d705053bf57617174fca2b869ea86ca64","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f493fa4_ceabdc1b","line":167,"in_reply_to":"1f493fa4_aea49009","updated":"2020-05-07 09:14:16.000000000","message":"We can try ++","commit_id":"1a552daee2c20cf6d40010962daba0f808baaee4"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"ff5af57ac947c1ee0c9cefb0198972155f82cc2f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f493fa4_91b455d3","line":167,"in_reply_to":"1f493fa4_ceabdc1b","updated":"2020-05-07 09:56:00.000000000","message":"Ah, yes. Having ovn-controller in charge of creating br-int would be a good thing. Less is more. ;)\n\nSo if we did that, we are still in need to manage create_public_bridge() below, right? I am assuming ovn-controller would never create that while still need to talk to it for adding a patch port.","commit_id":"1a552daee2c20cf6d40010962daba0f808baaee4"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"62aaa714806836f3e3f9a4834d98883b1ad50b04","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":651,"context_line":"        fi"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # Note: ovn-controller will create and configure br-int once it is started."},{"line_number":654,"context_line":"        # So, there is no need to explicitly create it here."},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        local ovscmd\u003d\"$OVS_SBINDIR/ovs-vswitchd --log-file --pidfile --detach\""},{"line_number":657,"context_line":"        _run_process ovs-vswitchd \"$ovscmd\" \"\" \"$STACK_GROUP\" \"root\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f493fa4_a49e7104","line":654,"range":{"start_line":653,"start_character":0,"end_line":654,"end_character":60},"updated":"2020-05-07 11:02:38.000000000","message":"Shall we wait here or somewhere else for the br-int to be created? Not sure if it\u0027s needed though\nIf not, maybe we can also drop this comment here as well? Doesn\u0027t harm anyways","commit_id":"3fbb671b2279b38b994d34d707b25c30142da3d3"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"5134ec806472aa26020a74118159ce929d7cf88c","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":651,"context_line":"        fi"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # Note: ovn-controller will create and configure br-int once it is started."},{"line_number":654,"context_line":"        # So, there is no need to explicitly create it here."},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"        local ovscmd\u003d\"$OVS_SBINDIR/ovs-vswitchd --log-file --pidfile --detach\""},{"line_number":657,"context_line":"        _run_process ovs-vswitchd \"$ovscmd\" \"\" \"$STACK_GROUP\" \"root\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f493fa4_62ef3987","line":654,"range":{"start_line":653,"start_character":0,"end_line":654,"end_character":60},"in_reply_to":"1f493fa4_a49e7104","updated":"2020-05-07 12:38:46.000000000","message":"ack. I do not think waiting is needed. the only place I see it potentially affected is on line 760 below. I will add it to the comment.","commit_id":"3fbb671b2279b38b994d34d707b25c30142da3d3"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e615347dc5fd21975c32cbbf8c0f2327ebff2b94","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1f493fa4_f8fc96b6","line":167,"range":{"start_line":167,"start_character":103,"end_line":167,"end_character":124},"updated":"2020-05-07 13:44:20.000000000","message":"This will not affect br-int not patch port creation on br-ex.\nPlease let me know if you think we should do this, or leave it as it was originally: protocols\u003dOpenFlow13","commit_id":"589dcac2719a380af99dc6a01b8f4047290db674"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e615347dc5fd21975c32cbbf8c0f2327ebff2b94","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    local ext_gw_ifc"},{"line_number":248,"context_line":"    ext_gw_ifc\u003d$(get_ext_gw_interface)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    ovs-vsctl --may-exist add-br $ext_gw_ifc -- set bridge $ext_gw_ifc protocols\u003dOpenFlow13,OpenFlow15"},{"line_number":251,"context_line":"    ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d$PHYSICAL_NETWORK:$ext_gw_ifc"},{"line_number":252,"context_line":"    if [ -n \"$FLOATING_RANGE\" ]; then"},{"line_number":253,"context_line":"        local cidr_len\u003d${FLOATING_RANGE#*/}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1f493fa4_3830be9e","line":250,"range":{"start_line":250,"start_character":81,"end_line":250,"end_character":102},"updated":"2020-05-07 13:44:20.000000000","message":"same.","commit_id":"589dcac2719a380af99dc6a01b8f4047290db674"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"247cfcd9f97465d92407ba5dc2e07f42469419aa","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_738549cf","line":167,"updated":"2020-05-07 14:24:12.000000000","message":"I\u0027m confused. Shall we remove this then based on what you wrote in the commit message?","commit_id":"ba16d2fc742bbb9c80f1aec2cbb6de8033d051e5"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"a36c5b3bff306e75cdf3efbd4d820bc90edb385b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_b78cdc7f","line":167,"in_reply_to":"1f493fa4_738549cf","updated":"2020-05-07 14:40:37.000000000","message":"Oh ok thanks for clarifying offline. This would still be called for vtep and provider bridges so we need to keep it.","commit_id":"ba16d2fc742bbb9c80f1aec2cbb6de8033d051e5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ef892f828e28ef53fa42d05b476ebb519b4f4b2b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_49a96fdb","line":167,"in_reply_to":"1f493fa4_771c1413","updated":"2020-05-08 10:17:54.000000000","message":"Cool, thanks for clarifying!","commit_id":"ba16d2fc742bbb9c80f1aec2cbb6de8033d051e5"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e6127845a14a9b512f5bb03bbb6254ef35ef5420","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# neutron-ovs-cleanup uses the OVSDB native interface."},{"line_number":165,"context_line":"function ovn_base_setup_bridge {"},{"line_number":166,"context_line":"    local bridge\u003d$1"},{"line_number":167,"context_line":"    local addbr_cmd\u003d\"ovs-vsctl --no-wait -- --may-exist add-br $bridge -- set bridge $bridge protocols\u003dOpenFlow13,OpenFlow15\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [ \"$OVS_DATAPATH_TYPE\" !\u003d \"system\" ] ; then"},{"line_number":170,"context_line":"        addbr_cmd\u003d\"$addbr_cmd -- set Bridge $bridge datapath_type\u003d${OVS_DATAPATH_TYPE}\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_771c1413","line":167,"in_reply_to":"1f493fa4_b78cdc7f","updated":"2020-05-07 14:46:31.000000000","message":"correct! this function would still be used for vtep and provider.","commit_id":"ba16d2fc742bbb9c80f1aec2cbb6de8033d051e5"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"247cfcd9f97465d92407ba5dc2e07f42469419aa","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    local ext_gw_ifc"},{"line_number":248,"context_line":"    ext_gw_ifc\u003d$(get_ext_gw_interface)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    ovs-vsctl --may-exist add-br $ext_gw_ifc -- set bridge $ext_gw_ifc protocols\u003dOpenFlow13,OpenFlow15"},{"line_number":251,"context_line":"    ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d$PHYSICAL_NETWORK:$ext_gw_ifc"},{"line_number":252,"context_line":"    if [ -n \"$FLOATING_RANGE\" ]; then"},{"line_number":253,"context_line":"        local cidr_len\u003d${FLOATING_RANGE#*/}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_935bb585","line":250,"range":{"start_line":250,"start_character":92,"end_line":250,"end_character":102},"updated":"2020-05-07 14:24:12.000000000","message":"This doesn\u0027t harm but not needed / unrelated to the fact that OVN moved to OF15, right? ovn-controller doesn\u0027t talk OF to the provider bridges AFAIU","commit_id":"ba16d2fc742bbb9c80f1aec2cbb6de8033d051e5"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e6127845a14a9b512f5bb03bbb6254ef35ef5420","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    local ext_gw_ifc"},{"line_number":248,"context_line":"    ext_gw_ifc\u003d$(get_ext_gw_interface)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    ovs-vsctl --may-exist add-br $ext_gw_ifc -- set bridge $ext_gw_ifc protocols\u003dOpenFlow13,OpenFlow15"},{"line_number":251,"context_line":"    ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d$PHYSICAL_NETWORK:$ext_gw_ifc"},{"line_number":252,"context_line":"    if [ -n \"$FLOATING_RANGE\" ]; then"},{"line_number":253,"context_line":"        local cidr_len\u003d${FLOATING_RANGE#*/}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_372bac30","line":250,"range":{"start_line":250,"start_character":92,"end_line":250,"end_character":102},"in_reply_to":"1f493fa4_935bb585","updated":"2020-05-07 14:46:31.000000000","message":"Valid point. Putting it here is more of a keeping it consistent with what we do on line 167. If others think we are better w.out OF15 or having just OF15 here please -1 this and I will make it right.","commit_id":"ba16d2fc742bbb9c80f1aec2cbb6de8033d051e5"}],"doc/source/admin/ovn/refarch/provider-networks.rst":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"62aaa714806836f3e3f9a4834d98883b1ad50b04","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#. On each compute node, create the provider bridge, map the provider"},{"line_number":28,"context_line":"   network to it, and add the underlying physical or logical (typically"},{"line_number":29,"context_line":"   a bond) network interface to it."},{"line_number":30,"context_line":"   `Recent OVN controllers \u003chttps://github.com/ovn-org/ovn/commit/6ec0b82038052866533f12823fe410308b3e457a\u003e`"},{"line_number":31,"context_line":"   use Openflow version 15, while older versions use 13. A way of"},{"line_number":32,"context_line":"   ensuring that the bridge is backward compatible is by listing"},{"line_number":33,"context_line":"   both in protocols, as shown below."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   .. code-block:: console"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_84ba556b","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":37},"updated":"2020-05-07 11:02:38.000000000","message":"I still fail to see why ovn-controller comes into picture here. ovn-controller doesn\u0027t install any flows on the provider bridge(s), it just creates patch ports between the ovn-bridge and the provider-bridge(s) when required.\nIs the patch port creation affected by the OF version?","commit_id":"3fbb671b2279b38b994d34d707b25c30142da3d3"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"5134ec806472aa26020a74118159ce929d7cf88c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#. On each compute node, create the provider bridge, map the provider"},{"line_number":28,"context_line":"   network to it, and add the underlying physical or logical (typically"},{"line_number":29,"context_line":"   a bond) network interface to it."},{"line_number":30,"context_line":"   `Recent OVN controllers \u003chttps://github.com/ovn-org/ovn/commit/6ec0b82038052866533f12823fe410308b3e457a\u003e`"},{"line_number":31,"context_line":"   use Openflow version 15, while older versions use 13. A way of"},{"line_number":32,"context_line":"   ensuring that the bridge is backward compatible is by listing"},{"line_number":33,"context_line":"   both in protocols, as shown below."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   .. code-block:: console"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_a2b78186","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":37},"in_reply_to":"1f493fa4_84ba556b","updated":"2020-05-07 12:38:46.000000000","message":"I don\u0027t think a patch port can be created in a bridge if the controller cannot connect to it to begin with. I will double check because I\u0027m second guessing myself now. ;)","commit_id":"3fbb671b2279b38b994d34d707b25c30142da3d3"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"89f52cf29733d8e9e1b238a1acb6e774d7ae0d1a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        #                 released."},{"line_number":244,"context_line":"        self.initial_protocols \u003d {"},{"line_number":245,"context_line":"            constants.OPENFLOW10, constants.OPENFLOW13, constants.OPENFLOW14,"},{"line_number":246,"context_line":"            constants.OPENFLOW15}"},{"line_number":247,"context_line":"        self.initial_protocols.add(self._highest_protocol_needed)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_c738df3c","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":32},"updated":"2020-05-07 11:42:00.000000000","message":"This is for ml2/ovs, I don\u0027t think it\u0027s a must here, is it?","commit_id":"3fbb671b2279b38b994d34d707b25c30142da3d3"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"5134ec806472aa26020a74118159ce929d7cf88c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        #                 released."},{"line_number":244,"context_line":"        self.initial_protocols \u003d {"},{"line_number":245,"context_line":"            constants.OPENFLOW10, constants.OPENFLOW13, constants.OPENFLOW14,"},{"line_number":246,"context_line":"            constants.OPENFLOW15}"},{"line_number":247,"context_line":"        self.initial_protocols.add(self._highest_protocol_needed)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_629459e9","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":32},"in_reply_to":"1f493fa4_c738df3c","updated":"2020-05-07 12:38:46.000000000","message":"ah, ack. I was not sure and wanted your eye on it and was afraid of forgetting to ask you. Let me revert this then.","commit_id":"3fbb671b2279b38b994d34d707b25c30142da3d3"}]}