)]}'
{"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0eeb6f8299beb675f64b453920d6d74fb4f82e21","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        a_config \u003d agent[\u0027configurations\u0027]"},{"line_number":180,"context_line":"        vif_type \u003d self.get_vif_type(context, agent, segment\u003dNone)"},{"line_number":181,"context_line":"        if vif_type !\u003d portbindings.VIF_TYPE_VHOST_USER:"},{"line_number":182,"context_line":"            details \u003d dict(self.vif_details)"},{"line_number":183,"context_line":"            hybrid \u003d portbindings.OVS_HYBRID_PLUG"},{"line_number":184,"context_line":"            details[hybrid] \u003d a_config.get(hybrid)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            sock_path \u003d self.agent_vhu_sockpath(agent, context.current[\u0027id\u0027])"},{"line_number":187,"context_line":"            caps \u003d a_config.get(\u0027ovs_capabilities\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_92eefcb1","line":184,"range":{"start_line":182,"start_character":12,"end_line":184,"end_character":50},"updated":"2020-05-08 13:42:44.000000000","message":"small nit: just being a bit pedantic, in one operation\n\ndetails \u003d {**self.vif_details,\n           portbindings.OVS_HYBRID_PLUG: a_config.get(hybrid)}","commit_id":"61fa6c859670dca18c90393e389bfd1969007149"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"866189c44014c1afb9e36ed9a95d2ebeb644c828","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        a_config \u003d agent[\u0027configurations\u0027]"},{"line_number":180,"context_line":"        vif_type \u003d self.get_vif_type(context, agent, segment\u003dNone)"},{"line_number":181,"context_line":"        if vif_type !\u003d portbindings.VIF_TYPE_VHOST_USER:"},{"line_number":182,"context_line":"            details \u003d dict(self.vif_details)"},{"line_number":183,"context_line":"            hybrid \u003d portbindings.OVS_HYBRID_PLUG"},{"line_number":184,"context_line":"            details[hybrid] \u003d a_config.get(hybrid)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            sock_path \u003d self.agent_vhu_sockpath(agent, context.current[\u0027id\u0027])"},{"line_number":187,"context_line":"            caps \u003d a_config.get(\u0027ovs_capabilities\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_463788e4","line":184,"range":{"start_line":182,"start_character":12,"end_line":184,"end_character":50},"in_reply_to":"1f493fa4_92eefcb1","updated":"2020-05-14 21:56:09.000000000","message":"Done","commit_id":"61fa6c859670dca18c90393e389bfd1969007149"}],"releasenotes/notes/Remove-firewall_driver-option-from-neutron-server-920564ec77503631.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"50e98977632890e3e283a5696e7ab7db67f5af7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    e.g. require hybrid plug of the ports."},{"line_number":8,"context_line":"    Possibility to report by agents if hybrid plugging is needed was added in"},{"line_number":9,"context_line":"    Newton release and usage of this option on the server\u0027s side was there"},{"line_number":10,"context_line":"    only for backward compatibility."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_3d36d9e8","line":10,"updated":"2020-05-08 14:00:00.000000000","message":"You know me, I try and fix the wording of things.  Does this work better?\n\nThe configuration option ``firewall_driver`` is no longer used by neutron-server, it only applies to the L2 agent.\nThis was required for backward-compatibility for hybrid plugging, but since the Newton release the L2 agent has been able to report hybrid plugging is needed in it\u0027s report message back to the server.","commit_id":"61fa6c859670dca18c90393e389bfd1969007149"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"866189c44014c1afb9e36ed9a95d2ebeb644c828","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    e.g. require hybrid plug of the ports."},{"line_number":8,"context_line":"    Possibility to report by agents if hybrid plugging is needed was added in"},{"line_number":9,"context_line":"    Newton release and usage of this option on the server\u0027s side was there"},{"line_number":10,"context_line":"    only for backward compatibility."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_c650b80d","line":10,"in_reply_to":"1f493fa4_3d36d9e8","updated":"2020-05-14 21:56:09.000000000","message":"Thx. As always in such cases, Your proposals are much better than mine :)","commit_id":"61fa6c859670dca18c90393e389bfd1969007149"}]}
