)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"196bc831de26820130a760a50c6fef7046cd8d27","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- get_bound_floatingips"},{"line_number":13,"context_line":"- get_bound_routers"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Those methods, using the \"QosPolicy_XXXX_Binding\" OVO interface, were"},{"line_number":16,"context_line":"retrieving all objects with a certain policy ID and then returning"},{"line_number":17,"context_line":"only the ID of the _XXXX_ object. That means to retrieve a full"},{"line_number":18,"context_line":"register list from the DB, then converted them to OVOs and extract"},{"line_number":19,"context_line":"only the _XXXX_ ID."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch retrieves only the _XXXX_ object IDs from the DB and"},{"line_number":22,"context_line":"returns the list, without the OVO conversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I891eba93b3b4abaec8ada13a032b5440cbb0548d"},{"line_number":25,"context_line":"Closes-Bug: #1877560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_b7655fe4","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":45},"updated":"2020-05-09 23:54:59.000000000","message":"I believe you can leverage \u0027get_values\u0027 (https://opendev.org/openstack/neutron/src/branch/master/neutron/objects/base.py#L646) to achieve the equivalent.\n\nAn usage example:  https://opendev.org/openstack/neutron/src/branch/master/neutron/db/ipam_backend_mixin.py#L354","commit_id":"db3040d2088c58545c0eff94dc51c1b2349afa5e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4145840b7641b4a8599add4c2bcf02d7d1a7893f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- get_bound_floatingips"},{"line_number":13,"context_line":"- get_bound_routers"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Those methods, using the \"QosPolicy_XXXX_Binding\" OVO interface, were"},{"line_number":16,"context_line":"retrieving all objects with a certain policy ID and then returning"},{"line_number":17,"context_line":"only the ID of the _XXXX_ object. That means to retrieve a full"},{"line_number":18,"context_line":"register list from the DB, then converted them to OVOs and extract"},{"line_number":19,"context_line":"only the _XXXX_ ID."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch retrieves only the _XXXX_ object IDs from the DB and"},{"line_number":22,"context_line":"returns the list, without the OVO conversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I891eba93b3b4abaec8ada13a032b5440cbb0548d"},{"line_number":25,"context_line":"Closes-Bug: #1877560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_aa0da936","line":22,"range":{"start_line":15,"start_character":0,"end_line":22,"end_character":45},"in_reply_to":"ff570b3c_b7655fe4","updated":"2020-05-13 16:32:53.000000000","message":"Right! This is the method I should use: it does not build an OVO but is part of the OVO interface. Perfect.","commit_id":"db3040d2088c58545c0eff94dc51c1b2349afa5e"}],"neutron/objects/qos/binding.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"de15720cf2c68ecc23eea6c8a70e986702f64e68","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            return []"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        return [data[0] for data in"},{"line_number":37,"context_line":"                context.session.query(cls._bound_model_id).filter_by("},{"line_number":38,"context_line":"                    policy_id\u003dpolicy_id).all()]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7774679a","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":37},"updated":"2020-05-09 23:48:45.000000000","message":"Just wondering. Why not use \u0027get_objects\u0027 in here?","commit_id":"db3040d2088c58545c0eff94dc51c1b2349afa5e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4145840b7641b4a8599add4c2bcf02d7d1a7893f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            return []"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        return [data[0] for data in"},{"line_number":37,"context_line":"                context.session.query(cls._bound_model_id).filter_by("},{"line_number":38,"context_line":"                    policy_id\u003dpolicy_id).all()]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_129feb50","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":37},"in_reply_to":"ff570b3c_7774679a","updated":"2020-05-13 16:32:53.000000000","message":"To improve the performance. With \"get_objects\" we are retrieving the DB object (the DB register plus the relationships) and then building the OVO instance. That takes more time than just retrieving one column from the model table, without the overload of the OVO layer.","commit_id":"db3040d2088c58545c0eff94dc51c1b2349afa5e"}]}