)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a66e4253309b47a61043b8cba8f3bfb5387a0cab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reraise timeout exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Catch all exceptions during get_device_details would likely cause problems when agent is starting up, because agent is going to clean stale flows eventually."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Ideally cleaning should also depend on values from failed devices but rather than sort out different situations, it might be beneficially to simply failed the sync when MQ is running abnormally."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_172b6094","line":9,"updated":"2020-05-11 12:34:08.000000000","message":"Please make line \u003c 80 chars","commit_id":"1f497adfed03958f858d8e5e16b566bd933184ed"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a66e4253309b47a61043b8cba8f3bfb5387a0cab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reraise timeout exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Catch all exceptions during get_device_details would likely cause problems when agent is starting up, because agent is going to clean stale flows eventually."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Ideally cleaning should also depend on values from failed devices but rather than sort out different situations, it might be beneficially to simply failed the sync when MQ is running abnormally."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I780a7d5f9a9c2e23ff421ecaebe6dbfbefc4450a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_42919499","line":10,"updated":"2020-05-11 12:34:08.000000000","message":"Please describe also how agent will handle new behavior.","commit_id":"1f497adfed03958f858d8e5e16b566bd933184ed"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a66e4253309b47a61043b8cba8f3bfb5387a0cab","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Catch all exceptions during get_device_details would likely cause problems when agent is starting up, because agent is going to clean stale flows eventually."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Ideally cleaning should also depend on values from failed devices but rather than sort out different situations, it might be beneficially to simply failed the sync when MQ is running abnormally."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I780a7d5f9a9c2e23ff421ecaebe6dbfbefc4450a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_a274f09a","line":12,"updated":"2020-05-11 12:34:08.000000000","message":"I thunk there is a bug for this, please link here","commit_id":"1f497adfed03958f858d8e5e16b566bd933184ed"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5ce20213ecdf01df527ca59d8eac02d407685db6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"exception just like other api did."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I780a7d5f9a9c2e23ff421ecaebe6dbfbefc4450a"},{"line_number":24,"context_line":"Partial-Bug: #726492"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_135cff49","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":20},"updated":"2020-05-12 07:40:35.000000000","message":"this is wrong bug ID, I guess this is the one: https://bugs.launchpad.net/neutron/+bug/1877248","commit_id":"085de852b8a510ae2a2ddc0ef40717b2a2d7f491"}],"neutron/agent/rpc.py":[{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"532764504510a2d5c241c67618e77ad8b4349bc4","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                # this is added to avoid unexpectedly clean stable"},{"line_number":312,"context_line":"                # flow when either MQ is working abnormally or server"},{"line_number":313,"context_line":"                # is overloaded"},{"line_number":314,"context_line":"                raise"},{"line_number":315,"context_line":"            except Exception:"},{"line_number":316,"context_line":"                LOG.exception(\"Failed to get details for device %s\", device)"},{"line_number":317,"context_line":"                result[\u0027failed_devices\u0027].append(device)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_38b757d8","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":21},"updated":"2020-05-12 14:32:20.000000000","message":"just simple raise?","commit_id":"3c9e1b0338b512cb1c25e99242a00b23492d3474"}]}