)]}'
{"devstack/lib/ovn_agent":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"0d7f2fab7d5b01f89a6749c7d6bab22d43da3d58","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# There are some ovs functions OVN depends on that must be sourced from"},{"line_number":20,"context_line":"# the ovs neutron plugins. After doing this, the OVN overrides must be"},{"line_number":21,"context_line":"# re-sourced."},{"line_number":22,"context_line":"source ${DEVSTACK_PATH}/lib/neutron_plugins/ovs_base"},{"line_number":23,"context_line":"source ${DEVSTACK_PATH}/lib/neutron_plugins/openvswitch_agent"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff570b3c_edb87f2b","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":22},"updated":"2020-05-12 13:50:41.000000000","message":"This might be not needed.","commit_id":"7e239f0c912f488da0ddf596ec5da228a33f8979"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2cba049875864ee5e9a8fed64963c69868dd495d","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    remove_ovs_packages"},{"line_number":474,"context_line":"    sudo rm -f $OVS_RUNDIR/*"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if use_new_ovn_repository; then"},{"line_number":477,"context_line":"        compile_ovs $OVN_BUILD_MODULES"},{"line_number":478,"context_line":"        compile_ovn $OVN_BUILD_MODULES"},{"line_number":479,"context_line":"    else"},{"line_number":480,"context_line":"        compile_ovs $OVN_BUILD_MODULES"},{"line_number":481,"context_line":"    fi"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    sudo mkdir -p $OVS_RUNDIR"},{"line_number":484,"context_line":"    sudo chown $(whoami) $OVS_RUNDIR"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"bf51134e_35658046","line":481,"range":{"start_line":476,"start_character":0,"end_line":481,"end_character":6},"updated":"2020-06-18 09:26:06.000000000","message":"How about:\n\n compile_ovs $OVN_BUILD_MODULES\n if use_new_ovn_repository; then\n     compile_ovn $OVN_BUILD_MODULES\n fi","commit_id":"70ff2586490dcbc0319a4619d772c6c436c26a0f"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"78d06164878fbf32b44b81c9de3212434e1a3102","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    remove_ovs_packages"},{"line_number":474,"context_line":"    sudo rm -f $OVS_RUNDIR/*"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if use_new_ovn_repository; then"},{"line_number":477,"context_line":"        compile_ovs $OVN_BUILD_MODULES"},{"line_number":478,"context_line":"        compile_ovn $OVN_BUILD_MODULES"},{"line_number":479,"context_line":"    else"},{"line_number":480,"context_line":"        compile_ovs $OVN_BUILD_MODULES"},{"line_number":481,"context_line":"    fi"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    sudo mkdir -p $OVS_RUNDIR"},{"line_number":484,"context_line":"    sudo chown $(whoami) $OVS_RUNDIR"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"bf51134e_582e6b43","line":481,"range":{"start_line":476,"start_character":0,"end_line":481,"end_character":6},"in_reply_to":"bf51134e_35658046","updated":"2020-06-18 11:38:22.000000000","message":":) yeah, I\u0027ll update it.","commit_id":"70ff2586490dcbc0319a4619d772c6c436c26a0f"}],"roles/configure_functional_tests/tasks/main.yaml":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a8fa55ff17c9f465064a08eec3aaeb0bc66f0e91","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        DEVSTACK_PATH\u003d{{ devstack_dir }}"},{"line_number":13,"context_line":"        TOP_DIR\u003d{{ devstack_dir }}"},{"line_number":14,"context_line":"        VENV\u003d{{ tests_venv }}"},{"line_number":15,"context_line":"        STACK_USER\u003d{{ stack_user }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        source $DEVSTACK_PATH/functions"},{"line_number":18,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_7369f023","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":18},"updated":"2020-05-12 15:18:34.000000000","message":"There is no ansible_environment stack_user.\nThe stack_user is by default \u0027stack\u0027, but it is defined with local.conf and/or stack.sh.","commit_id":"7e239f0c912f488da0ddf596ec5da228a33f8979"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a341c5b003932171601584a38d0fb2cbb8188501","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        source $DEVSTACK_PATH/functions"},{"line_number":18,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":19,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovn_agent"},{"line_number":20,"context_line":"        source $NEUTRON_PATH/tools/configure_for_func_testing.sh"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        configure_host_for_func_testing"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf51134e_32091695","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":51},"updated":"2020-06-18 08:23:23.000000000","message":"May be deleted from here.","commit_id":"f9be1496200ca1e45979fefbe540606b2be58ff6"}],"tools/configure_for_func_testing.sh":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"0d632fb5721399314de507f73376a8af7df31883","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        install_package $PACKAGES"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":113,"context_line":"        remove_ovs_packages"},{"line_number":114,"context_line":"        compile_ovn False /usr /var"},{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        PACKAGES\u003d$(get_packages general,neutron,q-agt,q-l3,openvswitch)"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_70cf0ab0","line":113,"updated":"2020-05-13 13:04:02.000000000","message":"I don\u0027t know how ovs packages may get pre-installed so we need to remove them. If someone knows could tell us if we need to remove ovn packages as well...","commit_id":"eb164f058ffd5cfe46bca11c9e75275fa5193d2b"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a19663aad903db48464378c92593add8f1087ee1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        # installing neutron, so their installation is conditional to"},{"line_number":305,"context_line":"        # minimize the work to do on a devstack-configured host."},{"line_number":306,"context_line":"        _install_base_deps"},{"line_number":307,"context_line":"        _install_agent_deps"},{"line_number":308,"context_line":"        _install_rpc_backend"},{"line_number":309,"context_line":"    fi"},{"line_number":310,"context_line":"    _install_post_devstack"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_f6995279","line":307,"range":{"start_line":307,"start_character":8,"end_line":307,"end_character":27},"updated":"2020-05-13 14:31:01.000000000","message":"_install_agent_deps -\u003e install_neutron_agent_packages -\u003e \n\n2020-05-13 11:41:56.876611 | controller | + lib/neutron-legacy:install_neutron_agent_packages_mutnauq:453 :   neutron_plugin_install_agent_packages\n2020-05-13 11:41:56.878490 | controller | + lib/neutron_plugins/openvswitch_agent:neutron_plugin_install_agent_packages:17 :   _neutron_ovs_base_install_agent_packages\n2020-05-13 11:41:56.880805 | controller | ++ lib/neutron_plugins/ovs_base:_neutron_ovs_base_install_agent_packages:64 :   get_packages openvswitch\n2020-05-13 11:41:56.882995 | controller | ++ functions-common:get_packages:1186       :   local xtrace","commit_id":"eb164f058ffd5cfe46bca11c9e75275fa5193d2b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2cba049875864ee5e9a8fed64963c69868dd495d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        install_package $PACKAGES"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        source $NEUTRON_PATH/devstack/lib/ovs"},{"line_number":112,"context_line":"        remove_ovs_packages"},{"line_number":113,"context_line":"        OVS_BRANCH\u003d\"v2.12.0\""},{"line_number":114,"context_line":"        compile_ovs False /usr /var"},{"line_number":115,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bf51134e_75d418be","side":"PARENT","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":27},"updated":"2020-06-18 09:26:06.000000000","message":"Don\u0027t we still need this?","commit_id":"7d8f400791707e5db7839dcdf3ef4dbbd1dd39bc"}]}