)]}'
{"neutron/plugins/ml2/drivers/mech_sriov/agent/eswitch_manager.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"af76755193f273d49ba3a1bb89c9de5c9c1a9c7d","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        @param pci_slot: Virtual Function address"},{"line_number":213,"context_line":"        @param rate_type: device rate name type. Could be \u0027max_tx_rate\u0027 and"},{"line_number":214,"context_line":"                          \u0027min_tx_rate\u0027 (\u0027rate\u0027 is not supported anymore)."},{"line_number":215,"context_line":"        @param rate_kbps: device rate in kbps"},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        vf_index \u003d self._get_vf_index(pci_slot)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_7936f1e9","line":214,"range":{"start_line":214,"start_character":41,"end_line":214,"end_character":72},"updated":"2020-06-10 13:23:38.000000000","message":"No risk to break existing conf or 3rd party code?\nFrom a quick code check, it seems to be fine (constant is still called IP_LINK_CAPABILITY_RATE, and no other calls found in codesearch)","commit_id":"87c58b339d3a96cf176eee8f6940ceb740bf520e"}],"neutron/services/logapi/drivers/openvswitch/ovs_firewall_log.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d85a6631e09c5d2f1e9f8e35cf88b0bdc8ac6da","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        journal_handler \u003d handlers.OSJournalHandler()"},{"line_number":63,"context_line":"        LOG.logger.addHandler(journal_handler)"},{"line_number":64,"context_line":"    else:"},{"line_number":65,"context_line":"        syslog_handler \u003d handlers.OSSysLogHandler()"},{"line_number":66,"context_line":"        LOG.logger.addHandler(syslog_handler)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_d8f5c684","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":51},"updated":"2020-06-05 08:00:26.000000000","message":"pylint fails here:\nneutron/services/logapi/drivers/openvswitch/ovs_firewall_log.py:62:26: E1120: \u001b[1;31mNo value for argument \u0027facility\u0027 in constructor call\u001b[0m (\u001b[1;31mno-value-for-parameter\u001b[0m)\n\nbut here:\nhttps://opendev.org/openstack/oslo.log/src/branch/stable/train/oslo_log/handlers.py#L59\n\n__init__ do not expect facility.... so I don\u0027t understand","commit_id":"5df65489dc64fc7ec305a3c711bbb6c41ffe488b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c101262a668e8ba5f0271b47416fa586d867c608","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        journal_handler \u003d handlers.OSJournalHandler()"},{"line_number":63,"context_line":"        LOG.logger.addHandler(journal_handler)"},{"line_number":64,"context_line":"    else:"},{"line_number":65,"context_line":"        syslog_handler \u003d handlers.OSSysLogHandler()"},{"line_number":66,"context_line":"        LOG.logger.addHandler(syslog_handler)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_abfd1a6f","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":51},"in_reply_to":"ff570b3c_d8f5c684","updated":"2020-06-05 09:19:11.000000000","message":"I talked to bnemec about this and they were going to propose a bump of oslo.log in stable branches of requirements","commit_id":"5df65489dc64fc7ec305a3c711bbb6c41ffe488b"}]}