)]}'
{"neutron/tests/fullstack/resources/client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3a83fa98bf34e481aed8e36c7b33f9ef4bd28609","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    def update_router(self, router_id, **kwargs):"},{"line_number":80,"context_line":"        return self._update_resource(\u0027router\u0027, router_id, kwargs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def create_segment(self, tenant_id, network, name, network_type\u003dNone,"},{"line_number":83,"context_line":"                       segmentation_id\u003dNone, physical_network\u003dNone):"},{"line_number":84,"context_line":"        resource_type \u003d \u0027segment\u0027"},{"line_number":85,"context_line":"        name \u003d name or utils.get_rand_name(prefix\u003dresource_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"6aa65646_6de9bcb2","line":82,"range":{"start_line":82,"start_character":29,"end_line":82,"end_character":38},"updated":"2020-12-16 16:03:50.000000000","message":"Could be project_id? We need to avoid tenant_id","commit_id":"9cea90fae7efc74fb557da2553244131547eb4ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9718037e7471273d60d05f919e405ffa73cced94","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    def update_router(self, router_id, **kwargs):"},{"line_number":80,"context_line":"        return self._update_resource(\u0027router\u0027, router_id, kwargs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def create_segment(self, tenant_id, network, name, network_type\u003dNone,"},{"line_number":83,"context_line":"                       segmentation_id\u003dNone, physical_network\u003dNone):"},{"line_number":84,"context_line":"        resource_type \u003d \u0027segment\u0027"},{"line_number":85,"context_line":"        name \u003d name or utils.get_rand_name(prefix\u003dresource_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"42bae93e_35c4ee20","line":82,"range":{"start_line":82,"start_character":29,"end_line":82,"end_character":38},"in_reply_to":"6aa65646_6de9bcb2","updated":"2020-12-17 10:58:27.000000000","message":"Yeah, I just \"copied\" the surrounding method signatures.","commit_id":"9cea90fae7efc74fb557da2553244131547eb4ef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3a83fa98bf34e481aed8e36c7b33f9ef4bd28609","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                       segmentation_id\u003dNone, physical_network\u003dNone):"},{"line_number":84,"context_line":"        resource_type \u003d \u0027segment\u0027"},{"line_number":85,"context_line":"        name \u003d name or utils.get_rand_name(prefix\u003dresource_type)"},{"line_number":86,"context_line":"        spec \u003d {\u0027tenant_id\u0027: tenant_id, \u0027name\u0027: name, \u0027network_id\u0027: network,"},{"line_number":87,"context_line":"                \u0027network_type\u0027: network_type,"},{"line_number":88,"context_line":"                \u0027physical_network\u0027: physical_network,"},{"line_number":89,"context_line":"                \u0027segmentation_id\u0027: segmentation_id}"}],"source_content_type":"text/x-python","patch_set":11,"id":"a276841f_54e1100c","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":26},"updated":"2020-12-16 16:03:50.000000000","message":"ditto","commit_id":"9cea90fae7efc74fb557da2553244131547eb4ef"}],"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ad4897070a144eebd0658998a6c6ff4d79123023","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        device1 \u003d utils.get_rand_device_name(prefix\u003d\u0027ens5\u0027)"},{"line_number":296,"context_line":"        device2 \u003d utils.get_rand_device_name(prefix\u003d\u0027ens6\u0027)"},{"line_number":297,"context_line":"        phys_dev_mapping \u003d \u0027%s:%s,%s:%s\u0027 % (\u0027%s_ens5\u0027 % PHYSICAL_NETWORK_NAME,"},{"line_number":298,"context_line":"                                            device1,"},{"line_number":299,"context_line":"                                            \u0027%s_ens6\u0027 % PHYSICAL_NETWORK_NAME,"},{"line_number":300,"context_line":"                                            device2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9b0b8b7b","line":297,"range":{"start_line":297,"start_character":44,"end_line":297,"end_character":77},"updated":"2020-05-18 14:32:24.000000000","message":"nit: why not same simple concatenation as on 181-182","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"651faf97c7de6a2e8dfc1d0697fe768af46efaef","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        device1 \u003d utils.get_rand_device_name(prefix\u003d\u0027ens5\u0027)"},{"line_number":296,"context_line":"        device2 \u003d utils.get_rand_device_name(prefix\u003d\u0027ens6\u0027)"},{"line_number":297,"context_line":"        phys_dev_mapping \u003d \u0027%s:%s,%s:%s\u0027 % (\u0027%s_ens5\u0027 % PHYSICAL_NETWORK_NAME,"},{"line_number":298,"context_line":"                                            device1,"},{"line_number":299,"context_line":"                                            \u0027%s_ens6\u0027 % PHYSICAL_NETWORK_NAME,"},{"line_number":300,"context_line":"                                            device2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_bb58f355","line":297,"range":{"start_line":297,"start_character":44,"end_line":297,"end_character":77},"in_reply_to":"ff570b3c_9b0b8b7b","updated":"2020-05-19 15:56:09.000000000","message":"I checked again and it was originally with %s, so I let it to be that way, though I made my additions simpler (I hope at least :-))","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b255a92cad8d57aca954b1b4b434f9560bd03cec","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        device1 \u003d utils.get_rand_device_name(prefix\u003d\u0027ens5\u0027)"},{"line_number":296,"context_line":"        device2 \u003d utils.get_rand_device_name(prefix\u003d\u0027ens6\u0027)"},{"line_number":297,"context_line":"        phys_dev_mapping \u003d \u0027%s:%s,%s:%s\u0027 % (\u0027%s_ens5\u0027 % PHYSICAL_NETWORK_NAME,"},{"line_number":298,"context_line":"                                            device1,"},{"line_number":299,"context_line":"                                            \u0027%s_ens6\u0027 % PHYSICAL_NETWORK_NAME,"},{"line_number":300,"context_line":"                                            device2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6a9ccabf","line":297,"range":{"start_line":297,"start_character":44,"end_line":297,"end_character":77},"in_reply_to":"ff570b3c_9b0b8b7b","updated":"2020-05-19 12:23:07.000000000","message":"thanks I can change that.","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"976b0651966d226621fd4843ab9241319ae17c19","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            },"},{"line_number":179,"context_line":"            \u0027ml2_type_vlan\u0027: {"},{"line_number":180,"context_line":"                \u0027network_vlan_ranges\u0027: PHYSICAL_NETWORK_NAME + \u0027:1000:1029,\u0027 +"},{"line_number":181,"context_line":"                PHYSICAL_NETWORK_NAME + \u0027_lb:1050:1059\u0027,"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"            },"},{"line_number":184,"context_line":"            \u0027ml2_type_gre\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_e63419fe","line":181,"updated":"2020-07-03 10:08:55.000000000","message":"Because of this change \"test_change_segmentation_id_with_bound_ports_in_network(Linux Bridge Agent)\" is not binding correctly the port and the test fails (should not be able to change the segmentation ID with a port bound)[1].\n\nThe problem there is that the LB agent of this host is located in \"physnet1_lb\" instead of \"physnet\":\n\n2020-07-01 09:21:14.768 20099 DEBUG neutron.plugins.ml2.drivers.mech_agent [req-f24b6111-78ac-46bd-817b-983ff8514372 - - - - -] Network a3d61e0d-5825-4e31-9231-5b9654113f5c with segment 37e31896-036d-4617-b432-ae5c43200e4a is connected to physical network physnet1, but agent host-e083f154 reported physical networks {\u0027physnet1_lb\u0027: \u0027portdae191\u0027}. The physical network must be configured on the agent if binding is to succeed. check_segment_for_agent /home/zuul/src/opendev.org/openstack/neutron/neutron/plugins/ml2/drivers/mech_agent.py:371\n\n\nThe same problem is affecting to \"test_l2_agent_restart(LB,Flat network)\" and \"test_l2_agent_restart(LB,VLANs)\".\n\n\n[1]https://51cdf8de6361ba9f0842-4a4d55ab26ddf3c599b7e736bfec3092.ssl.cf2.rackcdn.com/728904/6/check/neutron-fullstack-with-uwsgi/445d18c/controller/logs/dsvm-fullstack-logs/TestSegmentationId.test_change_segmentation_id_with_bound_ports_in_network_Linux-Bridge-Agent_/neutron-server--2020-07-01--09-20-55-253992_log.txt","commit_id":"7fe3481e1d2580971503a9036a8432955c23d7c5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"467115ed8d7215884c9fda0452c699e5fd73ae06","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            },"},{"line_number":179,"context_line":"            \u0027ml2_type_vlan\u0027: {"},{"line_number":180,"context_line":"                \u0027network_vlan_ranges\u0027: PHYSICAL_NETWORK_NAME + \u0027:1000:1029,\u0027 +"},{"line_number":181,"context_line":"                PHYSICAL_NETWORK_NAME + \u0027_lb:1050:1059\u0027,"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"            },"},{"line_number":184,"context_line":"            \u0027ml2_type_gre\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_e8366db4","line":181,"in_reply_to":"bf51134e_e63419fe","updated":"2020-07-08 08:53:38.000000000","message":"Thanks Rodolfo, I overlooked that issue","commit_id":"7fe3481e1d2580971503a9036a8432955c23d7c5"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"da4b30731a74933478d49ed02e030f11cb673b3d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            },"},{"line_number":184,"context_line":"            \u0027ml2_type_vlan\u0027: {"},{"line_number":185,"context_line":"                \u0027network_vlan_ranges\u0027: PHYSICAL_NETWORK_NAME + \u0027:1000:1029\u0027 +"},{"line_number":186,"context_line":"                                       net_vlan_ranges_extra,"},{"line_number":187,"context_line":"            },"},{"line_number":188,"context_line":"            \u0027ml2_type_gre\u0027: {"},{"line_number":189,"context_line":"                \u0027tunnel_id_ranges\u0027: \u00271:30\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_44693dbc","line":186,"updated":"2020-07-08 14:12:33.000000000","message":"pep8: E131 continuation line unaligned for hanging indent","commit_id":"255960e066abe108948fc50d49efdf3302e35b7d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"40dc9bd7717326174a95abbcececf3e804942dcf","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            },"},{"line_number":184,"context_line":"            \u0027ml2_type_vlan\u0027: {"},{"line_number":185,"context_line":"                \u0027network_vlan_ranges\u0027: PHYSICAL_NETWORK_NAME + \u0027:1000:1029\u0027 +"},{"line_number":186,"context_line":"                                       net_vlan_ranges_extra,"},{"line_number":187,"context_line":"            },"},{"line_number":188,"context_line":"            \u0027ml2_type_gre\u0027: {"},{"line_number":189,"context_line":"                \u0027tunnel_id_ranges\u0027: \u00271:30\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_443da1db","line":186,"updated":"2020-07-09 20:47:06.000000000","message":"pep8: E131 continuation line unaligned for hanging indent","commit_id":"98466559b6501afcf8d2a28c1b01e0294a3e9ea4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"698051d97488fbed0f275ce2a94f8bf9dfc0a0d2","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        phys_dev_mapping \u003d \u0027%s:%s,%s:%s\u0027 % (PHYSICAL_NETWORK_NAME,"},{"line_number":302,"context_line":"                                            device1,"},{"line_number":303,"context_line":"                                            PHYSICAL_NETWORK_NAME,"},{"line_number":304,"context_line":"                                            device2)"},{"line_number":305,"context_line":"        rp_bandwidths \u003d \u0027%s:%s:%s,%s:%s:%s\u0027 % (device1,"},{"line_number":306,"context_line":"                                               MINIMUM_BANDWIDTH_EGRESS_KBPS,"},{"line_number":307,"context_line":"                                               MINIMUM_BANDWIDTH_INGRESS_KBPS,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_07d3dd61","line":304,"updated":"2020-07-31 08:35:38.000000000","message":"unrelated changes?","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4abd98173947955e07de9e77a0331ab527723246","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        phys_dev_mapping \u003d \u0027%s:%s,%s:%s\u0027 % (PHYSICAL_NETWORK_NAME,"},{"line_number":302,"context_line":"                                            device1,"},{"line_number":303,"context_line":"                                            PHYSICAL_NETWORK_NAME,"},{"line_number":304,"context_line":"                                            device2)"},{"line_number":305,"context_line":"        rp_bandwidths \u003d \u0027%s:%s:%s,%s:%s:%s\u0027 % (device1,"},{"line_number":306,"context_line":"                                               MINIMUM_BANDWIDTH_EGRESS_KBPS,"},{"line_number":307,"context_line":"                                               MINIMUM_BANDWIDTH_INGRESS_KBPS,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_8948805c","line":304,"in_reply_to":"9f560f44_07d3dd61","updated":"2020-08-03 12:02:19.000000000","message":"Thanks, I missed this","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"}],"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"651faf97c7de6a2e8dfc1d0697fe768af46efaef","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                        namespace\u003dself.host_namespace,"},{"line_number":282,"context_line":"                        prefix_is_full_name\u003dTrue)).bridge"},{"line_number":283,"context_line":"                self.network_bridges[network_id] \u003d bridge"},{"line_number":284,"context_line":"        elif \"sriov\" in self.agents.keys():"},{"line_number":285,"context_line":"            bridge \u003d self.network_bridges.get(network_id, None)"},{"line_number":286,"context_line":"        return bridge"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5baf1729","line":285,"range":{"start_line":284,"start_character":0,"end_line":285,"end_character":63},"updated":"2020-05-19 15:56:09.000000000","message":"Something else is missing here as sometimes there is no valid bridge found. I have to add something like above for linuxbridge case","commit_id":"a9bda3e9218aa0d2931d203d478e21af5e6d676d"}],"neutron/tests/fullstack/test_dhcp_agent.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"1a2681666e6e46f1256df223954bd5b2224da2fc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                l2_pop\u003dFalse,"},{"line_number":259,"context_line":"                arp_responder\u003dFalse,"},{"line_number":260,"context_line":"                agent_down_time\u003dself.agent_down_time,"},{"line_number":261,"context_line":"                service_plugins\u003d\u0027router,segments\u0027"},{"line_number":262,"context_line":"            ),"},{"line_number":263,"context_line":"            host_descriptions)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a3dd8171","line":261,"range":{"start_line":261,"start_character":33,"end_line":261,"end_character":39},"updated":"2020-05-18 16:11:41.000000000","message":"Is this needed here?","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"06b5877ca72985eb9c2aac036927149c94b772a2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                l2_pop\u003dFalse,"},{"line_number":259,"context_line":"                arp_responder\u003dFalse,"},{"line_number":260,"context_line":"                agent_down_time\u003dself.agent_down_time,"},{"line_number":261,"context_line":"                service_plugins\u003d\u0027router,segments\u0027"},{"line_number":262,"context_line":"            ),"},{"line_number":263,"context_line":"            host_descriptions)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_cf0b6827","line":261,"range":{"start_line":261,"start_character":33,"end_line":261,"end_character":39},"in_reply_to":"ff570b3c_a3dd8171","updated":"2020-05-19 12:22:38.000000000","message":"router is \"default\" in fullstack tests (see: https://opendev.org/openstack/neutron/src/branch/master/neutron/tests/fullstack/resources/environment.py#L38), so this is why I let it as 1st in this list.\nBut I can remove it of course (I check if it changes anything how fullstack works :-))","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"1a2681666e6e46f1256df223954bd5b2224da2fc","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                    agent[\u0027configurations\u0027][\u0027device_mappings\u0027].keys())[0]"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        # openstack network create net0 --provider-network-type vlan"},{"line_number":281,"context_line":"        # --provider-physical-network PHY0 --provider-segment 100"},{"line_number":282,"context_line":"        self.network \u003d self.safe_client.create_network("},{"line_number":283,"context_line":"            tenant_id\u003dself.project_id, network_type\u003d\u0027vlan\u0027,"},{"line_number":284,"context_line":"            segmentation_id\u003d103, physical_network\u003dsriov_physnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_435c65ec","line":281,"updated":"2020-05-18 16:11:41.000000000","message":"I\u0027m not necessarily against this kind of comment, but if we have it then let\u0027s keep the segment_id in sync and let\u0027s have some meaningful physical network names.","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"651faf97c7de6a2e8dfc1d0697fe768af46efaef","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                    agent[\u0027configurations\u0027][\u0027device_mappings\u0027].keys())[0]"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        # openstack network create net0 --provider-network-type vlan"},{"line_number":281,"context_line":"        # --provider-physical-network PHY0 --provider-segment 100"},{"line_number":282,"context_line":"        self.network \u003d self.safe_client.create_network("},{"line_number":283,"context_line":"            tenant_id\u003dself.project_id, network_type\u003d\u0027vlan\u0027,"},{"line_number":284,"context_line":"            segmentation_id\u003d103, physical_network\u003dsriov_physnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5b7437cf","line":281,"in_reply_to":"ff570b3c_435c65ec","updated":"2020-05-19 15:56:09.000000000","message":"I removed these","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"1a2681666e6e46f1256df223954bd5b2224da2fc","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        subnet \u003d self.safe_client.create_subnet(self.project_id, self.network[\u0027id\u0027],"},{"line_number":296,"context_line":"            cidr\u003d\u002710.0.11.0/24\u0027, gateway_ip\u003d\u002710.0.11.1\u0027, name\u003d\u0027subnet-test\u0027,"},{"line_number":297,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":298,"context_line":"        self.vm \u003d self._spawn_vm()"},{"line_number":299,"context_line":"        self.vm.block_until_boot()"},{"line_number":300,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        dhcp_ports \u003d self.safe_client.list_ports(**{"},{"line_number":303,"context_line":"            \u0027device_owner\u0027: \u0027network:dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6325295c","line":300,"range":{"start_line":298,"start_character":0,"end_line":300,"end_character":46},"updated":"2020-05-18 16:11:41.000000000","message":"Do we need this? I think what we actually need is that a dhcp port gets created and goes to ACTIVE state.","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"06b5877ca72985eb9c2aac036927149c94b772a2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        subnet \u003d self.safe_client.create_subnet(self.project_id, self.network[\u0027id\u0027],"},{"line_number":296,"context_line":"            cidr\u003d\u002710.0.11.0/24\u0027, gateway_ip\u003d\u002710.0.11.1\u0027, name\u003d\u0027subnet-test\u0027,"},{"line_number":297,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":298,"context_line":"        self.vm \u003d self._spawn_vm()"},{"line_number":299,"context_line":"        self.vm.block_until_boot()"},{"line_number":300,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        dhcp_ports \u003d self.safe_client.list_ports(**{"},{"line_number":303,"context_line":"            \u0027device_owner\u0027: \u0027network:dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_4a7c6682","line":300,"range":{"start_line":298,"start_character":0,"end_line":300,"end_character":46},"in_reply_to":"ff570b3c_6325295c","updated":"2020-05-19 12:22:38.000000000","message":"Good point.\nThis is needed due to some fullstack speciality.\nWithout this I have no dhcp port.... I have to check why (I spent an afternoon with comparing config files generated by fullstack and my local env with devstack) I suppose some extra trigger is missing in case of fullstack.\n\nAnd because there is no nova i have to delete manually the VM port later (see l312.)","commit_id":"98bdb7a7a7afaccce60233f1a09e0bb88189e909"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"347d04bad5e4147368b746826233f8e197d4a2c7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import random"},{"line_number":16,"context_line":"import time"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from oslo_utils import uuidutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7c7bee26","line":16,"updated":"2020-05-19 19:28:04.000000000","message":"pep8: F401 \u0027time\u0027 imported but unused","commit_id":"a9bda3e9218aa0d2931d203d478e21af5e6d676d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"347d04bad5e4147368b746826233f8e197d4a2c7","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            environment.HostDescription("},{"line_number":249,"context_line":"                dhcp_agent\u003dTrue, l2_agent_type\u003dconstants.AGENT_TYPE_OVS),"},{"line_number":250,"context_line":"            environment.HostDescription("},{"line_number":251,"context_line":"                dhcp_agent\u003dFalse, l2_agent_type\u003dconstants.AGENT_TYPE_NIC_SWITCH)"},{"line_number":252,"context_line":"        ]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        env \u003d environment.Environment("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_dc767a3e","line":251,"updated":"2020-05-19 19:28:04.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"a9bda3e9218aa0d2931d203d478e21af5e6d676d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"347d04bad5e4147368b746826233f8e197d4a2c7","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            network_type\u003d\u0027vlan\u0027, name\u003d\u0027segment_2\u0027, segmentation_id\u003d103,"},{"line_number":287,"context_line":"            physical_network\u003dovs_physnet)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        subnet \u003d self.safe_client.create_subnet(self.project_id, self.network[\u0027id\u0027],"},{"line_number":290,"context_line":"            cidr\u003d\u002710.0.11.0/24\u0027, gateway_ip\u003d\u002710.0.11.1\u0027, name\u003d\u0027subnet-test\u0027,"},{"line_number":291,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_bc710647","line":289,"updated":"2020-05-19 19:28:04.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"a9bda3e9218aa0d2931d203d478e21af5e6d676d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"487290883fb3be03d089b327b0a8a4ad52c60609","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import random"},{"line_number":16,"context_line":"import time"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from oslo_utils import uuidutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_1cc1c72f","line":16,"updated":"2020-05-22 18:52:52.000000000","message":"pep8: F401 \u0027time\u0027 imported but unused","commit_id":"8d8c3d2789302cb7a5f066b38fa7b79fffeaf9bd"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"487290883fb3be03d089b327b0a8a4ad52c60609","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            network_type\u003d\u0027vlan\u0027, name\u003d\u0027segment_2\u0027, segmentation_id\u003d103,"},{"line_number":288,"context_line":"            physical_network\u003dovs_physnet)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        subnet \u003d self.safe_client.create_subnet(self.project_id, self.network[\u0027id\u0027],"},{"line_number":291,"context_line":"            cidr\u003d\u002710.0.11.0/24\u0027, gateway_ip\u003d\u002710.0.11.1\u0027, name\u003d\u0027subnet-test\u0027,"},{"line_number":292,"context_line":"            enable_dhcp\u003dTrue)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_7cdba320","line":290,"updated":"2020-05-22 18:52:52.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"8d8c3d2789302cb7a5f066b38fa7b79fffeaf9bd"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e9c3063921c9d93707d76c651d356cc6be6c2fdb","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        for port in self.safe_client.list_ports("},{"line_number":313,"context_line":"                **{\u0027network_id\u0027: self.network[\u0027id\u0027]}):"},{"line_number":314,"context_line":"            if port[\u0027device_owner\u0027] !\u003d \u0027network:dhcp\u0027:"},{"line_number":315,"context_line":"                self.client.delete_port(port[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        dhcp_ports \u003d self.safe_client.list_ports(**{"},{"line_number":318,"context_line":"            \u0027device_owner\u0027: \u0027network:dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_e1bfbcf8","line":315,"range":{"start_line":315,"start_character":28,"end_line":315,"end_character":39},"updated":"2020-05-28 07:32:42.000000000","message":"addCleanup() before the asserts would clean up even when the test fails, wouldn\u0027t it?","commit_id":"47da7f28d199e2d5e25121a8750f220eede138c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"77e8caf9d78b864af5058069bcade3de468f3efc","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        for port in self.safe_client.list_ports("},{"line_number":313,"context_line":"                **{\u0027network_id\u0027: self.network[\u0027id\u0027]}):"},{"line_number":314,"context_line":"            if port[\u0027device_owner\u0027] !\u003d \u0027network:dhcp\u0027:"},{"line_number":315,"context_line":"                self.client.delete_port(port[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        dhcp_ports \u003d self.safe_client.list_ports(**{"},{"line_number":318,"context_line":"            \u0027device_owner\u0027: \u0027network:dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_16ca7b9f","line":315,"range":{"start_line":315,"start_character":28,"end_line":315,"end_character":39},"in_reply_to":"ff570b3c_e1bfbcf8","updated":"2020-06-04 15:34:31.000000000","message":"This port here is created a the fake VM is created, so its fate is not in my hands.","commit_id":"47da7f28d199e2d5e25121a8750f220eede138c9"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e9c3063921c9d93707d76c651d356cc6be6c2fdb","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        common_utils.wait_until_true(_is_subnet_not_there)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.client.delete_segment(self.segment2[\u0027id\u0027])"},{"line_number":334,"context_line":"        self.safe_client.delete_network(self.network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_013ab096","line":333,"range":{"start_line":333,"start_character":20,"end_line":333,"end_character":34},"updated":"2020-05-28 07:32:42.000000000","message":"addCleanup() may be better.","commit_id":"47da7f28d199e2d5e25121a8750f220eede138c9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"77e8caf9d78b864af5058069bcade3de468f3efc","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        common_utils.wait_until_true(_is_subnet_not_there)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.client.delete_segment(self.segment2[\u0027id\u0027])"},{"line_number":334,"context_line":"        self.safe_client.delete_network(self.network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_96bdeb03","line":333,"range":{"start_line":333,"start_character":20,"end_line":333,"end_character":34},"in_reply_to":"ff570b3c_013ab096","updated":"2020-06-04 15:34:31.000000000","message":"Yeah after thinking on it these can be deleted.\nThe cleanup is added here: https://opendev.org/openstack/neutron/src/branch/master/neutron/tests/fullstack/resources/client.py#L50","commit_id":"47da7f28d199e2d5e25121a8750f220eede138c9"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"e9c3063921c9d93707d76c651d356cc6be6c2fdb","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        common_utils.wait_until_true(_is_subnet_not_there)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.client.delete_segment(self.segment2[\u0027id\u0027])"},{"line_number":334,"context_line":"        self.safe_client.delete_network(self.network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_6141ec0b","line":334,"range":{"start_line":334,"start_character":25,"end_line":334,"end_character":39},"updated":"2020-05-28 07:32:42.000000000","message":"here too","commit_id":"47da7f28d199e2d5e25121a8750f220eede138c9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"698051d97488fbed0f275ce2a94f8bf9dfc0a0d2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    dhcp_scheduler_class \u003d None"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self, env\u003dNone):"},{"line_number":43,"context_line":"        if not env:"},{"line_number":44,"context_line":"            host_descriptions \u003d ["},{"line_number":45,"context_line":"                environment.HostDescription("},{"line_number":46,"context_line":"                    dhcp_agent\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_4742f511","line":43,"updated":"2020-07-31 08:35:38.000000000","message":"if that is only to not recreate env already created in L254 maybe it would be better simple to not call\n\n    super(TestSubnetDeleteRace, self).setUp(env)\n\nand instead add L59-62 also in the setUp method in the TestSubnetDeleteRace class.","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4abd98173947955e07de9e77a0331ab527723246","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    dhcp_scheduler_class \u003d None"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self, env\u003dNone):"},{"line_number":43,"context_line":"        if not env:"},{"line_number":44,"context_line":"            host_descriptions \u003d ["},{"line_number":45,"context_line":"                environment.HostDescription("},{"line_number":46,"context_line":"                    dhcp_agent\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c97718a0","line":43,"in_reply_to":"9f560f44_4742f511","updated":"2020-08-03 12:02:19.000000000","message":"Thanks, that\u0027s a good idea","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"698051d97488fbed0f275ce2a94f8bf9dfc0a0d2","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    scenarios \u003d ["},{"line_number":241,"context_line":"        (constants.AGENT_TYPE_OVS,"},{"line_number":242,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":243,"context_line":"    ]"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def setUp(self):"},{"line_number":246,"context_line":"        host_descriptions \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_27454118","line":243,"updated":"2020-07-31 08:35:38.000000000","message":"You don\u0027t need this scenarios var here as it\u0027s not used. You are using \"mixed\" env below.","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4abd98173947955e07de9e77a0331ab527723246","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    scenarios \u003d ["},{"line_number":241,"context_line":"        (constants.AGENT_TYPE_OVS,"},{"line_number":242,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":243,"context_line":"    ]"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def setUp(self):"},{"line_number":246,"context_line":"        host_descriptions \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_a97c6483","line":243,"in_reply_to":"9f560f44_27454118","updated":"2020-08-03 12:02:19.000000000","message":"Done","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"698051d97488fbed0f275ce2a94f8bf9dfc0a0d2","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        self.vm.destroy()"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        # The port for the VM is still there, I suppose because it is not"},{"line_number":311,"context_line":"        # managed by nova"},{"line_number":312,"context_line":"        for port in self.safe_client.list_ports("},{"line_number":313,"context_line":"                **{\u0027network_id\u0027: self.network[\u0027id\u0027]}):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c76e0594","line":310,"range":{"start_line":310,"start_character":48,"end_line":310,"end_character":55},"updated":"2020-07-31 08:35:38.000000000","message":"nit: I think You should be sure :)","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"698051d97488fbed0f275ce2a94f8bf9dfc0a0d2","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        for port in self.safe_client.list_ports("},{"line_number":313,"context_line":"                **{\u0027network_id\u0027: self.network[\u0027id\u0027]}):"},{"line_number":314,"context_line":"            if port[\u0027device_owner\u0027] !\u003d \u0027network:dhcp\u0027:"},{"line_number":315,"context_line":"                self.client.delete_port(port[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        dhcp_ports \u003d self.safe_client.list_ports(**{"},{"line_number":318,"context_line":"            \u0027device_owner\u0027: \u0027network:dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_87f9adc9","line":315,"updated":"2020-07-31 08:35:38.000000000","message":"if You just need to find if of the port, You can get it like:\n\n    self.vm.neutron_port[\u0027id\u0027]\n\nand then this list of ports will not be needed probably.","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4abd98173947955e07de9e77a0331ab527723246","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        for port in self.safe_client.list_ports("},{"line_number":313,"context_line":"                **{\u0027network_id\u0027: self.network[\u0027id\u0027]}):"},{"line_number":314,"context_line":"            if port[\u0027device_owner\u0027] !\u003d \u0027network:dhcp\u0027:"},{"line_number":315,"context_line":"                self.client.delete_port(port[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        dhcp_ports \u003d self.safe_client.list_ports(**{"},{"line_number":318,"context_line":"            \u0027device_owner\u0027: \u0027network:dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_496b08b6","line":315,"in_reply_to":"9f560f44_87f9adc9","updated":"2020-08-03 12:02:19.000000000","message":"Thanks, it\u0027s much simpler","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"698051d97488fbed0f275ce2a94f8bf9dfc0a0d2","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        self.client.delete_subnet(subnet[\u0027id\u0027])"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        def _is_subnet_not_there():"},{"line_number":326,"context_line":"            snets \u003d self.safe_client.list_subnets()"},{"line_number":327,"context_line":"            if len(snets) \u003d\u003d 0:"},{"line_number":328,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c703a5b7","line":325,"range":{"start_line":325,"start_character":12,"end_line":325,"end_character":32},"updated":"2020-07-31 08:35:38.000000000","message":"maybe \"is_subnet_deleted\" would be better name?","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4abd98173947955e07de9e77a0331ab527723246","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        self.client.delete_subnet(subnet[\u0027id\u0027])"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        def _is_subnet_not_there():"},{"line_number":326,"context_line":"            snets \u003d self.safe_client.list_subnets()"},{"line_number":327,"context_line":"            if len(snets) \u003d\u003d 0:"},{"line_number":328,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_8961a0d6","line":325,"range":{"start_line":325,"start_character":12,"end_line":325,"end_character":32},"in_reply_to":"9f560f44_c703a5b7","updated":"2020-08-03 12:02:19.000000000","message":"Done","commit_id":"f29657568f9f877430057d6067d9dfe784232b99"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3a83fa98bf34e481aed8e36c7b33f9ef4bd28609","unresolved":true,"context_lines":[{"line_number":35,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":36,"context_line":"        (constants.AGENT_TYPE_LINUXBRIDGE,"},{"line_number":37,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_LINUXBRIDGE})"},{"line_number":38,"context_line":"    ]"},{"line_number":39,"context_line":"    boot_vm_for_test \u003d True"},{"line_number":40,"context_line":"    dhcp_scheduler_class \u003d None"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fdf6e4e1_74f77cb7","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":5},"updated":"2020-12-16 16:03:50.000000000","message":"You are already deploying two hosts, one with each driver. Do we need to repeat this test twice (executing the same test, regardless of \"self.l2_agent_type\" that is not used)?","commit_id":"9cea90fae7efc74fb557da2553244131547eb4ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9718037e7471273d60d05f919e405ffa73cced94","unresolved":true,"context_lines":[{"line_number":35,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_OVS}),"},{"line_number":36,"context_line":"        (constants.AGENT_TYPE_LINUXBRIDGE,"},{"line_number":37,"context_line":"         {\u0027l2_agent_type\u0027: constants.AGENT_TYPE_LINUXBRIDGE})"},{"line_number":38,"context_line":"    ]"},{"line_number":39,"context_line":"    boot_vm_for_test \u003d True"},{"line_number":40,"context_line":"    dhcp_scheduler_class \u003d None"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7609e8af_792389a6","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":5},"in_reply_to":"fdf6e4e1_74f77cb7","updated":"2020-12-17 10:58:27.000000000","message":"Yeah, that can be considered to clean up, perhaps as general fullstack cleanup","commit_id":"9cea90fae7efc74fb557da2553244131547eb4ef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bfd70eaacbc9b9e06d313cf2a21f70ffd69f92da","unresolved":true,"context_lines":[{"line_number":275,"context_line":"            if agent[\u0027binary\u0027] \u003d\u003d \u0027neutron-openvswitch-agent\u0027:"},{"line_number":276,"context_line":"                ovs_physnet \u003d list("},{"line_number":277,"context_line":"                    agent[\u0027configurations\u0027][\u0027bridge_mappings\u0027].keys())[0]"},{"line_number":278,"context_line":"            if agent[\u0027binary\u0027] \u003d\u003d \u0027neutron-linuxbridge-agent\u0027:"},{"line_number":279,"context_line":"                lb_physnet \u003d list("},{"line_number":280,"context_line":"                    agent[\u0027configurations\u0027][\u0027interface_mappings\u0027].keys())[0]"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fe292d0e_04f261fa","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":14},"updated":"2020-12-21 09:24:50.000000000","message":"nit: elif","commit_id":"c6034bf7f421541bad3f1a7e120e0f6bfa71cabc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bfd70eaacbc9b9e06d313cf2a21f70ffd69f92da","unresolved":true,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        common_utils.wait_until_true(_is_subnet_deleted)"},{"line_number":330,"context_line":"        # Note(lajoskatona): Here cleanup do its job and the cleanup"},{"line_number":331,"context_line":"        # will fail if the segment or network deletion is inpossible"}],"source_content_type":"text/x-python","patch_set":13,"id":"aee996fb_806a864b","line":331,"range":{"start_line":331,"start_character":58,"end_line":331,"end_character":68},"updated":"2020-12-21 09:24:50.000000000","message":"nitty nit: inpossible/impossible","commit_id":"c6034bf7f421541bad3f1a7e120e0f6bfa71cabc"}]}